This change refactors existing self-assignments within if clauses across the WebRTC codebase. *Why:* - Bug Prevention: Assignments within conditionals are frequently unintended errors, often mistaken for equality checks. - Clearer Code: Separating assignments from conditionals improves code readability and reduces the risk of misinterpretation. Change-Id: I199dc26a35ceca109a2ac569b446811314dfdf0b Bug: chromium:361594695 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/360460 Reviewed-by: Chuck Hays <haysc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42850}
45 lines
1.2 KiB
Plaintext
45 lines
1.2 KiB
Plaintext
/*
|
|
* Copyright 2016 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#import "RTCMetricsSampleInfo+Private.h"
|
|
|
|
#import "helpers/NSString+StdString.h"
|
|
|
|
@implementation RTC_OBJC_TYPE (RTCMetricsSampleInfo)
|
|
|
|
@synthesize name = _name;
|
|
@synthesize min = _min;
|
|
@synthesize max = _max;
|
|
@synthesize bucketCount = _bucketCount;
|
|
@synthesize samples = _samples;
|
|
|
|
#pragma mark - Private
|
|
|
|
- (instancetype)initWithNativeSampleInfo:
|
|
(const webrtc::metrics::SampleInfo &)info {
|
|
self = [super init];
|
|
if (self) {
|
|
_name = [NSString stringForStdString:info.name];
|
|
_min = info.min;
|
|
_max = info.max;
|
|
_bucketCount = info.bucket_count;
|
|
|
|
NSMutableDictionary *samples =
|
|
[NSMutableDictionary dictionaryWithCapacity:info.samples.size()];
|
|
for (auto const &sample : info.samples) {
|
|
[samples setObject:@(sample.second) forKey:@(sample.first)];
|
|
}
|
|
_samples = samples;
|
|
}
|
|
return self;
|
|
}
|
|
|
|
@end
|