de3360ec1d
Vp8FrameBufferController is currently just a renamed Vp8TemporalLayers, but subsequent CLs will modify Vp8FrameBufferController in ways that are not relevant for Vp8TemporalLayers. Namely: 1. Loss notifications will be added. 2. Packet-loss rate will be tracked. 3. RTT will be tracked. 4. Vp8FrameBufferController will be made injectable. Vp8TemporalLayers is retained in order to: 1. Avoid needlessly changing api/. 2. Place for code shared between DefaultTemporalLayers and ScreenshareLayers. We can remove it in the future (with a proper public announcement). Bug: webrtc:10382 Change-Id: I49ad1b9bc1954d51bb0b5e60361985f1eb12ae9f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126045 Reviewed-by: Erik Språng <sprang@webrtc.org> Commit-Queue: Elad Alon <eladalon@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27009}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.