a70695a3e1
The biggest change to NetEq is the move from a primary flag, to a Priority with two separate levels: one set by RED splitting and one set by the codec itself. This allows us to unambigously prioritize "fallback" packets from these two sources. I've chosen what I believe is the sensible ordering: packets that the codec prioritizes are chosen first, regardless of if they are secondary RED packets or not. So if we were to use Opus w/ FEC in RED, we'd only do Opus FEC decoding if there was no RED packet that could cover the time slot. With this change, PayloadSplitter now only deals with RED packets. Maybe it should be renamed RedPayloadSplitter? BUG=webrtc:5805 Review-Url: https://codereview.webrtc.org/2342443005 Cr-Commit-Position: refs/heads/master@{#14347}
52 lines
1.9 KiB
C++
52 lines
1.9 KiB
C++
/*
|
|
* Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef WEBRTC_MODULES_AUDIO_CODING_NETEQ_RED_PAYLOAD_SPLITTER_H_
|
|
#define WEBRTC_MODULES_AUDIO_CODING_NETEQ_RED_PAYLOAD_SPLITTER_H_
|
|
|
|
#include "webrtc/base/constructormagic.h"
|
|
#include "webrtc/modules/audio_coding/neteq/packet.h"
|
|
|
|
namespace webrtc {
|
|
|
|
// Forward declarations.
|
|
class DecoderDatabase;
|
|
|
|
// This class handles splitting of RED payloads into smaller parts.
|
|
// Codec-specific packet splitting can be performed by
|
|
// AudioDecoder::ParsePayload.
|
|
class RedPayloadSplitter {
|
|
public:
|
|
RedPayloadSplitter() {}
|
|
|
|
virtual ~RedPayloadSplitter() {}
|
|
|
|
// Splits each packet in |packet_list| into its separate RED payloads. Each
|
|
// RED payload is packetized into a Packet. The original elements in
|
|
// |packet_list| are properly deleted, and replaced by the new packets.
|
|
// Note that all packets in |packet_list| must be RED payloads, i.e., have
|
|
// RED headers according to RFC 2198 at the very beginning of the payload.
|
|
// Returns kOK or an error.
|
|
virtual bool SplitRed(PacketList* packet_list);
|
|
|
|
// Checks all packets in |packet_list|. Packets that are DTMF events or
|
|
// comfort noise payloads are kept. Except that, only one single payload type
|
|
// is accepted. Any packet with another payload type is discarded. Returns
|
|
// the number of discarded packets.
|
|
virtual int CheckRedPayloads(PacketList* packet_list,
|
|
const DecoderDatabase& decoder_database);
|
|
|
|
private:
|
|
RTC_DISALLOW_COPY_AND_ASSIGN(RedPayloadSplitter);
|
|
};
|
|
|
|
} // namespace webrtc
|
|
#endif // WEBRTC_MODULES_AUDIO_CODING_NETEQ_RED_PAYLOAD_SPLITTER_H_
|