admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
webrtc_m130/webrtc/modules/audio_coding/neteq
History
kwiberg 8a44e1d87b Let RTC_[D]CHECK_op accept arguments of different signedness 
With this change, instead of

  RTC_DCHECK_GE(unsigned_var, 17u);

we can simply write

  RTC_DCHECK_GE(unsigned_var, 17);

or even

  RTC_DCHECK_GE(unsigned_var, -17);  // Always true.

and the mathematically sensible thing will happen.

Perhaps more importantly, we can replace checks like

  // index is size_t, num_channels is int.
  RTC_DCHECK(num_channels >= 0
             && index < static_cast<size_t>(num_channels));

or, even worse, just

  // Surely num_channels isn't negative. That would be absurd!
  RTC_DCHECK_LT(index, static_cast<size_t>(num_channels));

with simply

  RTC_DCHECK_LT(index, num_channels);

In short, you no longer have to keep track of the signedness of the arguments, because the sensible thing will happen.

BUG=webrtc:6645

Review-Url: https://codereview.webrtc.org/2459793002
Cr-Commit-Position: refs/heads/master@{#14878}
2016-11-01 19:04:32 +00:00
..
include
AudioCodingModule: Specify decoders using SdpAudioFormat
2016-10-04 16:33:33 +00:00
mock
NetEq now works with packets as values, rather than pointers.
2016-10-24 15:25:33 +00:00
test
Sort #includes that got unsorted when gmock.h and gtest.h moved to webrtc/test/
2016-10-01 05:29:53 +00:00
tools
Relanding "Setting up an RTP input fuzzer for NetEq"
2016-10-05 09:27:48 +00:00
accelerate.cc
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
accelerate.h
Add RTC_ prefix to contructormagic macros.
2015-09-16 12:37:52 +00:00
audio_classifier_unittest.cc
Enable the -Wundef warning for clang
2016-09-29 00:42:08 +00:00
audio_classifier.cc
…
audio_classifier.h
Enable the -Wundef warning for clang
2016-09-29 00:42:08 +00:00
audio_decoder_impl.cc
NetEq decoder database: Don't keep track of sample rate for builtin decoders
2016-05-31 13:28:09 +00:00
audio_decoder_impl.h
Delete old video defines in engine config.
2016-10-07 05:07:36 +00:00
audio_decoder_unittest.cc
Delete DataLog abstraction, which was almost unused.
2016-10-21 08:53:01 +00:00
audio_multi_vector_unittest.cc
Enable the -Wundef warning for clang
2016-09-29 00:42:08 +00:00
audio_multi_vector.cc
Using ring buffer for AudioVector in NetEq.
2016-05-10 17:56:10 +00:00
audio_multi_vector.h
Add RTC_ prefix to contructormagic macros.
2015-09-16 12:37:52 +00:00
audio_vector_unittest.cc
Enable the -Wundef warning for clang
2016-09-29 00:42:08 +00:00
audio_vector.cc
Using ring buffer for AudioVector in NetEq.
2016-05-10 17:56:10 +00:00
audio_vector.h
Using ring buffer for AudioVector in NetEq.
2016-05-10 17:56:10 +00:00
background_noise_unittest.cc
Enable the -Wundef warning for clang
2016-09-29 00:42:08 +00:00
background_noise.cc
Using ring buffer for AudioVector in NetEq.
2016-05-10 17:56:10 +00:00
background_noise.h
Replace scoped_ptr with unique_ptr in webrtc/modules/audio_coding/neteq/
2016-02-14 17:28:39 +00:00
buffer_level_filter_unittest.cc
Enable the -Wundef warning for clang
2016-09-29 00:42:08 +00:00
buffer_level_filter.cc
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
buffer_level_filter.h
Add RTC_ prefix to contructormagic macros.
2015-09-16 12:37:52 +00:00
comfort_noise_unittest.cc
Sort #includes that got unsorted when gmock.h and gtest.h moved to webrtc/test/
2016-10-01 05:29:53 +00:00
comfort_noise.cc
NetEq now works with packets as values, rather than pointers.
2016-10-24 15:25:33 +00:00
comfort_noise.h
NetEq now works with packets as values, rather than pointers.
2016-10-24 15:25:33 +00:00
cross_correlation.cc
Reland "Avoiding overflow in cross correlation in NetEq."
2016-05-02 08:50:34 +00:00
cross_correlation.h
Reland "Avoiding overflow in cross correlation in NetEq."
2016-05-02 08:50:34 +00:00
decision_logic_fax.cc
Removed RTPHeader from NetEq's Packet struct.
2016-10-18 11:06:19 +00:00
decision_logic_fax.h
Removed RTPHeader from NetEq's Packet struct.
2016-10-18 11:06:19 +00:00
decision_logic_normal.cc
Removed RTPHeader from NetEq's Packet struct.
2016-10-18 11:06:19 +00:00
decision_logic_normal.h
Removed RTPHeader from NetEq's Packet struct.
2016-10-18 11:06:19 +00:00
decision_logic_unittest.cc
Sort #includes that got unsorted when gmock.h and gtest.h moved to webrtc/test/
2016-10-01 05:29:53 +00:00
decision_logic.cc
Removed RTPHeader from NetEq's Packet struct.
2016-10-18 11:06:19 +00:00
decision_logic.h
Removed RTPHeader from NetEq's Packet struct.
2016-10-18 11:06:19 +00:00
decoder_database_unittest.cc
NetEq now works with packets as values, rather than pointers.
2016-10-24 15:25:33 +00:00
decoder_database.cc
NetEq now works with packets as values, rather than pointers.
2016-10-24 15:25:33 +00:00
decoder_database.h
AudioCodingModule: Specify decoders using SdpAudioFormat
2016-10-04 16:33:33 +00:00
defines.h
…
delay_manager_unittest.cc
Sort #includes that got unsorted when gmock.h and gtest.h moved to webrtc/test/
2016-10-01 05:29:53 +00:00
delay_manager.cc
NetEq: Convert AverageIAT from int to float calculations
2016-10-13 10:35:58 +00:00
delay_manager.h
NetEq: Convert AverageIAT from int to float calculations
2016-10-13 10:35:58 +00:00
delay_peak_detector_unittest.cc
Enable the -Wundef warning for clang
2016-09-29 00:42:08 +00:00
delay_peak_detector.cc
NetEq: Fix a bug in DelayPeakDetector causing asserts to trigger
2016-06-22 16:07:07 +00:00
delay_peak_detector.h
Replace scoped_ptr with unique_ptr everywhere
2016-05-01 21:53:55 +00:00
dsp_helper_unittest.cc
Sort #includes that got unsorted when gmock.h and gtest.h moved to webrtc/test/
2016-10-01 05:29:53 +00:00
dsp_helper.cc
Using ring buffer for AudioVector in NetEq.
2016-05-10 17:56:10 +00:00
dsp_helper.h
Using ring buffer for AudioVector in NetEq.
2016-05-10 17:56:10 +00:00
dtmf_buffer_unittest.cc
Fix bug in DTMF generation where events with level > 36 would be ignored.
2016-10-11 11:35:40 +00:00
dtmf_buffer.cc
Fix bug in DTMF generation where events with level > 36 would be ignored.
2016-10-11 11:35:40 +00:00
dtmf_buffer.h
Add RTC_ prefix to contructormagic macros.
2015-09-16 12:37:52 +00:00
dtmf_tone_generator_unittest.cc
Fix bug in DTMF generation where events with level > 36 would be ignored.
2016-10-11 11:35:40 +00:00
dtmf_tone_generator.cc
Let RTC_[D]CHECK_op accept arguments of different signedness
2016-11-01 19:04:32 +00:00
dtmf_tone_generator.h
Fix bug in DTMF generation where events with level > 36 would be ignored.
2016-10-11 11:35:40 +00:00
expand_unittest.cc
Sort #includes that got unsorted when gmock.h and gtest.h moved to webrtc/test/
2016-10-01 05:29:53 +00:00
expand.cc
Using ring buffer for AudioVector in NetEq.
2016-05-10 17:56:10 +00:00
expand.h
NetEq: Implement Expand::Muted
2016-05-10 12:54:43 +00:00
merge_unittest.cc
Sort #includes that got unsorted when gmock.h and gtest.h moved to webrtc/test/
2016-10-01 05:29:53 +00:00
merge.cc
Using ring buffer for AudioVector in NetEq.
2016-05-10 17:56:10 +00:00
merge.h
Adding 120 ms frame length support in NetEq.
2016-05-02 11:46:19 +00:00
nack_tracker_unittest.cc
Sort #includes that got unsorted when gmock.h and gtest.h moved to webrtc/test/
2016-10-01 05:29:53 +00:00
nack_tracker.cc
NetEq: Rename Nack to NackTracker to avoid name collisions in GN
2016-06-08 13:43:49 +00:00
nack_tracker.h
NetEq: Rename Nack to NackTracker to avoid name collisions in GN
2016-06-08 13:43:49 +00:00
neteq_external_decoder_unittest.cc
AudioCodingModule: Specify decoders using SdpAudioFormat
2016-10-04 16:33:33 +00:00
neteq_impl_unittest.cc
NetEq now works with packets as values, rather than pointers.
2016-10-24 15:25:33 +00:00
neteq_impl.cc
NetEq now works with packets as values, rather than pointers.
2016-10-24 15:25:33 +00:00
neteq_impl.h
AudioCodingModule: Specify decoders using SdpAudioFormat
2016-10-04 16:33:33 +00:00
neteq_network_stats_unittest.cc
Sort #includes that got unsorted when gmock.h and gtest.h moved to webrtc/test/
2016-10-01 05:29:53 +00:00
neteq_stereo_unittest.cc
Sort #includes that got unsorted when gmock.h and gtest.h moved to webrtc/test/
2016-10-01 05:29:53 +00:00
neteq_tests.gypi
Add gtest as a dependency for neteq_quality_test_support.
2016-08-22 16:48:11 +00:00
neteq_unittest.cc
NetEq: Convert AverageIAT from int to float calculations
2016-10-13 10:35:58 +00:00
neteq_unittest.proto
Update NetEq network statistics in neteq_unittest.
2015-12-16 15:36:10 +00:00
neteq.cc
Moved injection of AudioDecoderFactory into voe::Channel.
2016-05-25 14:37:47 +00:00
neteq.gypi
Moved Opus-specific payload splitting into AudioDecoderOpus.
2016-09-22 09:07:03 +00:00
normal_unittest.cc
Sort #includes that got unsorted when gmock.h and gtest.h moved to webrtc/test/
2016-10-01 05:29:53 +00:00
normal.cc
NetEq: Update CNG code to accommodate 48 kHz sample rate
2016-08-26 06:53:43 +00:00
normal.h
Add RTC_ prefix to contructormagic macros.
2015-09-16 12:37:52 +00:00
OWNERS
Simplify OWNERS structure in modules/audio_coding
2015-06-29 11:54:50 +00:00
packet_buffer_unittest.cc
NetEq now works with packets as values, rather than pointers.
2016-10-24 15:25:33 +00:00
packet_buffer.cc
NetEq now works with packets as values, rather than pointers.
2016-10-24 15:25:33 +00:00
packet_buffer.h
NetEq now works with packets as values, rather than pointers.
2016-10-24 15:25:33 +00:00
packet.cc
NetEq now works with packets as values, rather than pointers.
2016-10-24 15:25:33 +00:00
packet.h
NetEq now works with packets as values, rather than pointers.
2016-10-24 15:25:33 +00:00
post_decode_vad_unittest.cc
Enable the -Wundef warning for clang
2016-09-29 00:42:08 +00:00
post_decode_vad.cc
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
post_decode_vad.h
Add RTC_ prefix to contructormagic macros.
2015-09-16 12:37:52 +00:00
preemptive_expand.cc
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
preemptive_expand.h
Add RTC_ prefix to contructormagic macros.
2015-09-16 12:37:52 +00:00
random_vector_unittest.cc
Enable the -Wundef warning for clang
2016-09-29 00:42:08 +00:00
random_vector.cc
…
random_vector.h
Add RTC_ prefix to contructormagic macros.
2015-09-16 12:37:52 +00:00
red_payload_splitter_unittest.cc
NetEq now works with packets as values, rather than pointers.
2016-10-24 15:25:33 +00:00
red_payload_splitter.cc
NetEq now works with packets as values, rather than pointers.
2016-10-24 15:25:33 +00:00
red_payload_splitter.h
Moved Opus-specific payload splitting into AudioDecoderOpus.
2016-09-22 09:07:03 +00:00
rtcp.cc
NetEq jitter calculation now done in uint64_t.
2016-10-31 15:59:34 +00:00
rtcp.h
NetEq jitter calculation now done in uint64_t.
2016-10-31 15:59:34 +00:00
statistics_calculator.cc
NetEq: Convert AverageIAT from int to float calculations
2016-10-13 10:35:58 +00:00
statistics_calculator.h
audio_coding: rename interface -> include
2015-10-29 10:31:11 +00:00
sync_buffer_unittest.cc
Enable the -Wundef warning for clang
2016-09-29 00:42:08 +00:00
sync_buffer.cc
Remove unused stuff from AudioFrame:
2016-03-29 23:42:12 +00:00
sync_buffer.h
Unit test for AudioFrame output from AcmReceiver::GetAudio
2016-04-06 08:03:07 +00:00
tick_timer_unittest.cc
Enable the -Wundef warning for clang
2016-09-29 00:42:08 +00:00
tick_timer.cc
Add a new TickTimer class to NetEq
2016-04-22 20:21:49 +00:00
tick_timer.h
Add a new TickTimer class to NetEq
2016-04-22 20:21:49 +00:00
time_stretch_unittest.cc
Sort #includes that got unsorted when gmock.h and gtest.h moved to webrtc/test/
2016-10-01 05:29:53 +00:00
time_stretch.cc
Reland "Avoiding overflow in cross correlation in NetEq."
2016-05-02 08:50:34 +00:00
time_stretch.h
Add RTC_ prefix to contructormagic macros.
2015-09-16 12:37:52 +00:00
timestamp_scaler_unittest.cc
NetEq now works with packets as values, rather than pointers.
2016-10-24 15:25:33 +00:00
timestamp_scaler.cc
NetEq now works with packets as values, rather than pointers.
2016-10-24 15:25:33 +00:00
timestamp_scaler.h
Add RTC_ prefix to contructormagic macros.
2015-09-16 12:37:52 +00:00