Mostly this consists of marking functions with override when
applicable, and moving function bodies from .h to .cc files.
Not inlining virtual functions with simple bodies such as
{ return false; }
strikes me as probably losing more in readability than we gain in
binary size and compilation time, but I guess it's just like any other
case where enabling a generally good warning forces us to write
slightly worse code in a couple of places.
BUG=163
R=kjellander@webrtc.org, tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/47429004
Cr-Commit-Position: refs/heads/master@{#8656}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8656 4adac7df-926f-26a2-2b94-8c16560cd09d
37 lines
970 B
C++
37 lines
970 B
C++
/*
|
|
* Copyright 2012 The WebRTC Project Authors. All rights reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef WEBRTC_BASE_SHA1DIGEST_H_
|
|
#define WEBRTC_BASE_SHA1DIGEST_H_
|
|
|
|
#include "webrtc/base/messagedigest.h"
|
|
#include "webrtc/base/sha1.h"
|
|
|
|
namespace rtc {
|
|
|
|
// A simple wrapper for our SHA-1 implementation.
|
|
class Sha1Digest : public MessageDigest {
|
|
public:
|
|
enum { kSize = SHA1_DIGEST_SIZE };
|
|
Sha1Digest() {
|
|
SHA1Init(&ctx_);
|
|
}
|
|
size_t Size() const override;
|
|
void Update(const void* buf, size_t len) override;
|
|
size_t Finish(void* buf, size_t len) override;
|
|
|
|
private:
|
|
SHA1_CTX ctx_;
|
|
};
|
|
|
|
} // namespace rtc
|
|
|
|
#endif // WEBRTC_BASE_SHA1DIGEST_H_
|