Revert "Revert "Update video_coding/codecs to new VideoFrameBuffer interface""
This reverts commit 88f94fa36aa61f7904d30251205c544ada2c4301.
Chromium code has been updated.
Original change's description:
> Revert "Update video_coding/codecs to new VideoFrameBuffer interface"
>
> This reverts commit 20ebf4ede803cd4f628ef9378700f60b72f2eab0.
>
> Reason for revert:
>
> Suspect of breaking FYI bots.
> See https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win7%20Tester/builds/9036 and others.
>
> Sample logs:
> Backtrace:
> [5024:1036:0607/173649.857:FATAL:webrtc_video_frame_adapter.cc(98)] Check failed: false.
> Backtrace:
> base::debug::StackTrace::StackTrace [0x02D04A37+55]
> base::debug::StackTrace::StackTrace [0x02CCBB8A+10]
> content::WebRtcVideoFrameAdapter::NativeToI420Buffer [0x0508AD71+305]
> webrtc::VideoFrameBuffer::ToI420 [0x0230BF67+39]
> webrtc::H264EncoderImpl::Encode [0x057E8D0B+267]
> webrtc::VCMGenericEncoder::Encode [0x057E0E34+333]
> webrtc::vcm::VideoSender::AddVideoFrame [0x057DED9B+796]
> webrtc::ViEEncoder::EncodeVideoFrame [0x057C00F6+884]
> webrtc::ViEEncoder::EncodeTask::Run [0x057C12D7+215]
> rtc::TaskQueue::PostTask [0x03EE5CFB+194]
> base::internal::Invoker<base::internal::BindState<enum extensions::`anonymous namespace'::VerificationResult (__cdecl*)(std::unique_ptr<extensions::NetworkingCastPrivateDelegate::Credentials,std::default_delete<extensions::NetworkingCastPrivateDelegate::C [0x02DDCAA5+31]
> base::internal::Invoker<base::internal::BindState<enum extensions::`anonymous namespace'::VerificationResult (__cdecl*)(std::unique_ptr<extensions::NetworkingCastPrivateDelegate::Credentials,std::default_delete<extensions::NetworkingCastPrivateDelegate::C [0x02DDEE86+22]
> base::debug::TaskAnnotator::RunTask [0x02D08289+409]
> base::MessageLoop::RunTask [0x02C8CEC1+1233]
> base::MessageLoop::DoWork [0x02C8C1AD+765]
> base::MessagePumpDefault::Run [0x02D0A20B+219]
> base::MessageLoop::Run [0x02C8C9DB+107]
> base::RunLoop::Run [0x02C89583+147]
> base::Thread::Run [0x02CBEFCD+173]
> base::Thread::ThreadMain [0x02CBFADE+622]
> base::PlatformThread::Sleep [0x02C9E1A2+290]
> BaseThreadInitThunk [0x75C3338A+18]
> RtlInitializeExceptionChain [0x773A9902+99]
> RtlInitializeExceptionChain [0x773A98D5+54]
>
> Original change's description:
> > Update video_coding/codecs to new VideoFrameBuffer interface
> >
> > This is a follow-up cleanup for CL
> > https://codereview.webrtc.org/2847383002/.
> >
> > Bug: webrtc:7632
> > Change-Id: I47861d779968f2fee94db9c017102a8e87e67fb7
> > Reviewed-on: https://chromium-review.googlesource.com/524163
> > Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
> > Reviewed-by: Niels Moller <nisse@webrtc.org>
> > Commit-Queue: Magnus Jedvert <magjed@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#18477}
>
> TBR=magjed@webrtc.org,nisse@webrtc.org,brandtr@webrtc.org
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:7632
>
> Change-Id: I3b73fc7d16ff19ceba196e964dcb36a36510912c
> Reviewed-on: https://chromium-review.googlesource.com/527793
> Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> Commit-Queue: Guido Urdaneta <guidou@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#18489}
TBR=tterriberry@mozilla.com,mflodman@webrtc.org,magjed@webrtc.org,stefan@webrtc.org,guidou@chromium.org,nisse@webrtc.org,brandtr@webrtc.org,webrtc-reviews@webrtc.org
# Not skipping CQ checks because original CL landed > 1 day ago.
No-Presubmit: true
Bug: webrtc:7632
Change-Id: I0962a704e8a9939d4364ce9069c863c9951654c9
Reviewed-on: https://chromium-review.googlesource.com/530684
Commit-Queue: Magnus Jedvert <magjed@webrtc.org>
Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#18527}
72dbe2a211