573b145ab5
This is a reland of commit 905c3a6c73d293882ef11942066ccda52a9e14d1 Change from previous attempt is between ps#1 and ps#2: Use PeerConnectionFactoryInterface::Options to clear the `network_ignore_mask`. Original change's description: > Move injection of PacketSocketFactory from PC to PCF > > Injection via PeerConnectionDependecies was broken, in not accepting > ownership of the injected object. > > Bug: webrtc:7447, webrtc:14204 > Change-Id: Ic53f05d51928b006fc1e46d502633d88471eb518 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266140 > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > Commit-Queue: Niels Moller <nisse@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#37270} Bug: webrtc:7447, webrtc:14204 Change-Id: Ic78ebec2e88a8c44699015c8c7a44e137f44253a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265982 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37290}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.