a5f1de1e65
Reason for revert: New CL for fixing the issues Original issue's description: > Revert of Injectable Obj-C video codecs (patchset #8 id:140001 of https://codereview.webrtc.org/2966023002/ ) > > Reason for revert: > Causes no video in certain scenarios. Please come up with a test plan or unit test to prevent such problems in the future. > > Original issue's description: > > Injectable Obj-C video codecs > > > > Initial CL for this effort, with a working RTCVideoEncoder/Decoder for H264 > > (wrapping the VideoToolbox codec). > > > > Some notes / things left to do: > > - There are some hard-coded references to codec types that are supported by > > webrtc::VideoCodec, cricket::VideoCodec, webrtc::CodecSpecificInfo etc > > since we need to convert to/from these types in ObjCVideoEncoder/Decoder. > > These types would need to be more codec agnostic to avoid this. > > - Most interfaces are borrowed from the design document for injectable > > codecs in Android. Some data in the corresponding C++ classes is discarded > > when converting to the Obj-C version, since it has fewer fields. I have not > > verified whether all data that we do keep is needed, or whether we might be > > losing anything useful in these conversions. > > - Implement the VideoToolbox codec code directly in the RTCVideoEncoderH264 > > classes, instead of wrapping webrtc::H264VideoToolboxEncoder / decoder. > > Eliminates converting between ObjC/C++ types outside the ObjCVideoEncoder/ > > Decoder wrapper classes. > > - List the injected codec factory's supported codecs in the list of codecs in > > AppRTCMobile. > > > > BUG=webrtc:7924 > > R=magjed@webrtc.org > > > > Review-Url: https://codereview.webrtc.org/2966023002 . > > Cr-Commit-Position: refs/heads/master@{#18928} > > Committed:a0349c138d> > TBR=magjed@webrtc.org,andersc@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:7924 > NOTRY=true > > Review-Url: https://codereview.webrtc.org/2975963002 > Cr-Commit-Position: refs/heads/master@{#18979} > Committed:1095ada7adR=magjed@webrtc.org TBR=tkchin@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7924 Review-Url: https://codereview.webrtc.org/2981583002 . Cr-Commit-Position: refs/heads/master@{#19002}
77 lines
2.4 KiB
C++
77 lines
2.4 KiB
C++
/*
|
|
* Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef WEBRTC_SDK_OBJC_FRAMEWORK_CLASSES_COMMON_HELPERS_H_
|
|
#define WEBRTC_SDK_OBJC_FRAMEWORK_CLASSES_COMMON_HELPERS_H_
|
|
|
|
#include <string>
|
|
|
|
namespace webrtc {
|
|
namespace ios {
|
|
|
|
bool CheckAndLogError(BOOL success, NSError* error);
|
|
|
|
NSString *NSStringFromStdString(const std::string& stdString);
|
|
std::string StdStringFromNSString(NSString* nsString);
|
|
|
|
// Return thread ID as a string.
|
|
std::string GetThreadId();
|
|
|
|
// Return thread ID as string suitable for debug logging.
|
|
std::string GetThreadInfo();
|
|
|
|
// Returns [NSThread currentThread] description as string.
|
|
// Example: <NSThread: 0x170066d80>{number = 1, name = main}
|
|
std::string GetCurrentThreadDescription();
|
|
|
|
#if defined(WEBRTC_IOS)
|
|
// Returns the current name of the operating system.
|
|
std::string GetSystemName();
|
|
|
|
// Returns the current version of the operating system as a string.
|
|
std::string GetSystemVersionAsString();
|
|
|
|
// Returns the version of the operating system in double representation.
|
|
// Uses a cached value of the system version.
|
|
double GetSystemVersion();
|
|
|
|
// Returns the device type.
|
|
// Examples: ”iPhone” and ”iPod touch”.
|
|
std::string GetDeviceType();
|
|
#endif // defined(WEBRTC_IOS)
|
|
|
|
// Returns a more detailed device name.
|
|
// Examples: "iPhone 5s (GSM)" and "iPhone 6 Plus".
|
|
std::string GetDeviceName();
|
|
|
|
// Returns the name of the process. Does not uniquely identify the process.
|
|
std::string GetProcessName();
|
|
|
|
// Returns the identifier of the process (often called process ID).
|
|
int GetProcessID();
|
|
|
|
// Returns a string containing the version of the operating system on which the
|
|
// process is executing. The string is string is human readable, localized, and
|
|
// is appropriate for displaying to the user.
|
|
std::string GetOSVersionString();
|
|
|
|
// Returns the number of processing cores available on the device.
|
|
int GetProcessorCount();
|
|
|
|
#if defined(WEBRTC_IOS)
|
|
// Indicates whether Low Power Mode is enabled on the iOS device.
|
|
bool GetLowPowerModeEnabled();
|
|
#endif
|
|
|
|
} // namespace ios
|
|
} // namespace webrtc
|
|
|
|
#endif // WEBRTC_SDK_OBJC_FRAMEWORK_CLASSES_COMMON_HELPERS_H_
|