b17806a4cf
This patch adds a StunDictionary. The dictionary has a reader and a writer. A writer can update a reader by creating a delta. The delta is applied by the reader, and the ack is applied by the writer. Using this mechanism, two ice agents can (in the future) communicate properties w/o manually needing to add new code. The delta and delta-ack attributes has been allocated at IANA. Bug: webrtc:15392 Change-Id: Icdbaf157004258b26ffa0c1f922e083b1ed23899 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/314901 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Jonas Oreland <jonaso@webrtc.org> Cr-Commit-Position: refs/heads/main@{#40513}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.