6060df5948
This is a reland of 11dc6571cb4ff3e71dee1557dfff8d9076e108d3 One fix that makes Web Platform Tests pass in debug mode is applied. Original change's description: > Implement transceiver.stop() > > This adds RtpTransceiver.StopStandard(), which behaves according to > the specification at > https://w3c.github.io/webrtc-pc/#dom-rtcrtptransceiver-stop > > It modifies RTCPeerConnection.getTransceivers() to return only > transceivers that have not been stopped. > > Rebase of armax' https://webrtc-review.googlesource.com/c/src/+/172762 > > Bug: chromium:980879 > Change-Id: I7d383ee874ccc0a006fdcf280496b5d4235425ce > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180580 > Reviewed-by: Kári Helgason <kthelgason@webrtc.org> > Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> > Reviewed-by: Guido Urdaneta <guidou@webrtc.org> > Commit-Queue: Harald Alvestrand <hta@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#31893} Bug: chromium:980879 Change-Id: Ide31d929ac5ea118d83fdf6a35a592af23f7dfa7 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/181263 Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Guido Urdaneta <guidou@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31907}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.