They can all benefit from moving, since they contain std::string and std::vector. We intended to add these in https://codereview.webrtc.org/1896953004/, but got compiler errors we couldn't make sense of, so we skipped them. It turns out that what the compiler was complaining about was that when we said we'd have a user-defined move constructor, it stopped generating a copy assignment operator for us. This CL solves the problem by outfitting the types with defaulted copy and move assignment operators too. Review URL: https://codereview.webrtc.org/1899173002 Cr-Commit-Position: refs/heads/master@{#12469}
69 lines
2.0 KiB
C++
69 lines
2.0 KiB
C++
/*
|
|
* Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "webrtc/modules/audio_coding/codecs/audio_encoder.h"
|
|
|
|
#include "webrtc/base/checks.h"
|
|
#include "webrtc/base/trace_event.h"
|
|
|
|
namespace webrtc {
|
|
|
|
AudioEncoder::EncodedInfo::EncodedInfo() = default;
|
|
AudioEncoder::EncodedInfo::EncodedInfo(const EncodedInfo&) = default;
|
|
AudioEncoder::EncodedInfo::EncodedInfo(EncodedInfo&&) = default;
|
|
AudioEncoder::EncodedInfo::~EncodedInfo() = default;
|
|
AudioEncoder::EncodedInfo& AudioEncoder::EncodedInfo::operator=(
|
|
const EncodedInfo&) = default;
|
|
AudioEncoder::EncodedInfo& AudioEncoder::EncodedInfo::operator=(EncodedInfo&&) =
|
|
default;
|
|
|
|
int AudioEncoder::RtpTimestampRateHz() const {
|
|
return SampleRateHz();
|
|
}
|
|
|
|
AudioEncoder::EncodedInfo AudioEncoder::Encode(
|
|
uint32_t rtp_timestamp,
|
|
rtc::ArrayView<const int16_t> audio,
|
|
rtc::Buffer* encoded) {
|
|
TRACE_EVENT0("webrtc", "AudioEncoder::Encode");
|
|
RTC_CHECK_EQ(audio.size(),
|
|
static_cast<size_t>(NumChannels() * SampleRateHz() / 100));
|
|
|
|
const size_t old_size = encoded->size();
|
|
EncodedInfo info = EncodeImpl(rtp_timestamp, audio, encoded);
|
|
RTC_CHECK_EQ(encoded->size() - old_size, info.encoded_bytes);
|
|
return info;
|
|
}
|
|
|
|
bool AudioEncoder::SetFec(bool enable) {
|
|
return !enable;
|
|
}
|
|
|
|
bool AudioEncoder::SetDtx(bool enable) {
|
|
return !enable;
|
|
}
|
|
|
|
bool AudioEncoder::SetApplication(Application application) {
|
|
return false;
|
|
}
|
|
|
|
void AudioEncoder::SetMaxPlaybackRate(int frequency_hz) {}
|
|
|
|
void AudioEncoder::SetProjectedPacketLossRate(double fraction) {}
|
|
|
|
void AudioEncoder::SetTargetBitrate(int target_bps) {}
|
|
|
|
size_t AudioEncoder::MaxEncodedBytes() const {
|
|
RTC_CHECK(false);
|
|
return 0;
|
|
}
|
|
|
|
} // namespace webrtc
|