b46083ed63
to use for the APM. It allows simple and rapid additions of exploratory data logpoints to use during bug investigations and module performance analysis. The new data logging functionality is also in this CL used to replace the existing data logging functionality present in the AEC. Additional information: As there was an issue with that the build flag for activating this feature was not present in all compilation units that included the feature additional changes were needed. A summary of the changes are -The build files were modified to ensure that the logging build flag always is set to either 0 or 1 for compilation units that include the feature. -Build-time checks in the appropriate places were added to ensure that the above is fulfilled. -The build object was added dynamically to the AEC state as a pointer to ensure that the size of that state is not dependent on whether the logging build flag is set or not. -The constructor of the AEC class needed to be modified in order to construct the logging object. For this a destructor was also needed. -An unused method without any declaration was removed in order to avoid any issues with the logging flag being set to 0 or 1. This CL will be immediately followed with an upcoming CL that replaces the logging in echo_cancellation.cc with the new functionality which will ensure that the logging flag is only used in one place within WebRTC, which in turn will fully ensure that all compilation units that uses the feature also have the flag properly set. BUG=webrtc:5201, webrtc:5298 Review-Url: https://codereview.webrtc.org/1877713002 Cr-Commit-Position: refs/heads/master@{#12607}
66 lines
1.8 KiB
C++
66 lines
1.8 KiB
C++
/*
|
|
* Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "webrtc/modules/audio_processing/logging/apm_data_dumper.h"
|
|
|
|
#include <sstream>
|
|
|
|
#include "webrtc/base/stringutils.h"
|
|
|
|
// Check to verify that the define is properly set.
|
|
#if !defined(WEBRTC_AEC_DEBUG_DUMP) || \
|
|
(WEBRTC_AEC_DEBUG_DUMP != 0 && WEBRTC_AEC_DEBUG_DUMP != 1)
|
|
#error "Set WEBRTC_AEC_DEBUG_DUMP to either 0 or 1"
|
|
#endif
|
|
|
|
namespace webrtc {
|
|
|
|
namespace {
|
|
|
|
#if WEBRTC_AEC_DEBUG_DUMP == 1
|
|
std::string FormFileName(const char* name,
|
|
int instance_index,
|
|
int reinit_index,
|
|
const std::string& suffix) {
|
|
std::stringstream ss;
|
|
ss << name << "_" << instance_index << "-" << reinit_index << suffix;
|
|
return ss.str();
|
|
}
|
|
#endif
|
|
|
|
} // namespace
|
|
|
|
#if WEBRTC_AEC_DEBUG_DUMP == 1
|
|
FILE* ApmDataDumper::GetRawFile(const char* name) {
|
|
std::string filename =
|
|
FormFileName(name, instance_index_, recording_set_index_, ".dat");
|
|
auto& f = raw_files_[filename];
|
|
if (!f) {
|
|
f.reset(fopen(filename.c_str(), "wb"));
|
|
}
|
|
return f.get();
|
|
}
|
|
|
|
WavWriter* ApmDataDumper::GetWavFile(const char* name,
|
|
int sample_rate_hz,
|
|
int num_channels) {
|
|
std::string filename =
|
|
FormFileName(name, instance_index_, recording_set_index_, ".wav");
|
|
auto& f = wav_files_[filename];
|
|
if (!f) {
|
|
f.reset(new WavWriter(filename.c_str(), sample_rate_hz, num_channels));
|
|
}
|
|
return f.get();
|
|
}
|
|
|
|
#endif
|
|
|
|
} // namespace webrtc
|