admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
webrtc_m130/sdk/BUILD.gn

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

1751 lines
58 KiB
Plaintext
Raw Normal View History

Build dynamic iOS SDK. - Places most ObjC code into webrtc/sdk/objc instead. - New gyp targets to build, strip and export symbols for dylib. - Removes old script used to generate dylib. BUG= Review URL: https://codereview.webrtc.org/1903663002 Cr-Commit-Position: refs/heads/master@{#12524}
2016-04-27 01:54:20 -07:00
# Copyright 2016 The WebRTC project authors. All Rights Reserved.
#
# Use of this source code is governed by a BSD-style license
# that can be found in the LICENSE file in the root of the source
# tree. An additional intellectual property rights grant can be found
# in the file PATENTS. All contributing project authors may
# be found in the AUTHORS file in the root of the source tree.
Make the libaom AV1 encoder optional in RTCDefaultVideoEncoderFactory. This is a partial revert of: https://webrtc-review.googlesource.com/c/src/+/262814 skip_shebang_check=True bug: webrtc:13573 Change-Id: I08282df91446efa79ca86cc8dfe3b6daeb4eec9a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264543 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37074}
2022-05-31 17:24:44 +02:00
import("//third_party/libaom/options.gni")
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
import("../webrtc.gni")
[GN] Add rtc_sdk_framework_objc target to GN The build artifacts don't look completely identical to the ones generated by the GYP targets, but manual review shows the same symbols are exported. On iOS, the version generated by the GN follows convention, including a "Headers" directory, and the .modulemap file. I think this is preferred over the gyp version. BUG=webrtc:6320 NOTRY=True TESTED=Run AppRTCDemo on iOS + Mac and verified with nm that they export the same symbols. Review-Url: https://codereview.webrtc.org/2340633003 Cr-Commit-Position: refs/heads/master@{#14228}
2016-09-15 04:30:18 -07:00
if (is_ios) {
Enable more unittests on iOS, and disable those that fail on simulator Tests enabled: * modules_unittests * ortc_unittests * rtc_media_unittests * rtc_unittests * video_capture_tests * video_engine_tests BUG=webrtc:5566,webrtc:4752,webrtc:5568,webrtc:5569 Review-Url: https://codereview.webrtc.org/2938193002 Cr-Commit-Position: refs/heads/master@{#18710}
2017-06-22 01:47:20 -07:00
import("//build/config/ios/ios_sdk.gni")
Move webrtc::CreatePeerConnectionFactory definition next to decl. This CL moves webrtc::CreatePeerConnectionFactory definitions out of pc:create_pc_factory and merges it with its declaration in the api/ directory. In order to avoid circular dependencies a new build target is created: * api:create_peerconnection_factory Bug: webrtc:9862 Change-Id: Ie215c94460cba026f5bf7d11c9a5aa03792064af Reviewed-on: https://webrtc-review.googlesource.com/c/111186 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25744}
2018-11-22 09:00:13 +01:00
import("//build/config/ios/rules.gni")
[GN] Add rtc_sdk_framework_objc target to GN The build artifacts don't look completely identical to the ones generated by the GYP targets, but manual review shows the same symbols are exported. On iOS, the version generated by the GN follows convention, including a "Headers" directory, and the .modulemap file. I think this is preferred over the gyp version. BUG=webrtc:6320 NOTRY=True TESTED=Run AppRTCDemo on iOS + Mac and verified with nm that they export the same symbols. Review-Url: https://codereview.webrtc.org/2340633003 Cr-Commit-Position: refs/heads/master@{#14228}
2016-09-15 04:30:18 -07:00
}
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
if (is_mac) {
import("//build/config/mac/rules.gni")
Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2911053002/ ) Reason for revert: Take three of relanding this after all internal issues have been resolved. Original issue's description: > Revert of Split iOS sdk in to separate targets (patchset #3 id:320001 of https://codereview.webrtc.org/2893843003/ ) > > Reason for revert: > Breaks downstream project. > > Original issue's description: > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2893593002/ ) > > > > Reason for revert: > > Take two of fixing downstream issues? > > > > Original issue's description: > > > Revert of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890733003/ ) > > > > > > Reason for revert: > > > Still problems with downstream projects > > > > > > Original issue's description: > > > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890513002/ ) > > > > > > > > Reason for revert: > > > > Fixing downstream breakages > > > > > > > > Original issue's description: > > > > > Revert of Split iOS sdk in to separate targets (patchset #13 id:280001 of https://codereview.webrtc.org/2862543002/ ) > > > > > > > > > > Reason for revert: > > > > > Breaking downstream projects. > > > > > > > > > > Original issue's description: > > > > > > Split iOS sdk in to separate targets > > > > > > > > > > > > This CL splits the iOS sdk into separate static libraries for video, > > > > > > audio, ui, common, and peerconnection-related code. This will in the > > > > > > future make it easier to compile WebRTC without unneeded components. > > > > > > > > > > > > BUG=webrtc:4867 > > > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2862543002 > > > > > > Cr-Commit-Position: refs/heads/master@{#18166} > > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/52c83fe7102f566cf35a7533092873d58b38f426 > > > > > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,kthelgason@webrtc.org > > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > > NOPRESUBMIT=true > > > > > NOTREECHECKS=true > > > > > NOTRY=true > > > > > BUG=webrtc:4867 > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2890513002 > > > > > Cr-Commit-Position: refs/heads/master@{#18170} > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/9756238084707787f735e1294e896e462e459717 > > > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > NOPRESUBMIT=true > > > > NOTREECHECKS=true > > > > NOTRY=true > > > > BUG=webrtc:4867 > > > > > > > > Review-Url: https://codereview.webrtc.org/2890733003 > > > > Cr-Commit-Position: refs/heads/master@{#18174} > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/d51e042492bedd057bc0cac7828979d5c7369cea > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=webrtc:4867 > > > > > > Review-Url: https://codereview.webrtc.org/2893593002 > > > Cr-Commit-Position: refs/heads/master@{#18182} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/37144b214e2baf62ecb262ab878dde8c59cdd6a3 > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=webrtc:4867 > > > > Review-Url: https://codereview.webrtc.org/2893843003 > > Cr-Commit-Position: refs/heads/master@{#18303} > > Committed: https://chromium.googlesource.com/external/webrtc/+/580c3522d294c877adfe555048c675bd8d166657 > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org,kthelgason@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:4867 > > Review-Url: https://codereview.webrtc.org/2911053002 > Cr-Commit-Position: refs/heads/master@{#18309} > Committed: https://chromium.googlesource.com/external/webrtc/+/af5c05540cc8208f682cafe88c5c16a505479196 TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org,mbonadei@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4867 Review-Url: https://codereview.webrtc.org/2913753003 Cr-Commit-Position: refs/heads/master@{#18319}
2017-05-30 01:48:47 -07:00
}
GN: New conventions, default target and refactorings Introduce a convention on categorizing GN targets: 1. Production code 2. Tests 3. Examples 4. Tools The first two have targets spread out all over the tree, while the latter are isolated to examples/ and tools/ directories. Another new convention: Each directory's BUILD.gn file shall contain a target named similar to the directory name. This target shall contain the 'most common' production code, i.e. so that most consumers of the directory can depend on only the directory (which implicitly means that target in GN). //webrtc:webrtc_tests is changed to depend on all WebRTC tests. From now on, it's necessary to add new test targets to this dependency tree in order to get them compiled. Two new group targets are created: //webrtc/modules/audio_coding:audio_coding_tests //webrtc/modules/audio_processing:audio_processing_tests to reduce the long list of tests in //webrtc:webrtc_tests. Visibility on //webrtc:webrtc and //webrtc:webrtc_tests is restricted to the root target, to avoid circular dependencies due to the monolithic property of these targets (a problem we've had in the past). The 'root' target at the top level is renamed to 'default', which means GN will build this target instead of _all_ generated targets (see https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/faq.md#Can-I-control-what-targets-are-built-by-default). This target now depends on everything we want to build, meaning all targets now explicitly needs to be wired up from the root target in order to get build. Having this, the number of compiled objects on Android is decreased from 8855 to 6276. It also gives us better control over our build. BUG=webrtc:6440 TESTED=git cl try --clobber NOTRY=True Review-Url: https://codereview.webrtc.org/2441383002 Cr-Commit-Position: refs/heads/master@{#14821}
2016-10-28 05:44:03 -07:00
group("sdk") {
Enable libjingle_peerconnection_datachannelonly_so target. This change also wires up the rest of the production code in webrtc/sdk/android to be built when the directory is a dependency. BUG=webrtc:7613 NOTRY=True Change-Id: Ideda181970a5a570c3f8148b033e471e926243d1 Reviewed-on: https://chromium-review.googlesource.com/548038 Reviewed-by: Zhi Huang <zhihuang@webrtc.org> Commit-Queue: Henrik Kjellander <kjellander@webrtc.org> Cr-Commit-Position: refs/heads/master@{#18791}
2017-06-27 08:56:46 +02:00
public_deps = []
if (!build_with_chromium) {
if (is_android) {
public_deps += [ "android" ]
}
if (is_ios) {
Rename all objc targets to be suffixed for consistency BUG=webrtc:6412 Review-Url: https://codereview.webrtc.org/3001023003 Cr-Commit-Position: refs/heads/master@{#19489}
2017-08-24 05:43:45 -07:00
public_deps += [ ":framework_objc" ]
Enable libjingle_peerconnection_datachannelonly_so target. This change also wires up the rest of the production code in webrtc/sdk/android to be built when the directory is a dependency. BUG=webrtc:7613 NOTRY=True Change-Id: Ideda181970a5a570c3f8148b033e471e926243d1 Reviewed-on: https://chromium-review.googlesource.com/548038 Reviewed-by: Zhi Huang <zhihuang@webrtc.org> Commit-Queue: Henrik Kjellander <kjellander@webrtc.org> Cr-Commit-Position: refs/heads/master@{#18791}
2017-06-27 08:56:46 +02:00
}
GN: New conventions, default target and refactorings Introduce a convention on categorizing GN targets: 1. Production code 2. Tests 3. Examples 4. Tools The first two have targets spread out all over the tree, while the latter are isolated to examples/ and tools/ directories. Another new convention: Each directory's BUILD.gn file shall contain a target named similar to the directory name. This target shall contain the 'most common' production code, i.e. so that most consumers of the directory can depend on only the directory (which implicitly means that target in GN). //webrtc:webrtc_tests is changed to depend on all WebRTC tests. From now on, it's necessary to add new test targets to this dependency tree in order to get them compiled. Two new group targets are created: //webrtc/modules/audio_coding:audio_coding_tests //webrtc/modules/audio_processing:audio_processing_tests to reduce the long list of tests in //webrtc:webrtc_tests. Visibility on //webrtc:webrtc and //webrtc:webrtc_tests is restricted to the root target, to avoid circular dependencies due to the monolithic property of these targets (a problem we've had in the past). The 'root' target at the top level is renamed to 'default', which means GN will build this target instead of _all_ generated targets (see https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/faq.md#Can-I-control-what-targets-are-built-by-default). This target now depends on everything we want to build, meaning all targets now explicitly needs to be wired up from the root target in order to get build. Having this, the number of compiled objects on Android is decreased from 8855 to 6276. It also gives us better control over our build. BUG=webrtc:6440 TESTED=git cl try --clobber NOTRY=True Review-Url: https://codereview.webrtc.org/2441383002 Cr-Commit-Position: refs/heads/master@{#14821}
2016-10-28 05:44:03 -07:00
}
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("media_constraints") {
Move MediaConstraintsInterface to sdk/, and make it a concrete class Bug: webrtc:9239 Change-Id: I545ebf59b078dd94bc466886616dd374e4b2e226 Reviewed-on: https://webrtc-review.googlesource.com/c/122502 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26682}
2019-02-13 08:52:27 +01:00
sources = [
"media_constraints.cc",
"media_constraints.h",
]
deps = [
"../api:audio_options_api",
"../api:libjingle_peerconnection_api",
]
Use absl_deps in order to preapre to the Abseil component build release. Bug: webrtc:1046390 Change-Id: Ia35545599de23b1a2c2d8be2d53469af7ac16f1d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176502 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31463}
2020-06-05 14:30:41 +02:00
absl_deps = [ "//third_party/abseil-cpp/absl/types:optional" ]
Move MediaConstraintsInterface to sdk/, and make it a concrete class Bug: webrtc:9239 Change-Id: I545ebf59b078dd94bc466886616dd374e4b2e226 Reviewed-on: https://webrtc-review.googlesource.com/c/122502 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26682}
2019-02-13 08:52:27 +01:00
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("sdk_tests") {
Move MediaConstraintsInterface to sdk/, and make it a concrete class Bug: webrtc:9239 Change-Id: I545ebf59b078dd94bc466886616dd374e4b2e226 Reviewed-on: https://webrtc-review.googlesource.com/c/122502 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26682}
2019-02-13 08:52:27 +01:00
testonly = true
Replace RTC_FALLTHROUGH with ABSL_FALLTHROUGH_INTENTED Bug: None Change-Id: I7287403f3fb13b8e30f92ca3cf1882b03bb53a6e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166176 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30283}
2020-01-16 14:41:10 +01:00
sources = [ "media_constraints_unittest.cc" ]
Move MediaConstraintsInterface to sdk/, and make it a concrete class Bug: webrtc:9239 Change-Id: I545ebf59b078dd94bc466886616dd374e4b2e226 Reviewed-on: https://webrtc-review.googlesource.com/c/122502 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26682}
2019-02-13 08:52:27 +01:00
deps = [
":media_constraints",
"../test:test_support",
]
}
Bump mac deployment target to 10.9 BUG=webrtc:6431 Review-Url: https://codereview.webrtc.org/2488943002 Cr-Commit-Position: refs/heads/master@{#15004}
2016-11-09 07:44:27 -08:00
if (is_ios || is_mac) {
Rename all objc targets to be suffixed for consistency BUG=webrtc:6412 Review-Url: https://codereview.webrtc.org/3001023003 Cr-Commit-Position: refs/heads/master@{#19489}
2017-08-24 05:43:45 -07:00
config("common_config_objc") {
Fix iOS GN build and cleanup system_wrappers Compile fixes for GN on iOS that finally gets our bots green. Changes to system_wrappers: * Updated to only use inclusive sources for maintainability * Add a few missing GN headers. * Cleanup GYP hack for atomic32_mac.cc * Renamed changes sources to avoid problems with GYP/GN file suffix rules: - atomic32_mac.cc -> atomic32_darwin.cc - atomic32_posix.cc -> atomic32_non_darwin_unix.cc See https://code.google.com/p/chromium/codesearch#chromium/src/build/config/BUILDCONFIG.gn&l=325 for details on which extensions can/cannot be used. BUG=webrtc:5586 NOTRY=True Review-Url: https://codereview.webrtc.org/1999723002 Cr-Commit-Position: refs/heads/master@{#12897}
2016-05-25 11:37:11 -07:00
include_dirs = [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc",
# This is needed so that framework headers can include base headers
# without pathname (so it works from within the framework module).
"objc/base",
Fix iOS GN build and cleanup system_wrappers Compile fixes for GN on iOS that finally gets our bots green. Changes to system_wrappers: * Updated to only use inclusive sources for maintainability * Add a few missing GN headers. * Cleanup GYP hack for atomic32_mac.cc * Renamed changes sources to avoid problems with GYP/GN file suffix rules: - atomic32_mac.cc -> atomic32_darwin.cc - atomic32_posix.cc -> atomic32_non_darwin_unix.cc See https://code.google.com/p/chromium/codesearch#chromium/src/build/config/BUILDCONFIG.gn&l=325 for details on which extensions can/cannot be used. BUG=webrtc:5586 NOTRY=True Review-Url: https://codereview.webrtc.org/1999723002 Cr-Commit-Position: refs/heads/master@{#12897}
2016-05-25 11:37:11 -07:00
]
Reenable some supressed warnings for the objc SDK. Bug: webrtc:8441 Change-Id: I6b427dfc1fe275e274d042766e0850628cf19994 Reviewed-on: https://webrtc-review.googlesource.com/15000 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20425}
2017-10-24 15:28:51 +02:00
cflags = [
Explicitly retain self in objc blocks to avoid compiler warning. Implicitly retaining self pointer (assuming this is intended behavior) causes compiler warning `-Wimplicit-retain-self`. We should do it explicitly. Bug: webrtc:9971 Change-Id: If77a67168d8a65ced78d5119b9a7332391d20bc9 Reviewed-on: https://webrtc-review.googlesource.com/c/109641 Commit-Queue: Jiawei Ou <ouj@fb.com> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25609}
2018-11-09 13:55:45 -08:00
"-Wimplicit-retain-self",
Reenable some supressed warnings for the objc SDK. Bug: webrtc:8441 Change-Id: I6b427dfc1fe275e274d042766e0850628cf19994 Reviewed-on: https://webrtc-review.googlesource.com/15000 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20425}
2017-10-24 15:28:51 +02:00
"-Wstrict-overflow",
"-Wmissing-field-initializers",
]
Reland "Added support of getting coverage on mac" This is a reland of 207cfdfbd8896e093f7088123eb729df174614d3 This was not a cause of bug chromium:888061 Original change's description: > Added support of getting coverage on mac > > Bug: chromium:844647 > Change-Id: Ia358d3a1dfc9a53149d68f811652f38245a0b408 > Reviewed-on: https://webrtc-review.googlesource.com/101041 > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > Commit-Queue: Artem Titarenko <artit@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#24779} Bug: chromium:844647 Change-Id: I14ecd48f2c6e5cf4978110b6aefae02222d3ff1e Reviewed-on: https://webrtc-review.googlesource.com/101780 Reviewed-by: Artem Titarenko <artit@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24817}
2018-09-19 17:53:59 +02:00
if (use_clang_coverage) {
configs = [ "//build/config/coverage:default_coverage" ]
}
Fix iOS GN build and cleanup system_wrappers Compile fixes for GN on iOS that finally gets our bots green. Changes to system_wrappers: * Updated to only use inclusive sources for maintainability * Add a few missing GN headers. * Cleanup GYP hack for atomic32_mac.cc * Renamed changes sources to avoid problems with GYP/GN file suffix rules: - atomic32_mac.cc -> atomic32_darwin.cc - atomic32_posix.cc -> atomic32_non_darwin_unix.cc See https://code.google.com/p/chromium/codesearch#chromium/src/build/config/BUILDCONFIG.gn&l=325 for details on which extensions can/cannot be used. BUG=webrtc:5586 NOTRY=True Review-Url: https://codereview.webrtc.org/1999723002 Cr-Commit-Position: refs/heads/master@{#12897}
2016-05-25 11:37:11 -07:00
}
Broadcast extension for AppRTCMobile on iOS This provides an environment for testing out using WebRTC from an iOS extension. It implements a ReplayKit broadcast extension for live streaming games and screensharing. The extension is only supported on iOS 11+ and is guarded by a build flag. Bug: webrtc:9335 Change-Id: Id218d6c73ef7599f5953c5a1e0e62e5d0dc4f10b Reviewed-on: https://webrtc-review.googlesource.com/80000 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23504}
2018-06-04 10:24:37 +02:00
config("used_from_extension") {
if (is_ios && rtc_apprtcmobile_broadcast_extension) {
cflags = [ "-fapplication-extension" ]
}
}
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
# TODO(bugs.webrtc.org/9627): Remove this when unused. Targets should depend on base_objc
# or helpers_objc directly instead.
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("common_objc") {
Change visibility of some build targets that are publicly used. Bug: None Change-Id: I9b0dc56364648ac4d4fa4b8bb67af44700621b24 Reviewed-on: https://webrtc-review.googlesource.com/93282 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24256}
2018-08-09 10:54:40 +02:00
visibility = [ "*" ]
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
Replace RTC_FALLTHROUGH with ABSL_FALLTHROUGH_INTENTED Bug: None Change-Id: I7287403f3fb13b8e30f92ca3cf1882b03bb53a6e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166176 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30283}
2020-01-16 14:41:10 +01:00
sources = [ "objc/helpers/noop.mm" ]
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
public_configs = [ ":common_config_objc" ]
deps = [
":base_objc",
":helpers_objc",
]
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("base_objc") {
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
visibility = [ "*" ]
Build dynamic iOS SDK. - Places most ObjC code into webrtc/sdk/objc instead. - New gyp targets to build, strip and export symbols for dylib. - Removes old script used to generate dylib. BUG= Review URL: https://codereview.webrtc.org/1903663002 Cr-Commit-Position: refs/heads/master@{#12524}
2016-04-27 01:54:20 -07:00
sources = [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/base/RTCCodecSpecificInfo.h",
"objc/base/RTCEncodedImage.h",
"objc/base/RTCEncodedImage.m",
"objc/base/RTCI420Buffer.h",
"objc/base/RTCLogging.h",
"objc/base/RTCLogging.mm",
"objc/base/RTCMacros.h",
"objc/base/RTCMutableI420Buffer.h",
"objc/base/RTCMutableYUVPlanarBuffer.h",
Expose RTCSSLCertificateVerifier from iOS SDK. Bug: webrtc:11710 Change-Id: I825c6350a71b2ff180520f8643cbd4d6febdc883 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/254821 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Yura Yaroshevich <yura.yaroshevich@gmail.com> Cr-Commit-Position: refs/heads/main@{#36284}
2022-03-11 09:22:08 +01:00
"objc/base/RTCSSLCertificateVerifier.h",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/base/RTCVideoCapturer.h",
"objc/base/RTCVideoCapturer.m",
"objc/base/RTCVideoCodecInfo.h",
"objc/base/RTCVideoCodecInfo.m",
"objc/base/RTCVideoDecoder.h",
"objc/base/RTCVideoDecoderFactory.h",
"objc/base/RTCVideoEncoder.h",
"objc/base/RTCVideoEncoderFactory.h",
"objc/base/RTCVideoEncoderQpThresholds.h",
"objc/base/RTCVideoEncoderQpThresholds.m",
"objc/base/RTCVideoEncoderSettings.h",
"objc/base/RTCVideoEncoderSettings.m",
"objc/base/RTCVideoFrame.h",
"objc/base/RTCVideoFrame.mm",
"objc/base/RTCVideoFrameBuffer.h",
"objc/base/RTCVideoRenderer.h",
"objc/base/RTCYUVPlanarBuffer.h",
Build dynamic iOS SDK. - Places most ObjC code into webrtc/sdk/objc instead. - New gyp targets to build, strip and export symbols for dylib. - Removes old script used to generate dylib. BUG= Review URL: https://codereview.webrtc.org/1903663002 Cr-Commit-Position: refs/heads/master@{#12524}
2016-04-27 01:54:20 -07:00
]
iOS/MacOS:Refactor metal rendering by extracting common implementation in separate super class. Included changes: - Fix rendering on iOS to support NV12 and i420 frames - Improve code style - Update build targets - Update tests BUG=webrtc:7079 Review-Url: https://codereview.webrtc.org/2784243003 Cr-Commit-Position: refs/heads/master@{#17923}
2017-04-28 02:14:54 -07:00
Enabling 'gn check' on webrtc/sdk BUG=webrtc:7499 Review-Url: https://codereview.webrtc.org/2818433003 Cr-Commit-Position: refs/heads/master@{#17805}
2017-04-21 00:02:02 -07:00
deps = [
Cleanup BUILD.gn files from imports like foo:foo Repalce all occurrences of foo:foo in deps with just foo in BUILD.gn files. Done with Sublime regex replace. Find: \b([-a-zA-Z0-9_]+):+\1\b In: *.gn Replace with: \1 Bug: None Change-Id: I40aba1b14face687a595b852ffe443cb20197611 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127899 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27225}
2019-03-21 13:35:10 +01:00
"../rtc_base",
Fix circular dependencies between optional, array_view, and rtc_base. This splits things out of rtc_base and makes dependencies explicit. Bug: webrtc:6828 Change-Id: Id521896c3c43595349021c857bec216e429a0c8d Reviewed-on: https://webrtc-review.googlesource.com/32780 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21264}
2017-12-13 16:05:42 +01:00
"../rtc_base:checks",
Remove //rtc_base:logging from public deps Bug: webrtc:8603 Change-Id: I2704da8618f88032adac7ae9eb2a0f47fce4a836 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257908 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Florent Castelli <orphis@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36443}
2022-04-04 15:06:30 +02:00
"../rtc_base:logging",
Enabling 'gn check' on webrtc/sdk BUG=webrtc:7499 Review-Url: https://codereview.webrtc.org/2818433003 Cr-Commit-Position: refs/heads/master@{#17805}
2017-04-21 00:02:02 -07:00
]
Broadcast extension for AppRTCMobile on iOS This provides an environment for testing out using WebRTC from an iOS extension. It implements a ReplayKit broadcast extension for live streaming games and screensharing. The extension is only supported on iOS 11+ and is guarded by a build flag. Bug: webrtc:9335 Change-Id: Id218d6c73ef7599f5953c5a1e0e62e5d0dc4f10b Reviewed-on: https://webrtc-review.googlesource.com/80000 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23504}
2018-06-04 10:24:37 +02:00
configs += [
"..:common_objc",
":used_from_extension",
]
Reland of GN: Enable ARC for Mac and iOS in rtc_* templates (patchset #1 id:1 of https://codereview.webrtc.org/2827223003/ ) Reason for revert: Relanding after fixing ARC issue. Original issue's description: > Revert of GN: Enable ARC for Mac and iOS in rtc_* templates (patchset #3 id:40001 of https://codereview.webrtc.org/2781713004/ ) > > Reason for revert: > Breaks mac build > > Original issue's description: > > GN: Enable ARC for Mac and iOS in rtc_* templates > > > > Remove all uses of retain/release and NSAutoreleasePool. > > > > This makes transformation to Bazel easier. > > > > This CL subsumes https://codereview.webrtc.org/2778163002 and depends on https://codereview.webrtc.org/2784483002/ > > > > BUG=webrtc:6412 > > > > Review-Url: https://codereview.webrtc.org/2781713004 > > Cr-Commit-Position: refs/heads/master@{#17780} > > Committed: https://chromium.googlesource.com/external/webrtc/+/6bda02b51dc00401d2a0d04be996ed10e5acac47 > > TBR=kjellander@webrtc.org,magjed@webrtc.org,stefan@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6412 > > Review-Url: https://codereview.webrtc.org/2827223003 > Cr-Commit-Position: refs/heads/master@{#17784} > Committed: https://chromium.googlesource.com/external/webrtc/+/7c8786ae8f2d8481f74b0ab16eb91a8101fe51dc TBR=kjellander@webrtc.org,magjed@webrtc.org,stefan@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6412 Review-Url: https://codereview.webrtc.org/2834273002 Cr-Commit-Position: refs/heads/master@{#17836}
2017-04-24 00:57:16 -07:00
Rename all objc targets to be suffixed for consistency BUG=webrtc:6412 Review-Url: https://codereview.webrtc.org/3001023003 Cr-Commit-Position: refs/heads/master@{#19489}
2017-08-24 05:43:45 -07:00
public_configs = [ ":common_config_objc" ]
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("helpers_objc") {
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
sources = [
Revert "Add a prefix for objc category." This reverts commit 181ea6e414c5982015ce161e6368120be3658ec4. Reason for revert: Breaks downstream project. Kári will help to land it next week. Original change's description: > Add a prefix for objc category. > > According to the Google Objective-C style [1], category names should > start with an appropriate prefix. WebRTC has some category definitions > for system interfaces, but it doesn't use prefixes. > > $ otool -ov WebRTC.framework/WebRTC | grep -E "^[0-9a-z]{16} 0x[0-9a-z]+ __OBJC_._CATEGORY" | grep -v "_RTC" > 0000000002160840 0x217c3c0 __OBJC_$_CATEGORY_UIDevice_$_H264Profile > 0000000002160850 0x21808b8 __OBJC_$_CATEGORY_AVCaptureSession_$_DevicePosition > 0000000002160858 0x2180968 __OBJC_$_CATEGORY_NSString_$_StdString > 0000000002160860 0x21809c8 __OBJC_$_CATEGORY_NSString_$_AbslStringView > > To avoid conflicts, prefix the names and methods of those categories. > Also remove sdk/objc/Framework/Classes/Common/NSString+StdString.h as > it is not used by any other files. > > [1] https://google.github.io/styleguide/objcguide.html#category-naming > > Bug: webrtc:13884 > Change-Id: I2cf2742af198ab4e0bfb15c0476d72971e50ceee > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262341 > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Kári Helgason <kthelgason@webrtc.org> > Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com> > Reviewed-by: Artem Titov <titovartem@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#36880} Bug: webrtc:13884 Change-Id: I85257088e4a3a62e01ff925ab5e77af83b078ef3 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262420 Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Artem Titov <titovartem@webrtc.org> Auto-Submit: Artem Titov <titovartem@webrtc.org> Owners-Override: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36885}
2022-05-13 14:46:42 +00:00
"objc/helpers/AVCaptureSession+DevicePosition.h",
"objc/helpers/AVCaptureSession+DevicePosition.mm",
"objc/helpers/NSString+StdString.h",
"objc/helpers/NSString+StdString.mm",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/helpers/RTCDispatcher+Private.h",
"objc/helpers/RTCDispatcher.h",
"objc/helpers/RTCDispatcher.m",
"objc/helpers/scoped_cftyperef.h",
]
deps = [
":base_objc",
"../rtc_base:checks",
]
Adopt absl::string_view in rtc_base/log_sinks This is part of a large scale effort to increase adoption of absl::string_view across the WebRTC code base. This CL adds absl::string_view versions of the OnLogMessage functions in rtc::LogSink. The const std::string& versions are kept for now since downstream clients use subclasses of LogSink and need to be migrated before these are removed. Bug: webrtc:13579 Change-Id: I57bb72ad503805ff0ca16f1d7aece2d44c65cb73 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/253980 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Xavier Lepaul‎ <xalep@webrtc.org> Owners-Override: Xavier Lepaul‎ <xalep@webrtc.org> Commit-Queue: Ali Tofigh <alito@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36189}
2022-03-14 13:32:04 +01:00
absl_deps = [ "//third_party/abseil-cpp/absl/strings" ]
Convert GN libs lists to frameworks GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: chromium:1052560 Change-Id: I263230ddd3c468061584423bba9e1f887503bcaa Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178601 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#31632}
2020-07-03 10:19:30 +02:00
frameworks = [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"AVFoundation.framework",
"CoreMedia.framework",
]
configs += [
"..:common_objc",
":used_from_extension",
]
public_configs = [ ":common_config_objc" ]
iOS/MacOS:Refactor metal rendering by extracting common implementation in separate super class. Included changes: - Fix rendering on iOS to support NV12 and i420 frames - Improve code style - Update build targets - Update tests BUG=webrtc:7079 Review-Url: https://codereview.webrtc.org/2784243003 Cr-Commit-Position: refs/heads/master@{#17923}
2017-04-28 02:14:54 -07:00
GN: Add SDK tests to rtc_unittests. In https://codereview.webrtc.org/2034923003 it was discovered that a test binary rtc_sdk_peerconnection_objc_tests was a dependency to rtc_unittests. Unfortunately gtest doesn't include dependent executables into the same test executable; only libraries (so theses tests weren't run). This CL incorporates those tests into rtc_unittests and does the same changes to the GN build. BUG=webrtc:5949 TESTED=Built and ran rtc_unittests locally on Mac. NOTRY=True Review-Url: https://codereview.webrtc.org/2041743003 Cr-Commit-Position: refs/heads/master@{#13060}
2016-06-08 01:14:15 -07:00
if (is_ios) {
sources += [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/helpers/RTCCameraPreviewView.h",
"objc/helpers/RTCCameraPreviewView.m",
"objc/helpers/UIDevice+RTCDevice.h",
"objc/helpers/UIDevice+RTCDevice.mm",
GN: Add SDK tests to rtc_unittests. In https://codereview.webrtc.org/2034923003 it was discovered that a test binary rtc_sdk_peerconnection_objc_tests was a dependency to rtc_unittests. Unfortunately gtest doesn't include dependent executables into the same test executable; only libraries (so theses tests weren't run). This CL incorporates those tests into rtc_unittests and does the same changes to the GN build. BUG=webrtc:5949 TESTED=Built and ran rtc_unittests locally on Mac. NOTRY=True Review-Url: https://codereview.webrtc.org/2041743003 Cr-Commit-Position: refs/heads/master@{#13060}
2016-06-08 01:14:15 -07:00
]
iOS/MacOS:Refactor metal rendering by extracting common implementation in separate super class. Included changes: - Fix rendering on iOS to support NV12 and i420 frames - Improve code style - Update build targets - Update tests BUG=webrtc:7079 Review-Url: https://codereview.webrtc.org/2784243003 Cr-Commit-Position: refs/heads/master@{#17923}
2017-04-28 02:14:54 -07:00
}
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
}
iOS/MacOS:Refactor metal rendering by extracting common implementation in separate super class. Included changes: - Fix rendering on iOS to support NV12 and i420 frames - Improve code style - Update build targets - Update tests BUG=webrtc:7079 Review-Url: https://codereview.webrtc.org/2784243003 Cr-Commit-Position: refs/heads/master@{#17923}
2017-04-28 02:14:54 -07:00
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
if (!build_with_chromium) {
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("callback_logger_objc") {
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
sources = [
"objc/api/logging/RTCCallbackLogger.h",
"objc/api/logging/RTCCallbackLogger.mm",
]
deps = [
":base_objc",
Adopt absl::string_view in rtc_base/log_sinks This is part of a large scale effort to increase adoption of absl::string_view across the WebRTC code base. This CL adds absl::string_view versions of the OnLogMessage functions in rtc::LogSink. The const std::string& versions are kept for now since downstream clients use subclasses of LogSink and need to be migrated before these are removed. Bug: webrtc:13579 Change-Id: I57bb72ad503805ff0ca16f1d7aece2d44c65cb73 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/253980 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Xavier Lepaul‎ <xalep@webrtc.org> Owners-Override: Xavier Lepaul‎ <xalep@webrtc.org> Commit-Queue: Ali Tofigh <alito@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36189}
2022-03-14 13:32:04 +01:00
":helpers_objc",
Cleanup BUILD.gn files from imports like foo:foo Repalce all occurrences of foo:foo in deps with just foo in BUILD.gn files. Done with Sublime regex replace. Find: \b([-a-zA-Z0-9_]+):+\1\b In: *.gn Replace with: \1 Bug: None Change-Id: I40aba1b14face687a595b852ffe443cb20197611 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127899 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27225}
2019-03-21 13:35:10 +01:00
"../rtc_base",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"../rtc_base:checks",
"../rtc_base:logging",
]
configs += [
"..:common_objc",
":used_from_extension",
]
Adopt absl::string_view in rtc_base/log_sinks This is part of a large scale effort to increase adoption of absl::string_view across the WebRTC code base. This CL adds absl::string_view versions of the OnLogMessage functions in rtc::LogSink. The const std::string& versions are kept for now since downstream clients use subclasses of LogSink and need to be migrated before these are removed. Bug: webrtc:13579 Change-Id: I57bb72ad503805ff0ca16f1d7aece2d44c65cb73 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/253980 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Xavier Lepaul‎ <xalep@webrtc.org> Owners-Override: Xavier Lepaul‎ <xalep@webrtc.org> Commit-Queue: Ali Tofigh <alito@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36189}
2022-03-14 13:32:04 +01:00
absl_deps = [ "//third_party/abseil-cpp/absl/strings" ]
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("file_logger_objc") {
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
sources = [
"objc/api/peerconnection/RTCFileLogger.h",
"objc/api/peerconnection/RTCFileLogger.mm",
]
deps = [
":base_objc",
Cleanup BUILD.gn files from imports like foo:foo Repalce all occurrences of foo:foo in deps with just foo in BUILD.gn files. Done with Sublime regex replace. Find: \b([-a-zA-Z0-9_]+):+\1\b In: *.gn Replace with: \1 Bug: None Change-Id: I40aba1b14face687a595b852ffe443cb20197611 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127899 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27225}
2019-03-21 13:35:10 +01:00
"../rtc_base",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"../rtc_base:checks",
"../rtc_base:logging",
]
configs += [
"..:common_objc",
":used_from_extension",
Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2911053002/ ) Reason for revert: Take three of relanding this after all internal issues have been resolved. Original issue's description: > Revert of Split iOS sdk in to separate targets (patchset #3 id:320001 of https://codereview.webrtc.org/2893843003/ ) > > Reason for revert: > Breaks downstream project. > > Original issue's description: > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2893593002/ ) > > > > Reason for revert: > > Take two of fixing downstream issues? > > > > Original issue's description: > > > Revert of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890733003/ ) > > > > > > Reason for revert: > > > Still problems with downstream projects > > > > > > Original issue's description: > > > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890513002/ ) > > > > > > > > Reason for revert: > > > > Fixing downstream breakages > > > > > > > > Original issue's description: > > > > > Revert of Split iOS sdk in to separate targets (patchset #13 id:280001 of https://codereview.webrtc.org/2862543002/ ) > > > > > > > > > > Reason for revert: > > > > > Breaking downstream projects. > > > > > > > > > > Original issue's description: > > > > > > Split iOS sdk in to separate targets > > > > > > > > > > > > This CL splits the iOS sdk into separate static libraries for video, > > > > > > audio, ui, common, and peerconnection-related code. This will in the > > > > > > future make it easier to compile WebRTC without unneeded components. > > > > > > > > > > > > BUG=webrtc:4867 > > > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2862543002 > > > > > > Cr-Commit-Position: refs/heads/master@{#18166} > > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/52c83fe7102f566cf35a7533092873d58b38f426 > > > > > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,kthelgason@webrtc.org > > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > > NOPRESUBMIT=true > > > > > NOTREECHECKS=true > > > > > NOTRY=true > > > > > BUG=webrtc:4867 > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2890513002 > > > > > Cr-Commit-Position: refs/heads/master@{#18170} > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/9756238084707787f735e1294e896e462e459717 > > > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > NOPRESUBMIT=true > > > > NOTREECHECKS=true > > > > NOTRY=true > > > > BUG=webrtc:4867 > > > > > > > > Review-Url: https://codereview.webrtc.org/2890733003 > > > > Cr-Commit-Position: refs/heads/master@{#18174} > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/d51e042492bedd057bc0cac7828979d5c7369cea > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=webrtc:4867 > > > > > > Review-Url: https://codereview.webrtc.org/2893593002 > > > Cr-Commit-Position: refs/heads/master@{#18182} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/37144b214e2baf62ecb262ab878dde8c59cdd6a3 > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=webrtc:4867 > > > > Review-Url: https://codereview.webrtc.org/2893843003 > > Cr-Commit-Position: refs/heads/master@{#18303} > > Committed: https://chromium.googlesource.com/external/webrtc/+/580c3522d294c877adfe555048c675bd8d166657 > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org,kthelgason@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:4867 > > Review-Url: https://codereview.webrtc.org/2911053002 > Cr-Commit-Position: refs/heads/master@{#18309} > Committed: https://chromium.googlesource.com/external/webrtc/+/af5c05540cc8208f682cafe88c5c16a505479196 TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org,mbonadei@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4867 Review-Url: https://codereview.webrtc.org/2913753003 Cr-Commit-Position: refs/heads/master@{#18319}
2017-05-30 01:48:47 -07:00
]
}
}
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
if (!build_with_chromium) {
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
if (is_ios) {
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("native_api_audio_device_module") {
Moving iOS Audio Device to sdk. This change forks the existing iOS audio device module and audio device from modules/audio_device/ into sdk/objc/Framework. It also updates RTCPeerConnectionFactory to use the forked implementation. The unit tests are re-implemented as XCTests. (was: https://webrtc-review.googlesource.com/c/src/+/67300) Bug: webrtc:9120 Change-Id: I46c09900246f75ca5285aeb38f7b8b295784ffac Reviewed-on: https://webrtc-review.googlesource.com/76741 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Commit-Queue: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23238}
2018-05-15 10:22:36 +02:00
visibility = [ "*" ]
sources = [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/native/api/audio_device_module.h",
"objc/native/api/audio_device_module.mm",
Moving iOS Audio Device to sdk. This change forks the existing iOS audio device module and audio device from modules/audio_device/ into sdk/objc/Framework. It also updates RTCPeerConnectionFactory to use the forked implementation. The unit tests are re-implemented as XCTests. (was: https://webrtc-review.googlesource.com/c/src/+/67300) Bug: webrtc:9120 Change-Id: I46c09900246f75ca5285aeb38f7b8b295784ffac Reviewed-on: https://webrtc-review.googlesource.com/76741 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Commit-Queue: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23238}
2018-05-15 10:22:36 +02:00
]
deps = [
":audio_device",
Move rtc::make_ref_counted to api/ Bug: webrtc:12701 Change-Id: If49095b101c1a1763c2a44a0284c0d670cce953f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265390 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37219}
2022-06-14 15:48:26 +02:00
"../api:make_ref_counted",
Moving iOS Audio Device to sdk. This change forks the existing iOS audio device module and audio device from modules/audio_device/ into sdk/objc/Framework. It also updates RTCPeerConnectionFactory to use the forked implementation. The unit tests are re-implemented as XCTests. (was: https://webrtc-review.googlesource.com/c/src/+/67300) Bug: webrtc:9120 Change-Id: I46c09900246f75ca5285aeb38f7b8b295784ffac Reviewed-on: https://webrtc-review.googlesource.com/76741 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Commit-Queue: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23238}
2018-05-15 10:22:36 +02:00
"../modules/audio_device:audio_device_api",
"../modules/audio_device:audio_device_generic",
"../rtc_base:checks",
Remove //rtc_base:logging from public deps Bug: webrtc:8603 Change-Id: I2704da8618f88032adac7ae9eb2a0f47fce4a836 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257908 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Florent Castelli <orphis@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36443}
2022-04-04 15:06:30 +02:00
"../rtc_base:logging",
Moving iOS Audio Device to sdk. This change forks the existing iOS audio device module and audio device from modules/audio_device/ into sdk/objc/Framework. It also updates RTCPeerConnectionFactory to use the forked implementation. The unit tests are re-implemented as XCTests. (was: https://webrtc-review.googlesource.com/c/src/+/67300) Bug: webrtc:9120 Change-Id: I46c09900246f75ca5285aeb38f7b8b295784ffac Reviewed-on: https://webrtc-review.googlesource.com/76741 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Commit-Queue: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23238}
2018-05-15 10:22:36 +02:00
"../system_wrappers",
]
}
rtc_source_set("audio_session_observer") {
visibility = [ ":*" ]
Replace RTC_FALLTHROUGH with ABSL_FALLTHROUGH_INTENTED Bug: None Change-Id: I7287403f3fb13b8e30f92ca3cf1882b03bb53a6e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166176 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30283}
2020-01-16 14:41:10 +01:00
sources = [ "objc/native/src/audio/audio_session_observer.h" ]
Moving iOS Audio Device to sdk. This change forks the existing iOS audio device module and audio device from modules/audio_device/ into sdk/objc/Framework. It also updates RTCPeerConnectionFactory to use the forked implementation. The unit tests are re-implemented as XCTests. (was: https://webrtc-review.googlesource.com/c/src/+/67300) Bug: webrtc:9120 Change-Id: I46c09900246f75ca5285aeb38f7b8b295784ffac Reviewed-on: https://webrtc-review.googlesource.com/76741 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Commit-Queue: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23238}
2018-05-15 10:22:36 +02:00
Reland "Refactor rtc_base build targets." This is a reland of 69241a93fb14f6527a26d5c94dde879013012d2a Fix: The problem was related to NO_MAIN_THREAD_WRAPPING, which affects https://source.chromium.org/chromium/chromium/src/+/master:third_party/webrtc/rtc_base/thread.cc;l=257-263;drc=7acc2d9fe3a6e3c4d8881d2bdfc9b8968a724cd5. The original CL didn't attach the definition of the macro NO_MAIN_THREAD_WRAPPING when building for Chromium (which doesn't have to be related to //rtc_base anymore but to //rtc_base:threading). Original change's description: > Refactor rtc_base build targets. > > The "//rtc_base:rtc_base" build target has historically been one of the > biggest targets in the WebRTC build. Big targets are the main source of > circular dependencies and non-API types leakage. > > This CL is a step forward into splitting "//rtc_base:rtc_base" into > smaller targets (as originally started in 2018). > > The only non-automated changes are (like re-wiring the build system): > * The creation of //rtc_base/async_resolver.{h,cc} which allows to > break a circular dependency (is has been extracted from > //rtc_base/net_helpers.{h,cc}). > * The creation of //rtc_base/internal/default_socket_server.{h,cc} to > break another circular dependency. > > Bug: webrtc:9987 > Change-Id: I0c8f5e7efe2c8fd8e6bffa0d6dd2dd494cf3df02 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/196903 > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#32941} Bug: webrtc:9987 Change-Id: I7cdf49d2aac8357f1f50f90010bf2c2f62fa19f6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/202021 Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33001}
2021-01-15 10:41:01 +01:00
deps = [
"../rtc_base",
"../rtc_base:threading",
]
Moving iOS Audio Device to sdk. This change forks the existing iOS audio device module and audio device from modules/audio_device/ into sdk/objc/Framework. It also updates RTCPeerConnectionFactory to use the forked implementation. The unit tests are re-implemented as XCTests. (was: https://webrtc-review.googlesource.com/c/src/+/67300) Bug: webrtc:9120 Change-Id: I46c09900246f75ca5285aeb38f7b8b295784ffac Reviewed-on: https://webrtc-review.googlesource.com/76741 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Commit-Queue: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23238}
2018-05-15 10:22:36 +02:00
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("audio_device") {
Moving iOS Audio Device to sdk. This change forks the existing iOS audio device module and audio device from modules/audio_device/ into sdk/objc/Framework. It also updates RTCPeerConnectionFactory to use the forked implementation. The unit tests are re-implemented as XCTests. (was: https://webrtc-review.googlesource.com/c/src/+/67300) Bug: webrtc:9120 Change-Id: I46c09900246f75ca5285aeb38f7b8b295784ffac Reviewed-on: https://webrtc-review.googlesource.com/76741 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Commit-Queue: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23238}
2018-05-15 10:22:36 +02:00
visibility = [ "*" ]
sources = [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/native/src/audio/audio_device_ios.h",
"objc/native/src/audio/audio_device_ios.mm",
"objc/native/src/audio/audio_device_module_ios.h",
"objc/native/src/audio/audio_device_module_ios.mm",
"objc/native/src/audio/helpers.h",
"objc/native/src/audio/helpers.mm",
"objc/native/src/audio/voice_processing_audio_unit.h",
"objc/native/src/audio/voice_processing_audio_unit.mm",
Moving iOS Audio Device to sdk. This change forks the existing iOS audio device module and audio device from modules/audio_device/ into sdk/objc/Framework. It also updates RTCPeerConnectionFactory to use the forked implementation. The unit tests are re-implemented as XCTests. (was: https://webrtc-review.googlesource.com/c/src/+/67300) Bug: webrtc:9120 Change-Id: I46c09900246f75ca5285aeb38f7b8b295784ffac Reviewed-on: https://webrtc-review.googlesource.com/76741 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Commit-Queue: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23238}
2018-05-15 10:22:36 +02:00
]
deps = [
":audio_objc",
":audio_session_observer",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
":base_objc",
Moving iOS Audio Device to sdk. This change forks the existing iOS audio device module and audio device from modules/audio_device/ into sdk/objc/Framework. It also updates RTCPeerConnectionFactory to use the forked implementation. The unit tests are re-implemented as XCTests. (was: https://webrtc-review.googlesource.com/c/src/+/67300) Bug: webrtc:9120 Change-Id: I46c09900246f75ca5285aeb38f7b8b295784ffac Reviewed-on: https://webrtc-review.googlesource.com/76741 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Commit-Queue: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23238}
2018-05-15 10:22:36 +02:00
"../api:array_view",
Remove //api:sequence_checker from public deps Bug: webrtc:8603 Change-Id: Ib572cdc5b5f4c1f0eb3357e5e0812fc9ce7437c4 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257915 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Florent Castelli <orphis@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36465}
2022-04-04 17:18:21 +02:00
"../api:sequence_checker",
Use Default instead of GlobalTaskQueueFactory to create AudioDeviceBuffer for ios Bug: webrtc:10284 Change-Id: Ibeaf3c79335abe9ac32522156b8e20a6e2266c49 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144034 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28427}
2019-06-27 15:16:34 +02:00
"../api/task_queue",
"../api/task_queue:default_task_queue_factory",
Moving iOS Audio Device to sdk. This change forks the existing iOS audio device module and audio device from modules/audio_device/ into sdk/objc/Framework. It also updates RTCPeerConnectionFactory to use the forked implementation. The unit tests are re-implemented as XCTests. (was: https://webrtc-review.googlesource.com/c/src/+/67300) Bug: webrtc:9120 Change-Id: I46c09900246f75ca5285aeb38f7b8b295784ffac Reviewed-on: https://webrtc-review.googlesource.com/76741 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Commit-Queue: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23238}
2018-05-15 10:22:36 +02:00
"../modules/audio_device:audio_device_api",
"../modules/audio_device:audio_device_buffer",
"../modules/audio_device:audio_device_generic",
Cleanup BUILD.gn files from imports like foo:foo Repalce all occurrences of foo:foo in deps with just foo in BUILD.gn files. Done with Sublime regex replace. Find: \b([-a-zA-Z0-9_]+):+\1\b In: *.gn Replace with: \1 Bug: None Change-Id: I40aba1b14face687a595b852ffe443cb20197611 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127899 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27225}
2019-03-21 13:35:10 +01:00
"../rtc_base",
Cleanup rtc_base_approved target Removed all unused or transitional parts Bug: webrtc:9838 Change-Id: I6bc14e4e0ac09ab27e4d739ac76bb6a4dfff2cb7 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260140 Commit-Queue: Florent Castelli <orphis@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36741}
2022-04-26 22:54:59 +02:00
"../rtc_base:buffer",
Moving iOS Audio Device to sdk. This change forks the existing iOS audio device module and audio device from modules/audio_device/ into sdk/objc/Framework. It also updates RTCPeerConnectionFactory to use the forked implementation. The unit tests are re-implemented as XCTests. (was: https://webrtc-review.googlesource.com/c/src/+/67300) Bug: webrtc:9120 Change-Id: I46c09900246f75ca5285aeb38f7b8b295784ffac Reviewed-on: https://webrtc-review.googlesource.com/76741 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Commit-Queue: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23238}
2018-05-15 10:22:36 +02:00
"../rtc_base:checks",
Remove //rtc_base:logging from public deps Bug: webrtc:8603 Change-Id: I2704da8618f88032adac7ae9eb2a0f47fce4a836 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257908 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Florent Castelli <orphis@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36443}
2022-04-04 15:06:30 +02:00
"../rtc_base:logging",
Remove //rtc_base:macromagic from public deps Bug: webrtc:8603 Change-Id: I9708df48c9bde9f86ba2d1a92a278bb0d09f3865 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257909 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Florent Castelli <orphis@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36444}
2022-04-04 15:18:46 +02:00
"../rtc_base:macromagic",
Remove //rtc_base:refcount from public deps Bug: webrtc:8603 Change-Id: Ib27a107ae809df739492846175f0e9c4af40d21a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257910 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Florent Castelli <orphis@webrtc.org> Reviewed-by: Florent Castelli <orphis@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36447}
2022-04-05 02:54:12 +02:00
"../rtc_base:refcount",
Reland "Refactor rtc_base build targets." This is a reland of 69241a93fb14f6527a26d5c94dde879013012d2a Fix: The problem was related to NO_MAIN_THREAD_WRAPPING, which affects https://source.chromium.org/chromium/chromium/src/+/master:third_party/webrtc/rtc_base/thread.cc;l=257-263;drc=7acc2d9fe3a6e3c4d8881d2bdfc9b8968a724cd5. The original CL didn't attach the definition of the macro NO_MAIN_THREAD_WRAPPING when building for Chromium (which doesn't have to be related to //rtc_base anymore but to //rtc_base:threading). Original change's description: > Refactor rtc_base build targets. > > The "//rtc_base:rtc_base" build target has historically been one of the > biggest targets in the WebRTC build. Big targets are the main source of > circular dependencies and non-API types leakage. > > This CL is a step forward into splitting "//rtc_base:rtc_base" into > smaller targets (as originally started in 2018). > > The only non-automated changes are (like re-wiring the build system): > * The creation of //rtc_base/async_resolver.{h,cc} which allows to > break a circular dependency (is has been extracted from > //rtc_base/net_helpers.{h,cc}). > * The creation of //rtc_base/internal/default_socket_server.{h,cc} to > break another circular dependency. > > Bug: webrtc:9987 > Change-Id: I0c8f5e7efe2c8fd8e6bffa0d6dd2dd494cf3df02 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/196903 > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#32941} Bug: webrtc:9987 Change-Id: I7cdf49d2aac8357f1f50f90010bf2c2f62fa19f6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/202021 Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33001}
2021-01-15 10:41:01 +01:00
"../rtc_base:threading",
Remove //rtc_base:timeutils from public deps Bug: webrtc:8603 Change-Id: Iaca9356d16275a02e8842c783f259131d72ef010 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257914 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Florent Castelli <orphis@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36460}
2022-04-04 17:16:15 +02:00
"../rtc_base:timeutils",
Adds workaround for audio not restarting after interruption Bug: webrtc:8126 Change-Id: I9499e7bf06cad598fd4406b590354d695fa1a9d6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/129927 Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27337}
2019-03-28 11:03:27 +01:00
"../system_wrappers:field_trial",
Remove deprecated field_trial_default and metrics_default. This CL removes some deprecated build targets (and their headers) from system_wrappers: - field_trial_api - field_trial_default - metrics_api - metrics_default It also refreshes all the dependencies on field_trial.h and metrics.h. A nice side effect is that it is finally possible to remove 'nogncheck' from the following files (when it was used with field_trial_default and metrics_default): - sdk/objc/api/peerconnection/RTCMetricsSampleInfo+Private.h - sdk/android/src/jni/pc/peerconnectionfactory.cc - sdk/objc/api/peerconnection/RTCFieldTrials.mm Bug: webrtc:9631 Change-Id: Ib621f41ef8ad0aba4fe1c1d7e749c044afc956c3 No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/100524 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24878}
2018-09-28 08:51:10 +02:00
"../system_wrappers:metrics",
Moving iOS Audio Device to sdk. This change forks the existing iOS audio device module and audio device from modules/audio_device/ into sdk/objc/Framework. It also updates RTCPeerConnectionFactory to use the forked implementation. The unit tests are re-implemented as XCTests. (was: https://webrtc-review.googlesource.com/c/src/+/67300) Bug: webrtc:9120 Change-Id: I46c09900246f75ca5285aeb38f7b8b295784ffac Reviewed-on: https://webrtc-review.googlesource.com/76741 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Commit-Queue: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23238}
2018-05-15 10:22:36 +02:00
]
Use absl_deps in order to preapre to the Abseil component build release. Bug: webrtc:1046390 Change-Id: Ia35545599de23b1a2c2d8be2d53469af7ac16f1d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176502 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31463}
2020-06-05 14:30:41 +02:00
absl_deps = [ "//third_party/abseil-cpp/absl/base:core_headers" ]
Moving iOS Audio Device to sdk. This change forks the existing iOS audio device module and audio device from modules/audio_device/ into sdk/objc/Framework. It also updates RTCPeerConnectionFactory to use the forked implementation. The unit tests are re-implemented as XCTests. (was: https://webrtc-review.googlesource.com/c/src/+/67300) Bug: webrtc:9120 Change-Id: I46c09900246f75ca5285aeb38f7b8b295784ffac Reviewed-on: https://webrtc-review.googlesource.com/76741 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Commit-Queue: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23238}
2018-05-15 10:22:36 +02:00
Convert GN libs lists to frameworks GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: chromium:1052560 Change-Id: I263230ddd3c468061584423bba9e1f887503bcaa Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178601 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#31632}
2020-07-03 10:19:30 +02:00
frameworks = [ "AudioToolbox.framework" ]
Moving iOS Audio Device to sdk. This change forks the existing iOS audio device module and audio device from modules/audio_device/ into sdk/objc/Framework. It also updates RTCPeerConnectionFactory to use the forked implementation. The unit tests are re-implemented as XCTests. (was: https://webrtc-review.googlesource.com/c/src/+/67300) Bug: webrtc:9120 Change-Id: I46c09900246f75ca5285aeb38f7b8b295784ffac Reviewed-on: https://webrtc-review.googlesource.com/76741 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Commit-Queue: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23238}
2018-05-15 10:22:36 +02:00
}
Make RTCAudioSession accessible to Swift. This is done by: 1. removing the <vector> include from RTCAudioSession+Private, 2. creating a audio_session_objc package that excludes the RTCNativeAudioSessionDelegateAdapter class. Bug: webrtc:11237 Change-Id: I36c86542a19e3244456fd164d908563b1435de29 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/163900 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Chuck Hays <haysc@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30177}
2019-12-26 23:01:42 -08:00
# This target exists to expose :audio_session_objc and
# :audio_session_delegate_adapter_objc for backward compatibility,
# and should be deprecated.
group("audio_objc") {
public_deps = [ # no-presubmit-check TODO(webrtc:11238)
":audio_session_delegate_adapter_objc",
":audio_session_objc",
]
}
rtc_library("audio_session_delegate_adapter_objc") {
sources = [
"objc/components/audio/RTCNativeAudioSessionDelegateAdapter.h",
"objc/components/audio/RTCNativeAudioSessionDelegateAdapter.mm",
]
configs += [
"..:common_objc",
":used_from_extension",
]
public_configs = [ ":common_config_objc" ]
deps = [
":audio_session_objc",
":audio_session_observer",
":base_objc",
]
}
rtc_library("audio_session_objc") {
Make the sdk:audio_session_objc target public. Bug: webrtc:11237 Change-Id: I83360b2608a58c7ab9f0cb050aa289df178eb66f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165560 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Joe Chen <jsphchn@google.com> Cr-Commit-Position: refs/heads/master@{#30201}
2020-01-09 08:31:06 -08:00
visibility = [ "*" ]
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
sources = [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/components/audio/RTCAudioSession+Configuration.mm",
"objc/components/audio/RTCAudioSession+Private.h",
"objc/components/audio/RTCAudioSession.h",
"objc/components/audio/RTCAudioSession.mm",
"objc/components/audio/RTCAudioSessionConfiguration.h",
"objc/components/audio/RTCAudioSessionConfiguration.m",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
]
Make RTCAudioSession accessible to Swift. This is done by: 1. removing the <vector> include from RTCAudioSession+Private, 2. creating a audio_session_objc package that excludes the RTCNativeAudioSessionDelegateAdapter class. Bug: webrtc:11237 Change-Id: I36c86542a19e3244456fd164d908563b1435de29 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/163900 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Chuck Hays <haysc@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30177}
2019-12-26 23:01:42 -08:00
Broadcast extension for AppRTCMobile on iOS This provides an environment for testing out using WebRTC from an iOS extension. It implements a ReplayKit broadcast extension for live streaming games and screensharing. The extension is only supported on iOS 11+ and is guarded by a build flag. Bug: webrtc:9335 Change-Id: Id218d6c73ef7599f5953c5a1e0e62e5d0dc4f10b Reviewed-on: https://webrtc-review.googlesource.com/80000 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23504}
2018-06-04 10:24:37 +02:00
configs += [
"..:common_objc",
":used_from_extension",
]
Move RTCAudioSession* files modules/audio_device/ -> sdk/Framework. BUG=NONE Review-Url: https://codereview.webrtc.org/2855023003 Cr-Commit-Position: refs/heads/master@{#18443}
2017-06-05 05:48:47 -07:00
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
public_configs = [ ":common_config_objc" ]
Fix public Obj-C header import. Fixes the Cocoapod. Bug: None Change-Id: If3ace3d01ba111fc83ae18455e8ff1cb5fc7b476 Reviewed-on: https://webrtc-review.googlesource.com/1572 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19863}
2017-09-15 14:07:30 +02:00
Convert GN libs lists to frameworks GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: chromium:1052560 Change-Id: I263230ddd3c468061584423bba9e1f887503bcaa Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178601 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#31632}
2020-07-03 10:19:30 +02:00
frameworks = [ "AVFoundation.framework" ]
Add necessary frameworks to sdk objc audio targets. These two dependency is not needed if other libraries or the app takes in the framework. But it will have a linker error they are included alone. It is just more "correct" this way. Bug: webrtc:9853 Change-Id: I20858de197f34e554904f82e3d6c19ff596226bf Reviewed-on: https://webrtc-review.googlesource.com/c/104963 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Commit-Queue: Jiawei Ou <ouj@fb.com> Cr-Commit-Position: refs/heads/master@{#25188}
2018-10-09 12:33:06 -07:00
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
deps = [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
":base_objc",
":helpers_objc",
Cleanup BUILD.gn files from imports like foo:foo Repalce all occurrences of foo:foo in deps with just foo in BUILD.gn files. Done with Sublime regex replace. Find: \b([-a-zA-Z0-9_]+):+\1\b In: *.gn Replace with: \1 Bug: None Change-Id: I40aba1b14face687a595b852ffe443cb20197611 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127899 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27225}
2019-03-21 13:35:10 +01:00
"../rtc_base",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
"../rtc_base:checks",
Reland "Replace RecursiveCriticalSection with Mutex in RTCAudioSession." This is a reland of f8da43d179043f1df2e1c3e2c49494bc23f4ec28 Original change's description: > Replace RecursiveCriticalSection with Mutex in RTCAudioSession. > > Bug: webrtc:11567 > Change-Id: I2a2ddbce57d070d6cbad5a64defb4c27be77a665 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/206472 > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > Reviewed-by: Kári Helgason <kthelgason@webrtc.org> > Commit-Queue: Niels Moller <nisse@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#33259} Bug: webrtc:11567 Change-Id: I4f7235dd164d8f698fe0bedea8c5dca50849f6d3 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/207432 Reviewed-by: Markus Handell <handellm@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33302}
2021-02-15 16:30:44 +01:00
"../rtc_base/synchronization:mutex",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
]
Verify that locks are handled correctly on RTCAudioSession This CL is for the same behavior as before [1], to emit the NSError when an application is not using the RTCAudioSession lock correctly. [1] https://webrtc-review.googlesource.com/c/src/+/207432 Bug: webrtc:13091 Change-Id: I031b0e963d33c92ce1af7a306edfa6be005e043d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/229461 Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Byoungchan Lee <daniel.l@hpcnt.com> Cr-Commit-Position: refs/heads/main@{#35018}
2021-09-06 22:32:52 +09:00
absl_deps = [ "//third_party/abseil-cpp/absl/base:core_headers" ]
Move RTCAudioSession* files modules/audio_device/ -> sdk/Framework. BUG=NONE Review-Url: https://codereview.webrtc.org/2855023003 Cr-Commit-Position: refs/heads/master@{#18443}
2017-06-05 05:48:47 -07:00
}
Implement network monitor for iOS. Notably, this should detect whether an interface is "available" or not, which should prevent the failure is with dual SIM card setups. This is gated behind a field trial for now, to ensure this doesn't cause any regressions due to false negatives (interfaces that are usable but not listed as available by NWPathMonitor). Bug: webrtc:10966 Change-Id: Ia3942c4c57b525d08d8b340e2325f3705cfd0304 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180923 Commit-Queue: Taylor <deadbeef@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Jonas Oreland <jonaso@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31977}
2020-08-19 16:41:54 -07:00
rtc_source_set("network_monitor_observer") {
visibility = [ ":*" ]
sources = [ "objc/native/src/network_monitor_observer.h" ]
Reland "Refactor rtc_base build targets." This is a reland of 69241a93fb14f6527a26d5c94dde879013012d2a Fix: The problem was related to NO_MAIN_THREAD_WRAPPING, which affects https://source.chromium.org/chromium/chromium/src/+/master:third_party/webrtc/rtc_base/thread.cc;l=257-263;drc=7acc2d9fe3a6e3c4d8881d2bdfc9b8968a724cd5. The original CL didn't attach the definition of the macro NO_MAIN_THREAD_WRAPPING when building for Chromium (which doesn't have to be related to //rtc_base anymore but to //rtc_base:threading). Original change's description: > Refactor rtc_base build targets. > > The "//rtc_base:rtc_base" build target has historically been one of the > biggest targets in the WebRTC build. Big targets are the main source of > circular dependencies and non-API types leakage. > > This CL is a step forward into splitting "//rtc_base:rtc_base" into > smaller targets (as originally started in 2018). > > The only non-automated changes are (like re-wiring the build system): > * The creation of //rtc_base/async_resolver.{h,cc} which allows to > break a circular dependency (is has been extracted from > //rtc_base/net_helpers.{h,cc}). > * The creation of //rtc_base/internal/default_socket_server.{h,cc} to > break another circular dependency. > > Bug: webrtc:9987 > Change-Id: I0c8f5e7efe2c8fd8e6bffa0d6dd2dd494cf3df02 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/196903 > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#32941} Bug: webrtc:9987 Change-Id: I7cdf49d2aac8357f1f50f90010bf2c2f62fa19f6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/202021 Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33001}
2021-01-15 10:41:01 +01:00
deps = [
"../rtc_base",
"../rtc_base:network_constants",
Remove //rtc_base:stringutils from public deps Bug: webrtc:8603 Change-Id: Ic2dfbe28d310cb4b35983b73e895fc95e8439669 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257913 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Florent Castelli <orphis@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36453}
2022-04-04 17:14:02 +02:00
"../rtc_base:stringutils",
Reland "Refactor rtc_base build targets." This is a reland of 69241a93fb14f6527a26d5c94dde879013012d2a Fix: The problem was related to NO_MAIN_THREAD_WRAPPING, which affects https://source.chromium.org/chromium/chromium/src/+/master:third_party/webrtc/rtc_base/thread.cc;l=257-263;drc=7acc2d9fe3a6e3c4d8881d2bdfc9b8968a724cd5. The original CL didn't attach the definition of the macro NO_MAIN_THREAD_WRAPPING when building for Chromium (which doesn't have to be related to //rtc_base anymore but to //rtc_base:threading). Original change's description: > Refactor rtc_base build targets. > > The "//rtc_base:rtc_base" build target has historically been one of the > biggest targets in the WebRTC build. Big targets are the main source of > circular dependencies and non-API types leakage. > > This CL is a step forward into splitting "//rtc_base:rtc_base" into > smaller targets (as originally started in 2018). > > The only non-automated changes are (like re-wiring the build system): > * The creation of //rtc_base/async_resolver.{h,cc} which allows to > break a circular dependency (is has been extracted from > //rtc_base/net_helpers.{h,cc}). > * The creation of //rtc_base/internal/default_socket_server.{h,cc} to > break another circular dependency. > > Bug: webrtc:9987 > Change-Id: I0c8f5e7efe2c8fd8e6bffa0d6dd2dd494cf3df02 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/196903 > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#32941} Bug: webrtc:9987 Change-Id: I7cdf49d2aac8357f1f50f90010bf2c2f62fa19f6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/202021 Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33001}
2021-01-15 10:41:01 +01:00
"../rtc_base:threading",
]
Adopt absl::string_view in function parameters under rtc_base/ This is part of a large-scale effort to increase adoption of absl::string_view across the WebRTC code base. This CL converts the majority of "const std::string&"s in function parameters under rtc_base/ to absl::string_view. Bug: webrtc:13579 Change-Id: I2b1e3776aa42326aa405f76bb324a2d233b21dca Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/254081 Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Xavier Lepaul‎ <xalep@webrtc.org> Reviewed-by: Anders Lilienthal <andersc@webrtc.org> Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Ali Tofigh <alito@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36239}
2022-03-17 15:47:49 +01:00
absl_deps = [ "//third_party/abseil-cpp/absl/strings" ]
Implement network monitor for iOS. Notably, this should detect whether an interface is "available" or not, which should prevent the failure is with dual SIM card setups. This is gated behind a field trial for now, to ensure this doesn't cause any regressions due to false negatives (interfaces that are usable but not listed as available by NWPathMonitor). Bug: webrtc:10966 Change-Id: Ia3942c4c57b525d08d8b340e2325f3705cfd0304 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180923 Commit-Queue: Taylor <deadbeef@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Jonas Oreland <jonaso@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31977}
2020-08-19 16:41:54 -07:00
}
rtc_library("network_monitor_objc") {
visibility = [ "*" ]
sources = [
"objc/components/network/RTCNetworkMonitor+Private.h",
"objc/components/network/RTCNetworkMonitor.h",
"objc/components/network/RTCNetworkMonitor.mm",
]
configs += [ ":used_from_extension" ]
frameworks = [ "Network.framework" ]
deps = [
":base_objc",
":helpers_objc",
":network_monitor_observer",
Adopt absl::string_view in function parameters under rtc_base/ This is part of a large-scale effort to increase adoption of absl::string_view across the WebRTC code base. This CL converts the majority of "const std::string&"s in function parameters under rtc_base/ to absl::string_view. Bug: webrtc:13579 Change-Id: I2b1e3776aa42326aa405f76bb324a2d233b21dca Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/254081 Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Xavier Lepaul‎ <xalep@webrtc.org> Reviewed-by: Anders Lilienthal <andersc@webrtc.org> Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Ali Tofigh <alito@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36239}
2022-03-17 15:47:49 +01:00
"../rtc_base:stringutils",
Implement network monitor for iOS. Notably, this should detect whether an interface is "available" or not, which should prevent the failure is with dual SIM card setups. This is gated behind a field trial for now, to ensure this doesn't cause any regressions due to false negatives (interfaces that are usable but not listed as available by NWPathMonitor). Bug: webrtc:10966 Change-Id: Ia3942c4c57b525d08d8b340e2325f3705cfd0304 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180923 Commit-Queue: Taylor <deadbeef@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Jonas Oreland <jonaso@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31977}
2020-08-19 16:41:54 -07:00
"../rtc_base/system:gcd_helpers",
]
}
Move RTCAudioSession* files modules/audio_device/ -> sdk/Framework. BUG=NONE Review-Url: https://codereview.webrtc.org/2855023003 Cr-Commit-Position: refs/heads/master@{#18443}
2017-06-05 05:48:47 -07:00
}
Support building WebRTC without audio and video for IOS. Reorganized the targets in webrtc/sdk/BUILD.gn so that the applications which use WebRTC DataChannel only can depend on the "peerconnection_factory_no_media" instead of "rtc_sdk_objc" to reduce the binary size. Provided a no-media implementation of RTCPeerConnectionFactory using the macro "HAVE_NO_MEDIA". BUG=webrtc:7613 Review-Url: https://codereview.webrtc.org/2944643002 Cr-Commit-Position: refs/heads/master@{#18819}
2017-06-28 14:05:44 -07:00
ObjC ADM: added RTCAudioDevice protocol [2/N] Bug: webrtc:14193 Change-Id: I616c4d338a0bbc57c22e1f1dcc4454512aecd967 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268195 Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Commit-Queue: Yury Yarashevich <yura.yaroshevich@gmail.com> Cr-Commit-Position: refs/heads/main@{#37925}
2022-08-29 12:22:35 +02:00
rtc_source_set("audio_device_api_objc") {
visibility = [ "*" ]
sources = [ "objc/components/audio/RTCAudioDevice.h" ]
public_configs = [ ":common_config_objc" ]
frameworks = [ "AudioToolbox.framework" ]
deps = [ ":base_objc" ]
}
ObjC ADM: target and dummy implementation [1/N] Bug: webrtc:14193 Change-Id: Ic89af1a489ba6b4c011851f09297ed22cecde008 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266720 Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37921}
2022-08-24 17:46:08 +02:00
rtc_library("audio_device_objc") {
visibility = [ "*" ]
Reland "ObjC ADM: record/play implementation via RTCAudioDevice [3/3]" This is a reland of commit 2b9aaad58f56744f5c573c3b918fe072566598a5 Original change's description: > ObjC ADM: record/play implementation via RTCAudioDevice [3/3] > > # Overview > This CL chain exposes new API from ObjC WebRTC SDK to inject custom > means to play and record audio. The goal of CLs is achieved by having > additional implementation of `webrtc::AudioDeviceModule` > called `ObjCAudioDeviceModule`. The feature > of `ObjCAudioDeviceModule` is that it does not directly use any > of OS-provided audio APIs like AudioUnit, AVAudioEngine, AudioQueue, > AVCaptureSession etc. Instead it delegates communication with specific > system audio API to user-injectable audio device instance which > implements `RTCAudioDevice` protocol. > `RTCAudioDevice` is new API added to ObC WebRTC SDK in the CL chain. > > # AudioDeviceBuffer > `ObjCAudioDeviceModule` does conform to heavy `AudioDeviceModule` > interface providing stubs for unrelated methods. It also implements > common low-level management of audio device buffer, which glues audio > PCM flow to/from WebRTC. > `ObjCAudioDeviceModule` owns single `webrtc::AudioDeviceBuffer` which > with the help of two `FineAudioBuffer` (one for recording and one for > playout) is exchanged audio PCMs with user-provided `RTCAudioDevice` > instance. > `webrtc::AudioDeviceBuffer` is configured to work with specific audio: > it has to know sample rate and channels count of audio being played and > recorded. These formats could be different between playout and > recording. `ObjCAudioDeviceModule` stores current audio parameters > applied to `webrtc::AudioDeviceBuffer` as fields of > type `webrtc::AudioParameters`. `RTCAudioDevice` has it's own variable > audio parameters like sample rate, channels count and IO buffer > duration. The audio parameters of `RTCAudioDevice` must be kept in sync > with audio parameters applied to `webrtc::AudioDeviceBuffer`, otherwise > audio playout and recording will be corrupted: audio is sent only > partially over the wire and/or audio is played with artifacts. > `ObjCAudioDeviceModule` reads current `RTCAudioDevice` audio parameters > when playout or recording is initialized. Whenever `RTCAudioDevice` > audio parameters parameters are changed, there must be a notification to > `ObjCAudioDeviceModule` to allow it to reconfigure > it's `webrtc::AudioDeviceBuffer`. The notification is performed > via `RTCAudioDeviceDelegate` object, which is provided > by `ObjCAudioDeviceModule` during initialization of `RTCAudioDevice`. > > # Threading > `ObjCAudioDeviceModule` is stick to same thread between initialization > and termination. The only exception is two IO functions invoked by SDK > user code presumably from real-time audio IO thread. > Implementation of `RTCAudioDevice` may rely on the fact that all the > methods of `RTCAudioDevice` are called on the same thread between > initialization and termination. `ObjCAudioDeviceModule` is also expect > that the implementation of `RTCAudioDevice` will call methods related > to notification of audio parameters changes and audio interruption are > invoked on `ObjCAudioDeviceModule` thread. To facilitate this > requirement `RTCAudioDeviceDelegate` provides two functions to execute > sync and async block on `ObjCAudioDeviceModule` thread. > Async block could be useful when handling audio session notifications to > dispatch whole block re-configuring audio objects used > by `RTCAudioDevice` implementation. > Sync block could be used to make sure changes to audio parameters > of ADB owned by `ObjCAudioDeviceModule` are notified, before interrupted > playout/recording restarted. > > Bug: webrtc:14193 > Change-Id: I5587ec6bbee3cf02bad70dd59b822feb0ada7f86 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269006 > Reviewed-by: Henrik Andreasson <henrika@google.com> > Commit-Queue: Yury Yarashevich <yura.yaroshevich@gmail.com> > Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> > Reviewed-by: Henrik Andreassson <henrika@webrtc.org> > Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#37928} Bug: webrtc:14193 Change-Id: Iaf950d24bb2394a20e50421d5122f72ce46ae840 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/273380 Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37946}
2022-08-29 21:00:31 +02:00
allow_poison = [ "default_task_queue" ]
ObjC ADM: target and dummy implementation [1/N] Bug: webrtc:14193 Change-Id: Ic89af1a489ba6b4c011851f09297ed22cecde008 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266720 Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37921}
2022-08-24 17:46:08 +02:00
sources = [
"objc/native/src/objc_audio_device.h",
"objc/native/src/objc_audio_device.mm",
Reland "ObjC ADM: record/play implementation via RTCAudioDevice [3/3]" This is a reland of commit 2b9aaad58f56744f5c573c3b918fe072566598a5 Original change's description: > ObjC ADM: record/play implementation via RTCAudioDevice [3/3] > > # Overview > This CL chain exposes new API from ObjC WebRTC SDK to inject custom > means to play and record audio. The goal of CLs is achieved by having > additional implementation of `webrtc::AudioDeviceModule` > called `ObjCAudioDeviceModule`. The feature > of `ObjCAudioDeviceModule` is that it does not directly use any > of OS-provided audio APIs like AudioUnit, AVAudioEngine, AudioQueue, > AVCaptureSession etc. Instead it delegates communication with specific > system audio API to user-injectable audio device instance which > implements `RTCAudioDevice` protocol. > `RTCAudioDevice` is new API added to ObC WebRTC SDK in the CL chain. > > # AudioDeviceBuffer > `ObjCAudioDeviceModule` does conform to heavy `AudioDeviceModule` > interface providing stubs for unrelated methods. It also implements > common low-level management of audio device buffer, which glues audio > PCM flow to/from WebRTC. > `ObjCAudioDeviceModule` owns single `webrtc::AudioDeviceBuffer` which > with the help of two `FineAudioBuffer` (one for recording and one for > playout) is exchanged audio PCMs with user-provided `RTCAudioDevice` > instance. > `webrtc::AudioDeviceBuffer` is configured to work with specific audio: > it has to know sample rate and channels count of audio being played and > recorded. These formats could be different between playout and > recording. `ObjCAudioDeviceModule` stores current audio parameters > applied to `webrtc::AudioDeviceBuffer` as fields of > type `webrtc::AudioParameters`. `RTCAudioDevice` has it's own variable > audio parameters like sample rate, channels count and IO buffer > duration. The audio parameters of `RTCAudioDevice` must be kept in sync > with audio parameters applied to `webrtc::AudioDeviceBuffer`, otherwise > audio playout and recording will be corrupted: audio is sent only > partially over the wire and/or audio is played with artifacts. > `ObjCAudioDeviceModule` reads current `RTCAudioDevice` audio parameters > when playout or recording is initialized. Whenever `RTCAudioDevice` > audio parameters parameters are changed, there must be a notification to > `ObjCAudioDeviceModule` to allow it to reconfigure > it's `webrtc::AudioDeviceBuffer`. The notification is performed > via `RTCAudioDeviceDelegate` object, which is provided > by `ObjCAudioDeviceModule` during initialization of `RTCAudioDevice`. > > # Threading > `ObjCAudioDeviceModule` is stick to same thread between initialization > and termination. The only exception is two IO functions invoked by SDK > user code presumably from real-time audio IO thread. > Implementation of `RTCAudioDevice` may rely on the fact that all the > methods of `RTCAudioDevice` are called on the same thread between > initialization and termination. `ObjCAudioDeviceModule` is also expect > that the implementation of `RTCAudioDevice` will call methods related > to notification of audio parameters changes and audio interruption are > invoked on `ObjCAudioDeviceModule` thread. To facilitate this > requirement `RTCAudioDeviceDelegate` provides two functions to execute > sync and async block on `ObjCAudioDeviceModule` thread. > Async block could be useful when handling audio session notifications to > dispatch whole block re-configuring audio objects used > by `RTCAudioDevice` implementation. > Sync block could be used to make sure changes to audio parameters > of ADB owned by `ObjCAudioDeviceModule` are notified, before interrupted > playout/recording restarted. > > Bug: webrtc:14193 > Change-Id: I5587ec6bbee3cf02bad70dd59b822feb0ada7f86 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269006 > Reviewed-by: Henrik Andreasson <henrika@google.com> > Commit-Queue: Yury Yarashevich <yura.yaroshevich@gmail.com> > Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> > Reviewed-by: Henrik Andreassson <henrika@webrtc.org> > Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#37928} Bug: webrtc:14193 Change-Id: Iaf950d24bb2394a20e50421d5122f72ce46ae840 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/273380 Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37946}
2022-08-29 21:00:31 +02:00
"objc/native/src/objc_audio_device_delegate.h",
"objc/native/src/objc_audio_device_delegate.mm",
ObjC ADM: target and dummy implementation [1/N] Bug: webrtc:14193 Change-Id: Ic89af1a489ba6b4c011851f09297ed22cecde008 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266720 Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37921}
2022-08-24 17:46:08 +02:00
]
deps = [
ObjC ADM: added RTCAudioDevice protocol [2/N] Bug: webrtc:14193 Change-Id: I616c4d338a0bbc57c22e1f1dcc4454512aecd967 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268195 Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Commit-Queue: Yury Yarashevich <yura.yaroshevich@gmail.com> Cr-Commit-Position: refs/heads/main@{#37925}
2022-08-29 12:22:35 +02:00
":audio_device_api_objc",
Reland "ObjC ADM: record/play implementation via RTCAudioDevice [3/3]" This is a reland of commit 2b9aaad58f56744f5c573c3b918fe072566598a5 Original change's description: > ObjC ADM: record/play implementation via RTCAudioDevice [3/3] > > # Overview > This CL chain exposes new API from ObjC WebRTC SDK to inject custom > means to play and record audio. The goal of CLs is achieved by having > additional implementation of `webrtc::AudioDeviceModule` > called `ObjCAudioDeviceModule`. The feature > of `ObjCAudioDeviceModule` is that it does not directly use any > of OS-provided audio APIs like AudioUnit, AVAudioEngine, AudioQueue, > AVCaptureSession etc. Instead it delegates communication with specific > system audio API to user-injectable audio device instance which > implements `RTCAudioDevice` protocol. > `RTCAudioDevice` is new API added to ObC WebRTC SDK in the CL chain. > > # AudioDeviceBuffer > `ObjCAudioDeviceModule` does conform to heavy `AudioDeviceModule` > interface providing stubs for unrelated methods. It also implements > common low-level management of audio device buffer, which glues audio > PCM flow to/from WebRTC. > `ObjCAudioDeviceModule` owns single `webrtc::AudioDeviceBuffer` which > with the help of two `FineAudioBuffer` (one for recording and one for > playout) is exchanged audio PCMs with user-provided `RTCAudioDevice` > instance. > `webrtc::AudioDeviceBuffer` is configured to work with specific audio: > it has to know sample rate and channels count of audio being played and > recorded. These formats could be different between playout and > recording. `ObjCAudioDeviceModule` stores current audio parameters > applied to `webrtc::AudioDeviceBuffer` as fields of > type `webrtc::AudioParameters`. `RTCAudioDevice` has it's own variable > audio parameters like sample rate, channels count and IO buffer > duration. The audio parameters of `RTCAudioDevice` must be kept in sync > with audio parameters applied to `webrtc::AudioDeviceBuffer`, otherwise > audio playout and recording will be corrupted: audio is sent only > partially over the wire and/or audio is played with artifacts. > `ObjCAudioDeviceModule` reads current `RTCAudioDevice` audio parameters > when playout or recording is initialized. Whenever `RTCAudioDevice` > audio parameters parameters are changed, there must be a notification to > `ObjCAudioDeviceModule` to allow it to reconfigure > it's `webrtc::AudioDeviceBuffer`. The notification is performed > via `RTCAudioDeviceDelegate` object, which is provided > by `ObjCAudioDeviceModule` during initialization of `RTCAudioDevice`. > > # Threading > `ObjCAudioDeviceModule` is stick to same thread between initialization > and termination. The only exception is two IO functions invoked by SDK > user code presumably from real-time audio IO thread. > Implementation of `RTCAudioDevice` may rely on the fact that all the > methods of `RTCAudioDevice` are called on the same thread between > initialization and termination. `ObjCAudioDeviceModule` is also expect > that the implementation of `RTCAudioDevice` will call methods related > to notification of audio parameters changes and audio interruption are > invoked on `ObjCAudioDeviceModule` thread. To facilitate this > requirement `RTCAudioDeviceDelegate` provides two functions to execute > sync and async block on `ObjCAudioDeviceModule` thread. > Async block could be useful when handling audio session notifications to > dispatch whole block re-configuring audio objects used > by `RTCAudioDevice` implementation. > Sync block could be used to make sure changes to audio parameters > of ADB owned by `ObjCAudioDeviceModule` are notified, before interrupted > playout/recording restarted. > > Bug: webrtc:14193 > Change-Id: I5587ec6bbee3cf02bad70dd59b822feb0ada7f86 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269006 > Reviewed-by: Henrik Andreasson <henrika@google.com> > Commit-Queue: Yury Yarashevich <yura.yaroshevich@gmail.com> > Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> > Reviewed-by: Henrik Andreassson <henrika@webrtc.org> > Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#37928} Bug: webrtc:14193 Change-Id: Iaf950d24bb2394a20e50421d5122f72ce46ae840 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/273380 Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37946}
2022-08-29 21:00:31 +02:00
"../api:array_view",
"../api:make_ref_counted",
"../api:refcountedbase",
"../api:scoped_refptr",
"../api:sequence_checker",
"../api/task_queue",
"../api/task_queue:default_task_queue_factory",
ObjC ADM: added RTCAudioDevice protocol [2/N] Bug: webrtc:14193 Change-Id: I616c4d338a0bbc57c22e1f1dcc4454512aecd967 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268195 Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Commit-Queue: Yury Yarashevich <yura.yaroshevich@gmail.com> Cr-Commit-Position: refs/heads/main@{#37925}
2022-08-29 12:22:35 +02:00
"../modules/audio_device:audio_device_api",
Reland "ObjC ADM: record/play implementation via RTCAudioDevice [3/3]" This is a reland of commit 2b9aaad58f56744f5c573c3b918fe072566598a5 Original change's description: > ObjC ADM: record/play implementation via RTCAudioDevice [3/3] > > # Overview > This CL chain exposes new API from ObjC WebRTC SDK to inject custom > means to play and record audio. The goal of CLs is achieved by having > additional implementation of `webrtc::AudioDeviceModule` > called `ObjCAudioDeviceModule`. The feature > of `ObjCAudioDeviceModule` is that it does not directly use any > of OS-provided audio APIs like AudioUnit, AVAudioEngine, AudioQueue, > AVCaptureSession etc. Instead it delegates communication with specific > system audio API to user-injectable audio device instance which > implements `RTCAudioDevice` protocol. > `RTCAudioDevice` is new API added to ObC WebRTC SDK in the CL chain. > > # AudioDeviceBuffer > `ObjCAudioDeviceModule` does conform to heavy `AudioDeviceModule` > interface providing stubs for unrelated methods. It also implements > common low-level management of audio device buffer, which glues audio > PCM flow to/from WebRTC. > `ObjCAudioDeviceModule` owns single `webrtc::AudioDeviceBuffer` which > with the help of two `FineAudioBuffer` (one for recording and one for > playout) is exchanged audio PCMs with user-provided `RTCAudioDevice` > instance. > `webrtc::AudioDeviceBuffer` is configured to work with specific audio: > it has to know sample rate and channels count of audio being played and > recorded. These formats could be different between playout and > recording. `ObjCAudioDeviceModule` stores current audio parameters > applied to `webrtc::AudioDeviceBuffer` as fields of > type `webrtc::AudioParameters`. `RTCAudioDevice` has it's own variable > audio parameters like sample rate, channels count and IO buffer > duration. The audio parameters of `RTCAudioDevice` must be kept in sync > with audio parameters applied to `webrtc::AudioDeviceBuffer`, otherwise > audio playout and recording will be corrupted: audio is sent only > partially over the wire and/or audio is played with artifacts. > `ObjCAudioDeviceModule` reads current `RTCAudioDevice` audio parameters > when playout or recording is initialized. Whenever `RTCAudioDevice` > audio parameters parameters are changed, there must be a notification to > `ObjCAudioDeviceModule` to allow it to reconfigure > it's `webrtc::AudioDeviceBuffer`. The notification is performed > via `RTCAudioDeviceDelegate` object, which is provided > by `ObjCAudioDeviceModule` during initialization of `RTCAudioDevice`. > > # Threading > `ObjCAudioDeviceModule` is stick to same thread between initialization > and termination. The only exception is two IO functions invoked by SDK > user code presumably from real-time audio IO thread. > Implementation of `RTCAudioDevice` may rely on the fact that all the > methods of `RTCAudioDevice` are called on the same thread between > initialization and termination. `ObjCAudioDeviceModule` is also expect > that the implementation of `RTCAudioDevice` will call methods related > to notification of audio parameters changes and audio interruption are > invoked on `ObjCAudioDeviceModule` thread. To facilitate this > requirement `RTCAudioDeviceDelegate` provides two functions to execute > sync and async block on `ObjCAudioDeviceModule` thread. > Async block could be useful when handling audio session notifications to > dispatch whole block re-configuring audio objects used > by `RTCAudioDevice` implementation. > Sync block could be used to make sure changes to audio parameters > of ADB owned by `ObjCAudioDeviceModule` are notified, before interrupted > playout/recording restarted. > > Bug: webrtc:14193 > Change-Id: I5587ec6bbee3cf02bad70dd59b822feb0ada7f86 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269006 > Reviewed-by: Henrik Andreasson <henrika@google.com> > Commit-Queue: Yury Yarashevich <yura.yaroshevich@gmail.com> > Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> > Reviewed-by: Henrik Andreassson <henrika@webrtc.org> > Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#37928} Bug: webrtc:14193 Change-Id: Iaf950d24bb2394a20e50421d5122f72ce46ae840 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/273380 Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37946}
2022-08-29 21:00:31 +02:00
"../modules/audio_device:audio_device_buffer",
"../rtc_base:buffer",
"../rtc_base:checks",
ObjC ADM: added RTCAudioDevice protocol [2/N] Bug: webrtc:14193 Change-Id: I616c4d338a0bbc57c22e1f1dcc4454512aecd967 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268195 Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Commit-Queue: Yury Yarashevich <yura.yaroshevich@gmail.com> Cr-Commit-Position: refs/heads/main@{#37925}
2022-08-29 12:22:35 +02:00
"../rtc_base:logging",
Reland "ObjC ADM: record/play implementation via RTCAudioDevice [3/3]" This is a reland of commit 2b9aaad58f56744f5c573c3b918fe072566598a5 Original change's description: > ObjC ADM: record/play implementation via RTCAudioDevice [3/3] > > # Overview > This CL chain exposes new API from ObjC WebRTC SDK to inject custom > means to play and record audio. The goal of CLs is achieved by having > additional implementation of `webrtc::AudioDeviceModule` > called `ObjCAudioDeviceModule`. The feature > of `ObjCAudioDeviceModule` is that it does not directly use any > of OS-provided audio APIs like AudioUnit, AVAudioEngine, AudioQueue, > AVCaptureSession etc. Instead it delegates communication with specific > system audio API to user-injectable audio device instance which > implements `RTCAudioDevice` protocol. > `RTCAudioDevice` is new API added to ObC WebRTC SDK in the CL chain. > > # AudioDeviceBuffer > `ObjCAudioDeviceModule` does conform to heavy `AudioDeviceModule` > interface providing stubs for unrelated methods. It also implements > common low-level management of audio device buffer, which glues audio > PCM flow to/from WebRTC. > `ObjCAudioDeviceModule` owns single `webrtc::AudioDeviceBuffer` which > with the help of two `FineAudioBuffer` (one for recording and one for > playout) is exchanged audio PCMs with user-provided `RTCAudioDevice` > instance. > `webrtc::AudioDeviceBuffer` is configured to work with specific audio: > it has to know sample rate and channels count of audio being played and > recorded. These formats could be different between playout and > recording. `ObjCAudioDeviceModule` stores current audio parameters > applied to `webrtc::AudioDeviceBuffer` as fields of > type `webrtc::AudioParameters`. `RTCAudioDevice` has it's own variable > audio parameters like sample rate, channels count and IO buffer > duration. The audio parameters of `RTCAudioDevice` must be kept in sync > with audio parameters applied to `webrtc::AudioDeviceBuffer`, otherwise > audio playout and recording will be corrupted: audio is sent only > partially over the wire and/or audio is played with artifacts. > `ObjCAudioDeviceModule` reads current `RTCAudioDevice` audio parameters > when playout or recording is initialized. Whenever `RTCAudioDevice` > audio parameters parameters are changed, there must be a notification to > `ObjCAudioDeviceModule` to allow it to reconfigure > it's `webrtc::AudioDeviceBuffer`. The notification is performed > via `RTCAudioDeviceDelegate` object, which is provided > by `ObjCAudioDeviceModule` during initialization of `RTCAudioDevice`. > > # Threading > `ObjCAudioDeviceModule` is stick to same thread between initialization > and termination. The only exception is two IO functions invoked by SDK > user code presumably from real-time audio IO thread. > Implementation of `RTCAudioDevice` may rely on the fact that all the > methods of `RTCAudioDevice` are called on the same thread between > initialization and termination. `ObjCAudioDeviceModule` is also expect > that the implementation of `RTCAudioDevice` will call methods related > to notification of audio parameters changes and audio interruption are > invoked on `ObjCAudioDeviceModule` thread. To facilitate this > requirement `RTCAudioDeviceDelegate` provides two functions to execute > sync and async block on `ObjCAudioDeviceModule` thread. > Async block could be useful when handling audio session notifications to > dispatch whole block re-configuring audio objects used > by `RTCAudioDevice` implementation. > Sync block could be used to make sure changes to audio parameters > of ADB owned by `ObjCAudioDeviceModule` are notified, before interrupted > playout/recording restarted. > > Bug: webrtc:14193 > Change-Id: I5587ec6bbee3cf02bad70dd59b822feb0ada7f86 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269006 > Reviewed-by: Henrik Andreasson <henrika@google.com> > Commit-Queue: Yury Yarashevich <yura.yaroshevich@gmail.com> > Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> > Reviewed-by: Henrik Andreassson <henrika@webrtc.org> > Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#37928} Bug: webrtc:14193 Change-Id: Iaf950d24bb2394a20e50421d5122f72ce46ae840 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/273380 Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37946}
2022-08-29 21:00:31 +02:00
"../rtc_base:safe_minmax",
"../rtc_base:threading",
"../rtc_base:timeutils",
ObjC ADM: added RTCAudioDevice protocol [2/N] Bug: webrtc:14193 Change-Id: I616c4d338a0bbc57c22e1f1dcc4454512aecd967 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268195 Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Commit-Queue: Yury Yarashevich <yura.yaroshevich@gmail.com> Cr-Commit-Position: refs/heads/main@{#37925}
2022-08-29 12:22:35 +02:00
]
}
rtc_library("objc_audio_device_module") {
visibility = [ "*" ]
Reland "ObjC ADM: record/play implementation via RTCAudioDevice [3/3]" This is a reland of commit 2b9aaad58f56744f5c573c3b918fe072566598a5 Original change's description: > ObjC ADM: record/play implementation via RTCAudioDevice [3/3] > > # Overview > This CL chain exposes new API from ObjC WebRTC SDK to inject custom > means to play and record audio. The goal of CLs is achieved by having > additional implementation of `webrtc::AudioDeviceModule` > called `ObjCAudioDeviceModule`. The feature > of `ObjCAudioDeviceModule` is that it does not directly use any > of OS-provided audio APIs like AudioUnit, AVAudioEngine, AudioQueue, > AVCaptureSession etc. Instead it delegates communication with specific > system audio API to user-injectable audio device instance which > implements `RTCAudioDevice` protocol. > `RTCAudioDevice` is new API added to ObC WebRTC SDK in the CL chain. > > # AudioDeviceBuffer > `ObjCAudioDeviceModule` does conform to heavy `AudioDeviceModule` > interface providing stubs for unrelated methods. It also implements > common low-level management of audio device buffer, which glues audio > PCM flow to/from WebRTC. > `ObjCAudioDeviceModule` owns single `webrtc::AudioDeviceBuffer` which > with the help of two `FineAudioBuffer` (one for recording and one for > playout) is exchanged audio PCMs with user-provided `RTCAudioDevice` > instance. > `webrtc::AudioDeviceBuffer` is configured to work with specific audio: > it has to know sample rate and channels count of audio being played and > recorded. These formats could be different between playout and > recording. `ObjCAudioDeviceModule` stores current audio parameters > applied to `webrtc::AudioDeviceBuffer` as fields of > type `webrtc::AudioParameters`. `RTCAudioDevice` has it's own variable > audio parameters like sample rate, channels count and IO buffer > duration. The audio parameters of `RTCAudioDevice` must be kept in sync > with audio parameters applied to `webrtc::AudioDeviceBuffer`, otherwise > audio playout and recording will be corrupted: audio is sent only > partially over the wire and/or audio is played with artifacts. > `ObjCAudioDeviceModule` reads current `RTCAudioDevice` audio parameters > when playout or recording is initialized. Whenever `RTCAudioDevice` > audio parameters parameters are changed, there must be a notification to > `ObjCAudioDeviceModule` to allow it to reconfigure > it's `webrtc::AudioDeviceBuffer`. The notification is performed > via `RTCAudioDeviceDelegate` object, which is provided > by `ObjCAudioDeviceModule` during initialization of `RTCAudioDevice`. > > # Threading > `ObjCAudioDeviceModule` is stick to same thread between initialization > and termination. The only exception is two IO functions invoked by SDK > user code presumably from real-time audio IO thread. > Implementation of `RTCAudioDevice` may rely on the fact that all the > methods of `RTCAudioDevice` are called on the same thread between > initialization and termination. `ObjCAudioDeviceModule` is also expect > that the implementation of `RTCAudioDevice` will call methods related > to notification of audio parameters changes and audio interruption are > invoked on `ObjCAudioDeviceModule` thread. To facilitate this > requirement `RTCAudioDeviceDelegate` provides two functions to execute > sync and async block on `ObjCAudioDeviceModule` thread. > Async block could be useful when handling audio session notifications to > dispatch whole block re-configuring audio objects used > by `RTCAudioDevice` implementation. > Sync block could be used to make sure changes to audio parameters > of ADB owned by `ObjCAudioDeviceModule` are notified, before interrupted > playout/recording restarted. > > Bug: webrtc:14193 > Change-Id: I5587ec6bbee3cf02bad70dd59b822feb0ada7f86 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269006 > Reviewed-by: Henrik Andreasson <henrika@google.com> > Commit-Queue: Yury Yarashevich <yura.yaroshevich@gmail.com> > Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> > Reviewed-by: Henrik Andreassson <henrika@webrtc.org> > Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#37928} Bug: webrtc:14193 Change-Id: Iaf950d24bb2394a20e50421d5122f72ce46ae840 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/273380 Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37946}
2022-08-29 21:00:31 +02:00
allow_poison = [ "default_task_queue" ]
ObjC ADM: added RTCAudioDevice protocol [2/N] Bug: webrtc:14193 Change-Id: I616c4d338a0bbc57c22e1f1dcc4454512aecd967 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268195 Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Commit-Queue: Yury Yarashevich <yura.yaroshevich@gmail.com> Cr-Commit-Position: refs/heads/main@{#37925}
2022-08-29 12:22:35 +02:00
sources = [
"objc/native/api/objc_audio_device_module.h",
"objc/native/api/objc_audio_device_module.mm",
]
deps = [
":audio_device_api_objc",
":audio_device_objc",
"../api:make_ref_counted",
ObjC ADM: target and dummy implementation [1/N] Bug: webrtc:14193 Change-Id: Ic89af1a489ba6b4c011851f09297ed22cecde008 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266720 Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37921}
2022-08-24 17:46:08 +02:00
"../modules/audio_device:audio_device_api",
"../rtc_base:logging",
]
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("videosource_objc") {
Support building WebRTC without audio and video for IOS. Reorganized the targets in webrtc/sdk/BUILD.gn so that the applications which use WebRTC DataChannel only can depend on the "peerconnection_factory_no_media" instead of "rtc_sdk_objc" to reduce the binary size. Provided a no-media implementation of RTCPeerConnectionFactory using the macro "HAVE_NO_MEDIA". BUG=webrtc:7613 Review-Url: https://codereview.webrtc.org/2944643002 Cr-Commit-Position: refs/heads/master@{#18819}
2017-06-28 14:05:44 -07:00
sources = [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/api/peerconnection/RTCVideoSource+Private.h",
"objc/api/peerconnection/RTCVideoSource.h",
"objc/api/peerconnection/RTCVideoSource.mm",
Support building WebRTC without audio and video for IOS. Reorganized the targets in webrtc/sdk/BUILD.gn so that the applications which use WebRTC DataChannel only can depend on the "peerconnection_factory_no_media" instead of "rtc_sdk_objc" to reduce the binary size. Provided a no-media implementation of RTCPeerConnectionFactory using the macro "HAVE_NO_MEDIA". BUG=webrtc:7613 Review-Url: https://codereview.webrtc.org/2944643002 Cr-Commit-Position: refs/heads/master@{#18819}
2017-06-28 14:05:44 -07:00
]
deps = [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
":base_objc",
Fix native api in preparation for native_api example. Add native api conversions for video frames and video renderer. This also requires some changes to sdk/BUILD to avoid cyclic dependencies. Bug: webrtc:8832 Change-Id: Ibf21e63bdcae195dcb61d63f9262e6a8dc4fa790 Reviewed-on: https://webrtc-review.googlesource.com/57142 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22340}
2018-03-07 10:32:03 +01:00
":mediasource_objc",
":native_video",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
":videoframebuffer_objc",
Support building WebRTC without audio and video for IOS. Reorganized the targets in webrtc/sdk/BUILD.gn so that the applications which use WebRTC DataChannel only can depend on the "peerconnection_factory_no_media" instead of "rtc_sdk_objc" to reduce the binary size. Provided a no-media implementation of RTCPeerConnectionFactory using the macro "HAVE_NO_MEDIA". BUG=webrtc:7613 Review-Url: https://codereview.webrtc.org/2944643002 Cr-Commit-Position: refs/heads/master@{#18819}
2017-06-28 14:05:44 -07:00
"../api:libjingle_peerconnection_api",
New build target api:media_interface Bug: webrtc:8733 Change-Id: I84bbefb1a5ef8e592db29b79499d60ac80c23464 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153180 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Steve Anton <steveanton@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29234}
2019-09-17 14:30:41 +02:00
"../api:media_stream_interface",
New file api/video/BUILD.gn Build targets involving files under api/video/ are moved into this file, from api/BUILD.gn. In addition, drop "_api" part of target names, and move the header file api/videosinkinterface.h to api/video/video_sink_interface.h. Bug: webrtc:9253 Change-Id: I2896d3f063db8dff902bc29738578395b2fcc155 Reviewed-on: https://webrtc-review.googlesource.com/75500 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23207}
2018-05-11 11:15:30 +02:00
"../api/video:video_frame",
Prepare for splitting the api/video:video_frames build rule. This change is part of a change to break the dependency between "api:rtp_headers" and "api/video:video_frame". It does so by first creating an empty "api/video:video_rtp_headers" build rule so that downstream projects can be fixed before moving the source files. Bug: webrtc:10668 Change-Id: I81aa6edfef3639b457a40aa93de048e62cbfd8ef Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140291 Commit-Queue: Chen Xing <chxg@google.com> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28209}
2019-06-10 12:59:38 +02:00
"../api/video:video_rtp_headers",
Support building WebRTC without audio and video for IOS. Reorganized the targets in webrtc/sdk/BUILD.gn so that the applications which use WebRTC DataChannel only can depend on the "peerconnection_factory_no_media" instead of "rtc_sdk_objc" to reduce the binary size. Provided a no-media implementation of RTCPeerConnectionFactory using the macro "HAVE_NO_MEDIA". BUG=webrtc:7613 Review-Url: https://codereview.webrtc.org/2944643002 Cr-Commit-Position: refs/heads/master@{#18819}
2017-06-28 14:05:44 -07:00
"../common_video",
"../media:rtc_media_base",
Finish removal of source files from rtc_pc_base No-try: True Bug: webrtc:13805 Change-Id: Ib7048205fe62379d1a5c01cdbca81ba93b41cf47 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256022 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36355}
2022-03-28 12:06:34 +00:00
"../pc:video_track_source_proxy",
Cleanup BUILD.gn files from imports like foo:foo Repalce all occurrences of foo:foo in deps with just foo in BUILD.gn files. Done with Sublime regex replace. Find: \b([-a-zA-Z0-9_]+):+\1\b In: *.gn Replace with: \1 Bug: None Change-Id: I40aba1b14face687a595b852ffe443cb20197611 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127899 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27225}
2019-03-21 13:35:10 +01:00
"../rtc_base",
Fix circular dependencies between optional, array_view, and rtc_base. This splits things out of rtc_base and makes dependencies explicit. Bug: webrtc:6828 Change-Id: Id521896c3c43595349021c857bec216e429a0c8d Reviewed-on: https://webrtc-review.googlesource.com/32780 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21264}
2017-12-13 16:05:42 +01:00
"../rtc_base:checks",
Reland "Refactor rtc_base build targets." This is a reland of 69241a93fb14f6527a26d5c94dde879013012d2a Fix: The problem was related to NO_MAIN_THREAD_WRAPPING, which affects https://source.chromium.org/chromium/chromium/src/+/master:third_party/webrtc/rtc_base/thread.cc;l=257-263;drc=7acc2d9fe3a6e3c4d8881d2bdfc9b8968a724cd5. The original CL didn't attach the definition of the macro NO_MAIN_THREAD_WRAPPING when building for Chromium (which doesn't have to be related to //rtc_base anymore but to //rtc_base:threading). Original change's description: > Refactor rtc_base build targets. > > The "//rtc_base:rtc_base" build target has historically been one of the > biggest targets in the WebRTC build. Big targets are the main source of > circular dependencies and non-API types leakage. > > This CL is a step forward into splitting "//rtc_base:rtc_base" into > smaller targets (as originally started in 2018). > > The only non-automated changes are (like re-wiring the build system): > * The creation of //rtc_base/async_resolver.{h,cc} which allows to > break a circular dependency (is has been extracted from > //rtc_base/net_helpers.{h,cc}). > * The creation of //rtc_base/internal/default_socket_server.{h,cc} to > break another circular dependency. > > Bug: webrtc:9987 > Change-Id: I0c8f5e7efe2c8fd8e6bffa0d6dd2dd494cf3df02 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/196903 > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#32941} Bug: webrtc:9987 Change-Id: I7cdf49d2aac8357f1f50f90010bf2c2f62fa19f6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/202021 Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33001}
2021-01-15 10:41:01 +01:00
"../rtc_base:threading",
Removing $rtc_libyuv_dir and removing useless dependencies on libyuv. This CL removes the following GN variables: rtc_build_libyuv, rtc_libyuv_dir (as requested in webrtc:7906). It also removes some unneeded dependencies on //third_party/libyuv. WebRTC targets were using public_deps to depend on //third_party/libyuv and this created a build graph where targets that were depending on //third_party/libyuv were not declaring the dependency to GN because they were somehow getting it from another target that was exposing //third_party/libyuv header files even if it wasn't directly depending on it. Bug: webrtc:8605, webrtc:7906 Change-Id: If71f7988fd80421dc2ad887cf94c2ac66366c3fb Reviewed-on: https://webrtc-review.googlesource.com/32201 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21275}
2017-12-14 11:24:00 +01:00
"//third_party/libyuv",
Support building WebRTC without audio and video for IOS. Reorganized the targets in webrtc/sdk/BUILD.gn so that the applications which use WebRTC DataChannel only can depend on the "peerconnection_factory_no_media" instead of "rtc_sdk_objc" to reduce the binary size. Provided a no-media implementation of RTCPeerConnectionFactory using the macro "HAVE_NO_MEDIA". BUG=webrtc:7613 Review-Url: https://codereview.webrtc.org/2944643002 Cr-Commit-Position: refs/heads/master@{#18819}
2017-06-28 14:05:44 -07:00
]
Broadcast extension for AppRTCMobile on iOS This provides an environment for testing out using WebRTC from an iOS extension. It implements a ReplayKit broadcast extension for live streaming games and screensharing. The extension is only supported on iOS 11+ and is guarded by a build flag. Bug: webrtc:9335 Change-Id: Id218d6c73ef7599f5953c5a1e0e62e5d0dc4f10b Reviewed-on: https://webrtc-review.googlesource.com/80000 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23504}
2018-06-04 10:24:37 +02:00
configs += [
"..:common_objc",
":used_from_extension",
]
Support building WebRTC without audio and video for IOS. Reorganized the targets in webrtc/sdk/BUILD.gn so that the applications which use WebRTC DataChannel only can depend on the "peerconnection_factory_no_media" instead of "rtc_sdk_objc" to reduce the binary size. Provided a no-media implementation of RTCPeerConnectionFactory using the macro "HAVE_NO_MEDIA". BUG=webrtc:7613 Review-Url: https://codereview.webrtc.org/2944643002 Cr-Commit-Position: refs/heads/master@{#18819}
2017-06-28 14:05:44 -07:00
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("videoframebuffer_objc") {
Change visibility of some build targets that are publicly used. Bug: None Change-Id: I9b0dc56364648ac4d4fa4b8bb67af44700621b24 Reviewed-on: https://webrtc-review.googlesource.com/93282 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24256}
2018-08-09 10:54:40 +02:00
visibility = [ "*" ]
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
sources = [
Include i420 buffers in Obj-C framework again. These headers was lost in the cleanup CL for the Obj-C directories. This puts them back in the framework headers. Note that since the protocol and interface was split into two different headers, and all public framework headers are put into a flat directory structure, I had to rename the implementation files so they would not collide in the framework header directory. Bug: webrtc:9701 Change-Id: I42d4c1e02bdfa4e114575f527c4c42a19be8fb52 Reviewed-on: https://webrtc-review.googlesource.com/97330 Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24539}
2018-09-03 14:44:50 +02:00
"objc/api/video_frame_buffer/RTCNativeI420Buffer+Private.h",
"objc/api/video_frame_buffer/RTCNativeI420Buffer.h",
"objc/api/video_frame_buffer/RTCNativeI420Buffer.mm",
"objc/api/video_frame_buffer/RTCNativeMutableI420Buffer.h",
"objc/api/video_frame_buffer/RTCNativeMutableI420Buffer.mm",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/components/video_frame_buffer/RTCCVPixelBuffer.h",
"objc/components/video_frame_buffer/RTCCVPixelBuffer.mm",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
]
deps = [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
":base_objc",
Remove //rtc_base:logging from public deps Bug: webrtc:8603 Change-Id: I2704da8618f88032adac7ae9eb2a0f47fce4a836 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257908 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Florent Castelli <orphis@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36443}
2022-04-04 15:06:30 +02:00
"../rtc_base:logging",
New file api/video/BUILD.gn Build targets involving files under api/video/ are moved into this file, from api/BUILD.gn. In addition, drop "_api" part of target names, and move the header file api/videosinkinterface.h to api/video/video_sink_interface.h. Bug: webrtc:9253 Change-Id: I2896d3f063db8dff902bc29738578395b2fcc155 Reviewed-on: https://webrtc-review.googlesource.com/75500 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23207}
2018-05-11 11:15:30 +02:00
"//api/video:video_frame",
Prepare for splitting the api/video:video_frames build rule. This change is part of a change to break the dependency between "api:rtp_headers" and "api/video:video_frame". It does so by first creating an empty "api/video:video_rtp_headers" build rule so that downstream projects can be fixed before moving the source files. Bug: webrtc:10668 Change-Id: I81aa6edfef3639b457a40aa93de048e62cbfd8ef Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140291 Commit-Queue: Chen Xing <chxg@google.com> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28209}
2019-06-10 12:59:38 +02:00
"//api/video:video_rtp_headers",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
"//common_video",
"//rtc_base:checks",
"//third_party/libyuv",
]
Broadcast extension for AppRTCMobile on iOS This provides an environment for testing out using WebRTC from an iOS extension. It implements a ReplayKit broadcast extension for live streaming games and screensharing. The extension is only supported on iOS 11+ and is guarded by a build flag. Bug: webrtc:9335 Change-Id: Id218d6c73ef7599f5953c5a1e0e62e5d0dc4f10b Reviewed-on: https://webrtc-review.googlesource.com/80000 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23504}
2018-06-04 10:24:37 +02:00
configs += [
"..:common_objc",
":used_from_extension",
]
Convert GN libs lists to frameworks GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: chromium:1052560 Change-Id: I263230ddd3c468061584423bba9e1f887503bcaa Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178601 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#31632}
2020-07-03 10:19:30 +02:00
frameworks = [
Finally delete deprecated mac capturer. Landing this CL will break video_loopback but cl 124827 fixes that. Bug: webrtc:6898, webrtc:6333, webrtc:7861 Change-Id: Iecbbf75fab08570cc537784f7bbd11a841a2e5a6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/124828 Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27012}
2019-03-07 10:44:26 +01:00
"VideoToolbox.framework",
Reland "Don't use all_dependent_configs for sdk frameworks" This is a reland of 63741c7fa1aa55a38af11ac8cc04498722f9407d It's possible to reland after the downstream fix in https://chromium-review.googlesource.com/1730415 Original change's description: > Don't use all_dependent_configs for sdk frameworks > > libs should be propagated to the final binary even without that: > https://gn.googlesource.com/gn/+/master/docs/reference.md#var_libs > > But add some missing SDK framework dependencies: > > * RTCNativeI420Buffer.mm uses CGBitmapContextGetBytesPerRow. > * socketrocket uses SecCertificateCopyData. > > Bug: None > Change-Id: Iba38a5dfaf470a5a790d494cbec8ade44b1d16ba > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146082 > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Commit-Queue: Oleh Prypin <oprypin@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#28605} Bug: None Change-Id: I6a1cd80c5177ef3a3b92ee55fc91e187b202d864 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/147720 Commit-Queue: Oleh Prypin <oprypin@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28740}
2019-07-18 22:25:48 +02:00
"CoreGraphics.framework",
Finally delete deprecated mac capturer. Landing this CL will break video_loopback but cl 124827 fixes that. Bug: webrtc:6898, webrtc:6333, webrtc:7861 Change-Id: Iecbbf75fab08570cc537784f7bbd11a841a2e5a6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/124828 Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27012}
2019-03-07 10:44:26 +01:00
"CoreVideo.framework",
]
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
}
iOS: Get WebRTC building for Mac Catalyst - Add an option for disabling the OpenGL renderer - Change the build script to use correct header location - Use Metal compatibility for h264 CoreVideo buffers Bug: webrtc:11516 Change-Id: Ia34a9305648e75904ac36e69593ffefedd833bfb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/224200 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34426}
2021-07-06 12:16:41 -07:00
rtc_library("opengl_objc") {
Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2911053002/ ) Reason for revert: Take three of relanding this after all internal issues have been resolved. Original issue's description: > Revert of Split iOS sdk in to separate targets (patchset #3 id:320001 of https://codereview.webrtc.org/2893843003/ ) > > Reason for revert: > Breaks downstream project. > > Original issue's description: > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2893593002/ ) > > > > Reason for revert: > > Take two of fixing downstream issues? > > > > Original issue's description: > > > Revert of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890733003/ ) > > > > > > Reason for revert: > > > Still problems with downstream projects > > > > > > Original issue's description: > > > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890513002/ ) > > > > > > > > Reason for revert: > > > > Fixing downstream breakages > > > > > > > > Original issue's description: > > > > > Revert of Split iOS sdk in to separate targets (patchset #13 id:280001 of https://codereview.webrtc.org/2862543002/ ) > > > > > > > > > > Reason for revert: > > > > > Breaking downstream projects. > > > > > > > > > > Original issue's description: > > > > > > Split iOS sdk in to separate targets > > > > > > > > > > > > This CL splits the iOS sdk into separate static libraries for video, > > > > > > audio, ui, common, and peerconnection-related code. This will in the > > > > > > future make it easier to compile WebRTC without unneeded components. > > > > > > > > > > > > BUG=webrtc:4867 > > > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2862543002 > > > > > > Cr-Commit-Position: refs/heads/master@{#18166} > > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/52c83fe7102f566cf35a7533092873d58b38f426 > > > > > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,kthelgason@webrtc.org > > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > > NOPRESUBMIT=true > > > > > NOTREECHECKS=true > > > > > NOTRY=true > > > > > BUG=webrtc:4867 > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2890513002 > > > > > Cr-Commit-Position: refs/heads/master@{#18170} > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/9756238084707787f735e1294e896e462e459717 > > > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > NOPRESUBMIT=true > > > > NOTREECHECKS=true > > > > NOTRY=true > > > > BUG=webrtc:4867 > > > > > > > > Review-Url: https://codereview.webrtc.org/2890733003 > > > > Cr-Commit-Position: refs/heads/master@{#18174} > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/d51e042492bedd057bc0cac7828979d5c7369cea > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=webrtc:4867 > > > > > > Review-Url: https://codereview.webrtc.org/2893593002 > > > Cr-Commit-Position: refs/heads/master@{#18182} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/37144b214e2baf62ecb262ab878dde8c59cdd6a3 > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=webrtc:4867 > > > > Review-Url: https://codereview.webrtc.org/2893843003 > > Cr-Commit-Position: refs/heads/master@{#18303} > > Committed: https://chromium.googlesource.com/external/webrtc/+/580c3522d294c877adfe555048c675bd8d166657 > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org,kthelgason@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:4867 > > Review-Url: https://codereview.webrtc.org/2911053002 > Cr-Commit-Position: refs/heads/master@{#18309} > Committed: https://chromium.googlesource.com/external/webrtc/+/af5c05540cc8208f682cafe88c5c16a505479196 TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org,mbonadei@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4867 Review-Url: https://codereview.webrtc.org/2913753003 Cr-Commit-Position: refs/heads/master@{#18319}
2017-05-30 01:48:47 -07:00
sources = [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/components/renderer/opengl/RTCDefaultShader.h",
"objc/components/renderer/opengl/RTCDefaultShader.mm",
"objc/components/renderer/opengl/RTCI420TextureCache.h",
"objc/components/renderer/opengl/RTCI420TextureCache.mm",
"objc/components/renderer/opengl/RTCOpenGLDefines.h",
"objc/components/renderer/opengl/RTCShader.h",
"objc/components/renderer/opengl/RTCShader.mm",
"objc/components/renderer/opengl/RTCVideoViewShading.h",
iOS/MacOS:Refactor metal rendering by extracting common implementation in separate super class. Included changes: - Fix rendering on iOS to support NV12 and i420 frames - Improve code style - Update build targets - Update tests BUG=webrtc:7079 Review-Url: https://codereview.webrtc.org/2784243003 Cr-Commit-Position: refs/heads/master@{#17923}
2017-04-28 02:14:54 -07:00
]
Convert GN libs lists to frameworks GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: chromium:1052560 Change-Id: I263230ddd3c468061584423bba9e1f887503bcaa Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178601 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#31632}
2020-07-03 10:19:30 +02:00
frameworks = [ "CoreVideo.framework" ]
iOS/MacOS:Refactor metal rendering by extracting common implementation in separate super class. Included changes: - Fix rendering on iOS to support NV12 and i420 frames - Improve code style - Update build targets - Update tests BUG=webrtc:7079 Review-Url: https://codereview.webrtc.org/2784243003 Cr-Commit-Position: refs/heads/master@{#17923}
2017-04-28 02:14:54 -07:00
if (is_ios) {
Reland of Add metal view, shaders and renderer. (patchset #1 id:1 of https://codereview.webrtc.org/2711003004/ ) Reason for revert: Re-land Original issue's description: > Revert of Add metal view, shaders and renderer. (patchset #18 id:340001 of https://codereview.webrtc.org/2651743007/ ) > > Reason for revert: > Reverting due to breakage in the Google3 import > > Original issue's description: > > Add metal view, shaders and renderer. > > > > This CL submits standalone Metal view, renderer and shader. > > > > BUG=webrtc:7079 > > > > Review-Url: https://codereview.webrtc.org/2651743007 > > Cr-Commit-Position: refs/heads/master@{#16787} > > Committed: https://chromium.googlesource.com/external/webrtc/+/fc8c97f950a4fead4a5debe3c838942db1834010 > > TBR=magjed@webrtc.org,kthelgason@webrtc.org,tkchin@webrtc.org,haysc@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7079 > > Review-Url: https://codereview.webrtc.org/2711003004 > Cr-Commit-Position: refs/heads/master@{#16788} > Committed: https://chromium.googlesource.com/external/webrtc/+/b681aabdfcdcb22de049df3916f2dd8c40dcbf57 TBR=magjed@webrtc.org,kthelgason@webrtc.org,tkchin@webrtc.org,haysc@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:7079 Review-Url: https://codereview.webrtc.org/2716703004 Cr-Commit-Position: refs/heads/master@{#16846}
2017-02-26 11:44:13 -08:00
sources += [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/components/renderer/opengl/RTCNV12TextureCache.h",
"objc/components/renderer/opengl/RTCNV12TextureCache.m",
Reland of Add metal view, shaders and renderer. (patchset #1 id:1 of https://codereview.webrtc.org/2711003004/ ) Reason for revert: Re-land Original issue's description: > Revert of Add metal view, shaders and renderer. (patchset #18 id:340001 of https://codereview.webrtc.org/2651743007/ ) > > Reason for revert: > Reverting due to breakage in the Google3 import > > Original issue's description: > > Add metal view, shaders and renderer. > > > > This CL submits standalone Metal view, renderer and shader. > > > > BUG=webrtc:7079 > > > > Review-Url: https://codereview.webrtc.org/2651743007 > > Cr-Commit-Position: refs/heads/master@{#16787} > > Committed: https://chromium.googlesource.com/external/webrtc/+/fc8c97f950a4fead4a5debe3c838942db1834010 > > TBR=magjed@webrtc.org,kthelgason@webrtc.org,tkchin@webrtc.org,haysc@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7079 > > Review-Url: https://codereview.webrtc.org/2711003004 > Cr-Commit-Position: refs/heads/master@{#16788} > Committed: https://chromium.googlesource.com/external/webrtc/+/b681aabdfcdcb22de049df3916f2dd8c40dcbf57 TBR=magjed@webrtc.org,kthelgason@webrtc.org,tkchin@webrtc.org,haysc@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:7079 Review-Url: https://codereview.webrtc.org/2716703004 Cr-Commit-Position: refs/heads/master@{#16846}
2017-02-26 11:44:13 -08:00
]
Convert GN libs lists to frameworks GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: chromium:1052560 Change-Id: I263230ddd3c468061584423bba9e1f887503bcaa Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178601 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#31632}
2020-07-03 10:19:30 +02:00
frameworks += [
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
"GLKit.framework",
"OpenGLES.framework",
"QuartzCore.framework",
]
} else if (is_mac) {
Convert GN libs lists to frameworks GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: chromium:1052560 Change-Id: I263230ddd3c468061584423bba9e1f887503bcaa Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178601 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#31632}
2020-07-03 10:19:30 +02:00
frameworks += [
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
"CoreMedia.framework",
"OpenGL.framework",
Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2911053002/ ) Reason for revert: Take three of relanding this after all internal issues have been resolved. Original issue's description: > Revert of Split iOS sdk in to separate targets (patchset #3 id:320001 of https://codereview.webrtc.org/2893843003/ ) > > Reason for revert: > Breaks downstream project. > > Original issue's description: > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2893593002/ ) > > > > Reason for revert: > > Take two of fixing downstream issues? > > > > Original issue's description: > > > Revert of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890733003/ ) > > > > > > Reason for revert: > > > Still problems with downstream projects > > > > > > Original issue's description: > > > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890513002/ ) > > > > > > > > Reason for revert: > > > > Fixing downstream breakages > > > > > > > > Original issue's description: > > > > > Revert of Split iOS sdk in to separate targets (patchset #13 id:280001 of https://codereview.webrtc.org/2862543002/ ) > > > > > > > > > > Reason for revert: > > > > > Breaking downstream projects. > > > > > > > > > > Original issue's description: > > > > > > Split iOS sdk in to separate targets > > > > > > > > > > > > This CL splits the iOS sdk into separate static libraries for video, > > > > > > audio, ui, common, and peerconnection-related code. This will in the > > > > > > future make it easier to compile WebRTC without unneeded components. > > > > > > > > > > > > BUG=webrtc:4867 > > > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2862543002 > > > > > > Cr-Commit-Position: refs/heads/master@{#18166} > > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/52c83fe7102f566cf35a7533092873d58b38f426 > > > > > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,kthelgason@webrtc.org > > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > > NOPRESUBMIT=true > > > > > NOTREECHECKS=true > > > > > NOTRY=true > > > > > BUG=webrtc:4867 > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2890513002 > > > > > Cr-Commit-Position: refs/heads/master@{#18170} > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/9756238084707787f735e1294e896e462e459717 > > > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > NOPRESUBMIT=true > > > > NOTREECHECKS=true > > > > NOTRY=true > > > > BUG=webrtc:4867 > > > > > > > > Review-Url: https://codereview.webrtc.org/2890733003 > > > > Cr-Commit-Position: refs/heads/master@{#18174} > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/d51e042492bedd057bc0cac7828979d5c7369cea > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=webrtc:4867 > > > > > > Review-Url: https://codereview.webrtc.org/2893593002 > > > Cr-Commit-Position: refs/heads/master@{#18182} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/37144b214e2baf62ecb262ab878dde8c59cdd6a3 > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=webrtc:4867 > > > > Review-Url: https://codereview.webrtc.org/2893843003 > > Cr-Commit-Position: refs/heads/master@{#18303} > > Committed: https://chromium.googlesource.com/external/webrtc/+/580c3522d294c877adfe555048c675bd8d166657 > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org,kthelgason@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:4867 > > Review-Url: https://codereview.webrtc.org/2911053002 > Cr-Commit-Position: refs/heads/master@{#18309} > Committed: https://chromium.googlesource.com/external/webrtc/+/af5c05540cc8208f682cafe88c5c16a505479196 TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org,mbonadei@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4867 Review-Url: https://codereview.webrtc.org/2913753003 Cr-Commit-Position: refs/heads/master@{#18319}
2017-05-30 01:48:47 -07:00
]
Reland of Add metal view, shaders and renderer. (patchset #1 id:1 of https://codereview.webrtc.org/2711003004/ ) Reason for revert: Re-land Original issue's description: > Revert of Add metal view, shaders and renderer. (patchset #18 id:340001 of https://codereview.webrtc.org/2651743007/ ) > > Reason for revert: > Reverting due to breakage in the Google3 import > > Original issue's description: > > Add metal view, shaders and renderer. > > > > This CL submits standalone Metal view, renderer and shader. > > > > BUG=webrtc:7079 > > > > Review-Url: https://codereview.webrtc.org/2651743007 > > Cr-Commit-Position: refs/heads/master@{#16787} > > Committed: https://chromium.googlesource.com/external/webrtc/+/fc8c97f950a4fead4a5debe3c838942db1834010 > > TBR=magjed@webrtc.org,kthelgason@webrtc.org,tkchin@webrtc.org,haysc@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7079 > > Review-Url: https://codereview.webrtc.org/2711003004 > Cr-Commit-Position: refs/heads/master@{#16788} > Committed: https://chromium.googlesource.com/external/webrtc/+/b681aabdfcdcb22de049df3916f2dd8c40dcbf57 TBR=magjed@webrtc.org,kthelgason@webrtc.org,tkchin@webrtc.org,haysc@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:7079 Review-Url: https://codereview.webrtc.org/2716703004 Cr-Commit-Position: refs/heads/master@{#16846}
2017-02-26 11:44:13 -08:00
}
Silence OpenGLES deprecation warning. The deprecation warning started to trigger after the iOS deployment target has been updated from 10 to 12 by https://webrtc-review.googlesource.com/c/src/+/224543. This macro was not defined in tests because the relevant bots were excluded from CQ when that happened. Bug: webrtc:12928, webrtc:12937 Change-Id: I6e1891c5080b172cbd74649e0a115b25d6c87d56 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/225020 Reviewed-by: Victor Boivie <boivie@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34417}
2021-07-05 16:47:49 +02:00
# TODO(bugs.webrtc.org/12937): Remove OpenGL deprecation warning
# workaround.
Increase iOS deployment target from 10 to 12. TBR=kthelgason@webrtc.org Bug: webrtc:12928 Change-Id: I50de09972bf012e78a9bc9f1d98d8d07aab4e180 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/224543 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34409}
2021-07-02 16:19:32 +02:00
defines = [ "GLES_SILENCE_DEPRECATION" ]
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2911053002/ ) Reason for revert: Take three of relanding this after all internal issues have been resolved. Original issue's description: > Revert of Split iOS sdk in to separate targets (patchset #3 id:320001 of https://codereview.webrtc.org/2893843003/ ) > > Reason for revert: > Breaks downstream project. > > Original issue's description: > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2893593002/ ) > > > > Reason for revert: > > Take two of fixing downstream issues? > > > > Original issue's description: > > > Revert of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890733003/ ) > > > > > > Reason for revert: > > > Still problems with downstream projects > > > > > > Original issue's description: > > > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890513002/ ) > > > > > > > > Reason for revert: > > > > Fixing downstream breakages > > > > > > > > Original issue's description: > > > > > Revert of Split iOS sdk in to separate targets (patchset #13 id:280001 of https://codereview.webrtc.org/2862543002/ ) > > > > > > > > > > Reason for revert: > > > > > Breaking downstream projects. > > > > > > > > > > Original issue's description: > > > > > > Split iOS sdk in to separate targets > > > > > > > > > > > > This CL splits the iOS sdk into separate static libraries for video, > > > > > > audio, ui, common, and peerconnection-related code. This will in the > > > > > > future make it easier to compile WebRTC without unneeded components. > > > > > > > > > > > > BUG=webrtc:4867 > > > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2862543002 > > > > > > Cr-Commit-Position: refs/heads/master@{#18166} > > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/52c83fe7102f566cf35a7533092873d58b38f426 > > > > > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,kthelgason@webrtc.org > > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > > NOPRESUBMIT=true > > > > > NOTREECHECKS=true > > > > > NOTRY=true > > > > > BUG=webrtc:4867 > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2890513002 > > > > > Cr-Commit-Position: refs/heads/master@{#18170} > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/9756238084707787f735e1294e896e462e459717 > > > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > NOPRESUBMIT=true > > > > NOTREECHECKS=true > > > > NOTRY=true > > > > BUG=webrtc:4867 > > > > > > > > Review-Url: https://codereview.webrtc.org/2890733003 > > > > Cr-Commit-Position: refs/heads/master@{#18174} > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/d51e042492bedd057bc0cac7828979d5c7369cea > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=webrtc:4867 > > > > > > Review-Url: https://codereview.webrtc.org/2893593002 > > > Cr-Commit-Position: refs/heads/master@{#18182} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/37144b214e2baf62ecb262ab878dde8c59cdd6a3 > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=webrtc:4867 > > > > Review-Url: https://codereview.webrtc.org/2893843003 > > Cr-Commit-Position: refs/heads/master@{#18303} > > Committed: https://chromium.googlesource.com/external/webrtc/+/580c3522d294c877adfe555048c675bd8d166657 > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org,kthelgason@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:4867 > > Review-Url: https://codereview.webrtc.org/2911053002 > Cr-Commit-Position: refs/heads/master@{#18309} > Committed: https://chromium.googlesource.com/external/webrtc/+/af5c05540cc8208f682cafe88c5c16a505479196 TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org,mbonadei@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4867 Review-Url: https://codereview.webrtc.org/2913753003 Cr-Commit-Position: refs/heads/master@{#18319}
2017-05-30 01:48:47 -07:00
deps = [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
":base_objc",
":helpers_objc",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
":mediaconstraints_objc",
Create experimental Obj-C++ API. This can be used to wrap Objective-C components in C++ classes, so users can use the WebRTC C++ API directly together with the iOS specific components provided by our SDK. Bug: webrtc:8832 Change-Id: I6d34f7ec62d51df8d3a5340a2e17d30ae73e13e8 Reviewed-on: https://webrtc-review.googlesource.com/46162 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21850}
2018-02-01 15:47:05 +01:00
":native_video",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
":videoframebuffer_objc",
Fix native api in preparation for native_api example. Add native api conversions for video frames and video renderer. This also requires some changes to sdk/BUILD to avoid cyclic dependencies. Bug: webrtc:8832 Change-Id: Ibf21e63bdcae195dcb61d63f9262e6a8dc4fa790 Reviewed-on: https://webrtc-review.googlesource.com/57142 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22340}
2018-03-07 10:32:03 +01:00
":videosource_objc",
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
"../api:libjingle_peerconnection_api",
New file api/video/BUILD.gn Build targets involving files under api/video/ are moved into this file, from api/BUILD.gn. In addition, drop "_api" part of target names, and move the header file api/videosinkinterface.h to api/video/video_sink_interface.h. Bug: webrtc:9253 Change-Id: I2896d3f063db8dff902bc29738578395b2fcc155 Reviewed-on: https://webrtc-review.googlesource.com/75500 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23207}
2018-05-11 11:15:30 +02:00
"../api/video:video_frame",
Prepare for splitting the api/video:video_frames build rule. This change is part of a change to break the dependency between "api:rtp_headers" and "api/video:video_frame". It does so by first creating an empty "api/video:video_rtp_headers" build rule so that downstream projects can be fixed before moving the source files. Bug: webrtc:10668 Change-Id: I81aa6edfef3639b457a40aa93de048e62cbfd8ef Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140291 Commit-Queue: Chen Xing <chxg@google.com> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28209}
2019-06-10 12:59:38 +02:00
"../api/video:video_rtp_headers",
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
"../common_video",
"../media:rtc_media_base",
Cleanup BUILD.gn files from imports like foo:foo Repalce all occurrences of foo:foo in deps with just foo in BUILD.gn files. Done with Sublime regex replace. Find: \b([-a-zA-Z0-9_]+):+\1\b In: *.gn Replace with: \1 Bug: None Change-Id: I40aba1b14face687a595b852ffe443cb20197611 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127899 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27225}
2019-03-21 13:35:10 +01:00
"../rtc_base",
Fix circular dependencies between optional, array_view, and rtc_base. This splits things out of rtc_base and makes dependencies explicit. Bug: webrtc:6828 Change-Id: Id521896c3c43595349021c857bec216e429a0c8d Reviewed-on: https://webrtc-review.googlesource.com/32780 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21264}
2017-12-13 16:05:42 +01:00
"../rtc_base:checks",
Remove //rtc_base:logging from public deps Bug: webrtc:8603 Change-Id: I2704da8618f88032adac7ae9eb2a0f47fce4a836 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257908 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Florent Castelli <orphis@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36443}
2022-04-04 15:06:30 +02:00
"../rtc_base:logging",
Build dynamic iOS SDK. - Places most ObjC code into webrtc/sdk/objc instead. - New gyp targets to build, strip and export symbols for dylib. - Removes old script used to generate dylib. BUG= Review URL: https://codereview.webrtc.org/1903663002 Cr-Commit-Position: refs/heads/master@{#12524}
2016-04-27 01:54:20 -07:00
]
Use absl_deps in order to preapre to the Abseil component build release. Bug: webrtc:1046390 Change-Id: Ia35545599de23b1a2c2d8be2d53469af7ac16f1d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176502 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31463}
2020-06-05 14:30:41 +02:00
absl_deps = [ "//third_party/abseil-cpp/absl/types:optional" ]
Build dynamic iOS SDK. - Places most ObjC code into webrtc/sdk/objc instead. - New gyp targets to build, strip and export symbols for dylib. - Removes old script used to generate dylib. BUG= Review URL: https://codereview.webrtc.org/1903663002 Cr-Commit-Position: refs/heads/master@{#12524}
2016-04-27 01:54:20 -07:00
Broadcast extension for AppRTCMobile on iOS This provides an environment for testing out using WebRTC from an iOS extension. It implements a ReplayKit broadcast extension for live streaming games and screensharing. The extension is only supported on iOS 11+ and is guarded by a build flag. Bug: webrtc:9335 Change-Id: Id218d6c73ef7599f5953c5a1e0e62e5d0dc4f10b Reviewed-on: https://webrtc-review.googlesource.com/80000 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23504}
2018-06-04 10:24:37 +02:00
configs += [
"..:common_objc",
":used_from_extension",
]
Implement CVO for iOS capturer The rotation is currently always applied by AVFoundation by reconfiguring the capture connection video orientation. This CL sets the rotation field in the frame instead. This avoids the current flash in the video when the device is rotated, and also avoids reconfiguring the local encoder and remote decoder when the device is rotated. BUG=b/30651939 Review-Url: https://codereview.webrtc.org/2271583003 Cr-Commit-Position: refs/heads/master@{#13916}
2016-08-25 03:25:04 -07:00
}
GN: Tighten up test target visibility + refactorings Make all rtc_source_test target that contains tests that are included in a test executable only be visible to the rtc_test target. Doing this exposed a couple of errors and dependency problems that were resolved. Having this could have prevented duplicated execution of tests like the case that was recently fixed by deadbeef@ in https://codereview.webrtc.org/2820263004 New targets: * //webrtc/modules/rtp_rtcp:fec_test_helper * //webrtc/modules/rtp_rtcp:mock_rtp_rtcp * //webrtc/modules/remote_bitrate_estimator:mock_remote_bitrate_observer The mock files and targets should probably be moved into webrtc/test in the future, but that's out of the scope of this CL. BUG=webrtc:5716 NOTRY=True Review-Url: https://codereview.webrtc.org/2828793003 Cr-Commit-Position: refs/heads/master@{#17863}
2017-04-25 04:04:50 -07:00
iOS: Get WebRTC building for Mac Catalyst - Add an option for disabling the OpenGL renderer - Change the build script to use correct header location - Use Metal compatibility for h264 CoreVideo buffers Bug: webrtc:11516 Change-Id: Ia34a9305648e75904ac36e69593ffefedd833bfb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/224200 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34426}
2021-07-06 12:16:41 -07:00
rtc_library("opengl_ui_objc") {
Revert "Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*""" This reverts commit c73e1f437889d882cbf2987f7fb3a029a6150613. Reason for revert: The problem with failed deps in chrome content/renderer had already been fixed in https://webrtc-review.googlesource.com/c/src/+/38660 Original change's description: > Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*"" > > This reverts commit 588c548657b3ddf76e7b3f241263eef7f5799f16. > > Reason for revert: > > Breaks Chrome FYI: > > /b/c/b/Linux_Builder/src/buildtools/linux64/gn gen //out/Release --check > -> returned 1 > ERROR at //build/split_static_library.gni:12:5: Dependency not allowed. > static_library(target_name) { > ^---------------------------- > The item //content/renderer:renderer > can not depend on //third_party/webrtc/media:rtc_internal_video_codecs > because it is not in //third_party/webrtc/media:rtc_internal_video_codecs's visibility list: [ > //third_party/webrtc/* > //third_party/webrtc_overrides/* > ] > > https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webrtc.fyi%2FLinux_Builder%2F23560%2F%2B%2Frecipes%2Fsteps%2Fgenerate_build_files%2F0%2Fstdout > > Original change's description: > > GN rtc_* templates: Set default visibility to webrtc_root + "/*" > > > > This means that by default, targets are visible to everything under > > the WebRTC root, but not visible to anything else. > > > > API targets are manually tagged with visibility "*", so that targets > > outside the WebRTC tree can see them. > > > > BUG=webrtc:8254 > > > > Change-Id: Icdbee6e0d22d93240ff2fb530c8f9dc48e351509 > > Reviewed-on: https://webrtc-review.googlesource.com/24140 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#21548} > > TBR=mbonadei@webrtc.org,kwiberg@webrtc.org > > Change-Id: I06620ce3d6f67482935c22efa231dd6cab91625a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:8254 > Reviewed-on: https://webrtc-review.googlesource.com/38760 > Reviewed-by: Per Kjellander <perkj@webrtc.org> > Commit-Queue: Per Kjellander <perkj@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#21555} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,perkj@webrtc.org Change-Id: I6f720078ce21bd172e0a6471bae8c4c011e4a657 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:8254 Reviewed-on: https://webrtc-review.googlesource.com/38860 Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Per Kjellander <perkj@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21558}
2018-01-10 15:54:53 +00:00
visibility = [ "*" ]
Removing RTC_SUPPORTS_METAL compilation flag. This flag is a holdover from before either macOS or the iOS Simulator supported Metal rendering. Bug: webrtc:12638 Change-Id: Iced21bfac40192f609b65f5ea1dc3393ee1695fb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/222461 Commit-Queue: Jake Bromberg <jakebromberg@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34347}
2021-06-14 13:44:25 -07:00
allow_poison = [
"audio_codecs", # TODO(bugs.webrtc.org/8396): Remove.
"default_task_queue",
]
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
if (is_ios) {
sources = [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/components/renderer/opengl/RTCDisplayLinkTimer.h",
"objc/components/renderer/opengl/RTCDisplayLinkTimer.m",
"objc/components/renderer/opengl/RTCEAGLVideoView.h",
"objc/components/renderer/opengl/RTCEAGLVideoView.m",
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
]
Silence OpenGLES deprecation warning. The deprecation warning started to trigger after the iOS deployment target has been updated from 10 to 12 by https://webrtc-review.googlesource.com/c/src/+/224543. This macro was not defined in tests because the relevant bots were excluded from CQ when that happened. Bug: webrtc:12928, webrtc:12937 Change-Id: I6e1891c5080b172cbd74649e0a115b25d6c87d56 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/225020 Reviewed-by: Victor Boivie <boivie@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34417}
2021-07-05 16:47:49 +02:00
# TODO(bugs.webrtc.org/12937): Remove OpenGL deprecation warning
# workaround.
Increase iOS deployment target from 10 to 12. TBR=kthelgason@webrtc.org Bug: webrtc:12928 Change-Id: I50de09972bf012e78a9bc9f1d98d8d07aab4e180 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/224543 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34409}
2021-07-02 16:19:32 +02:00
defines = [ "GLES_SILENCE_DEPRECATION" ]
GN: Tighten up test target visibility + refactorings Make all rtc_source_test target that contains tests that are included in a test executable only be visible to the rtc_test target. Doing this exposed a couple of errors and dependency problems that were resolved. Having this could have prevented duplicated execution of tests like the case that was recently fixed by deadbeef@ in https://codereview.webrtc.org/2820263004 New targets: * //webrtc/modules/rtp_rtcp:fec_test_helper * //webrtc/modules/rtp_rtcp:mock_rtp_rtcp * //webrtc/modules/remote_bitrate_estimator:mock_remote_bitrate_observer The mock files and targets should probably be moved into webrtc/test in the future, but that's out of the scope of this CL. BUG=webrtc:5716 NOTRY=True Review-Url: https://codereview.webrtc.org/2828793003 Cr-Commit-Position: refs/heads/master@{#17863}
2017-04-25 04:04:50 -07:00
}
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
if (is_mac) {
sources = [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/components/renderer/opengl/RTCNSGLVideoView.h",
"objc/components/renderer/opengl/RTCNSGLVideoView.m",
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
]
}
configs += [ "..:common_objc" ]
Enabling 'gn check' on webrtc/sdk BUG=webrtc:7499 Review-Url: https://codereview.webrtc.org/2818433003 Cr-Commit-Position: refs/heads/master@{#17805}
2017-04-21 00:02:02 -07:00
deps = [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
":base_objc",
":helpers_objc",
Removing RTC_SUPPORTS_METAL compilation flag. This flag is a holdover from before either macOS or the iOS Simulator supported Metal rendering. Bug: webrtc:12638 Change-Id: Iced21bfac40192f609b65f5ea1dc3393ee1695fb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/222461 Commit-Queue: Jake Bromberg <jakebromberg@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34347}
2021-06-14 13:44:25 -07:00
":metal_objc",
iOS: Get WebRTC building for Mac Catalyst - Add an option for disabling the OpenGL renderer - Change the build script to use correct header location - Use Metal compatibility for h264 CoreVideo buffers Bug: webrtc:11516 Change-Id: Ia34a9305648e75904ac36e69593ffefedd833bfb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/224200 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34426}
2021-07-06 12:16:41 -07:00
":opengl_objc",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
":videocapture_objc",
":videoframebuffer_objc",
Enabling 'gn check' on webrtc/sdk BUG=webrtc:7499 Review-Url: https://codereview.webrtc.org/2818433003 Cr-Commit-Position: refs/heads/master@{#17805}
2017-04-21 00:02:02 -07:00
]
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
}
Enabling 'gn check' on webrtc/sdk BUG=webrtc:7499 Review-Url: https://codereview.webrtc.org/2818433003 Cr-Commit-Position: refs/heads/master@{#17805}
2017-04-21 00:02:02 -07:00
Removing RTC_SUPPORTS_METAL compilation flag. This flag is a holdover from before either macOS or the iOS Simulator supported Metal rendering. Bug: webrtc:12638 Change-Id: Iced21bfac40192f609b65f5ea1dc3393ee1695fb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/222461 Commit-Queue: Jake Bromberg <jakebromberg@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34347}
2021-06-14 13:44:25 -07:00
rtc_library("metal_objc") {
visibility = [ "*" ]
allow_poison = [
"audio_codecs", # TODO(bugs.webrtc.org/8396): Remove.
"default_task_queue",
]
sources = [
"objc/components/renderer/metal/RTCMTLI420Renderer.h",
"objc/components/renderer/metal/RTCMTLI420Renderer.mm",
"objc/components/renderer/metal/RTCMTLNV12Renderer.h",
"objc/components/renderer/metal/RTCMTLNV12Renderer.mm",
"objc/components/renderer/metal/RTCMTLRGBRenderer.h",
"objc/components/renderer/metal/RTCMTLRGBRenderer.mm",
"objc/components/renderer/metal/RTCMTLRenderer+Private.h",
"objc/components/renderer/metal/RTCMTLRenderer.h",
"objc/components/renderer/metal/RTCMTLRenderer.mm",
]
frameworks = [
"CoreVideo.framework",
"Metal.framework",
"MetalKit.framework",
]
if (is_ios) {
sources += [
"objc/components/renderer/metal/RTCMTLVideoView.h",
"objc/components/renderer/metal/RTCMTLVideoView.m",
Add missing AppKit dependency Bug: None Change-Id: I8175ca0f60b6ebccf7aed6a46e8faff3878c2963 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148584 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28817}
2019-08-09 09:44:19 +02:00
]
Removing RTC_SUPPORTS_METAL compilation flag. This flag is a holdover from before either macOS or the iOS Simulator supported Metal rendering. Bug: webrtc:12638 Change-Id: Iced21bfac40192f609b65f5ea1dc3393ee1695fb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/222461 Commit-Queue: Jake Bromberg <jakebromberg@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34347}
2021-06-14 13:44:25 -07:00
}
if (is_mac) {
sources += [
"objc/components/renderer/metal/RTCMTLNSVideoView.h",
"objc/components/renderer/metal/RTCMTLNSVideoView.m",
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
]
Removing RTC_SUPPORTS_METAL compilation flag. This flag is a holdover from before either macOS or the iOS Simulator supported Metal rendering. Bug: webrtc:12638 Change-Id: Iced21bfac40192f609b65f5ea1dc3393ee1695fb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/222461 Commit-Queue: Jake Bromberg <jakebromberg@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34347}
2021-06-14 13:44:25 -07:00
frameworks += [ "AppKit.framework" ]
Refactor rtc_unittests into several targets. Also fix some warnings. NOTRY=True BUG=webrtc:6954 Review-Url: https://codereview.webrtc.org/2611663002 Cr-Commit-Position: refs/heads/master@{#15900}
2017-01-04 07:11:23 -08:00
}
Removing RTC_SUPPORTS_METAL compilation flag. This flag is a holdover from before either macOS or the iOS Simulator supported Metal rendering. Bug: webrtc:12638 Change-Id: Iced21bfac40192f609b65f5ea1dc3393ee1695fb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/222461 Commit-Queue: Jake Bromberg <jakebromberg@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34347}
2021-06-14 13:44:25 -07:00
deps = [
":base_objc",
":peerconnectionfactory_base_objc",
":videoframebuffer_objc",
"../api/video:video_frame",
"../api/video:video_rtp_headers",
"../rtc_base:checks",
]
configs += [ "..:common_objc" ]
public_configs = [ ":common_config_objc" ]
Refactor rtc_unittests into several targets. Also fix some warnings. NOTRY=True BUG=webrtc:6954 Review-Url: https://codereview.webrtc.org/2611663002 Cr-Commit-Position: refs/heads/master@{#15900}
2017-01-04 07:11:23 -08:00
}
[GN] Add rtc_sdk_framework_objc target to GN The build artifacts don't look completely identical to the ones generated by the GYP targets, but manual review shows the same symbols are exported. On iOS, the version generated by the GN follows convention, including a "Headers" directory, and the .modulemap file. I think this is preferred over the gyp version. BUG=webrtc:6320 NOTRY=True TESTED=Run AppRTCDemo on iOS + Mac and verified with nm that they export the same symbols. Review-Url: https://codereview.webrtc.org/2340633003 Cr-Commit-Position: refs/heads/master@{#14228}
2016-09-15 04:30:18 -07:00
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
# TODO(bugs.webrtc.org/9627): Remove this target.
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("videocapturebase_objc") {
Add an example app for iOS native API. Demonstrates how to use the iOS native API to wrap components into C++ classes. This CL also introduces a native API wrapper for the capturer. The C++ code is forked from the corresponding CL for Android at https://webrtc-review.googlesource.com/c/src/+/60540 Bug: webrtc:8832 Change-Id: I12d9f30e701c0222628e329218f6d5bfca26e6e0 Reviewed-on: https://webrtc-review.googlesource.com/61422 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22484}
2018-03-15 09:41:03 +01:00
visibility = [ "*" ]
Replace RTC_FALLTHROUGH with ABSL_FALLTHROUGH_INTENTED Bug: None Change-Id: I7287403f3fb13b8e30f92ca3cf1882b03bb53a6e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166176 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30283}
2020-01-16 14:41:10 +01:00
sources = [ "objc/helpers/noop.mm" ]
Add an example app for iOS native API. Demonstrates how to use the iOS native API to wrap components into C++ classes. This CL also introduces a native API wrapper for the capturer. The C++ code is forked from the corresponding CL for Android at https://webrtc-review.googlesource.com/c/src/+/60540 Bug: webrtc:8832 Change-Id: I12d9f30e701c0222628e329218f6d5bfca26e6e0 Reviewed-on: https://webrtc-review.googlesource.com/61422 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22484}
2018-03-15 09:41:03 +01:00
configs += [ "..:common_objc" ]
public_configs = [ ":common_config_objc" ]
deps = [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
":base_objc",
Add an example app for iOS native API. Demonstrates how to use the iOS native API to wrap components into C++ classes. This CL also introduces a native API wrapper for the capturer. The C++ code is forked from the corresponding CL for Android at https://webrtc-review.googlesource.com/c/src/+/60540 Bug: webrtc:8832 Change-Id: I12d9f30e701c0222628e329218f6d5bfca26e6e0 Reviewed-on: https://webrtc-review.googlesource.com/61422 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22484}
2018-03-15 09:41:03 +01:00
":videoframebuffer_objc",
]
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("videocapture_objc") {
Revert "Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*""" This reverts commit c73e1f437889d882cbf2987f7fb3a029a6150613. Reason for revert: The problem with failed deps in chrome content/renderer had already been fixed in https://webrtc-review.googlesource.com/c/src/+/38660 Original change's description: > Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*"" > > This reverts commit 588c548657b3ddf76e7b3f241263eef7f5799f16. > > Reason for revert: > > Breaks Chrome FYI: > > /b/c/b/Linux_Builder/src/buildtools/linux64/gn gen //out/Release --check > -> returned 1 > ERROR at //build/split_static_library.gni:12:5: Dependency not allowed. > static_library(target_name) { > ^---------------------------- > The item //content/renderer:renderer > can not depend on //third_party/webrtc/media:rtc_internal_video_codecs > because it is not in //third_party/webrtc/media:rtc_internal_video_codecs's visibility list: [ > //third_party/webrtc/* > //third_party/webrtc_overrides/* > ] > > https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webrtc.fyi%2FLinux_Builder%2F23560%2F%2B%2Frecipes%2Fsteps%2Fgenerate_build_files%2F0%2Fstdout > > Original change's description: > > GN rtc_* templates: Set default visibility to webrtc_root + "/*" > > > > This means that by default, targets are visible to everything under > > the WebRTC root, but not visible to anything else. > > > > API targets are manually tagged with visibility "*", so that targets > > outside the WebRTC tree can see them. > > > > BUG=webrtc:8254 > > > > Change-Id: Icdbee6e0d22d93240ff2fb530c8f9dc48e351509 > > Reviewed-on: https://webrtc-review.googlesource.com/24140 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#21548} > > TBR=mbonadei@webrtc.org,kwiberg@webrtc.org > > Change-Id: I06620ce3d6f67482935c22efa231dd6cab91625a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:8254 > Reviewed-on: https://webrtc-review.googlesource.com/38760 > Reviewed-by: Per Kjellander <perkj@webrtc.org> > Commit-Queue: Per Kjellander <perkj@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#21555} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,perkj@webrtc.org Change-Id: I6f720078ce21bd172e0a6471bae8c4c011e4a657 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:8254 Reviewed-on: https://webrtc-review.googlesource.com/38860 Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Per Kjellander <perkj@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21558}
2018-01-10 15:54:53 +00:00
visibility = [ "*" ]
Remove legacy video codec factories. Removes the deprecated video codec factories and the related flag and helper classes. Bug: webrtc:7925 Change-Id: I0a6d1666ece9ad074fefc79b626ba241765e1b98 Reviewed-on: https://webrtc-review.googlesource.com/c/113940 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Steve Anton <steveanton@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26245}
2019-01-14 14:23:23 +01:00
allow_poison = [ "audio_codecs" ] # TODO(bugs.webrtc.org/8396): Remove.
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
sources = [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/components/capturer/RTCCameraVideoCapturer.h",
"objc/components/capturer/RTCCameraVideoCapturer.m",
Switch AppRTCMobile #import headers. Bug: None Change-Id: Ia03faae59e4891039fc6c0acdeb51fdfea048c7b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/189547 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32447}
2020-10-19 16:12:43 +02:00
"objc/components/capturer/RTCFileVideoCapturer.h",
"objc/components/capturer/RTCFileVideoCapturer.m",
Support building WebRTC without audio and video for IOS. Reorganized the targets in webrtc/sdk/BUILD.gn so that the applications which use WebRTC DataChannel only can depend on the "peerconnection_factory_no_media" instead of "rtc_sdk_objc" to reduce the binary size. Provided a no-media implementation of RTCPeerConnectionFactory using the macro "HAVE_NO_MEDIA". BUG=webrtc:7613 Review-Url: https://codereview.webrtc.org/2944643002 Cr-Commit-Position: refs/heads/master@{#18819}
2017-06-28 14:05:44 -07:00
]
Convert GN libs lists to frameworks GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: chromium:1052560 Change-Id: I263230ddd3c468061584423bba9e1f887503bcaa Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178601 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#31632}
2020-07-03 10:19:30 +02:00
frameworks = [
Finally delete deprecated mac capturer. Landing this CL will break video_loopback but cl 124827 fixes that. Bug: webrtc:6898, webrtc:6333, webrtc:7861 Change-Id: Iecbbf75fab08570cc537784f7bbd11a841a2e5a6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/124828 Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27012}
2019-03-07 10:44:26 +01:00
"AVFoundation.framework",
"CoreVideo.framework",
Switch AppRTCMobile #import headers. Bug: None Change-Id: Ia03faae59e4891039fc6c0acdeb51fdfea048c7b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/189547 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32447}
2020-10-19 16:12:43 +02:00
"QuartzCore.framework",
Finally delete deprecated mac capturer. Landing this CL will break video_loopback but cl 124827 fixes that. Bug: webrtc:6898, webrtc:6333, webrtc:7861 Change-Id: Iecbbf75fab08570cc537784f7bbd11a841a2e5a6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/124828 Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27012}
2019-03-07 10:44:26 +01:00
]
Support building WebRTC without audio and video for IOS. Reorganized the targets in webrtc/sdk/BUILD.gn so that the applications which use WebRTC DataChannel only can depend on the "peerconnection_factory_no_media" instead of "rtc_sdk_objc" to reduce the binary size. Provided a no-media implementation of RTCPeerConnectionFactory using the macro "HAVE_NO_MEDIA". BUG=webrtc:7613 Review-Url: https://codereview.webrtc.org/2944643002 Cr-Commit-Position: refs/heads/master@{#18819}
2017-06-28 14:05:44 -07:00
configs += [ "..:common_objc" ]
Rename all objc targets to be suffixed for consistency BUG=webrtc:6412 Review-Url: https://codereview.webrtc.org/3001023003 Cr-Commit-Position: refs/heads/master@{#19489}
2017-08-24 05:43:45 -07:00
public_configs = [ ":common_config_objc" ]
Support building WebRTC without audio and video for IOS. Reorganized the targets in webrtc/sdk/BUILD.gn so that the applications which use WebRTC DataChannel only can depend on the "peerconnection_factory_no_media" instead of "rtc_sdk_objc" to reduce the binary size. Provided a no-media implementation of RTCPeerConnectionFactory using the macro "HAVE_NO_MEDIA". BUG=webrtc:7613 Review-Url: https://codereview.webrtc.org/2944643002 Cr-Commit-Position: refs/heads/master@{#18819}
2017-06-28 14:05:44 -07:00
deps = [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
":base_objc",
":helpers_objc",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
":videoframebuffer_objc",
Reland "Leverage dispatch_queue_create_with_target when possible." This is a reland of de86381161651816c078adeb354902b15d03a35b Original change's description: > Leverage dispatch_queue_create_with_target when possible. > > Replacing dispatch_queue_create followed by > dispatch_set_target_queue with dispatch_queue_create_with_target > is claimed to be source of GCD performance improvement: > https://developer.apple.com/videos/play/wwdc2017/706/ > Video since 40 min. Slides since 199. > > Bug: webrtc:9055 > Change-Id: I0136f7faaef0951a7ad243bc8772f3ee952d5470 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168491 > Reviewed-by: Tommi <tommi@webrtc.org> > Reviewed-by: Kári Helgason <kthelgason@webrtc.org> > Commit-Queue: Yura Yaroshevich <yura.yaroshevich@gmail.com> > Cr-Commit-Position: refs/heads/master@{#30781} Bug: webrtc:9055 Change-Id: I36b0b6423c81c0497f66f7c993741c33ff6ec5ba Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170443 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30821}
2020-03-16 18:00:59 +03:00
"../rtc_base/system:gcd_helpers",
Support building WebRTC without audio and video for IOS. Reorganized the targets in webrtc/sdk/BUILD.gn so that the applications which use WebRTC DataChannel only can depend on the "peerconnection_factory_no_media" instead of "rtc_sdk_objc" to reduce the binary size. Provided a no-media implementation of RTCPeerConnectionFactory using the macro "HAVE_NO_MEDIA". BUG=webrtc:7613 Review-Url: https://codereview.webrtc.org/2944643002 Cr-Commit-Position: refs/heads/master@{#18819}
2017-06-28 14:05:44 -07:00
]
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("videocodec_objc") {
GN hack to tag targets as poisonous (and use it with audio codecs) Only specially taggged targets may transitively depend on poisonous targets. We first apply it to audio codecs. This makes it much clearer exactly what parts of the code still have dependencies on the audio codecs (and we want to eventually get rid of pretty much all of them). Bug: webrtc:8396, webrtc:9121 Change-Id: Iba5c2e806c702b5cfe881022674705f647896d43 Reviewed-on: https://webrtc-review.googlesource.com/69520 Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22979}
2018-04-22 19:55:00 +02:00
visibility = [ "*" ]
Enable -Wexit-time-destructors and -Wglobal-constructors. This CL enables -Wexit-time-destructors and -Wglobal-constructors on rtc_static_library and rtc_source_set build targets. It also adds the possibility to suppress these warnings because they trigger in a few places. The long term goal is to avoid regressions on this and remove all the suppressions. Bug: webrtc:9693 Change-Id: I4c1ecc137ef9e87ec5e66981ce95d96fb082727c Reviewed-on: https://webrtc-review.googlesource.com/98380 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24604}
2018-09-06 13:45:44 +02:00
configs += [ "..:no_global_constructors" ]
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
sources = [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/components/video_codec/RTCCodecSpecificInfoH264+Private.h",
"objc/components/video_codec/RTCCodecSpecificInfoH264.h",
"objc/components/video_codec/RTCCodecSpecificInfoH264.mm",
"objc/components/video_codec/RTCH264ProfileLevelId.h",
"objc/components/video_codec/RTCH264ProfileLevelId.mm",
Support building WebRTC without audio and video for IOS. Reorganized the targets in webrtc/sdk/BUILD.gn so that the applications which use WebRTC DataChannel only can depend on the "peerconnection_factory_no_media" instead of "rtc_sdk_objc" to reduce the binary size. Provided a no-media implementation of RTCPeerConnectionFactory using the macro "HAVE_NO_MEDIA". BUG=webrtc:7613 Review-Url: https://codereview.webrtc.org/2944643002 Cr-Commit-Position: refs/heads/master@{#18819}
2017-06-28 14:05:44 -07:00
]
Init max supported H.264 profile at runtime on iOS Bug: webrtc:9134, webrtc:7992 Change-Id: Id24c570bf3296298901f61ee817a3d7c3f8c6347 Reviewed-on: https://webrtc-review.googlesource.com/71560 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23034}
2018-04-26 15:41:01 +03:00
if (is_ios) {
sources += [
Revert "Add a prefix for objc category." This reverts commit 181ea6e414c5982015ce161e6368120be3658ec4. Reason for revert: Breaks downstream project. Kári will help to land it next week. Original change's description: > Add a prefix for objc category. > > According to the Google Objective-C style [1], category names should > start with an appropriate prefix. WebRTC has some category definitions > for system interfaces, but it doesn't use prefixes. > > $ otool -ov WebRTC.framework/WebRTC | grep -E "^[0-9a-z]{16} 0x[0-9a-z]+ __OBJC_._CATEGORY" | grep -v "_RTC" > 0000000002160840 0x217c3c0 __OBJC_$_CATEGORY_UIDevice_$_H264Profile > 0000000002160850 0x21808b8 __OBJC_$_CATEGORY_AVCaptureSession_$_DevicePosition > 0000000002160858 0x2180968 __OBJC_$_CATEGORY_NSString_$_StdString > 0000000002160860 0x21809c8 __OBJC_$_CATEGORY_NSString_$_AbslStringView > > To avoid conflicts, prefix the names and methods of those categories. > Also remove sdk/objc/Framework/Classes/Common/NSString+StdString.h as > it is not used by any other files. > > [1] https://google.github.io/styleguide/objcguide.html#category-naming > > Bug: webrtc:13884 > Change-Id: I2cf2742af198ab4e0bfb15c0476d72971e50ceee > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262341 > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Kári Helgason <kthelgason@webrtc.org> > Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com> > Reviewed-by: Artem Titov <titovartem@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#36880} Bug: webrtc:13884 Change-Id: I85257088e4a3a62e01ff925ab5e77af83b078ef3 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262420 Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Artem Titov <titovartem@webrtc.org> Auto-Submit: Artem Titov <titovartem@webrtc.org> Owners-Override: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36885}
2022-05-13 14:46:42 +00:00
"objc/components/video_codec/UIDevice+H264Profile.h",
"objc/components/video_codec/UIDevice+H264Profile.mm",
Init max supported H.264 profile at runtime on iOS Bug: webrtc:9134, webrtc:7992 Change-Id: Id24c570bf3296298901f61ee817a3d7c3f8c6347 Reviewed-on: https://webrtc-review.googlesource.com/71560 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23034}
2018-04-26 15:41:01 +03:00
]
}
Implicitly suppress //build/config/clang:find_bad_constructs. Since there is no way to enable/disable these diagnostics at runtime, this CL moves the suppression into the rtc_* templates in order to remove the need to explicitly add the snippet of code needed to suppress it (currently copy/pasted in 144 locations). The diagnostic that causes the most problems is the one about "complex class/struct explicit ctor/dtor" [1] because WebRTC doesn't find it useful enough. Other diagnostics are good (for example the one that warns about using "virtual" instead of "override", but that will be covered by this clang-tidy check [2]) while others are Chromium related so they have never triggered. [1] - https://cs.chromium.org/chromium/src/tools/clang/plugins/FindBadConstructsConsumer.cpp?l=147-167&rcl=b4bebe1aa15dba7ca5fcc6456a81a55665327c3a [2] - https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-override.html Bug: webrtc:163 Change-Id: Icbf27efa5b369100a31e6a32df1a0913729b3b34 Reviewed-on: https://webrtc-review.googlesource.com/c/125088 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26918}
2019-03-01 10:32:56 +01:00
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
public_configs = [ ":common_config_objc" ]
deps = [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
":base_objc",
":helpers_objc",
Reland of Injectable Obj-C video codecs (patchset #1 id:1 of https://codereview.webrtc.org/2980173002/ ) Reason for revert: Relanding after fixing issues with no video. Original issue's description: > Revert of Injectable Obj-C video codecs (patchset #2 id:370001 of https://codereview.webrtc.org/2979983002/ ) > > Reason for revert: > Still having problems with no video. Reverting. > Once no video is visible, no video is available from then on even if the callee app is in the foreground. > > > Original issue's description: > > Reland of Injectable Obj-C video codecs (patchset #1 id:1 of https://codereview.webrtc.org/2979973002/ ) > > > > Reason for revert: > > Fix the broken build file > > > > Original issue's description: > > > Revert of Injectable Obj-C video codecs (patchset #3 id:400001 of https://codereview.webrtc.org/2981583002/ ) > > > > > > Reason for revert: > > > Breaks bots. Build file incorrect. > > > > > > Original issue's description: > > > > Reland of Injectable Obj-C video codecs (patchset #1 id:1 of https://codereview.webrtc.org/2975963002/ ) > > > > > > > > Reason for revert: > > > > New CL for fixing the issues > > > > > > > > Original issue's description: > > > > > Revert of Injectable Obj-C video codecs (patchset #8 id:140001 of https://codereview.webrtc.org/2966023002/ ) > > > > > > > > > > Reason for revert: > > > > > Causes no video in certain scenarios. Please come up with a test plan or unit test to prevent such problems in the future. > > > > > > > > > > Original issue's description: > > > > > > Injectable Obj-C video codecs > > > > > > > > > > > > Initial CL for this effort, with a working RTCVideoEncoder/Decoder for H264 > > > > > > (wrapping the VideoToolbox codec). > > > > > > > > > > > > Some notes / things left to do: > > > > > > - There are some hard-coded references to codec types that are supported by > > > > > > webrtc::VideoCodec, cricket::VideoCodec, webrtc::CodecSpecificInfo etc > > > > > > since we need to convert to/from these types in ObjCVideoEncoder/Decoder. > > > > > > These types would need to be more codec agnostic to avoid this. > > > > > > - Most interfaces are borrowed from the design document for injectable > > > > > > codecs in Android. Some data in the corresponding C++ classes is discarded > > > > > > when converting to the Obj-C version, since it has fewer fields. I have not > > > > > > verified whether all data that we do keep is needed, or whether we might be > > > > > > losing anything useful in these conversions. > > > > > > - Implement the VideoToolbox codec code directly in the RTCVideoEncoderH264 > > > > > > classes, instead of wrapping webrtc::H264VideoToolboxEncoder / decoder. > > > > > > Eliminates converting between ObjC/C++ types outside the ObjCVideoEncoder/ > > > > > > Decoder wrapper classes. > > > > > > - List the injected codec factory's supported codecs in the list of codecs in > > > > > > AppRTCMobile. > > > > > > > > > > > > BUG=webrtc:7924 > > > > > > R=magjed@webrtc.org > > > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2966023002 . > > > > > > Cr-Commit-Position: refs/heads/master@{#18928} > > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/a0349c138db62c52435be84b6c837f5f4758e264 > > > > > > > > > > TBR=magjed@webrtc.org,andersc@webrtc.org > > > > > # Not skipping CQ checks because original CL landed more than 1 days ago. > > > > > BUG=webrtc:7924 > > > > > NOTRY=true > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2975963002 > > > > > Cr-Commit-Position: refs/heads/master@{#18979} > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/1095ada7ad56fe29b7b2bbc560a8f6475a7978ce > > > > > > > > R=magjed@webrtc.org > > > > TBR=tkchin@webrtc.org > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > NOPRESUBMIT=true > > > > NOTREECHECKS=true > > > > NOTRY=true > > > > BUG=webrtc:7924 > > > > > > > > Review-Url: https://codereview.webrtc.org/2981583002 . > > > > Cr-Commit-Position: refs/heads/master@{#19002} > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/a5f1de1e6541de03f944bcbf49be87c01f57a18b > > > > > > TBR=magjed@webrtc.org,tkchin@webrtc.org,jtteh@webrtc.org,andersc@webrtc.org > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=webrtc:7924 > > > > > > Review-Url: https://codereview.webrtc.org/2979973002 > > > Cr-Commit-Position: refs/heads/master@{#19004} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/81d40ee1491d5229c2677cc04b1f40d67c2babef > > > > TBR=magjed@webrtc.org,tkchin@webrtc.org,jtteh@webrtc.org,sprang@webrtc.org > > BUG=webrtc:7924 > > > > Review-Url: https://codereview.webrtc.org/2979983002 > > Cr-Commit-Position: refs/heads/master@{#19005} > > Committed: https://chromium.googlesource.com/external/webrtc/+/732a3437da4db7b452758b8e1cf26fce0ce3bf65 > > TBR=magjed@webrtc.org,tkchin@webrtc.org,sprang@webrtc.org,haysc@webrtc.org,andersc@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:7924 > > Review-Url: https://codereview.webrtc.org/2980173002 > Cr-Commit-Position: refs/heads/master@{#19036} > Committed: https://chromium.googlesource.com/external/webrtc/+/860f7298166084d966749e22b69aa2fdcf4d4ed6 TBR=magjed@webrtc.org,tkchin@webrtc.org,sprang@webrtc.org,haysc@webrtc.org,andersc@webrtc.org,jtteh@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:7924 Review-Url: https://codereview.webrtc.org/2977213002 Cr-Commit-Position: refs/heads/master@{#19135}
2017-07-25 07:55:58 -07:00
"../api/video_codecs:video_codecs_api",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
"../common_video",
Support building WebRTC without audio and video for IOS. Reorganized the targets in webrtc/sdk/BUILD.gn so that the applications which use WebRTC DataChannel only can depend on the "peerconnection_factory_no_media" instead of "rtc_sdk_objc" to reduce the binary size. Provided a no-media implementation of RTCPeerConnectionFactory using the macro "HAVE_NO_MEDIA". BUG=webrtc:7613 Review-Url: https://codereview.webrtc.org/2944643002 Cr-Commit-Position: refs/heads/master@{#18819}
2017-06-28 14:05:44 -07:00
"../media:rtc_media_base",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
"../modules/video_coding:video_codec_interface",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"../rtc_base:checks",
Support building WebRTC without audio and video for IOS. Reorganized the targets in webrtc/sdk/BUILD.gn so that the applications which use WebRTC DataChannel only can depend on the "peerconnection_factory_no_media" instead of "rtc_sdk_objc" to reduce the binary size. Provided a no-media implementation of RTCPeerConnectionFactory using the macro "HAVE_NO_MEDIA". BUG=webrtc:7613 Review-Url: https://codereview.webrtc.org/2944643002 Cr-Commit-Position: refs/heads/master@{#18819}
2017-06-28 14:05:44 -07:00
]
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("default_codec_factory_objc") {
Enable building WebRTC without built-in software codecs This CL adds a GN build flag to include builtin software codecs (enabled by default). When setting the flag to false, libvpx can also be excluded. The benefit is that the resulting binary is smaller. Replaces https://webrtc-review.googlesource.com/c/src/+/29203 Bug: webrtc:7925 Change-Id: Id330ea8a43169e449ee139eca18e4557cc932e10 Reviewed-on: https://webrtc-review.googlesource.com/36340 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21818}
2018-01-30 10:32:13 +01:00
sources = [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/components/video_codec/RTCDefaultVideoDecoderFactory.h",
"objc/components/video_codec/RTCDefaultVideoDecoderFactory.m",
"objc/components/video_codec/RTCDefaultVideoEncoderFactory.h",
"objc/components/video_codec/RTCDefaultVideoEncoderFactory.m",
Enable building WebRTC without built-in software codecs This CL adds a GN build flag to include builtin software codecs (enabled by default). When setting the flag to false, libvpx can also be excluded. The benefit is that the resulting binary is smaller. Replaces https://webrtc-review.googlesource.com/c/src/+/29203 Bug: webrtc:7925 Change-Id: Id330ea8a43169e449ee139eca18e4557cc932e10 Reviewed-on: https://webrtc-review.googlesource.com/36340 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21818}
2018-01-30 10:32:13 +01:00
]
deps = [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
":base_objc",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
":native_video",
":videocodec_objc",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
":videotoolbox_objc",
ObjC SDK: Stop using built-in SW video codecs This CL removes the use of default built-in SW in the ObjC layer. If a client want to depend on the video SW codecs, they must inject them explicitly. Bug: webrtc:7925 Change-Id: If752e7f02109ff768dc5ec38d935203de85987c2 Reviewed-on: https://webrtc-review.googlesource.com/69800 Commit-Queue: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23073}
2018-04-13 15:36:43 +02:00
":vp8",
":vp9",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
":vpx_codec_constants",
]
Always include the actual encoder implementation when RTCVideoEncoderAV1 is used. Bug: webrtc:13573, b/236813931 Change-Id: I943ce51dac23bcbd6efe10413cfa9478f4ce6f55 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266485 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Commit-Queue: Philip Eliasson <philipel@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37352}
2022-06-22 14:24:59 +02:00
defines = []
if (enable_libaom) {
defines += [ "RTC_USE_LIBAOM_AV1_ENCODER" ]
deps += [ ":libaom_av1_encoder" ]
}
Always include the actual decoder implementation when RTCVideoDecoderAV1 is used. Bug: webrtc:13573, b/236814111 Change-Id: I053fcec3d85fdc9f8d3b72af1735b4091ec5f7c6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267620 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37418}
2022-07-04 10:44:14 +02:00
if (rtc_include_dav1d_in_internal_decoder_factory) {
deps += [ ":dav1d_decoder" ]
}
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("vpx_codec_constants") {
Enable -Wexit-time-destructors and -Wglobal-constructors. This CL enables -Wexit-time-destructors and -Wglobal-constructors on rtc_static_library and rtc_source_set build targets. It also adds the possibility to suppress these warnings because they trigger in a few places. The long term goal is to avoid regressions on this and remove all the suppressions. Bug: webrtc:9693 Change-Id: I4c1ecc137ef9e87ec5e66981ce95d96fb082727c Reviewed-on: https://webrtc-review.googlesource.com/98380 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24604}
2018-09-06 13:45:44 +02:00
configs += [ "..:no_global_constructors" ]
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
sources = [
"objc/api/video_codec/RTCVideoCodecConstants.h",
"objc/api/video_codec/RTCVideoCodecConstants.mm",
]
deps = [
":base_objc",
"../media:rtc_media_base",
Enable building WebRTC without built-in software codecs This CL adds a GN build flag to include builtin software codecs (enabled by default). When setting the flag to false, libvpx can also be excluded. The benefit is that the resulting binary is smaller. Replaces https://webrtc-review.googlesource.com/c/src/+/29203 Bug: webrtc:7925 Change-Id: Id330ea8a43169e449ee139eca18e4557cc932e10 Reviewed-on: https://webrtc-review.googlesource.com/36340 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21818}
2018-01-30 10:32:13 +01:00
]
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("vp8") {
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
visibility = [ "*" ]
Break out the part of the iSAC codec that's used for Voice Activity Detection The audio processing code is using parts of the iSAC codec to do voice activity detection (VAD), but it's undesirable for it to pull in the entire iSAC codec as a dependency. So this CL factors out the parts of iSAC that's needed for VAD to a separate build target. Bug: webrtc:8396 Change-Id: I884e25d8fd0bc815fca664352b0573b4b173880e Reviewed-on: https://webrtc-review.googlesource.com/69640 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23110}
2018-04-27 04:31:53 +02:00
allow_poison = [ "software_video_codecs" ]
Enable building WebRTC without built-in software codecs This CL adds a GN build flag to include builtin software codecs (enabled by default). When setting the flag to false, libvpx can also be excluded. The benefit is that the resulting binary is smaller. Replaces https://webrtc-review.googlesource.com/c/src/+/29203 Bug: webrtc:7925 Change-Id: Id330ea8a43169e449ee139eca18e4557cc932e10 Reviewed-on: https://webrtc-review.googlesource.com/36340 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21818}
2018-01-30 10:32:13 +01:00
sources = [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/api/video_codec/RTCVideoDecoderVP8.h",
"objc/api/video_codec/RTCVideoDecoderVP8.mm",
"objc/api/video_codec/RTCVideoEncoderVP8.h",
"objc/api/video_codec/RTCVideoEncoderVP8.mm",
Enable building WebRTC without built-in software codecs This CL adds a GN build flag to include builtin software codecs (enabled by default). When setting the flag to false, libvpx can also be excluded. The benefit is that the resulting binary is smaller. Replaces https://webrtc-review.googlesource.com/c/src/+/29203 Bug: webrtc:7925 Change-Id: Id330ea8a43169e449ee139eca18e4557cc932e10 Reviewed-on: https://webrtc-review.googlesource.com/36340 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21818}
2018-01-30 10:32:13 +01:00
]
deps = [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
":base_objc",
Fix native api in preparation for native_api example. Add native api conversions for video frames and video renderer. This also requires some changes to sdk/BUILD to avoid cyclic dependencies. Bug: webrtc:8832 Change-Id: Ibf21e63bdcae195dcb61d63f9262e6a8dc4fa790 Reviewed-on: https://webrtc-review.googlesource.com/57142 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22340}
2018-03-07 10:32:03 +01:00
":wrapped_native_codec_objc",
Enable building WebRTC without built-in software codecs This CL adds a GN build flag to include builtin software codecs (enabled by default). When setting the flag to false, libvpx can also be excluded. The benefit is that the resulting binary is smaller. Replaces https://webrtc-review.googlesource.com/c/src/+/29203 Bug: webrtc:7925 Change-Id: Id330ea8a43169e449ee139eca18e4557cc932e10 Reviewed-on: https://webrtc-review.googlesource.com/36340 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21818}
2018-01-30 10:32:13 +01:00
"../modules/video_coding:webrtc_vp8",
]
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("vp9") {
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
visibility = [ "*" ]
Break out the part of the iSAC codec that's used for Voice Activity Detection The audio processing code is using parts of the iSAC codec to do voice activity detection (VAD), but it's undesirable for it to pull in the entire iSAC codec as a dependency. So this CL factors out the parts of iSAC that's needed for VAD to a separate build target. Bug: webrtc:8396 Change-Id: I884e25d8fd0bc815fca664352b0573b4b173880e Reviewed-on: https://webrtc-review.googlesource.com/69640 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23110}
2018-04-27 04:31:53 +02:00
allow_poison = [ "software_video_codecs" ]
Enable building WebRTC without built-in software codecs This CL adds a GN build flag to include builtin software codecs (enabled by default). When setting the flag to false, libvpx can also be excluded. The benefit is that the resulting binary is smaller. Replaces https://webrtc-review.googlesource.com/c/src/+/29203 Bug: webrtc:7925 Change-Id: Id330ea8a43169e449ee139eca18e4557cc932e10 Reviewed-on: https://webrtc-review.googlesource.com/36340 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21818}
2018-01-30 10:32:13 +01:00
sources = [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/api/video_codec/RTCVideoDecoderVP9.h",
"objc/api/video_codec/RTCVideoDecoderVP9.mm",
"objc/api/video_codec/RTCVideoEncoderVP9.h",
"objc/api/video_codec/RTCVideoEncoderVP9.mm",
Enable building WebRTC without built-in software codecs This CL adds a GN build flag to include builtin software codecs (enabled by default). When setting the flag to false, libvpx can also be excluded. The benefit is that the resulting binary is smaller. Replaces https://webrtc-review.googlesource.com/c/src/+/29203 Bug: webrtc:7925 Change-Id: Id330ea8a43169e449ee139eca18e4557cc932e10 Reviewed-on: https://webrtc-review.googlesource.com/36340 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21818}
2018-01-30 10:32:13 +01:00
]
deps = [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
":base_objc",
Fix native api in preparation for native_api example. Add native api conversions for video frames and video renderer. This also requires some changes to sdk/BUILD to avoid cyclic dependencies. Bug: webrtc:8832 Change-Id: Ibf21e63bdcae195dcb61d63f9262e6a8dc4fa790 Reviewed-on: https://webrtc-review.googlesource.com/57142 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22340}
2018-03-07 10:32:03 +01:00
":wrapped_native_codec_objc",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"../media:rtc_media_base",
Enable building WebRTC without built-in software codecs This CL adds a GN build flag to include builtin software codecs (enabled by default). When setting the flag to false, libvpx can also be excluded. The benefit is that the resulting binary is smaller. Replaces https://webrtc-review.googlesource.com/c/src/+/29203 Bug: webrtc:7925 Change-Id: Id330ea8a43169e449ee139eca18e4557cc932e10 Reviewed-on: https://webrtc-review.googlesource.com/36340 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21818}
2018-01-30 10:32:13 +01:00
"../modules/video_coding:webrtc_vp9",
]
}
Always include the actual decoder implementation when RTCVideoDecoderAV1 is used. Bug: webrtc:13573, b/236814111 Change-Id: I053fcec3d85fdc9f8d3b72af1735b4091ec5f7c6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267620 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37418}
2022-07-04 10:44:14 +02:00
rtc_library("dav1d_decoder") {
Add AV1 encoder&decoder wrappers for iOS SDK. It is now possible to use AV1 encoder and decoder on iOS and test them in apps like AppRTCMobile. Bug: None Change-Id: Ifae221020e5abf3809010676862eecd9ffeec5e3 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/208400 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33378}
2021-03-03 12:29:42 +03:00
visibility = [ "*" ]
allow_poison = [ "software_video_codecs" ]
sources = [
"objc/api/video_codec/RTCVideoDecoderAV1.h",
"objc/api/video_codec/RTCVideoDecoderAV1.mm",
]
deps = [
":base_objc",
":wrapped_native_codec_objc",
"../media:rtc_media_base",
Always include the actual decoder implementation when RTCVideoDecoderAV1 is used. Bug: webrtc:13573, b/236814111 Change-Id: I053fcec3d85fdc9f8d3b72af1735b4091ec5f7c6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267620 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37418}
2022-07-04 10:44:14 +02:00
"../modules/video_coding/codecs/av1:dav1d_decoder",
Add AV1 encoder&decoder wrappers for iOS SDK. It is now possible to use AV1 encoder and decoder on iOS and test them in apps like AppRTCMobile. Bug: None Change-Id: Ifae221020e5abf3809010676862eecd9ffeec5e3 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/208400 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33378}
2021-03-03 12:29:42 +03:00
]
Always include the actual encoder implementation when RTCVideoEncoderAV1 is used. Bug: webrtc:13573, b/236813931 Change-Id: I943ce51dac23bcbd6efe10413cfa9478f4ce6f55 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266485 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Commit-Queue: Philip Eliasson <philipel@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37352}
2022-06-22 14:24:59 +02:00
}
Make the libaom AV1 encoder optional in RTCDefaultVideoEncoderFactory. This is a partial revert of: https://webrtc-review.googlesource.com/c/src/+/262814 skip_shebang_check=True bug: webrtc:13573 Change-Id: I08282df91446efa79ca86cc8dfe3b6daeb4eec9a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264543 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37074}
2022-05-31 17:24:44 +02:00
Always include the actual encoder implementation when RTCVideoEncoderAV1 is used. Bug: webrtc:13573, b/236813931 Change-Id: I943ce51dac23bcbd6efe10413cfa9478f4ce6f55 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266485 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Commit-Queue: Philip Eliasson <philipel@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37352}
2022-06-22 14:24:59 +02:00
rtc_library("libaom_av1_encoder") {
visibility = [ "*" ]
allow_poison = [ "software_video_codecs" ]
sources = [
"objc/api/video_codec/RTCVideoEncoderAV1.h",
"objc/api/video_codec/RTCVideoEncoderAV1.mm",
]
deps = [
":base_objc",
":wrapped_native_codec_objc",
"../media:rtc_media_base",
"../modules/video_coding/codecs/av1:libaom_av1_encoder",
]
Add AV1 encoder&decoder wrappers for iOS SDK. It is now possible to use AV1 encoder and decoder on iOS and test them in apps like AppRTCMobile. Bug: None Change-Id: Ifae221020e5abf3809010676862eecd9ffeec5e3 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/208400 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33378}
2021-03-03 12:29:42 +03:00
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("mediaconstraints_objc") {
Enable -Wexit-time-destructors and -Wglobal-constructors. This CL enables -Wexit-time-destructors and -Wglobal-constructors on rtc_static_library and rtc_source_set build targets. It also adds the possibility to suppress these warnings because they trigger in a few places. The long term goal is to avoid regressions on this and remove all the suppressions. Bug: webrtc:9693 Change-Id: I4c1ecc137ef9e87ec5e66981ce95d96fb082727c Reviewed-on: https://webrtc-review.googlesource.com/98380 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24604}
2018-09-06 13:45:44 +02:00
configs += [ "..:no_global_constructors" ]
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
sources = [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/api/peerconnection/RTCMediaConstraints+Private.h",
"objc/api/peerconnection/RTCMediaConstraints.h",
"objc/api/peerconnection/RTCMediaConstraints.mm",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
]
public_configs = [ ":common_config_objc" ]
deps = [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
":base_objc",
":helpers_objc",
Move MediaConstraintsInterface to sdk/, and make it a concrete class Bug: webrtc:9239 Change-Id: I545ebf59b078dd94bc466886616dd374e4b2e226 Reviewed-on: https://webrtc-review.googlesource.com/c/122502 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26682}
2019-02-13 08:52:27 +01:00
":media_constraints",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
]
}
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
# TODO(bugs.webrtc.org/9627): Remove, targets should depend on base_objc.
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("videorenderer_objc") {
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
visibility = [ "*" ]
Replace RTC_FALLTHROUGH with ABSL_FALLTHROUGH_INTENTED Bug: None Change-Id: I7287403f3fb13b8e30f92ca3cf1882b03bb53a6e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166176 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30283}
2020-01-16 14:41:10 +01:00
sources = [ "objc/helpers/noop.mm" ]
Fix native api in preparation for native_api example. Add native api conversions for video frames and video renderer. This also requires some changes to sdk/BUILD to avoid cyclic dependencies. Bug: webrtc:8832 Change-Id: Ibf21e63bdcae195dcb61d63f9262e6a8dc4fa790 Reviewed-on: https://webrtc-review.googlesource.com/57142 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22340}
2018-03-07 10:32:03 +01:00
configs += [ "..:common_objc" ]
public_configs = [ ":common_config_objc" ]
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
Replace RTC_FALLTHROUGH with ABSL_FALLTHROUGH_INTENTED Bug: None Change-Id: I7287403f3fb13b8e30f92ca3cf1882b03bb53a6e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166176 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30283}
2020-01-16 14:41:10 +01:00
deps = [ ":base_objc" ]
Fix native api in preparation for native_api example. Add native api conversions for video frames and video renderer. This also requires some changes to sdk/BUILD to avoid cyclic dependencies. Bug: webrtc:8832 Change-Id: Ibf21e63bdcae195dcb61d63f9262e6a8dc4fa790 Reviewed-on: https://webrtc-review.googlesource.com/57142 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22340}
2018-03-07 10:32:03 +01:00
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("videorendereradapter_objc") {
GN hack to tag targets as poisonous (and use it with audio codecs) Only specially taggged targets may transitively depend on poisonous targets. We first apply it to audio codecs. This makes it much clearer exactly what parts of the code still have dependencies on the audio codecs (and we want to eventually get rid of pretty much all of them). Bug: webrtc:8396, webrtc:9121 Change-Id: Iba5c2e806c702b5cfe881022674705f647896d43 Reviewed-on: https://webrtc-review.googlesource.com/69520 Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22979}
2018-04-22 19:55:00 +02:00
visibility = [ "*" ]
Remove legacy video codec factories. Removes the deprecated video codec factories and the related flag and helper classes. Bug: webrtc:7925 Change-Id: I0a6d1666ece9ad074fefc79b626ba241765e1b98 Reviewed-on: https://webrtc-review.googlesource.com/c/113940 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Steve Anton <steveanton@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26245}
2019-01-14 14:23:23 +01:00
allow_poison = [ "audio_codecs" ] # TODO(bugs.webrtc.org/8396): Remove.
Fix native api in preparation for native_api example. Add native api conversions for video frames and video renderer. This also requires some changes to sdk/BUILD to avoid cyclic dependencies. Bug: webrtc:8832 Change-Id: Ibf21e63bdcae195dcb61d63f9262e6a8dc4fa790 Reviewed-on: https://webrtc-review.googlesource.com/57142 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22340}
2018-03-07 10:32:03 +01:00
sources = [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/api/RTCVideoRendererAdapter+Private.h",
"objc/api/RTCVideoRendererAdapter.h",
"objc/api/RTCVideoRendererAdapter.mm",
Fix native api in preparation for native_api example. Add native api conversions for video frames and video renderer. This also requires some changes to sdk/BUILD to avoid cyclic dependencies. Bug: webrtc:8832 Change-Id: Ibf21e63bdcae195dcb61d63f9262e6a8dc4fa790 Reviewed-on: https://webrtc-review.googlesource.com/57142 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22340}
2018-03-07 10:32:03 +01:00
]
configs += [ "..:common_objc" ]
public_configs = [ ":common_config_objc" ]
deps = [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
":base_objc",
Fix native api in preparation for native_api example. Add native api conversions for video frames and video renderer. This also requires some changes to sdk/BUILD to avoid cyclic dependencies. Bug: webrtc:8832 Change-Id: Ibf21e63bdcae195dcb61d63f9262e6a8dc4fa790 Reviewed-on: https://webrtc-review.googlesource.com/57142 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22340}
2018-03-07 10:32:03 +01:00
":native_api",
":videoframebuffer_objc",
"../api:libjingle_peerconnection_api",
New build target api:media_interface Bug: webrtc:8733 Change-Id: I84bbefb1a5ef8e592db29b79499d60ac80c23464 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153180 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Steve Anton <steveanton@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29234}
2019-09-17 14:30:41 +02:00
"../api:media_stream_interface",
Fix native api in preparation for native_api example. Add native api conversions for video frames and video renderer. This also requires some changes to sdk/BUILD to avoid cyclic dependencies. Bug: webrtc:8832 Change-Id: Ibf21e63bdcae195dcb61d63f9262e6a8dc4fa790 Reviewed-on: https://webrtc-review.googlesource.com/57142 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22340}
2018-03-07 10:32:03 +01:00
]
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("mediasource_objc") {
Fix native api in preparation for native_api example. Add native api conversions for video frames and video renderer. This also requires some changes to sdk/BUILD to avoid cyclic dependencies. Bug: webrtc:8832 Change-Id: Ibf21e63bdcae195dcb61d63f9262e6a8dc4fa790 Reviewed-on: https://webrtc-review.googlesource.com/57142 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22340}
2018-03-07 10:32:03 +01:00
sources = [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/api/peerconnection/RTCMediaSource+Private.h",
"objc/api/peerconnection/RTCMediaSource.h",
"objc/api/peerconnection/RTCMediaSource.mm",
Fix native api in preparation for native_api example. Add native api conversions for video frames and video renderer. This also requires some changes to sdk/BUILD to avoid cyclic dependencies. Bug: webrtc:8832 Change-Id: Ibf21e63bdcae195dcb61d63f9262e6a8dc4fa790 Reviewed-on: https://webrtc-review.googlesource.com/57142 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22340}
2018-03-07 10:32:03 +01:00
]
Broadcast extension for AppRTCMobile on iOS This provides an environment for testing out using WebRTC from an iOS extension. It implements a ReplayKit broadcast extension for live streaming games and screensharing. The extension is only supported on iOS 11+ and is guarded by a build flag. Bug: webrtc:9335 Change-Id: Id218d6c73ef7599f5953c5a1e0e62e5d0dc4f10b Reviewed-on: https://webrtc-review.googlesource.com/80000 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23504}
2018-06-04 10:24:37 +02:00
configs += [
"..:common_objc",
":used_from_extension",
]
Fix native api in preparation for native_api example. Add native api conversions for video frames and video renderer. This also requires some changes to sdk/BUILD to avoid cyclic dependencies. Bug: webrtc:8832 Change-Id: Ibf21e63bdcae195dcb61d63f9262e6a8dc4fa790 Reviewed-on: https://webrtc-review.googlesource.com/57142 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22340}
2018-03-07 10:32:03 +01:00
public_configs = [ ":common_config_objc" ]
deps = [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
":base_objc",
New build target api:media_interface Bug: webrtc:8733 Change-Id: I84bbefb1a5ef8e592db29b79499d60ac80c23464 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153180 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Steve Anton <steveanton@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29234}
2019-09-17 14:30:41 +02:00
"../api:media_stream_interface",
Fix native api in preparation for native_api example. Add native api conversions for video frames and video renderer. This also requires some changes to sdk/BUILD to avoid cyclic dependencies. Bug: webrtc:8832 Change-Id: Ibf21e63bdcae195dcb61d63f9262e6a8dc4fa790 Reviewed-on: https://webrtc-review.googlesource.com/57142 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22340}
2018-03-07 10:32:03 +01:00
"../rtc_base:checks",
]
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("base_native_additions_objc") {
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
sources = [
"objc/api/peerconnection/RTCEncodedImage+Private.h",
"objc/api/peerconnection/RTCEncodedImage+Private.mm",
"objc/api/peerconnection/RTCVideoCodecInfo+Private.h",
"objc/api/peerconnection/RTCVideoCodecInfo+Private.mm",
"objc/api/peerconnection/RTCVideoEncoderSettings+Private.h",
"objc/api/peerconnection/RTCVideoEncoderSettings+Private.mm",
]
configs += [ "..:common_objc" ]
public_configs = [ ":common_config_objc" ]
deps = [
":base_objc",
":helpers_objc",
Move EncodedImage class to api/video/ Bug: webrtc:9378 Change-Id: I8fb3b19cad0ad428abc6c8e6b507180d461882ba Reviewed-on: https://webrtc-review.googlesource.com/c/104002 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Peter Slatala <psla@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25033}
2018-10-05 14:17:58 +02:00
"../api/video:encoded_image",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"../api/video_codecs:video_codecs_api",
"../modules/video_coding:video_codec_interface",
Cleanup BUILD.gn files from imports like foo:foo Repalce all occurrences of foo:foo in deps with just foo in BUILD.gn files. Done with Sublime regex replace. Find: \b([-a-zA-Z0-9_]+):+\1\b In: *.gn Replace with: \1 Bug: None Change-Id: I40aba1b14face687a595b852ffe443cb20197611 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127899 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27225}
2019-03-21 13:35:10 +01:00
"../rtc_base",
Remove //rtc_base:refcount from public deps Bug: webrtc:8603 Change-Id: Ib27a107ae809df739492846175f0e9c4af40d21a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257910 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Florent Castelli <orphis@webrtc.org> Reviewed-by: Florent Castelli <orphis@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36447}
2022-04-05 02:54:12 +02:00
"../rtc_base:refcount",
Remove //rtc_base:safe_conversions from public deps Bug: webrtc:8603 Change-Id: I285ac30975039f8fe9882d1673cc8e4a615c8618 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257912 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Florent Castelli <orphis@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36452}
2022-04-04 17:04:37 +02:00
"../rtc_base:safe_conversions",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
]
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("peerconnectionfactory_base_objc") {
GN hack to tag targets as poisonous (and use it with audio codecs) Only specially taggged targets may transitively depend on poisonous targets. We first apply it to audio codecs. This makes it much clearer exactly what parts of the code still have dependencies on the audio codecs (and we want to eventually get rid of pretty much all of them). Bug: webrtc:8396, webrtc:9121 Change-Id: Iba5c2e806c702b5cfe881022674705f647896d43 Reviewed-on: https://webrtc-review.googlesource.com/69520 Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22979}
2018-04-22 19:55:00 +02:00
visibility = [ "*" ]
Poison default task queue factory Users of webrtc generally should be able to choose own task queue implementation. Poison avoids accidental dependency of a low level component on the default implementation Android and ios apis are still de-facto forced to use the default implementation. Bug: webrtc:10284 Change-Id: I67ecf2317f43ee32b0c9e8a6e69f1e0987cf1914 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144786 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28524}
2019-07-10 12:44:43 +02:00
allow_poison = [
"audio_codecs", # TODO(bugs.webrtc.org/8396): Remove.
"default_task_queue",
]
Modify global variables to not call the destructor on exit. In logging.cc, use the pointer of the static variable so that it doesn't need a global constructor/exit time destructor. In RTCFieldTrials.mm, store the field trial string as a char pointer instead of a std::unique_ptr to ensure that it is never freed. LSAN will be unhappy with this fix, but WebRTC itself hasn't been tested with LSAN enabled, and any code changed in this CL does not build with build_with_chromium=true, so it shouldn't be a problem. Bug: webrtc:9693, webrtc:11665 Change-Id: Ia28e3534170e0817b815717f6efe862f7b51ef62 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/237320 Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Artem Titov <titovartem@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Byoungchan Lee <daniel.l@hpcnt.com> Cr-Commit-Position: refs/heads/main@{#35391}
2021-11-19 19:03:49 +09:00
configs += [ "..:no_global_constructors" ]
Support building WebRTC without audio and video for IOS. Reorganized the targets in webrtc/sdk/BUILD.gn so that the applications which use WebRTC DataChannel only can depend on the "peerconnection_factory_no_media" instead of "rtc_sdk_objc" to reduce the binary size. Provided a no-media implementation of RTCPeerConnectionFactory using the macro "HAVE_NO_MEDIA". BUG=webrtc:7613 Review-Url: https://codereview.webrtc.org/2944643002 Cr-Commit-Position: refs/heads/master@{#18819}
2017-06-28 14:05:44 -07:00
sources = [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/api/peerconnection/RTCAudioSource+Private.h",
"objc/api/peerconnection/RTCAudioSource.h",
"objc/api/peerconnection/RTCAudioSource.mm",
"objc/api/peerconnection/RTCAudioTrack+Private.h",
"objc/api/peerconnection/RTCAudioTrack.h",
"objc/api/peerconnection/RTCAudioTrack.mm",
"objc/api/peerconnection/RTCCertificate.h",
"objc/api/peerconnection/RTCCertificate.mm",
"objc/api/peerconnection/RTCConfiguration+Native.h",
"objc/api/peerconnection/RTCConfiguration+Private.h",
"objc/api/peerconnection/RTCConfiguration.h",
"objc/api/peerconnection/RTCConfiguration.mm",
Promotoing webrtc::CryptoOptions to RTCConfiguration. With the expanding use cases for webrtc::CryptoOptions it makes more sense for it to be be available per peer connection instead of only as a factory option. To support backwards compatability for now this code will support the factory method of setting crypto options by default. However it will completely overwrite these settings if an RTCConfiguration.crypto_options is provided. Got LGTM offline from Sami, adding him to TBR if he has any further comments. TBR=sakal@webrtc.org Bug: webrtc:9891 Change-Id: I86914cab69284ad82afd7285fd84ec5f4f2c4986 Reviewed-on: https://webrtc-review.googlesource.com/c/107029 Commit-Queue: Benjamin Wright <benwright@webrtc.org> Reviewed-by: Seth Hampson <shampson@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25375}
2018-10-25 10:16:44 -07:00
"objc/api/peerconnection/RTCCryptoOptions.h",
"objc/api/peerconnection/RTCCryptoOptions.mm",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/api/peerconnection/RTCDataChannel+Private.h",
"objc/api/peerconnection/RTCDataChannel.h",
"objc/api/peerconnection/RTCDataChannel.mm",
"objc/api/peerconnection/RTCDataChannelConfiguration+Private.h",
"objc/api/peerconnection/RTCDataChannelConfiguration.h",
"objc/api/peerconnection/RTCDataChannelConfiguration.mm",
"objc/api/peerconnection/RTCDtmfSender+Private.h",
"objc/api/peerconnection/RTCDtmfSender.h",
"objc/api/peerconnection/RTCDtmfSender.mm",
"objc/api/peerconnection/RTCFieldTrials.h",
"objc/api/peerconnection/RTCFieldTrials.mm",
"objc/api/peerconnection/RTCIceCandidate+Private.h",
"objc/api/peerconnection/RTCIceCandidate.h",
"objc/api/peerconnection/RTCIceCandidate.mm",
Implement JNI and objc implementation for icecandidateerror event This CL adds the callback on ICE Candidate Error to the Android and the iOS SDKs. Spec: https://www.w3.org/TR/webrtc/#dom-rtcpeerconnection-onicecandidateerror Bug: webrtc:13446 Change-Id: I6e511aaa80f1aa8f4310d8518d1144d97470cd7e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239460 Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Henrik Andreassson <henrika@webrtc.org> Cr-Commit-Position: refs/heads/main@{#35531}
2021-11-30 19:01:43 +09:00
"objc/api/peerconnection/RTCIceCandidateErrorEvent+Private.h",
"objc/api/peerconnection/RTCIceCandidateErrorEvent.h",
"objc/api/peerconnection/RTCIceCandidateErrorEvent.mm",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/api/peerconnection/RTCIceServer+Private.h",
"objc/api/peerconnection/RTCIceServer.h",
"objc/api/peerconnection/RTCIceServer.mm",
"objc/api/peerconnection/RTCLegacyStatsReport+Private.h",
"objc/api/peerconnection/RTCLegacyStatsReport.h",
"objc/api/peerconnection/RTCLegacyStatsReport.mm",
"objc/api/peerconnection/RTCMediaStream+Private.h",
"objc/api/peerconnection/RTCMediaStream.h",
"objc/api/peerconnection/RTCMediaStream.mm",
"objc/api/peerconnection/RTCMediaStreamTrack+Private.h",
"objc/api/peerconnection/RTCMediaStreamTrack.h",
"objc/api/peerconnection/RTCMediaStreamTrack.mm",
"objc/api/peerconnection/RTCMetrics.h",
"objc/api/peerconnection/RTCMetrics.mm",
"objc/api/peerconnection/RTCMetricsSampleInfo+Private.h",
"objc/api/peerconnection/RTCMetricsSampleInfo.h",
"objc/api/peerconnection/RTCMetricsSampleInfo.mm",
"objc/api/peerconnection/RTCPeerConnection+DataChannel.mm",
"objc/api/peerconnection/RTCPeerConnection+Private.h",
"objc/api/peerconnection/RTCPeerConnection+Stats.mm",
"objc/api/peerconnection/RTCPeerConnection.h",
"objc/api/peerconnection/RTCPeerConnection.mm",
"objc/api/peerconnection/RTCPeerConnectionFactory+Native.h",
"objc/api/peerconnection/RTCPeerConnectionFactory+Private.h",
"objc/api/peerconnection/RTCPeerConnectionFactory.h",
"objc/api/peerconnection/RTCPeerConnectionFactory.mm",
"objc/api/peerconnection/RTCPeerConnectionFactoryBuilder+DefaultComponents.h",
"objc/api/peerconnection/RTCPeerConnectionFactoryBuilder+DefaultComponents.mm",
"objc/api/peerconnection/RTCPeerConnectionFactoryBuilder.h",
"objc/api/peerconnection/RTCPeerConnectionFactoryBuilder.mm",
"objc/api/peerconnection/RTCPeerConnectionFactoryOptions+Private.h",
"objc/api/peerconnection/RTCPeerConnectionFactoryOptions.h",
"objc/api/peerconnection/RTCPeerConnectionFactoryOptions.mm",
"objc/api/peerconnection/RTCRtcpParameters+Private.h",
"objc/api/peerconnection/RTCRtcpParameters.h",
"objc/api/peerconnection/RTCRtcpParameters.mm",
"objc/api/peerconnection/RTCRtpCodecParameters+Private.h",
"objc/api/peerconnection/RTCRtpCodecParameters.h",
"objc/api/peerconnection/RTCRtpCodecParameters.mm",
"objc/api/peerconnection/RTCRtpEncodingParameters+Private.h",
"objc/api/peerconnection/RTCRtpEncodingParameters.h",
"objc/api/peerconnection/RTCRtpEncodingParameters.mm",
"objc/api/peerconnection/RTCRtpHeaderExtension+Private.h",
"objc/api/peerconnection/RTCRtpHeaderExtension.h",
"objc/api/peerconnection/RTCRtpHeaderExtension.mm",
"objc/api/peerconnection/RTCRtpParameters+Private.h",
"objc/api/peerconnection/RTCRtpParameters.h",
"objc/api/peerconnection/RTCRtpParameters.mm",
Add FrameEncryptor/FrameDecryptor support to Objective C API for WebRTC. This change adds bindings so that native FrameEncryptor and native FrameDecryptor objects can be set on the objective C RTCRtpSender and RTCRtpReceiver objects. Bug: webrtc:9681 Change-Id: Iec4006ea020d6ab6adcc0ad068dcd8fb2738063d Reviewed-on: https://webrtc-review.googlesource.com/c/103020 Commit-Queue: Benjamin Wright <benwright@webrtc.org> Reviewed-by: Steve Anton <steveanton@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24936}
2018-10-02 10:20:58 -07:00
"objc/api/peerconnection/RTCRtpReceiver+Native.h",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/api/peerconnection/RTCRtpReceiver+Private.h",
"objc/api/peerconnection/RTCRtpReceiver.h",
"objc/api/peerconnection/RTCRtpReceiver.mm",
Add FrameEncryptor/FrameDecryptor support to Objective C API for WebRTC. This change adds bindings so that native FrameEncryptor and native FrameDecryptor objects can be set on the objective C RTCRtpSender and RTCRtpReceiver objects. Bug: webrtc:9681 Change-Id: Iec4006ea020d6ab6adcc0ad068dcd8fb2738063d Reviewed-on: https://webrtc-review.googlesource.com/c/103020 Commit-Queue: Benjamin Wright <benwright@webrtc.org> Reviewed-by: Steve Anton <steveanton@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24936}
2018-10-02 10:20:58 -07:00
"objc/api/peerconnection/RTCRtpSender+Native.h",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/api/peerconnection/RTCRtpSender+Private.h",
"objc/api/peerconnection/RTCRtpSender.h",
"objc/api/peerconnection/RTCRtpSender.mm",
"objc/api/peerconnection/RTCRtpTransceiver+Private.h",
"objc/api/peerconnection/RTCRtpTransceiver.h",
"objc/api/peerconnection/RTCRtpTransceiver.mm",
"objc/api/peerconnection/RTCSSLAdapter.h",
"objc/api/peerconnection/RTCSSLAdapter.mm",
"objc/api/peerconnection/RTCSessionDescription+Private.h",
"objc/api/peerconnection/RTCSessionDescription.h",
"objc/api/peerconnection/RTCSessionDescription.mm",
Adding entry point for the v2 stats API. Bug: webrtc:10345 Change-Id: I9271376ff60f5fc6e9014b7dd9a8a5682bdbf452 Reviewed-on: https://webrtc-review.googlesource.com/c/123780 Commit-Queue: Peter Hanspers <peterhanspers@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26801}
2019-02-21 17:27:09 +01:00
"objc/api/peerconnection/RTCStatisticsReport+Private.h",
"objc/api/peerconnection/RTCStatisticsReport.h",
"objc/api/peerconnection/RTCStatisticsReport.mm",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/api/peerconnection/RTCTracing.h",
"objc/api/peerconnection/RTCTracing.mm",
"objc/api/peerconnection/RTCVideoTrack+Private.h",
"objc/api/peerconnection/RTCVideoTrack.h",
"objc/api/peerconnection/RTCVideoTrack.mm",
Remove unsupported mac framework target. We don't have a use case for it and have no reason to support it. BUG=webrtc:6706 Review-Url: https://codereview.webrtc.org/2543723004 Cr-Commit-Position: refs/heads/master@{#15428}
2016-12-05 11:27:30 -08:00
]
[GN] Add rtc_sdk_framework_objc target to GN The build artifacts don't look completely identical to the ones generated by the GYP targets, but manual review shows the same symbols are exported. On iOS, the version generated by the GN follows convention, including a "Headers" directory, and the .modulemap file. I think this is preferred over the gyp version. BUG=webrtc:6320 NOTRY=True TESTED=Run AppRTCDemo on iOS + Mac and verified with nm that they export the same symbols. Review-Url: https://codereview.webrtc.org/2340633003 Cr-Commit-Position: refs/heads/master@{#14228}
2016-09-15 04:30:18 -07:00
Broadcast extension for AppRTCMobile on iOS This provides an environment for testing out using WebRTC from an iOS extension. It implements a ReplayKit broadcast extension for live streaming games and screensharing. The extension is only supported on iOS 11+ and is guarded by a build flag. Bug: webrtc:9335 Change-Id: Id218d6c73ef7599f5953c5a1e0e62e5d0dc4f10b Reviewed-on: https://webrtc-review.googlesource.com/80000 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23504}
2018-06-04 10:24:37 +02:00
configs += [
"..:common_objc",
":used_from_extension",
]
Rename all objc targets to be suffixed for consistency BUG=webrtc:6412 Review-Url: https://codereview.webrtc.org/3001023003 Cr-Commit-Position: refs/heads/master@{#19489}
2017-08-24 05:43:45 -07:00
public_configs = [ ":common_config_objc" ]
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
[GN] Add rtc_sdk_framework_objc target to GN The build artifacts don't look completely identical to the ones generated by the GYP targets, but manual review shows the same symbols are exported. On iOS, the version generated by the GN follows convention, including a "Headers" directory, and the .modulemap file. I think this is preferred over the gyp version. BUG=webrtc:6320 NOTRY=True TESTED=Run AppRTCDemo on iOS + Mac and verified with nm that they export the same symbols. Review-Url: https://codereview.webrtc.org/2340633003 Cr-Commit-Position: refs/heads/master@{#14228}
2016-09-15 04:30:18 -07:00
deps = [
ObjC ADM: added RTCAudioDevice protocol [2/N] Bug: webrtc:14193 Change-Id: I616c4d338a0bbc57c22e1f1dcc4454512aecd967 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268195 Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Commit-Queue: Yury Yarashevich <yura.yaroshevich@gmail.com> Cr-Commit-Position: refs/heads/main@{#37925}
2022-08-29 12:22:35 +02:00
":audio_device_api_objc",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
":base_native_additions_objc",
":base_objc",
":file_logger_objc",
":helpers_objc",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
":mediaconstraints_objc",
Fix native api in preparation for native_api example. Add native api conversions for video frames and video renderer. This also requires some changes to sdk/BUILD to avoid cyclic dependencies. Bug: webrtc:8832 Change-Id: Ibf21e63bdcae195dcb61d63f9262e6a8dc4fa790 Reviewed-on: https://webrtc-review.googlesource.com/57142 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22340}
2018-03-07 10:32:03 +01:00
":mediasource_objc",
Create experimental Obj-C++ API. This can be used to wrap Objective-C components in C++ classes, so users can use the WebRTC C++ API directly together with the iOS specific components provided by our SDK. Bug: webrtc:8832 Change-Id: I6d34f7ec62d51df8d3a5340a2e17d30ae73e13e8 Reviewed-on: https://webrtc-review.googlesource.com/46162 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21850}
2018-02-01 15:47:05 +01:00
":native_api",
":native_video",
ObjC ADM: added RTCAudioDevice protocol [2/N] Bug: webrtc:14193 Change-Id: I616c4d338a0bbc57c22e1f1dcc4454512aecd967 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268195 Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Commit-Queue: Yury Yarashevich <yura.yaroshevich@gmail.com> Cr-Commit-Position: refs/heads/main@{#37925}
2022-08-29 12:22:35 +02:00
":objc_audio_device_module",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
":videoframebuffer_objc",
Fix native api in preparation for native_api example. Add native api conversions for video frames and video renderer. This also requires some changes to sdk/BUILD to avoid cyclic dependencies. Bug: webrtc:8832 Change-Id: Ibf21e63bdcae195dcb61d63f9262e6a8dc4fa790 Reviewed-on: https://webrtc-review.googlesource.com/57142 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22340}
2018-03-07 10:32:03 +01:00
":videorendereradapter_objc",
":videosource_objc",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
":videotoolbox_objc",
Stop using public_deps in pc/. TBR=phoglund@webrtc.org Bug: webrtc:8603 Change-Id: If18e5a4d212392bbd9b4e1f9c2f00ee79a2ab348 No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/29864 Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21139}
2017-12-06 11:23:19 +01:00
"../api:libjingle_peerconnection_api",
New build target api:media_interface Bug: webrtc:8733 Change-Id: I84bbefb1a5ef8e592db29b79499d60ac80c23464 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153180 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Steve Anton <steveanton@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29234}
2019-09-17 14:30:41 +02:00
"../api:media_stream_interface",
Delete deprecated StartRtcEventLog override with PlatformFile Bug: webrtc:6463 Change-Id: I57c2372a232d72b054d8e3e4f423e11b3fb22430 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134460 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Reviewed-by: Elad Alon <eladalon@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28131}
2019-05-13 12:27:23 +02:00
"../api:rtc_event_log_output_file",
Adding entry point for the v2 stats API. Bug: webrtc:10345 Change-Id: I9271376ff60f5fc6e9014b7dd9a8a5682bdbf452 Reviewed-on: https://webrtc-review.googlesource.com/c/123780 Commit-Queue: Peter Hanspers <peterhanspers@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26801}
2019-02-21 17:27:09 +01:00
"../api:rtc_stats_api",
New target for api/rtp_parameters.h and api/media_types.h. The new target does not depend on libjingle_peerconnection_api, and to do this, the named "audio" and "video" string literals had to be moved from media_stream_interface.cc to media_types.cc. In this cl, the dependency on libjingle_peerconnection_api can be dropped from a few targets. No-Presubmit: True Bug: webrtc:8733 Change-Id: Icc675280d5c3c537f2255a9389ff18a482049921 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/53861 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28998}
2019-08-26 10:45:28 +02:00
"../api:rtp_parameters",
Remove rtc_base/scoped_ref_ptr.h. The type rtc::scoped_refptr<T> is now part of api/. Please include it from api/scoped_refptr.h. More info: See: https://groups.google.com/forum/#!topic/discuss-webrtc/Mme2MSz4z4o. Bug: webrtc:9887, webrtc:8205 No-Try: True Change-Id: Ic6c7c81e226e59f12f7933e472f573ae097b55bf Reviewed-on: https://webrtc-review.googlesource.com/c/119041 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26414}
2019-01-25 20:26:48 +01:00
"../api:scoped_refptr",
Create a peer connection factory builder Similar to the builder on android: https://cs.chromium.org/chromium/src/third_party/webrtc/sdk/android/api/org/webrtc/PeerConnectionFactory.java?rcl=b90e63c620877712e45ee320cfa25cb825bf5373&l=134 1. A builder will allow us to choose what module factories to provide and use default for the others. 2. A helper category is added to provide helpers functions for creating common builders. Bug: None Change-Id: I5889bdd7dc2a2aeded62ef5f2c2381edd07089b3 Reviewed-on: https://webrtc-review.googlesource.com/83280 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23696}
2018-06-20 16:18:59 -07:00
"../api/audio_codecs:audio_codecs_api",
AudioCodingModule::Create(): Require caller to supply an AudioDecoderFactory So that we don't have to be capable of creating one ourselves, which requires a dependency on the audio decoders. BUG=webrtc:5801, webrtc:8396 Change-Id: I80749ec3b86cba73994307046d05964f59167d44 Reviewed-on: https://webrtc-review.googlesource.com/18440 Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Oskar Sundbom <ossu@webrtc.org> Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22774}
2018-04-06 10:06:42 +02:00
"../api/audio_codecs:builtin_audio_decoder_factory",
Create a peer connection factory builder Similar to the builder on android: https://cs.chromium.org/chromium/src/third_party/webrtc/sdk/android/api/org/webrtc/PeerConnectionFactory.java?rcl=b90e63c620877712e45ee320cfa25cb825bf5373&l=134 1. A builder will allow us to choose what module factories to provide and use default for the others. 2. A helper category is added to provide helpers functions for creating common builders. Bug: None Change-Id: I5889bdd7dc2a2aeded62ef5f2c2381edd07089b3 Reviewed-on: https://webrtc-review.googlesource.com/83280 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23696}
2018-06-20 16:18:59 -07:00
"../api/audio_codecs:builtin_audio_encoder_factory",
Introduce api/crypto/BUILD.gn. No-Try: True Bug: webrtc:8733 Change-Id: I8679735be1e5069e371a9f1115a54e897e09964b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/152622 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29186}
2019-09-13 14:42:15 +02:00
"../api/crypto:frame_decryptor_interface",
"../api/crypto:frame_encryptor_interface",
Delete RtcEventLogFactory factory as now unused Bug: webrtc:10206, webrtc:10284 Change-Id: I34fa780f566b52e375ec625bf0d5d02c505d9912 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/143782 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28400}
2019-06-26 15:49:47 +02:00
"../api/rtc_event_log:rtc_event_log_factory",
Use single argument PeerConnectionFactory factory in objc code Bug: webrtc:10284 Change-Id: If656af94636731d1caa208db78e460740edbf83c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/137422 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28002}
2019-05-17 13:20:14 +02:00
"../api/task_queue:default_task_queue_factory",
Reland: Wires up WebrtcKeyValueBasedConfig in media engines. This is a reland of https://webrtc-review.googlesource.com/c/src/+/174261 Patchset 1 contains the old cl (plus a merge conflict fix). Later patchets are bufixes: A PeerConnection can be created without a Call instance (in the case of DataChannel only), so we can't always use that to fetch the current trials. Old CL descritpion: This replaces field_trial:: -based functions from system_wrappers. Field trials are still used as fallback, but injectable trials are now possible. // Since re-land is otherwise unchanged, setting previous reviewers as TBR TBR=kthelgason@webrtc.org,mbonadei@webrtc.org,stefan@webrtc.org,srte@webrtc.org Bug: webrtc:11926 Change-Id: I57a9e8c3454f226f77fb93215bcac83da65034b0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185003 Commit-Queue: Erik Språng <sprang@webrtc.org> Reviewed-by: Per Kjellander <perkj@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32163}
2020-09-22 11:36:35 +02:00
"../api/transport:field_trial_based_config",
New file api/video/BUILD.gn Build targets involving files under api/video/ are moved into this file, from api/BUILD.gn. In addition, drop "_api" part of target names, and move the header file api/videosinkinterface.h to api/video/video_sink_interface.h. Bug: webrtc:9253 Change-Id: I2896d3f063db8dff902bc29738578395b2fcc155 Reviewed-on: https://webrtc-review.googlesource.com/75500 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23207}
2018-05-11 11:15:30 +02:00
"../api/video:video_frame",
Prepare for splitting the api/video:video_frames build rule. This change is part of a change to break the dependency between "api:rtp_headers" and "api/video:video_frame". It does so by first creating an empty "api/video:video_rtp_headers" build rule so that downstream projects can be fixed before moving the source files. Bug: webrtc:10668 Change-Id: I81aa6edfef3639b457a40aa93de048e62cbfd8ef Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140291 Commit-Queue: Chen Xing <chxg@google.com> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28209}
2019-06-10 12:59:38 +02:00
"../api/video:video_rtp_headers",
Injectable software video codecs in Obj-C. When injecting video codec factories in the Obj-C SDK, use the new peer connection API that uses webrtc::Video{De,En}CoderFactory classes and does not automatically add internal software codecs. Instead the injected factory can support internal VP8 and VP9 codecs through the included Obj-C classes RTCVideo{De,En}coderVP{8,9}. When not explicitly injecting any video codec factory, the old code path is still used and injects only H264 as an external codec and the internal codec factory is used. Bug: webrtc:7925 Change-Id: I657d30dfde71da9c0be341e213ab9f97a04caa58 Reviewed-on: https://webrtc-review.googlesource.com/3620 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20175}
2017-10-05 16:55:38 +02:00
"../api/video_codecs:video_codecs_api",
Revert "Revert "Revert "Revert "Support more formats in RTCVideoFrame"""" This reverts commit 1cfeb435427a2fa677a495e34c882096efc193d0. Reason for revert: Fix unit test Original change's description: > Revert "Revert "Revert "Support more formats in RTCVideoFrame""" > > This reverts commit 7583390d1a3a7c4e9a77da0d77250abac0c34d1d. > > Reason for revert: Breaks unit tests > > Original change's description: > > Revert "Revert "Support more formats in RTCVideoFrame"" > > > > This reverts commit 0789dab2cbd1617e94d7300e375163d42345f3d4. > > > > Reason for revert: Include obc_corevideoframebuffer target > > > > Original change's description: > > > Revert "Support more formats in RTCVideoFrame" > > > > > > This reverts commit bd2220a9c496ef2e8567b68d4be9435a110bdc34. > > > > > > Reason for revert: Broke external clients > > > > > > Original change's description: > > > > Support more formats in RTCVideoFrame > > > > > > > > Implement Obj-C version of webrtc::VideoFrameBuffer and use that in > > > > RTCVideoFrame. > > > > > > > > Bug: webrtc:7785 > > > > Change-Id: I49f42bcf451dd6769b3a79a65fe7b400dce22677 > > > > Reviewed-on: https://chromium-review.googlesource.com/536773 > > > > Commit-Queue: Anders Carlsson <andersc@webrtc.org> > > > > Reviewed-by: Magnus Jedvert <magjed@webrtc.org> > > > > Cr-Commit-Position: refs/heads/master@{#18691} > > > > > > TBR=magjed@webrtc.org,andersc@webrtc.org > > > > > > Change-Id: Id765dd9543ed0613a6b2de108b268c3501025fcd > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: webrtc:7785 > > > Reviewed-on: https://chromium-review.googlesource.com/542837 > > > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > > > Commit-Queue: Anders Carlsson <andersc@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#18697} > > > > TBR=magjed@webrtc.org,andersc@webrtc.org > > > > Change-Id: I1ef5313b4a6c56eb8c7fd02d95db62c4e3c00255 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: webrtc:7785 > > Reviewed-on: https://chromium-review.googlesource.com/542838 > > Commit-Queue: Anders Carlsson <andersc@webrtc.org> > > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#18716} > > TBR=magjed@webrtc.org,andersc@webrtc.org > > Change-Id: Id12f33698eb02041607cb9a5c54f37f01bfac5b1 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:7785 > Reviewed-on: https://chromium-review.googlesource.com/544840 > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > Commit-Queue: Anders Carlsson <andersc@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#18718} TBR=magjed@webrtc.org,andersc@webrtc.org Change-Id: I184303ecba8db91ef7de709f982a295a2efe92eb Bug: webrtc:7785 Reviewed-on: https://chromium-review.googlesource.com/544841 Commit-Queue: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#18731}
2017-06-22 15:26:30 +02:00
"../common_video",
Remove HAVE_NO_MEDIA from Obj-C API. This build configuration is not really supported/tested. Bug: b/36882554 Change-Id: I8b5b2c93b1cf5e4d6627183c5449437e4589a5ea Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266741 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37322}
2022-06-24 10:00:49 +02:00
"../media:rtc_audio_video",
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
"../media:rtc_media_base",
Create a peer connection factory builder Similar to the builder on android: https://cs.chromium.org/chromium/src/third_party/webrtc/sdk/android/api/org/webrtc/PeerConnectionFactory.java?rcl=b90e63c620877712e45ee320cfa25cb825bf5373&l=134 1. A builder will allow us to choose what module factories to provide and use default for the others. 2. A helper category is added to provide helpers functions for creating common builders. Bug: None Change-Id: I5889bdd7dc2a2aeded62ef5f2c2381edd07089b3 Reviewed-on: https://webrtc-review.googlesource.com/83280 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23696}
2018-06-20 16:18:59 -07:00
"../modules/audio_device:audio_device_api",
Cleanup BUILD.gn files from imports like foo:foo Repalce all occurrences of foo:foo in deps with just foo in BUILD.gn files. Done with Sublime regex replace. Find: \b([-a-zA-Z0-9_]+):+\1\b In: *.gn Replace with: \1 Bug: None Change-Id: I40aba1b14face687a595b852ffe443cb20197611 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127899 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27225}
2019-03-21 13:35:10 +01:00
"../modules/audio_processing",
Reland "Isolating APM API build target: making :api an actual target." This reverts commit 61c6e5643e7ea058e653956980a90e033249c055. Reason for revert: downstream projects prepared for this change Original change's description: > Revert "Isolating APM API build target: making :api an actual target." > > This reverts commit a7f77a7c05b5d26520fd01a773ffb2c8b15b60ff. > > Reason for revert: breaking downstream > > Original change's description: > > Isolating APM API build target: making :api an actual target. > > > > This CL is part of a refactoring work to unblock other CLs > > that would generate a circular dependency when including > > modules/audio_processing. It will also allow to easily move > > the APM interface part under //api. > > > > More in detail, this change moves the APM interface files from > > the build target modules/audio_processing to > > modules/audio_processing:api. It also adds :api as dependency > > where needed. > > > > Bug: webrtc:9535 > > Change-Id: I72829e22d08ba4d75985f0421e6e8bf0216ebecd > > Reviewed-on: https://webrtc-review.googlesource.com/c/109501 > > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > > Reviewed-by: Kári Helgason <kthelgason@webrtc.org> > > Reviewed-by: Niels Moller <nisse@webrtc.org> > > Reviewed-by: Sam Zackrisson <saza@webrtc.org> > > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#25539} > > TBR=saza@webrtc.org,alessiob@webrtc.org,kwiberg@webrtc.org,nisse@webrtc.org,kthelgason@webrtc.org > > Change-Id: I974c6237311e7c06970aa62e5f6940f3aa80113d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:9535 > Reviewed-on: https://webrtc-review.googlesource.com/c/109820 > Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#25540} TBR=saza@webrtc.org,alessiob@webrtc.org,kwiberg@webrtc.org,nisse@webrtc.org,kthelgason@webrtc.org Change-Id: Ic8ed4cc3baf43d639ce13cae256c007728c3ad92 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:9535 Reviewed-on: https://webrtc-review.googlesource.com/c/109884 Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25547}
2018-11-07 14:29:54 +00:00
"../modules/audio_processing:api",
Add untracked headers to video_coding. This creates a new target for pure defines and interfaces. I think that makes sense (though include/ makes it harder to see when .cc and .h files should live together). Bug: webrtc:7620 Change-Id: Ifb0f50faf99166202836c0446feed3443eb52c6e Reviewed-on: https://webrtc-review.googlesource.com/34657 Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21516}
2018-01-08 11:05:10 +01:00
"../modules/video_coding:video_codec_interface",
Remove internal dependencies on pc:peerconnection target This CL replaces those references with the smallest set of targets that can satisfy the linker dependencies revealed by building the "all" target. Bug: webrtc:13634 Change-Id: Ia778630b18e1164138c41d245c3c8effed67f8e5 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257282 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36445}
2022-03-31 19:53:50 +00:00
"../pc:peer_connection_factory",
"../pc:webrtc_sdp",
Cleanup BUILD.gn files from imports like foo:foo Repalce all occurrences of foo:foo in deps with just foo in BUILD.gn files. Done with Sublime regex replace. Find: \b([-a-zA-Z0-9_]+):+\1\b In: *.gn Replace with: \1 Bug: None Change-Id: I40aba1b14face687a595b852ffe443cb20197611 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127899 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27225}
2019-03-21 13:35:10 +01:00
"../rtc_base",
Fix circular dependencies between optional, array_view, and rtc_base. This splits things out of rtc_base and makes dependencies explicit. Bug: webrtc:6828 Change-Id: Id521896c3c43595349021c857bec216e429a0c8d Reviewed-on: https://webrtc-review.googlesource.com/32780 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21264}
2017-12-13 16:05:42 +01:00
"../rtc_base:checks",
Move event_tracer out of rtc_base_approved Bug: webrtc:9838 Change-Id: Ic3c424729b5edd3e378c4195afe33ae5c88ad491 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259312 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36637}
2022-04-19 17:47:13 +02:00
"../rtc_base:event_tracer",
Remove //rtc_base:logging from public deps Bug: webrtc:8603 Change-Id: I2704da8618f88032adac7ae9eb2a0f47fce4a836 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257908 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Florent Castelli <orphis@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36443}
2022-04-04 15:06:30 +02:00
"../rtc_base:logging",
Reland "Refactor rtc_base build targets." This is a reland of 69241a93fb14f6527a26d5c94dde879013012d2a Fix: The problem was related to NO_MAIN_THREAD_WRAPPING, which affects https://source.chromium.org/chromium/chromium/src/+/master:third_party/webrtc/rtc_base/thread.cc;l=257-263;drc=7acc2d9fe3a6e3c4d8881d2bdfc9b8968a724cd5. The original CL didn't attach the definition of the macro NO_MAIN_THREAD_WRAPPING when building for Chromium (which doesn't have to be related to //rtc_base anymore but to //rtc_base:threading). Original change's description: > Refactor rtc_base build targets. > > The "//rtc_base:rtc_base" build target has historically been one of the > biggest targets in the WebRTC build. Big targets are the main source of > circular dependencies and non-API types leakage. > > This CL is a step forward into splitting "//rtc_base:rtc_base" into > smaller targets (as originally started in 2018). > > The only non-automated changes are (like re-wiring the build system): > * The creation of //rtc_base/async_resolver.{h,cc} which allows to > break a circular dependency (is has been extracted from > //rtc_base/net_helpers.{h,cc}). > * The creation of //rtc_base/internal/default_socket_server.{h,cc} to > break another circular dependency. > > Bug: webrtc:9987 > Change-Id: I0c8f5e7efe2c8fd8e6bffa0d6dd2dd494cf3df02 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/196903 > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#32941} Bug: webrtc:9987 Change-Id: I7cdf49d2aac8357f1f50f90010bf2c2f62fa19f6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/202021 Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33001}
2021-01-15 10:41:01 +01:00
"../rtc_base:network_constants",
Remove //rtc_base:safe_conversions from public deps Bug: webrtc:8603 Change-Id: I285ac30975039f8fe9882d1673cc8e4a615c8618 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257912 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Florent Castelli <orphis@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36452}
2022-04-04 17:04:37 +02:00
"../rtc_base:safe_conversions",
Adopt absl::string_view in system_wrappers/ Bug: webrtc:13579 Change-Id: Id0e6515c63a3c9aa6d7effef7a2bd8b5ef35af09 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262245 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Ali Tofigh <alito@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Xavier Lepaul‎ <xalep@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36904}
2022-05-13 10:26:58 +02:00
"../rtc_base:stringutils",
Add proxy access to some methods in Obj-C SDK Most calls to C++ PeerConnection and related classes are proxied to internal threads in WebRTC. However, there is no such thing in the Obj-C SDK. It would be nice to proxy methods in the Obj-C SDK as well. RTCMediaStream and RTCVideoTrack have NSMutableArray members, and it can throw NSRangeException when it has race conditions, so that it would be a good starting point. Also, remove some NSAsserts as its condition isn't a fatal error, and it doesn't affect the production already. Bug: None Change-Id: I10b44a9c773d62a5c04c254986733a6b67d51617 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262840 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37283}
2022-06-21 09:19:34 +09:00
"../rtc_base:threading",
Remove //rtc_base:timeutils from public deps Bug: webrtc:8603 Change-Id: Iaca9356d16275a02e8842c783f259131d72ef010 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257914 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Florent Castelli <orphis@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36460}
2022-04-04 17:16:15 +02:00
"../rtc_base:timeutils",
Remove internal dependencies on pc:peerconnection target This CL replaces those references with the smallest set of targets that can satisfy the linker dependencies revealed by building the "all" target. Bug: webrtc:13634 Change-Id: Ia778630b18e1164138c41d245c3c8effed67f8e5 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257282 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36445}
2022-03-31 19:53:50 +00:00
"../stats:rtc_stats",
Remove deprecated field_trial_default and metrics_default. This CL removes some deprecated build targets (and their headers) from system_wrappers: - field_trial_api - field_trial_default - metrics_api - metrics_default It also refreshes all the dependencies on field_trial.h and metrics.h. A nice side effect is that it is finally possible to remove 'nogncheck' from the following files (when it was used with field_trial_default and metrics_default): - sdk/objc/api/peerconnection/RTCMetricsSampleInfo+Private.h - sdk/android/src/jni/pc/peerconnectionfactory.cc - sdk/objc/api/peerconnection/RTCFieldTrials.mm Bug: webrtc:9631 Change-Id: Ib621f41ef8ad0aba4fe1c1d7e749c044afc956c3 No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/100524 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24878}
2018-09-28 08:51:10 +02:00
"../system_wrappers:field_trial",
"../system_wrappers:metrics",
[GN] Add rtc_sdk_framework_objc target to GN The build artifacts don't look completely identical to the ones generated by the GYP targets, but manual review shows the same symbols are exported. On iOS, the version generated by the GN follows convention, including a "Headers" directory, and the .modulemap file. I think this is preferred over the gyp version. BUG=webrtc:6320 NOTRY=True TESTED=Run AppRTCDemo on iOS + Mac and verified with nm that they export the same symbols. Review-Url: https://codereview.webrtc.org/2340633003 Cr-Commit-Position: refs/heads/master@{#14228}
2016-09-15 04:30:18 -07:00
]
Moving iOS Audio Device to sdk. This change forks the existing iOS audio device module and audio device from modules/audio_device/ into sdk/objc/Framework. It also updates RTCPeerConnectionFactory to use the forked implementation. The unit tests are re-implemented as XCTests. (was: https://webrtc-review.googlesource.com/c/src/+/67300) Bug: webrtc:9120 Change-Id: I46c09900246f75ca5285aeb38f7b8b295784ffac Reviewed-on: https://webrtc-review.googlesource.com/76741 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Commit-Queue: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23238}
2018-05-15 10:22:36 +02:00
if (is_ios) {
deps += [ ":native_api_audio_device_module" ]
}
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
}
Reland of GN: Enable ARC for Mac and iOS in rtc_* templates (patchset #1 id:1 of https://codereview.webrtc.org/2827223003/ ) Reason for revert: Relanding after fixing ARC issue. Original issue's description: > Revert of GN: Enable ARC for Mac and iOS in rtc_* templates (patchset #3 id:40001 of https://codereview.webrtc.org/2781713004/ ) > > Reason for revert: > Breaks mac build > > Original issue's description: > > GN: Enable ARC for Mac and iOS in rtc_* templates > > > > Remove all uses of retain/release and NSAutoreleasePool. > > > > This makes transformation to Bazel easier. > > > > This CL subsumes https://codereview.webrtc.org/2778163002 and depends on https://codereview.webrtc.org/2784483002/ > > > > BUG=webrtc:6412 > > > > Review-Url: https://codereview.webrtc.org/2781713004 > > Cr-Commit-Position: refs/heads/master@{#17780} > > Committed: https://chromium.googlesource.com/external/webrtc/+/6bda02b51dc00401d2a0d04be996ed10e5acac47 > > TBR=kjellander@webrtc.org,magjed@webrtc.org,stefan@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6412 > > Review-Url: https://codereview.webrtc.org/2827223003 > Cr-Commit-Position: refs/heads/master@{#17784} > Committed: https://chromium.googlesource.com/external/webrtc/+/7c8786ae8f2d8481f74b0ab16eb91a8101fe51dc TBR=kjellander@webrtc.org,magjed@webrtc.org,stefan@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6412 Review-Url: https://codereview.webrtc.org/2834273002 Cr-Commit-Position: refs/heads/master@{#17836}
2017-04-24 00:57:16 -07:00
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
if (rtc_include_tests) {
Reland "Add file capturer to AppRTCMobile on simulator." This is a reland of 5adcd198752b651f7b7e9199a91f9b873b7d7237 Original change's description: > Add file capturer to AppRTCMobile on simulator. > > To achieve this, the CL does the following > - Adds sample mp4 video > - Refactors the existing RTCFileVideoCapturer to achieve continious > capture and adds tests. > > Bug: webrtc:8406 > Change-Id: Ibc0891176c58ec9053b42e340d2113036e7199ec > Reviewed-on: https://webrtc-review.googlesource.com/12180 > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > Reviewed-by: Magnus Jedvert <magjed@webrtc.org> > Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#20598} Bug: webrtc:8406 Change-Id: I93be89b86e342a9a8195e19ebaf4aef1410d2c20 Reviewed-on: https://webrtc-review.googlesource.com/23200 Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20870}
2017-11-15 13:15:24 +01:00
if (is_ios) {
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("sdk_unittests_sources") {
Add xctest target to migrate sdk/objc/Framework to it. This CL adds all the scaffolding needed to support xctest target in sdk/objc/Framework and adds the target to the bot configuration. The benefits of this are two-fold. 1. We'll separate framework unittests from their current target, `rtc_unittests`, that has many many other tests. This way framework unit tests will have nice, compact, selfcontained target. 2. We'll harvest the power of XCTest (native testing framework) that should hopefully make adding and writing objc tests easier. This CL migrates only one test to prove the setup works. More tests will be migrated in follow up cls. Bug: webrtc:8382 Change-Id: I0b5b9596c2a6d91683d13632323441de1aa461e0 Reviewed-on: https://webrtc-review.googlesource.com/8501 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20289}
2017-10-12 13:46:00 +02:00
testonly = true
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
include_dirs = [ "objc/" ]
Reland "Add file capturer to AppRTCMobile on simulator." This is a reland of 5adcd198752b651f7b7e9199a91f9b873b7d7237 Original change's description: > Add file capturer to AppRTCMobile on simulator. > > To achieve this, the CL does the following > - Adds sample mp4 video > - Refactors the existing RTCFileVideoCapturer to achieve continious > capture and adds tests. > > Bug: webrtc:8406 > Change-Id: Ibc0891176c58ec9053b42e340d2113036e7199ec > Reviewed-on: https://webrtc-review.googlesource.com/12180 > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > Reviewed-by: Magnus Jedvert <magjed@webrtc.org> > Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#20598} Bug: webrtc:8406 Change-Id: I93be89b86e342a9a8195e19ebaf4aef1410d2c20 Reviewed-on: https://webrtc-review.googlesource.com/23200 Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20870}
2017-11-15 13:15:24 +01:00
Add xctest target to migrate sdk/objc/Framework to it. This CL adds all the scaffolding needed to support xctest target in sdk/objc/Framework and adds the target to the bot configuration. The benefits of this are two-fold. 1. We'll separate framework unittests from their current target, `rtc_unittests`, that has many many other tests. This way framework unit tests will have nice, compact, selfcontained target. 2. We'll harvest the power of XCTest (native testing framework) that should hopefully make adding and writing objc tests easier. This CL migrates only one test to prove the setup works. More tests will be migrated in follow up cls. Bug: webrtc:8382 Change-Id: I0b5b9596c2a6d91683d13632323441de1aa461e0 Reviewed-on: https://webrtc-review.googlesource.com/8501 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20289}
2017-10-12 13:46:00 +02:00
sources = [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/unittests/ObjCVideoTrackSource_xctest.mm",
Remove objc tests from rtc_unittests and move tests to sdk_unittests The tests in rtc_unittests_objc are old gtest based tests and The tests in sdk_unittests are XCTest based tests. The objc tests in rtc_unittest are causing problems [1], so I think it's time to combine the two types of objc tests. Renaming the files to match the existing sdk_unittests and removing the use of gtest helper functions (eg, EXPECT_EQ) are planned for follow-up CLs. [1] https://webrtc-review.googlesource.com/c/src/+/261724/9 Bug: webrtc:8382 Change-Id: I9308b35f654c4479c9df72bf7cd7f4032e267eb2 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262380 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36878}
2022-05-13 19:59:49 +09:00
"objc/unittests/RTCAudioSessionTest.mm",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/unittests/RTCCVPixelBuffer_xctest.mm",
"objc/unittests/RTCCallbackLogger_xctest.m",
Remove objc tests from rtc_unittests and move tests to sdk_unittests The tests in rtc_unittests_objc are old gtest based tests and The tests in sdk_unittests are XCTest based tests. The objc tests in rtc_unittest are causing problems [1], so I think it's time to combine the two types of objc tests. Renaming the files to match the existing sdk_unittests and removing the use of gtest helper functions (eg, EXPECT_EQ) are planned for follow-up CLs. [1] https://webrtc-review.googlesource.com/c/src/+/261724/9 Bug: webrtc:8382 Change-Id: I9308b35f654c4479c9df72bf7cd7f4032e267eb2 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262380 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36878}
2022-05-13 19:59:49 +09:00
"objc/unittests/RTCCameraVideoCapturerTests.mm",
"objc/unittests/RTCCertificateTest.mm",
"objc/unittests/RTCConfigurationTest.mm",
"objc/unittests/RTCDataChannelConfigurationTest.mm",
Reland "Update RTCEncodedImage to not use deprecated mutable_data call." This reverts commit 966bcc4bd5cc7aee5963e784ddf0caf668b2d6e6. Reason for revert: Fixing upstream issues. Original change's description: > Revert "Update RTCEncodedImage to not use deprecated mutable_data call." > > This reverts commit 677e62785dd39cbc730edcbb7ef99909dd292b11. > > Reason for revert: > The RTC_DCHECK_EQ(self.buffer.bytes, self.encodedData->data()) line is triggering for every call > > Original change's description: > > Update RTCEncodedImage to not use deprecated mutable_data call. > > > > Bug: webrtc:9378 > > Change-Id: If1e6284e2d11009097c87d15b98a2768a1d71521 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168524 > > Commit-Queue: Kári Helgason <kthelgason@webrtc.org> > > Reviewed-by: Niels Moller <nisse@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#30518} > > TBR=nisse@webrtc.org,kthelgason@webrtc.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: webrtc:9378 > Change-Id: I91b6df1148224785c209a7306ec186a952f5e289 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168620 > Reviewed-by: Zeke Chin <tkchin@webrtc.org> > Commit-Queue: Zeke Chin <tkchin@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#30527} TBR=nisse@webrtc.org,kthelgason@webrtc.org,tkchin@webrtc.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:9378 Change-Id: I1c0e61d8a390a5999f8dbbbda6f094d71f9b0678 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168740 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30588}
2020-02-20 07:34:45 -08:00
"objc/unittests/RTCEncodedImage_xctest.mm",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/unittests/RTCFileVideoCapturer_xctest.mm",
"objc/unittests/RTCH264ProfileLevelId_xctest.m",
Remove objc tests from rtc_unittests and move tests to sdk_unittests The tests in rtc_unittests_objc are old gtest based tests and The tests in sdk_unittests are XCTest based tests. The objc tests in rtc_unittest are causing problems [1], so I think it's time to combine the two types of objc tests. Renaming the files to match the existing sdk_unittests and removing the use of gtest helper functions (eg, EXPECT_EQ) are planned for follow-up CLs. [1] https://webrtc-review.googlesource.com/c/src/+/261724/9 Bug: webrtc:8382 Change-Id: I9308b35f654c4479c9df72bf7cd7f4032e267eb2 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262380 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36878}
2022-05-13 19:59:49 +09:00
"objc/unittests/RTCIceCandidateTest.mm",
"objc/unittests/RTCIceServerTest.mm",
Removing RTC_SUPPORTS_METAL compilation flag. This flag is a holdover from before either macOS or the iOS Simulator supported Metal rendering. Bug: webrtc:12638 Change-Id: Iced21bfac40192f609b65f5ea1dc3393ee1695fb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/222461 Commit-Queue: Jake Bromberg <jakebromberg@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34347}
2021-06-14 13:44:25 -07:00
"objc/unittests/RTCMTLVideoView_xctest.m",
Remove objc tests from rtc_unittests and move tests to sdk_unittests The tests in rtc_unittests_objc are old gtest based tests and The tests in sdk_unittests are XCTest based tests. The objc tests in rtc_unittest are causing problems [1], so I think it's time to combine the two types of objc tests. Renaming the files to match the existing sdk_unittests and removing the use of gtest helper functions (eg, EXPECT_EQ) are planned for follow-up CLs. [1] https://webrtc-review.googlesource.com/c/src/+/261724/9 Bug: webrtc:8382 Change-Id: I9308b35f654c4479c9df72bf7cd7f4032e267eb2 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262380 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36878}
2022-05-13 19:59:49 +09:00
"objc/unittests/RTCMediaConstraintsTest.mm",
Add a missing NULL check before releasing a texture ref. This causes a crash if the NV12 texture cache attempts to upload textures for a frame with a NULL backing CVPixelBufferRef. Bug: webrtc:10175 Change-Id: I6866dcde5ace745cbd95b762254294aa8406c2a5 Reviewed-on: https://webrtc-review.googlesource.com/c/115430 Commit-Queue: Chuck Hays <haysc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26140}
2019-01-04 12:03:31 -08:00
"objc/unittests/RTCNV12TextureCache_xctest.m",
Remove objc tests from rtc_unittests and move tests to sdk_unittests The tests in rtc_unittests_objc are old gtest based tests and The tests in sdk_unittests are XCTest based tests. The objc tests in rtc_unittest are causing problems [1], so I think it's time to combine the two types of objc tests. Renaming the files to match the existing sdk_unittests and removing the use of gtest helper functions (eg, EXPECT_EQ) are planned for follow-up CLs. [1] https://webrtc-review.googlesource.com/c/src/+/261724/9 Bug: webrtc:8382 Change-Id: I9308b35f654c4479c9df72bf7cd7f4032e267eb2 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262380 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36878}
2022-05-13 19:59:49 +09:00
"objc/unittests/RTCPeerConnectionFactoryBuilderTest.mm",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/unittests/RTCPeerConnectionFactory_xctest.m",
Remove objc tests from rtc_unittests and move tests to sdk_unittests The tests in rtc_unittests_objc are old gtest based tests and The tests in sdk_unittests are XCTest based tests. The objc tests in rtc_unittest are causing problems [1], so I think it's time to combine the two types of objc tests. Renaming the files to match the existing sdk_unittests and removing the use of gtest helper functions (eg, EXPECT_EQ) are planned for follow-up CLs. [1] https://webrtc-review.googlesource.com/c/src/+/261724/9 Bug: webrtc:8382 Change-Id: I9308b35f654c4479c9df72bf7cd7f4032e267eb2 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262380 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36878}
2022-05-13 19:59:49 +09:00
"objc/unittests/RTCPeerConnectionTest.mm",
"objc/unittests/RTCSessionDescriptionTest.mm",
"objc/unittests/RTCTracingTest.mm",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/unittests/frame_buffer_helpers.h",
"objc/unittests/frame_buffer_helpers.mm",
Add iOS SDK unit tests for nalu_rewriter Bug: webrtc:9939 Change-Id: I6848786009ee10ffed60743d9e3a2acaf65540c6 Reviewed-on: https://webrtc-review.googlesource.com/c/108440 Reviewed-by: Artem Titarenko <artit@webrtc.org> Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Commit-Queue: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25422}
2018-10-29 18:18:09 +01:00
"objc/unittests/nalu_rewriter_xctest.mm",
Remove objc tests from rtc_unittests and move tests to sdk_unittests The tests in rtc_unittests_objc are old gtest based tests and The tests in sdk_unittests are XCTest based tests. The objc tests in rtc_unittest are causing problems [1], so I think it's time to combine the two types of objc tests. Renaming the files to match the existing sdk_unittests and removing the use of gtest helper functions (eg, EXPECT_EQ) are planned for follow-up CLs. [1] https://webrtc-review.googlesource.com/c/src/+/261724/9 Bug: webrtc:8382 Change-Id: I9308b35f654c4479c9df72bf7cd7f4032e267eb2 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262380 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36878}
2022-05-13 19:59:49 +09:00
"objc/unittests/objc_video_decoder_factory_tests.mm",
"objc/unittests/objc_video_encoder_factory_tests.mm",
"objc/unittests/scoped_cftyperef_tests.mm",
Add xctest target to migrate sdk/objc/Framework to it. This CL adds all the scaffolding needed to support xctest target in sdk/objc/Framework and adds the target to the bot configuration. The benefits of this are two-fold. 1. We'll separate framework unittests from their current target, `rtc_unittests`, that has many many other tests. This way framework unit tests will have nice, compact, selfcontained target. 2. We'll harvest the power of XCTest (native testing framework) that should hopefully make adding and writing objc tests easier. This CL migrates only one test to prove the setup works. More tests will be migrated in follow up cls. Bug: webrtc:8382 Change-Id: I0b5b9596c2a6d91683d13632323441de1aa461e0 Reviewed-on: https://webrtc-review.googlesource.com/8501 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20289}
2017-10-12 13:46:00 +02:00
]
Reland "Add file capturer to AppRTCMobile on simulator." This is a reland of 5adcd198752b651f7b7e9199a91f9b873b7d7237 Original change's description: > Add file capturer to AppRTCMobile on simulator. > > To achieve this, the CL does the following > - Adds sample mp4 video > - Refactors the existing RTCFileVideoCapturer to achieve continious > capture and adds tests. > > Bug: webrtc:8406 > Change-Id: Ibc0891176c58ec9053b42e340d2113036e7199ec > Reviewed-on: https://webrtc-review.googlesource.com/12180 > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > Reviewed-by: Magnus Jedvert <magjed@webrtc.org> > Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#20598} Bug: webrtc:8406 Change-Id: I93be89b86e342a9a8195e19ebaf4aef1410d2c20 Reviewed-on: https://webrtc-review.googlesource.com/23200 Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20870}
2017-11-15 13:15:24 +01:00
Silence OpenGLES deprecation warning. The deprecation warning started to trigger after the iOS deployment target has been updated from 10 to 12 by https://webrtc-review.googlesource.com/c/src/+/224543. This macro was not defined in tests because the relevant bots were excluded from CQ when that happened. Bug: webrtc:12928, webrtc:12937 Change-Id: I6e1891c5080b172cbd74649e0a115b25d6c87d56 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/225020 Reviewed-by: Victor Boivie <boivie@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34417}
2021-07-05 16:47:49 +02:00
# TODO(bugs.webrtc.org/12937): Remove OpenGL deprecation warning
# workaround.
defines = [ "GLES_SILENCE_DEPRECATION" ]
Moving iOS Audio Device to sdk. This change forks the existing iOS audio device module and audio device from modules/audio_device/ into sdk/objc/Framework. It also updates RTCPeerConnectionFactory to use the forked implementation. The unit tests are re-implemented as XCTests. (was: https://webrtc-review.googlesource.com/c/src/+/67300) Bug: webrtc:9120 Change-Id: I46c09900246f75ca5285aeb38f7b8b295784ffac Reviewed-on: https://webrtc-review.googlesource.com/76741 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Commit-Queue: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23238}
2018-05-15 10:22:36 +02:00
# TODO(peterhanspers): Reenable these tests on simulator.
# See bugs.webrtc.org/7812
Remove usage of "use_ios_simulator". This GN variable has been removed by https://chromium-review.googlesource.com/c/chromium/src/+/2476278, in favour of directly using "target_environment". Change-Id: I4cfdea8faf3b4dc1e4568c76058520fe1cd52845 Bug: webrtc:12059 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/189763 Commit-Queue: Lahiru Ginnaliya Gamathige <glahiru@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32448}
2020-10-20 02:43:02 -07:00
if (target_environment != "simulator") {
Moving iOS Audio Device to sdk. This change forks the existing iOS audio device module and audio device from modules/audio_device/ into sdk/objc/Framework. It also updates RTCPeerConnectionFactory to use the forked implementation. The unit tests are re-implemented as XCTests. (was: https://webrtc-review.googlesource.com/c/src/+/67300) Bug: webrtc:9120 Change-Id: I46c09900246f75ca5285aeb38f7b8b295784ffac Reviewed-on: https://webrtc-review.googlesource.com/76741 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Commit-Queue: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23238}
2018-05-15 10:22:36 +02:00
sources += [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/unittests/RTCAudioDeviceModule_xctest.mm",
"objc/unittests/RTCAudioDevice_xctest.mm",
Moving iOS Audio Device to sdk. This change forks the existing iOS audio device module and audio device from modules/audio_device/ into sdk/objc/Framework. It also updates RTCPeerConnectionFactory to use the forked implementation. The unit tests are re-implemented as XCTests. (was: https://webrtc-review.googlesource.com/c/src/+/67300) Bug: webrtc:9120 Change-Id: I46c09900246f75ca5285aeb38f7b8b295784ffac Reviewed-on: https://webrtc-review.googlesource.com/76741 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Commit-Queue: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23238}
2018-05-15 10:22:36 +02:00
]
}
Add xctest target to migrate sdk/objc/Framework to it. This CL adds all the scaffolding needed to support xctest target in sdk/objc/Framework and adds the target to the bot configuration. The benefits of this are two-fold. 1. We'll separate framework unittests from their current target, `rtc_unittests`, that has many many other tests. This way framework unit tests will have nice, compact, selfcontained target. 2. We'll harvest the power of XCTest (native testing framework) that should hopefully make adding and writing objc tests easier. This CL migrates only one test to prove the setup works. More tests will be migrated in follow up cls. Bug: webrtc:8382 Change-Id: I0b5b9596c2a6d91683d13632323441de1aa461e0 Reviewed-on: https://webrtc-review.googlesource.com/8501 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20289}
2017-10-12 13:46:00 +02:00
deps = [
Moving iOS Audio Device to sdk. This change forks the existing iOS audio device module and audio device from modules/audio_device/ into sdk/objc/Framework. It also updates RTCPeerConnectionFactory to use the forked implementation. The unit tests are re-implemented as XCTests. (was: https://webrtc-review.googlesource.com/c/src/+/67300) Bug: webrtc:9120 Change-Id: I46c09900246f75ca5285aeb38f7b8b295784ffac Reviewed-on: https://webrtc-review.googlesource.com/76741 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Commit-Queue: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23238}
2018-05-15 10:22:36 +02:00
":audio_device",
Make RTCAudioSession accessible to Swift. This is done by: 1. removing the <vector> include from RTCAudioSession+Private, 2. creating a audio_session_objc package that excludes the RTCNativeAudioSessionDelegateAdapter class. Bug: webrtc:11237 Change-Id: I36c86542a19e3244456fd164d908563b1435de29 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/163900 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Chuck Hays <haysc@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30177}
2019-12-26 23:01:42 -08:00
":audio_session_objc",
Reland "Update RTCEncodedImage to not use deprecated mutable_data call." This reverts commit 966bcc4bd5cc7aee5963e784ddf0caf668b2d6e6. Reason for revert: Fixing upstream issues. Original change's description: > Revert "Update RTCEncodedImage to not use deprecated mutable_data call." > > This reverts commit 677e62785dd39cbc730edcbb7ef99909dd292b11. > > Reason for revert: > The RTC_DCHECK_EQ(self.buffer.bytes, self.encodedData->data()) line is triggering for every call > > Original change's description: > > Update RTCEncodedImage to not use deprecated mutable_data call. > > > > Bug: webrtc:9378 > > Change-Id: If1e6284e2d11009097c87d15b98a2768a1d71521 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168524 > > Commit-Queue: Kári Helgason <kthelgason@webrtc.org> > > Reviewed-by: Niels Moller <nisse@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#30518} > > TBR=nisse@webrtc.org,kthelgason@webrtc.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: webrtc:9378 > Change-Id: I91b6df1148224785c209a7306ec186a952f5e289 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168620 > Reviewed-by: Zeke Chin <tkchin@webrtc.org> > Commit-Queue: Zeke Chin <tkchin@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#30527} TBR=nisse@webrtc.org,kthelgason@webrtc.org,tkchin@webrtc.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:9378 Change-Id: I1c0e61d8a390a5999f8dbbbda6f094d71f9b0678 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168740 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30588}
2020-02-20 07:34:45 -08:00
":base_native_additions_objc",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
":base_objc",
":callback_logger_objc",
Generate iOS framework umbrella header. Instead of keeping the umbrella header in sync manually and needing ifdefs to make it include the correct headers depending on platform, generate it based on the headers we include in the framework target. Can also be used to only include internal software codec headers when compiling with support for them. Bug: webrtc:7925 Change-Id: I63f97af1efc8710cfd62d527fcb343fed05daae2 Reviewed-on: https://webrtc-review.googlesource.com/38702 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21613}
2018-01-15 13:31:03 +01:00
":framework_objc",
Remove objc tests from rtc_unittests and move tests to sdk_unittests The tests in rtc_unittests_objc are old gtest based tests and The tests in sdk_unittests are XCTest based tests. The objc tests in rtc_unittest are causing problems [1], so I think it's time to combine the two types of objc tests. Renaming the files to match the existing sdk_unittests and removing the use of gtest helper functions (eg, EXPECT_EQ) are planned for follow-up CLs. [1] https://webrtc-review.googlesource.com/c/src/+/261724/9 Bug: webrtc:8382 Change-Id: I9308b35f654c4479c9df72bf7cd7f4032e267eb2 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262380 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36878}
2022-05-13 19:59:49 +09:00
":helpers_objc",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
":mediaconstraints_objc",
Removing RTC_SUPPORTS_METAL compilation flag. This flag is a holdover from before either macOS or the iOS Simulator supported Metal rendering. Bug: webrtc:12638 Change-Id: Iced21bfac40192f609b65f5ea1dc3393ee1695fb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/222461 Commit-Queue: Jake Bromberg <jakebromberg@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34347}
2021-06-14 13:44:25 -07:00
":metal_objc",
Reland "Add unit tests for RTCCVPixelBuffer and ObjCVideoTrackSource." This is a reland of 4ea50c2b421ae3e40d1d02b8eb8c5802288b181e Original change's description: > Add unit tests for RTCCVPixelBuffer and ObjCVideoTrackSource. > > This CL also fixes a couple of bugs found in the toI420 method for > RTCCVPixelBuffers backed by RGB CVPixelBuffers. > > Bug: webrtc:9007 > Change-Id: I19ab8177f4b124a503cfda9f0166bd960f668982 > Reviewed-on: https://webrtc-review.googlesource.com/64940 > Commit-Queue: Anders Carlsson <andersc@webrtc.org> > Reviewed-by: Kári Helgason <kthelgason@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#22656} Bug: webrtc:9007 Change-Id: I2a787c64f8d23ffc4ef2419fc258d965f8a9480b Reviewed-on: https://webrtc-review.googlesource.com/66341 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22706}
2018-04-03 11:40:39 +02:00
":native_api",
Moving iOS Audio Device to sdk. This change forks the existing iOS audio device module and audio device from modules/audio_device/ into sdk/objc/Framework. It also updates RTCPeerConnectionFactory to use the forked implementation. The unit tests are re-implemented as XCTests. (was: https://webrtc-review.googlesource.com/c/src/+/67300) Bug: webrtc:9120 Change-Id: I46c09900246f75ca5285aeb38f7b8b295784ffac Reviewed-on: https://webrtc-review.googlesource.com/76741 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Commit-Queue: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23238}
2018-05-15 10:22:36 +02:00
":native_api_audio_device_module",
Reland "Add unit tests for RTCCVPixelBuffer and ObjCVideoTrackSource." This is a reland of 4ea50c2b421ae3e40d1d02b8eb8c5802288b181e Original change's description: > Add unit tests for RTCCVPixelBuffer and ObjCVideoTrackSource. > > This CL also fixes a couple of bugs found in the toI420 method for > RTCCVPixelBuffers backed by RGB CVPixelBuffers. > > Bug: webrtc:9007 > Change-Id: I19ab8177f4b124a503cfda9f0166bd960f668982 > Reviewed-on: https://webrtc-review.googlesource.com/64940 > Commit-Queue: Anders Carlsson <andersc@webrtc.org> > Reviewed-by: Kári Helgason <kthelgason@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#22656} Bug: webrtc:9007 Change-Id: I2a787c64f8d23ffc4ef2419fc258d965f8a9480b Reviewed-on: https://webrtc-review.googlesource.com/66341 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22706}
2018-04-03 11:40:39 +02:00
":native_video",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
":peerconnectionfactory_base_objc",
Add iOS SDK unit tests for nalu_rewriter Bug: webrtc:9939 Change-Id: I6848786009ee10ffed60743d9e3a2acaf65540c6 Reviewed-on: https://webrtc-review.googlesource.com/c/108440 Reviewed-by: Artem Titarenko <artit@webrtc.org> Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Commit-Queue: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25422}
2018-10-29 18:18:09 +01:00
":video_toolbox_cc",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
":videocapture_objc",
Obj-C SDK for parsing and generating H264 ProfileLevelIds. Expose this functionality in the Obj-C SDK to make it nicer to use for Obj-C clients. Bug: None Change-Id: I5cb511af8799ac0fda15153d16f2550b848b93b2 Reviewed-on: https://webrtc-review.googlesource.com/80481 Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23488}
2018-06-01 12:51:09 +02:00
":videocodec_objc",
Reland "Add unit tests for RTCCVPixelBuffer and ObjCVideoTrackSource." This is a reland of 4ea50c2b421ae3e40d1d02b8eb8c5802288b181e Original change's description: > Add unit tests for RTCCVPixelBuffer and ObjCVideoTrackSource. > > This CL also fixes a couple of bugs found in the toI420 method for > RTCCVPixelBuffers backed by RGB CVPixelBuffers. > > Bug: webrtc:9007 > Change-Id: I19ab8177f4b124a503cfda9f0166bd960f668982 > Reviewed-on: https://webrtc-review.googlesource.com/64940 > Commit-Queue: Anders Carlsson <andersc@webrtc.org> > Reviewed-by: Kári Helgason <kthelgason@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#22656} Bug: webrtc:9007 Change-Id: I2a787c64f8d23ffc4ef2419fc258d965f8a9480b Reviewed-on: https://webrtc-review.googlesource.com/66341 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22706}
2018-04-03 11:40:39 +02:00
":videoframebuffer_objc",
Fix native api in preparation for native_api example. Add native api conversions for video frames and video renderer. This also requires some changes to sdk/BUILD to avoid cyclic dependencies. Bug: webrtc:8832 Change-Id: Ibf21e63bdcae195dcb61d63f9262e6a8dc4fa790 Reviewed-on: https://webrtc-review.googlesource.com/57142 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22340}
2018-03-07 10:32:03 +01:00
":videosource_objc",
Add xctest target to migrate sdk/objc/Framework to it. This CL adds all the scaffolding needed to support xctest target in sdk/objc/Framework and adds the target to the bot configuration. The benefits of this are two-fold. 1. We'll separate framework unittests from their current target, `rtc_unittests`, that has many many other tests. This way framework unit tests will have nice, compact, selfcontained target. 2. We'll harvest the power of XCTest (native testing framework) that should hopefully make adding and writing objc tests easier. This CL migrates only one test to prove the setup works. More tests will be migrated in follow up cls. Bug: webrtc:8382 Change-Id: I0b5b9596c2a6d91683d13632323441de1aa461e0 Reviewed-on: https://webrtc-review.googlesource.com/8501 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20289}
2017-10-12 13:46:00 +02:00
":videotoolbox_objc",
Remove rtc_base/scoped_ref_ptr.h. The type rtc::scoped_refptr<T> is now part of api/. Please include it from api/scoped_refptr.h. More info: See: https://groups.google.com/forum/#!topic/discuss-webrtc/Mme2MSz4z4o. Bug: webrtc:9887, webrtc:8205 No-Try: True Change-Id: Ic6c7c81e226e59f12f7933e472f573ae097b55bf Reviewed-on: https://webrtc-review.googlesource.com/c/119041 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26414}
2019-01-25 20:26:48 +01:00
"../api:scoped_refptr",
Remove objc tests from rtc_unittests and move tests to sdk_unittests The tests in rtc_unittests_objc are old gtest based tests and The tests in sdk_unittests are XCTest based tests. The objc tests in rtc_unittest are causing problems [1], so I think it's time to combine the two types of objc tests. Renaming the files to match the existing sdk_unittests and removing the use of gtest helper functions (eg, EXPECT_EQ) are planned for follow-up CLs. [1] https://webrtc-review.googlesource.com/c/src/+/261724/9 Bug: webrtc:8382 Change-Id: I9308b35f654c4479c9df72bf7cd7f4032e267eb2 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262380 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36878}
2022-05-13 19:59:49 +09:00
"../api/audio_codecs:builtin_audio_decoder_factory",
"../api/audio_codecs:builtin_audio_encoder_factory",
Fix build errors of RTCAudioDeviceTests This happend because sdk_unittests is not built on arm/arm64 iOS build. Bug: webrtc:11022 Change-Id: I8f9adfd48e11c8512c27992804cc9b69dff15ded Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/156100 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29407}
2019-10-08 23:58:41 +09:00
"../api/task_queue:default_task_queue_factory",
Reland "Add scaling interface to VideoFrameBuffer" (Reland with no changes after the fix to the downstream project) This can be overriden for kNative frame types to perform scaling efficiently. Default implementations for existing buffer types require actual buffer implementation, thus this CL also merges "video_frame" with "video_frame_I420" build targets. Originally Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/186303 (Landing with TBR as it's unchaged reland of already approved CL) TBR=nisse@webrtc.org,sakal@webrtc.org Bug: webrtc:11976, chromium:1132299 Change-Id: Ia23f7d3e474bd9cdc177104cc5c6d772f04b210f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/187345 Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Stefan Holmer <stefan@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32362}
2020-10-08 14:36:33 +00:00
"../api/video:video_frame",
Remove objc tests from rtc_unittests and move tests to sdk_unittests The tests in rtc_unittests_objc are old gtest based tests and The tests in sdk_unittests are XCTest based tests. The objc tests in rtc_unittest are causing problems [1], so I think it's time to combine the two types of objc tests. Renaming the files to match the existing sdk_unittests and removing the use of gtest helper functions (eg, EXPECT_EQ) are planned for follow-up CLs. [1] https://webrtc-review.googlesource.com/c/src/+/261724/9 Bug: webrtc:8382 Change-Id: I9308b35f654c4479c9df72bf7cd7f4032e267eb2 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262380 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36878}
2022-05-13 19:59:49 +09:00
"../api/video_codecs:video_codecs_api",
Cleanup BUILD.gn files from imports like foo:foo Repalce all occurrences of foo:foo in deps with just foo in BUILD.gn files. Done with Sublime regex replace. Find: \b([-a-zA-Z0-9_]+):+\1\b In: *.gn Replace with: \1 Bug: None Change-Id: I40aba1b14face687a595b852ffe443cb20197611 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127899 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27225}
2019-03-21 13:35:10 +01:00
"../common_video",
Add xctest target to migrate sdk/objc/Framework to it. This CL adds all the scaffolding needed to support xctest target in sdk/objc/Framework and adds the target to the bot configuration. The benefits of this are two-fold. 1. We'll separate framework unittests from their current target, `rtc_unittests`, that has many many other tests. This way framework unit tests will have nice, compact, selfcontained target. 2. We'll harvest the power of XCTest (native testing framework) that should hopefully make adding and writing objc tests easier. This CL migrates only one test to prove the setup works. More tests will be migrated in follow up cls. Bug: webrtc:8382 Change-Id: I0b5b9596c2a6d91683d13632323441de1aa461e0 Reviewed-on: https://webrtc-review.googlesource.com/8501 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20289}
2017-10-12 13:46:00 +02:00
"../media:rtc_media_base",
Reland "Add unit tests for RTCCVPixelBuffer and ObjCVideoTrackSource." This is a reland of 4ea50c2b421ae3e40d1d02b8eb8c5802288b181e Original change's description: > Add unit tests for RTCCVPixelBuffer and ObjCVideoTrackSource. > > This CL also fixes a couple of bugs found in the toI420 method for > RTCCVPixelBuffers backed by RGB CVPixelBuffers. > > Bug: webrtc:9007 > Change-Id: I19ab8177f4b124a503cfda9f0166bd960f668982 > Reviewed-on: https://webrtc-review.googlesource.com/64940 > Commit-Queue: Anders Carlsson <andersc@webrtc.org> > Reviewed-by: Kári Helgason <kthelgason@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#22656} Bug: webrtc:9007 Change-Id: I2a787c64f8d23ffc4ef2419fc258d965f8a9480b Reviewed-on: https://webrtc-review.googlesource.com/66341 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22706}
2018-04-03 11:40:39 +02:00
"../media:rtc_media_tests_utils",
Remove objc tests from rtc_unittests and move tests to sdk_unittests The tests in rtc_unittests_objc are old gtest based tests and The tests in sdk_unittests are XCTest based tests. The objc tests in rtc_unittest are causing problems [1], so I think it's time to combine the two types of objc tests. Renaming the files to match the existing sdk_unittests and removing the use of gtest helper functions (eg, EXPECT_EQ) are planned for follow-up CLs. [1] https://webrtc-review.googlesource.com/c/src/+/261724/9 Bug: webrtc:8382 Change-Id: I9308b35f654c4479c9df72bf7cd7f4032e267eb2 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262380 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36878}
2022-05-13 19:59:49 +09:00
"../modules/audio_device:audio_device_api",
"../modules/audio_processing:api",
"../modules/video_coding:video_codec_interface",
Cleanup BUILD.gn files from imports like foo:foo Repalce all occurrences of foo:foo in deps with just foo in BUILD.gn files. Done with Sublime regex replace. Find: \b([-a-zA-Z0-9_]+):+\1\b In: *.gn Replace with: \1 Bug: None Change-Id: I40aba1b14face687a595b852ffe443cb20197611 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127899 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27225}
2019-03-21 13:35:10 +01:00
"../rtc_base",
Decouple //rtc_base:rtc_base_tests_utils from gunit. This CL decouples //rtc_base:rtc_base_tests_utils from gunit by moving gunit helpers (rtc_base/gunit.h) and rtc_base/testclient.h (which depends on gunit helpers) to their own build target. It also removes some unused dependencies in the WebRTC build graph. Bug: None Change-Id: Ia9820e84ff697da39b351eef73c45f6e4bdf2623 Reviewed-on: https://webrtc-review.googlesource.com/c/111861 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25769}
2018-11-23 13:15:08 +01:00
"../rtc_base:gunit_helpers",
Remove //rtc_base:macromagic from public deps Bug: webrtc:8603 Change-Id: I9708df48c9bde9f86ba2d1a92a278bb0d09f3865 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257909 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Florent Castelli <orphis@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36444}
2022-04-04 15:18:46 +02:00
"../rtc_base:macromagic",
Remove //rtc_base:refcount from public deps Bug: webrtc:8603 Change-Id: Ib27a107ae809df739492846175f0e9c4af40d21a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257910 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Florent Castelli <orphis@webrtc.org> Reviewed-by: Florent Castelli <orphis@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36447}
2022-04-05 02:54:12 +02:00
"../rtc_base:refcount",
Remove objc tests from rtc_unittests and move tests to sdk_unittests The tests in rtc_unittests_objc are old gtest based tests and The tests in sdk_unittests are XCTest based tests. The objc tests in rtc_unittest are causing problems [1], so I think it's time to combine the two types of objc tests. Renaming the files to match the existing sdk_unittests and removing the use of gtest helper functions (eg, EXPECT_EQ) are planned for follow-up CLs. [1] https://webrtc-review.googlesource.com/c/src/+/261724/9 Bug: webrtc:8382 Change-Id: I9308b35f654c4479c9df72bf7cd7f4032e267eb2 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262380 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36878}
2022-05-13 19:59:49 +09:00
"../rtc_base:rtc_event",
Fix -Wunused-but-set-variable Bug: chromium:1203071 Change-Id: I338bd31ab0e74751f2c0abd5d441ea03ac33dead Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/237880 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#35350}
2021-11-16 11:31:57 +09:00
"../rtc_base/system:unused",
Cleanup BUILD.gn files from imports like foo:foo Repalce all occurrences of foo:foo in deps with just foo in BUILD.gn files. Done with Sublime regex replace. Find: \b([-a-zA-Z0-9_]+):+\1\b In: *.gn Replace with: \1 Bug: None Change-Id: I40aba1b14face687a595b852ffe443cb20197611 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127899 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27225}
2019-03-21 13:35:10 +01:00
"../system_wrappers",
Reland "Add unit tests for RTCCVPixelBuffer and ObjCVideoTrackSource." This is a reland of 4ea50c2b421ae3e40d1d02b8eb8c5802288b181e Original change's description: > Add unit tests for RTCCVPixelBuffer and ObjCVideoTrackSource. > > This CL also fixes a couple of bugs found in the toI420 method for > RTCCVPixelBuffers backed by RGB CVPixelBuffers. > > Bug: webrtc:9007 > Change-Id: I19ab8177f4b124a503cfda9f0166bd960f668982 > Reviewed-on: https://webrtc-review.googlesource.com/64940 > Commit-Queue: Anders Carlsson <andersc@webrtc.org> > Reviewed-by: Kári Helgason <kthelgason@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#22656} Bug: webrtc:9007 Change-Id: I2a787c64f8d23ffc4ef2419fc258d965f8a9480b Reviewed-on: https://webrtc-review.googlesource.com/66341 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22706}
2018-04-03 11:40:39 +02:00
"//third_party/libyuv",
Add xctest target to migrate sdk/objc/Framework to it. This CL adds all the scaffolding needed to support xctest target in sdk/objc/Framework and adds the target to the bot configuration. The benefits of this are two-fold. 1. We'll separate framework unittests from their current target, `rtc_unittests`, that has many many other tests. This way framework unit tests will have nice, compact, selfcontained target. 2. We'll harvest the power of XCTest (native testing framework) that should hopefully make adding and writing objc tests easier. This CL migrates only one test to prove the setup works. More tests will be migrated in follow up cls. Bug: webrtc:8382 Change-Id: I0b5b9596c2a6d91683d13632323441de1aa461e0 Reviewed-on: https://webrtc-review.googlesource.com/8501 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20289}
2017-10-12 13:46:00 +02:00
]
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
iOS: Get WebRTC building for Mac Catalyst - Add an option for disabling the OpenGL renderer - Change the build script to use correct header location - Use Metal compatibility for h264 CoreVideo buffers Bug: webrtc:11516 Change-Id: Ia34a9305648e75904ac36e69593ffefedd833bfb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/224200 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34426}
2021-07-06 12:16:41 -07:00
if (rtc_ios_macos_use_opengl_rendering) {
deps += [ ":opengl_objc" ]
}
Add xctest target to migrate sdk/objc/Framework to it. This CL adds all the scaffolding needed to support xctest target in sdk/objc/Framework and adds the target to the bot configuration. The benefits of this are two-fold. 1. We'll separate framework unittests from their current target, `rtc_unittests`, that has many many other tests. This way framework unit tests will have nice, compact, selfcontained target. 2. We'll harvest the power of XCTest (native testing framework) that should hopefully make adding and writing objc tests easier. This CL migrates only one test to prove the setup works. More tests will be migrated in follow up cls. Bug: webrtc:8382 Change-Id: I0b5b9596c2a6d91683d13632323441de1aa461e0 Reviewed-on: https://webrtc-review.googlesource.com/8501 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20289}
2017-10-12 13:46:00 +02:00
public_deps = [
"//build/config/ios:xctest",
"//third_party/ocmock",
]
}
Reland "Add file capturer to AppRTCMobile on simulator." This is a reland of 5adcd198752b651f7b7e9199a91f9b873b7d7237 Original change's description: > Add file capturer to AppRTCMobile on simulator. > > To achieve this, the CL does the following > - Adds sample mp4 video > - Refactors the existing RTCFileVideoCapturer to achieve continious > capture and adds tests. > > Bug: webrtc:8406 > Change-Id: Ibc0891176c58ec9053b42e340d2113036e7199ec > Reviewed-on: https://webrtc-review.googlesource.com/12180 > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > Reviewed-by: Magnus Jedvert <magjed@webrtc.org> > Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#20598} Bug: webrtc:8406 Change-Id: I93be89b86e342a9a8195e19ebaf4aef1410d2c20 Reviewed-on: https://webrtc-review.googlesource.com/23200 Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20870}
2017-11-15 13:15:24 +01:00
bundle_data("sdk_unittests_bundle_data") {
sources = [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/unittests/audio_short16.pcm",
"objc/unittests/audio_short44.pcm",
"objc/unittests/audio_short48.pcm",
Moving iOS Audio Device to sdk. This change forks the existing iOS audio device module and audio device from modules/audio_device/ into sdk/objc/Framework. It also updates RTCPeerConnectionFactory to use the forked implementation. The unit tests are re-implemented as XCTests. (was: https://webrtc-review.googlesource.com/c/src/+/67300) Bug: webrtc:9120 Change-Id: I46c09900246f75ca5285aeb38f7b8b295784ffac Reviewed-on: https://webrtc-review.googlesource.com/76741 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Commit-Queue: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23238}
2018-05-15 10:22:36 +02:00
# Sample video taken from https://media.xiph.org/video/derf/
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/unittests/foreman.mp4",
Reland "Add file capturer to AppRTCMobile on simulator." This is a reland of 5adcd198752b651f7b7e9199a91f9b873b7d7237 Original change's description: > Add file capturer to AppRTCMobile on simulator. > > To achieve this, the CL does the following > - Adds sample mp4 video > - Refactors the existing RTCFileVideoCapturer to achieve continious > capture and adds tests. > > Bug: webrtc:8406 > Change-Id: Ibc0891176c58ec9053b42e340d2113036e7199ec > Reviewed-on: https://webrtc-review.googlesource.com/12180 > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > Reviewed-by: Magnus Jedvert <magjed@webrtc.org> > Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#20598} Bug: webrtc:8406 Change-Id: I93be89b86e342a9a8195e19ebaf4aef1410d2c20 Reviewed-on: https://webrtc-review.googlesource.com/23200 Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20870}
2017-11-15 13:15:24 +01:00
]
Replace RTC_FALLTHROUGH with ABSL_FALLTHROUGH_INTENTED Bug: None Change-Id: I7287403f3fb13b8e30f92ca3cf1882b03bb53a6e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166176 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30283}
2020-01-16 14:41:10 +01:00
outputs = [ "{{bundle_resources_dir}}/{{source_file_part}}" ]
Reland "Add file capturer to AppRTCMobile on simulator." This is a reland of 5adcd198752b651f7b7e9199a91f9b873b7d7237 Original change's description: > Add file capturer to AppRTCMobile on simulator. > > To achieve this, the CL does the following > - Adds sample mp4 video > - Refactors the existing RTCFileVideoCapturer to achieve continious > capture and adds tests. > > Bug: webrtc:8406 > Change-Id: Ibc0891176c58ec9053b42e340d2113036e7199ec > Reviewed-on: https://webrtc-review.googlesource.com/12180 > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > Reviewed-by: Magnus Jedvert <magjed@webrtc.org> > Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#20598} Bug: webrtc:8406 Change-Id: I93be89b86e342a9a8195e19ebaf4aef1410d2c20 Reviewed-on: https://webrtc-review.googlesource.com/23200 Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20870}
2017-11-15 13:15:24 +01:00
}
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
# These tests use static linking.
Reland "Switch from rtc_ios_xctest_test to rtc_test". This is a reland of https://webrtc-review.googlesource.com/c/src/+/182680, and it is based on https://chromium-review.googlesource.com/c/chromium/src/+/2414169 which allows to force a "test" to be executed as an XCtest on a build target basis instead of on a GN args basis like it was happening in https://webrtc-review.googlesource.com/c/src/+/182680 because that was causing issues when launching tests on real devices. Bug: webrtc:11881, webrtc:11937 Change-Id: I4bec7f471cd0f878b6050f266cd0cca3b518d415 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184360 Reviewed-by: Dirk Pranke <dpranke@google.com> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32126}
2020-09-16 15:09:53 +02:00
rtc_test("sdk_unittests") {
is_xctest = true
Add xctest target to migrate sdk/objc/Framework to it. This CL adds all the scaffolding needed to support xctest target in sdk/objc/Framework and adds the target to the bot configuration. The benefits of this are two-fold. 1. We'll separate framework unittests from their current target, `rtc_unittests`, that has many many other tests. This way framework unit tests will have nice, compact, selfcontained target. 2. We'll harvest the power of XCTest (native testing framework) that should hopefully make adding and writing objc tests easier. This CL migrates only one test to prove the setup works. More tests will be migrated in follow up cls. Bug: webrtc:8382 Change-Id: I0b5b9596c2a6d91683d13632323441de1aa461e0 Reviewed-on: https://webrtc-review.googlesource.com/8501 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20289}
2017-10-12 13:46:00 +02:00
info_plist = "//test/ios/Info.plist"
Replace RTC_FALLTHROUGH with ABSL_FALLTHROUGH_INTENTED Bug: None Change-Id: I7287403f3fb13b8e30f92ca3cf1882b03bb53a6e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166176 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30283}
2020-01-16 14:41:10 +01:00
sources = [ "objc/unittests/main.mm" ]
Reland "Add file capturer to AppRTCMobile on simulator." This is a reland of 5adcd198752b651f7b7e9199a91f9b873b7d7237 Original change's description: > Add file capturer to AppRTCMobile on simulator. > > To achieve this, the CL does the following > - Adds sample mp4 video > - Refactors the existing RTCFileVideoCapturer to achieve continious > capture and adds tests. > > Bug: webrtc:8406 > Change-Id: Ibc0891176c58ec9053b42e340d2113036e7199ec > Reviewed-on: https://webrtc-review.googlesource.com/12180 > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > Reviewed-by: Magnus Jedvert <magjed@webrtc.org> > Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#20598} Bug: webrtc:8406 Change-Id: I93be89b86e342a9a8195e19ebaf4aef1410d2c20 Reviewed-on: https://webrtc-review.googlesource.com/23200 Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20870}
2017-11-15 13:15:24 +01:00
Roll chromium_revision c7f14188a3..afb0a631b9 (687843:688061) Additionally, remove stale ios recipe variables due to this change: https://chromium-review.googlesource.com/c/chromium/src/+/1394435 Change log: https://chromium.googlesource.com/chromium/src/+log/c7f14188a3..afb0a631b9 Full diff: https://chromium.googlesource.com/chromium/src/+/c7f14188a3..afb0a631b9 Changed dependencies * src/base: https://chromium.googlesource.com/chromium/src/base/+log/1ed92f77f9..845cdcdcd2 * src/build: https://chromium.googlesource.com/chromium/src/build/+log/8f7634e82e..7539a9c425 * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/d5987ad4b8..17cf6dfd7e * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/db51c13bec..c96b0fc8eb * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/d53a889e2e..d9108ec1ca * src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/3a96577620..1f288d915d * src/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/e9d5f427b5..27e17f7851 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/6f8134e8f5..054f3713fb DEPS diff: https://chromium.googlesource.com/chromium/src/+/c7f14188a3..afb0a631b9/DEPS No update to Clang. TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com, BUG=None Change-Id: I97a8a461afa46f79fab683a6467d8622024b56a3 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149806 Reviewed-by: Artem Titarenko <artit@webrtc.org> Commit-Queue: Artem Titarenko <artit@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28899}
2019-08-19 14:24:00 +02:00
extra_substitutions = [ "GTEST_BUNDLE_ID_SUFFIX=generic-unit-test" ]
Add xctest target to migrate sdk/objc/Framework to it. This CL adds all the scaffolding needed to support xctest target in sdk/objc/Framework and adds the target to the bot configuration. The benefits of this are two-fold. 1. We'll separate framework unittests from their current target, `rtc_unittests`, that has many many other tests. This way framework unit tests will have nice, compact, selfcontained target. 2. We'll harvest the power of XCTest (native testing framework) that should hopefully make adding and writing objc tests easier. This CL migrates only one test to prove the setup works. More tests will be migrated in follow up cls. Bug: webrtc:8382 Change-Id: I0b5b9596c2a6d91683d13632323441de1aa461e0 Reviewed-on: https://webrtc-review.googlesource.com/8501 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20289}
2017-10-12 13:46:00 +02:00
deps = [
Fixed crash when PCF is destroyed before PC in ObjC Bug: webrtc:9231 Change-Id: Iaf18257b8f38fa786d462bca5f860f9a7b1cc2d0 Reviewed-on: https://webrtc-review.googlesource.com/78800 Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23674}
2018-06-19 12:51:51 +03:00
":peerconnectionfactory_base_objc",
Reland "Add file capturer to AppRTCMobile on simulator." This is a reland of 5adcd198752b651f7b7e9199a91f9b873b7d7237 Original change's description: > Add file capturer to AppRTCMobile on simulator. > > To achieve this, the CL does the following > - Adds sample mp4 video > - Refactors the existing RTCFileVideoCapturer to achieve continious > capture and adds tests. > > Bug: webrtc:8406 > Change-Id: Ibc0891176c58ec9053b42e340d2113036e7199ec > Reviewed-on: https://webrtc-review.googlesource.com/12180 > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > Reviewed-by: Magnus Jedvert <magjed@webrtc.org> > Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#20598} Bug: webrtc:8406 Change-Id: I93be89b86e342a9a8195e19ebaf4aef1410d2c20 Reviewed-on: https://webrtc-review.googlesource.com/23200 Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20870}
2017-11-15 13:15:24 +01:00
":sdk_unittests_bundle_data",
Add xctest target to migrate sdk/objc/Framework to it. This CL adds all the scaffolding needed to support xctest target in sdk/objc/Framework and adds the target to the bot configuration. The benefits of this are two-fold. 1. We'll separate framework unittests from their current target, `rtc_unittests`, that has many many other tests. This way framework unit tests will have nice, compact, selfcontained target. 2. We'll harvest the power of XCTest (native testing framework) that should hopefully make adding and writing objc tests easier. This CL migrates only one test to prove the setup works. More tests will be migrated in follow up cls. Bug: webrtc:8382 Change-Id: I0b5b9596c2a6d91683d13632323441de1aa461e0 Reviewed-on: https://webrtc-review.googlesource.com/8501 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20289}
2017-10-12 13:46:00 +02:00
":sdk_unittests_sources",
Prepare for deletion of the NO_MAIN_THREAD_WRAPPING preprocessor define This is a partial reland of https://webrtc-review.googlesource.com/c/src/+/39680, including only the (hopefully) non-problematic parts of it, but postponing actual deletion of automatic thread wrapping. Bug: webrtc:9714 Change-Id: I9b79dd073f0e945cbb62f3b54cff05eaaea9b06c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141664 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28265}
2019-06-12 11:30:59 +02:00
"../rtc_base",
Reland "Refactor rtc_base build targets." This is a reland of 69241a93fb14f6527a26d5c94dde879013012d2a Fix: The problem was related to NO_MAIN_THREAD_WRAPPING, which affects https://source.chromium.org/chromium/chromium/src/+/master:third_party/webrtc/rtc_base/thread.cc;l=257-263;drc=7acc2d9fe3a6e3c4d8881d2bdfc9b8968a724cd5. The original CL didn't attach the definition of the macro NO_MAIN_THREAD_WRAPPING when building for Chromium (which doesn't have to be related to //rtc_base anymore but to //rtc_base:threading). Original change's description: > Refactor rtc_base build targets. > > The "//rtc_base:rtc_base" build target has historically been one of the > biggest targets in the WebRTC build. Big targets are the main source of > circular dependencies and non-API types leakage. > > This CL is a step forward into splitting "//rtc_base:rtc_base" into > smaller targets (as originally started in 2018). > > The only non-automated changes are (like re-wiring the build system): > * The creation of //rtc_base/async_resolver.{h,cc} which allows to > break a circular dependency (is has been extracted from > //rtc_base/net_helpers.{h,cc}). > * The creation of //rtc_base/internal/default_socket_server.{h,cc} to > break another circular dependency. > > Bug: webrtc:9987 > Change-Id: I0c8f5e7efe2c8fd8e6bffa0d6dd2dd494cf3df02 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/196903 > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#32941} Bug: webrtc:9987 Change-Id: I7cdf49d2aac8357f1f50f90010bf2c2f62fa19f6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/202021 Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33001}
2021-01-15 10:41:01 +01:00
"../rtc_base:threading",
Add support for computing iOS code coverage Also disable failing PosixSignalDeliveryTest* tests for iOS Bug: chromium:844647 Change-Id: I64bb233bef2f06f6778f2d475b6d3ad685fb9143 Reviewed-on: https://webrtc-review.googlesource.com/c/105641 Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Reviewed-by: Artem Titarenko <artit@webrtc.org> Commit-Queue: Artem Titarenko <artit@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25524}
2018-11-06 12:29:29 +01:00
"//test:test_support",
Add xctest target to migrate sdk/objc/Framework to it. This CL adds all the scaffolding needed to support xctest target in sdk/objc/Framework and adds the target to the bot configuration. The benefits of this are two-fold. 1. We'll separate framework unittests from their current target, `rtc_unittests`, that has many many other tests. This way framework unit tests will have nice, compact, selfcontained target. 2. We'll harvest the power of XCTest (native testing framework) that should hopefully make adding and writing objc tests easier. This CL migrates only one test to prove the setup works. More tests will be migrated in follow up cls. Bug: webrtc:8382 Change-Id: I0b5b9596c2a6d91683d13632323441de1aa461e0 Reviewed-on: https://webrtc-review.googlesource.com/8501 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20289}
2017-10-12 13:46:00 +02:00
]
ldflags = [ "-all_load" ]
}
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
# These tests link to the framework.
Reland "Switch from rtc_ios_xctest_test to rtc_test". This is a reland of https://webrtc-review.googlesource.com/c/src/+/182680, and it is based on https://chromium-review.googlesource.com/c/chromium/src/+/2414169 which allows to force a "test" to be executed as an XCtest on a build target basis instead of on a GN args basis like it was happening in https://webrtc-review.googlesource.com/c/src/+/182680 because that was causing issues when launching tests on real devices. Bug: webrtc:11881, webrtc:11937 Change-Id: I4bec7f471cd0f878b6050f266cd0cca3b518d415 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184360 Reviewed-by: Dirk Pranke <dpranke@google.com> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32126}
2020-09-16 15:09:53 +02:00
rtc_test("sdk_framework_unittests") {
is_xctest = true
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
info_plist = "//test/ios/Info.plist"
sources = [
"objc/unittests/RTCDoNotPutCPlusPlusInFrameworkHeaders_xctest.m",
Add support for computing iOS code coverage Also disable failing PosixSignalDeliveryTest* tests for iOS Bug: chromium:844647 Change-Id: I64bb233bef2f06f6778f2d475b6d3ad685fb9143 Reviewed-on: https://webrtc-review.googlesource.com/c/105641 Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Reviewed-by: Artem Titarenko <artit@webrtc.org> Commit-Queue: Artem Titarenko <artit@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25524}
2018-11-06 12:29:29 +01:00
"objc/unittests/main.mm",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
]
Roll chromium_revision c7f14188a3..afb0a631b9 (687843:688061) Additionally, remove stale ios recipe variables due to this change: https://chromium-review.googlesource.com/c/chromium/src/+/1394435 Change log: https://chromium.googlesource.com/chromium/src/+log/c7f14188a3..afb0a631b9 Full diff: https://chromium.googlesource.com/chromium/src/+/c7f14188a3..afb0a631b9 Changed dependencies * src/base: https://chromium.googlesource.com/chromium/src/base/+log/1ed92f77f9..845cdcdcd2 * src/build: https://chromium.googlesource.com/chromium/src/build/+log/8f7634e82e..7539a9c425 * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/d5987ad4b8..17cf6dfd7e * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/db51c13bec..c96b0fc8eb * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/d53a889e2e..d9108ec1ca * src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/3a96577620..1f288d915d * src/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/e9d5f427b5..27e17f7851 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/6f8134e8f5..054f3713fb DEPS diff: https://chromium.googlesource.com/chromium/src/+/c7f14188a3..afb0a631b9/DEPS No update to Clang. TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com, BUG=None Change-Id: I97a8a461afa46f79fab683a6467d8622024b56a3 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149806 Reviewed-by: Artem Titarenko <artit@webrtc.org> Commit-Queue: Artem Titarenko <artit@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28899}
2019-08-19 14:24:00 +02:00
extra_substitutions = [ "GTEST_BUNDLE_ID_SUFFIX=generic-unit-test" ]
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
deps = [
":framework_objc+link",
":ios_framework_bundle",
Prepare for deletion of the NO_MAIN_THREAD_WRAPPING preprocessor define This is a partial reland of https://webrtc-review.googlesource.com/c/src/+/39680, including only the (hopefully) non-problematic parts of it, but postponing actual deletion of automatic thread wrapping. Bug: webrtc:9714 Change-Id: I9b79dd073f0e945cbb62f3b54cff05eaaea9b06c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141664 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28265}
2019-06-12 11:30:59 +02:00
"../rtc_base",
Reland "Refactor rtc_base build targets." This is a reland of 69241a93fb14f6527a26d5c94dde879013012d2a Fix: The problem was related to NO_MAIN_THREAD_WRAPPING, which affects https://source.chromium.org/chromium/chromium/src/+/master:third_party/webrtc/rtc_base/thread.cc;l=257-263;drc=7acc2d9fe3a6e3c4d8881d2bdfc9b8968a724cd5. The original CL didn't attach the definition of the macro NO_MAIN_THREAD_WRAPPING when building for Chromium (which doesn't have to be related to //rtc_base anymore but to //rtc_base:threading). Original change's description: > Refactor rtc_base build targets. > > The "//rtc_base:rtc_base" build target has historically been one of the > biggest targets in the WebRTC build. Big targets are the main source of > circular dependencies and non-API types leakage. > > This CL is a step forward into splitting "//rtc_base:rtc_base" into > smaller targets (as originally started in 2018). > > The only non-automated changes are (like re-wiring the build system): > * The creation of //rtc_base/async_resolver.{h,cc} which allows to > break a circular dependency (is has been extracted from > //rtc_base/net_helpers.{h,cc}). > * The creation of //rtc_base/internal/default_socket_server.{h,cc} to > break another circular dependency. > > Bug: webrtc:9987 > Change-Id: I0c8f5e7efe2c8fd8e6bffa0d6dd2dd494cf3df02 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/196903 > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#32941} Bug: webrtc:9987 Change-Id: I7cdf49d2aac8357f1f50f90010bf2c2f62fa19f6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/202021 Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33001}
2021-01-15 10:41:01 +01:00
"../rtc_base:threading",
Add support for computing iOS code coverage Also disable failing PosixSignalDeliveryTest* tests for iOS Bug: chromium:844647 Change-Id: I64bb233bef2f06f6778f2d475b6d3ad685fb9143 Reviewed-on: https://webrtc-review.googlesource.com/c/105641 Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Reviewed-by: Artem Titarenko <artit@webrtc.org> Commit-Queue: Artem Titarenko <artit@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25524}
2018-11-06 12:29:29 +01:00
"//test:test_support",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
]
}
Add xctest target to migrate sdk/objc/Framework to it. This CL adds all the scaffolding needed to support xctest target in sdk/objc/Framework and adds the target to the bot configuration. The benefits of this are two-fold. 1. We'll separate framework unittests from their current target, `rtc_unittests`, that has many many other tests. This way framework unit tests will have nice, compact, selfcontained target. 2. We'll harvest the power of XCTest (native testing framework) that should hopefully make adding and writing objc tests easier. This CL migrates only one test to prove the setup works. More tests will be migrated in follow up cls. Bug: webrtc:8382 Change-Id: I0b5b9596c2a6d91683d13632323441de1aa461e0 Reviewed-on: https://webrtc-review.googlesource.com/8501 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org> Commit-Queue: Daniela Jovanoska Petrenko <denicija@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20289}
2017-10-12 13:46:00 +02:00
}
[GN] Add rtc_sdk_framework_objc target to GN The build artifacts don't look completely identical to the ones generated by the GYP targets, but manual review shows the same symbols are exported. On iOS, the version generated by the GN follows convention, including a "Headers" directory, and the .modulemap file. I think this is preferred over the gyp version. BUG=webrtc:6320 NOTRY=True TESTED=Run AppRTCDemo on iOS + Mac and verified with nm that they export the same symbols. Review-Url: https://codereview.webrtc.org/2340633003 Cr-Commit-Position: refs/heads/master@{#14228}
2016-09-15 04:30:18 -07:00
}
GN: Build iOS framework in build_ios_libs.sh BUG=webrtc:6372 NOTRY=True R=kjellander@webrtc.org Review URL: https://codereview.webrtc.org/2408983002 . Cr-Commit-Position: refs/heads/master@{#14603}
2016-10-11 13:27:26 -07:00
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
if (is_ios) {
Merge GN templates for iOS and MacOS framework creation The two GN templates are nearly identical, so merge them to reduce maintenance. Bug: webrtc:13949 Change-Id: I5f53ade5f9d09ce6f23a6cb29c9d39df4485a237 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/258380 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com> Cr-Commit-Position: refs/heads/main@{#36495}
2022-04-08 18:23:14 +09:00
apple_framework_bundle_with_umbrella_header("framework_objc") {
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
info_plist = "objc/Info.plist"
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
output_name = "WebRTC"
Revert "Adding injectable audio decoder and encoder factory support to the RTCPeerConnection obj-c layer." This reverts commit 96de428fd1f301c3ad1355183b45e44db5ef3f7f. Reason for revert: Gives compile errors because the new ObjC++ headers are included in some targets that use ObjC. Original change's description: > Adding injectable audio decoder and encoder factory support to the RTCPeerConnection obj-c layer. > > Bug: webrtc:8093 > Change-Id: I868ce5f75a72c6deb065dec60784289d045ae22a > Reviewed-on: https://chromium-review.googlesource.com/608981 > Commit-Queue: Jeremy Newton-Smith <jeremyns@webrtc.org> > Reviewed-by: Zeke Chin <tkchin@webrtc.org> > Reviewed-by: Kári Tristan Helgason <kthelgason@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#19477} TBR=kjellander@webrtc.org,tkchin@webrtc.org,kthelgason@webrtc.org,jeremyns@webrtc.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:8093 Change-Id: I3ade9dd979c9f13990a2972b15b786b8e78e1cd4 Reviewed-on: https://chromium-review.googlesource.com/640810 Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Commit-Queue: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19573}
2017-08-29 09:49:43 +00:00
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
common_objc_headers = [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/base/RTCCodecSpecificInfo.h",
"objc/base/RTCEncodedImage.h",
Include i420 buffers in Obj-C framework again. These headers was lost in the cleanup CL for the Obj-C directories. This puts them back in the framework headers. Note that since the protocol and interface was split into two different headers, and all public framework headers are put into a flat directory structure, I had to rename the implementation files so they would not collide in the framework header directory. Bug: webrtc:9701 Change-Id: I42d4c1e02bdfa4e114575f527c4c42a19be8fb52 Reviewed-on: https://webrtc-review.googlesource.com/97330 Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24539}
2018-09-03 14:44:50 +02:00
"objc/base/RTCI420Buffer.h",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/base/RTCLogging.h",
"objc/base/RTCMacros.h",
Include i420 buffers in Obj-C framework again. These headers was lost in the cleanup CL for the Obj-C directories. This puts them back in the framework headers. Note that since the protocol and interface was split into two different headers, and all public framework headers are put into a flat directory structure, I had to rename the implementation files so they would not collide in the framework header directory. Bug: webrtc:9701 Change-Id: I42d4c1e02bdfa4e114575f527c4c42a19be8fb52 Reviewed-on: https://webrtc-review.googlesource.com/97330 Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24539}
2018-09-03 14:44:50 +02:00
"objc/base/RTCMutableI420Buffer.h",
"objc/base/RTCMutableYUVPlanarBuffer.h",
Expose RTCSSLCertificateVerifier from iOS SDK. Bug: webrtc:11710 Change-Id: I825c6350a71b2ff180520f8643cbd4d6febdc883 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/254821 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Yura Yaroshevich <yura.yaroshevich@gmail.com> Cr-Commit-Position: refs/heads/main@{#36284}
2022-03-11 09:22:08 +01:00
"objc/base/RTCSSLCertificateVerifier.h",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/base/RTCVideoCapturer.h",
"objc/base/RTCVideoCodecInfo.h",
"objc/base/RTCVideoDecoder.h",
"objc/base/RTCVideoDecoderFactory.h",
"objc/base/RTCVideoEncoder.h",
"objc/base/RTCVideoEncoderFactory.h",
"objc/base/RTCVideoEncoderQpThresholds.h",
"objc/base/RTCVideoEncoderSettings.h",
"objc/base/RTCVideoFrame.h",
"objc/base/RTCVideoFrameBuffer.h",
"objc/base/RTCVideoRenderer.h",
Include i420 buffers in Obj-C framework again. These headers was lost in the cleanup CL for the Obj-C directories. This puts them back in the framework headers. Note that since the protocol and interface was split into two different headers, and all public framework headers are put into a flat directory structure, I had to rename the implementation files so they would not collide in the framework header directory. Bug: webrtc:9701 Change-Id: I42d4c1e02bdfa4e114575f527c4c42a19be8fb52 Reviewed-on: https://webrtc-review.googlesource.com/97330 Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24539}
2018-09-03 14:44:50 +02:00
"objc/base/RTCYUVPlanarBuffer.h",
ObjC ADM: added RTCAudioDevice protocol [2/N] Bug: webrtc:14193 Change-Id: I616c4d338a0bbc57c22e1f1dcc4454512aecd967 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268195 Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Commit-Queue: Yury Yarashevich <yura.yaroshevich@gmail.com> Cr-Commit-Position: refs/heads/main@{#37925}
2022-08-29 12:22:35 +02:00
"objc/components/audio/RTCAudioDevice.h",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/components/audio/RTCAudioSession.h",
"objc/components/audio/RTCAudioSessionConfiguration.h",
"objc/components/capturer/RTCCameraVideoCapturer.h",
"objc/components/capturer/RTCFileVideoCapturer.h",
Implement network monitor for iOS. Notably, this should detect whether an interface is "available" or not, which should prevent the failure is with dual SIM card setups. This is gated behind a field trial for now, to ensure this doesn't cause any regressions due to false negatives (interfaces that are usable but not listed as available by NWPathMonitor). Bug: webrtc:10966 Change-Id: Ia3942c4c57b525d08d8b340e2325f3705cfd0304 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180923 Commit-Queue: Taylor <deadbeef@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Jonas Oreland <jonaso@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31977}
2020-08-19 16:41:54 -07:00
"objc/components/network/RTCNetworkMonitor.h",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/components/renderer/metal/RTCMTLVideoView.h",
"objc/components/renderer/opengl/RTCEAGLVideoView.h",
"objc/components/renderer/opengl/RTCVideoViewShading.h",
"objc/components/video_codec/RTCCodecSpecificInfoH264.h",
"objc/components/video_codec/RTCDefaultVideoDecoderFactory.h",
"objc/components/video_codec/RTCDefaultVideoEncoderFactory.h",
"objc/components/video_codec/RTCH264ProfileLevelId.h",
"objc/components/video_codec/RTCVideoDecoderFactoryH264.h",
"objc/components/video_codec/RTCVideoDecoderH264.h",
"objc/components/video_codec/RTCVideoEncoderFactoryH264.h",
"objc/components/video_codec/RTCVideoEncoderH264.h",
"objc/components/video_frame_buffer/RTCCVPixelBuffer.h",
"objc/helpers/RTCCameraPreviewView.h",
"objc/helpers/RTCDispatcher.h",
"objc/helpers/UIDevice+RTCDevice.h",
"objc/api/peerconnection/RTCAudioSource.h",
"objc/api/peerconnection/RTCAudioTrack.h",
"objc/api/peerconnection/RTCConfiguration.h",
"objc/api/peerconnection/RTCDataChannel.h",
"objc/api/peerconnection/RTCDataChannelConfiguration.h",
"objc/api/peerconnection/RTCFieldTrials.h",
"objc/api/peerconnection/RTCIceCandidate.h",
Implement JNI and objc implementation for icecandidateerror event This CL adds the callback on ICE Candidate Error to the Android and the iOS SDKs. Spec: https://www.w3.org/TR/webrtc/#dom-rtcpeerconnection-onicecandidateerror Bug: webrtc:13446 Change-Id: I6e511aaa80f1aa8f4310d8518d1144d97470cd7e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239460 Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Henrik Andreassson <henrika@webrtc.org> Cr-Commit-Position: refs/heads/main@{#35531}
2021-11-30 19:01:43 +09:00
"objc/api/peerconnection/RTCIceCandidateErrorEvent.h",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/api/peerconnection/RTCIceServer.h",
"objc/api/peerconnection/RTCLegacyStatsReport.h",
"objc/api/peerconnection/RTCMediaConstraints.h",
"objc/api/peerconnection/RTCMediaSource.h",
"objc/api/peerconnection/RTCMediaStream.h",
"objc/api/peerconnection/RTCMediaStreamTrack.h",
"objc/api/peerconnection/RTCMetrics.h",
"objc/api/peerconnection/RTCMetricsSampleInfo.h",
"objc/api/peerconnection/RTCPeerConnection.h",
"objc/api/peerconnection/RTCPeerConnectionFactory.h",
"objc/api/peerconnection/RTCPeerConnectionFactoryOptions.h",
"objc/api/peerconnection/RTCRtcpParameters.h",
"objc/api/peerconnection/RTCRtpCodecParameters.h",
"objc/api/peerconnection/RTCRtpEncodingParameters.h",
"objc/api/peerconnection/RTCRtpHeaderExtension.h",
"objc/api/peerconnection/RTCRtpParameters.h",
"objc/api/peerconnection/RTCRtpReceiver.h",
"objc/api/peerconnection/RTCRtpSender.h",
"objc/api/peerconnection/RTCRtpTransceiver.h",
"objc/api/peerconnection/RTCDtmfSender.h",
"objc/api/peerconnection/RTCSSLAdapter.h",
"objc/api/peerconnection/RTCSessionDescription.h",
Add RTCStatisticsReport.h to WebRTC.framework. Bug: webrtc:11041 Change-Id: I2ae5a7db9697f70426feaf0c31ee4e0b9b654cc6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157800 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29554}
2019-10-21 11:25:18 +08:00
"objc/api/peerconnection/RTCStatisticsReport.h",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/api/peerconnection/RTCTracing.h",
"objc/api/peerconnection/RTCCertificate.h",
Promotoing webrtc::CryptoOptions to RTCConfiguration. With the expanding use cases for webrtc::CryptoOptions it makes more sense for it to be be available per peer connection instead of only as a factory option. To support backwards compatability for now this code will support the factory method of setting crypto options by default. However it will completely overwrite these settings if an RTCConfiguration.crypto_options is provided. Got LGTM offline from Sami, adding him to TBR if he has any further comments. TBR=sakal@webrtc.org Bug: webrtc:9891 Change-Id: I86914cab69284ad82afd7285fd84ec5f4f2c4986 Reviewed-on: https://webrtc-review.googlesource.com/c/107029 Commit-Queue: Benjamin Wright <benwright@webrtc.org> Reviewed-by: Seth Hampson <shampson@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25375}
2018-10-25 10:16:44 -07:00
"objc/api/peerconnection/RTCCryptoOptions.h",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/api/peerconnection/RTCVideoSource.h",
"objc/api/peerconnection/RTCVideoTrack.h",
Include i420 buffers in Obj-C framework again. These headers was lost in the cleanup CL for the Obj-C directories. This puts them back in the framework headers. Note that since the protocol and interface was split into two different headers, and all public framework headers are put into a flat directory structure, I had to rename the implementation files so they would not collide in the framework header directory. Bug: webrtc:9701 Change-Id: I42d4c1e02bdfa4e114575f527c4c42a19be8fb52 Reviewed-on: https://webrtc-review.googlesource.com/97330 Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24539}
2018-09-03 14:44:50 +02:00
"objc/api/video_codec/RTCVideoCodecConstants.h",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/api/video_codec/RTCVideoDecoderVP8.h",
"objc/api/video_codec/RTCVideoDecoderVP9.h",
Add AV1 encoder&decoder wrappers for iOS SDK. It is now possible to use AV1 encoder and decoder on iOS and test them in apps like AppRTCMobile. Bug: None Change-Id: Ifae221020e5abf3809010676862eecd9ffeec5e3 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/208400 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33378}
2021-03-03 12:29:42 +03:00
"objc/api/video_codec/RTCVideoDecoderAV1.h",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/api/video_codec/RTCVideoEncoderVP8.h",
"objc/api/video_codec/RTCVideoEncoderVP9.h",
Add AV1 encoder&decoder wrappers for iOS SDK. It is now possible to use AV1 encoder and decoder on iOS and test them in apps like AppRTCMobile. Bug: None Change-Id: Ifae221020e5abf3809010676862eecd9ffeec5e3 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/208400 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33378}
2021-03-03 12:29:42 +03:00
"objc/api/video_codec/RTCVideoEncoderAV1.h",
Include i420 buffers in Obj-C framework again. These headers was lost in the cleanup CL for the Obj-C directories. This puts them back in the framework headers. Note that since the protocol and interface was split into two different headers, and all public framework headers are put into a flat directory structure, I had to rename the implementation files so they would not collide in the framework header directory. Bug: webrtc:9701 Change-Id: I42d4c1e02bdfa4e114575f527c4c42a19be8fb52 Reviewed-on: https://webrtc-review.googlesource.com/97330 Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24539}
2018-09-03 14:44:50 +02:00
"objc/api/video_frame_buffer/RTCNativeI420Buffer.h",
"objc/api/video_frame_buffer/RTCNativeMutableI420Buffer.h",
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
]
ObjC SDK: Stop using built-in SW video codecs This CL removes the use of default built-in SW in the ObjC layer. If a client want to depend on the video SW codecs, they must inject them explicitly. Bug: webrtc:7925 Change-Id: If752e7f02109ff768dc5ec38d935203de85987c2 Reviewed-on: https://webrtc-review.googlesource.com/69800 Commit-Queue: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23073}
2018-04-13 15:36:43 +02:00
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
if (!build_with_chromium) {
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
common_objc_headers += [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/api/logging/RTCCallbackLogger.h",
"objc/api/peerconnection/RTCFileLogger.h",
Add new Logger to iOS SDK to be able to intercept logs and report them to the appropriate system Bug: webrtc:8695 Change-Id: I4f81529222dcaf3dded1a0ab93fabf5cda1fdef8 Reviewed-on: https://webrtc-review.googlesource.com/37001 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21821}
2018-01-30 15:46:13 +01:00
]
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
}
Reland of Adding backward compatibility header (patchset #1 id:1 of https://codereview.webrtc.org/2908143003/ ) Reason for revert: Take three of relanding this after all internal issues have been resolved. Original issue's description: > Revert of Adding backward compatibility header (patchset #1 id:1 of https://codereview.webrtc.org/2909923002/ ) > > Reason for revert: > Breaks downstream project. > > Original issue's description: > > Adding backward compatibility header > > > > This header will be removed ad soon as downstream projects will be > > updated. > > > > BUG=webrtc:4867 > > NOTRY=True > > TBR=kjellander@webrtc.org > > > > Review-Url: https://codereview.webrtc.org/2909923002 > > Cr-Commit-Position: refs/heads/master@{#18306} > > Committed: https://chromium.googlesource.com/external/webrtc/+/4fa8a97cc3268de73ad021ff56aaa9bf1a566ed4 > > TBR=kjellander@webrtc.org,magjed@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:4867 > > Review-Url: https://codereview.webrtc.org/2908143003 > Cr-Commit-Position: refs/heads/master@{#18308} > Committed: https://chromium.googlesource.com/external/webrtc/+/6684fdce93ff25a837117cd7a811a6d86cbe4b20 TBR=kjellander@webrtc.org,magjed@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4867 Review-Url: https://codereview.webrtc.org/2912773003 Cr-Commit-Position: refs/heads/master@{#18320}
2017-05-30 01:50:35 -07:00
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
sources = common_objc_headers
public_headers = common_objc_headers
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
ldflags = [
"-all_load",
"-install_name",
"@rpath/$output_name.framework/$output_name",
]
Actually move CoreVideoFrameBuffer from webrtc/common_video/ to webrtc/sdk/objc/ The previous reland https://codereview.webrtc.org/2860033002/ didn't actually move CoreVideoFrameBuffer because of a rebase mistake. This CL moves the files. BUG=None Review-Url: https://codereview.webrtc.org/2864303002 Cr-Commit-Position: refs/heads/master@{#18048}
2017-05-08 05:32:05 -07:00
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
deps = [
Rename all objc targets to be suffixed for consistency BUG=webrtc:6412 Review-Url: https://codereview.webrtc.org/3001023003 Cr-Commit-Position: refs/heads/master@{#19489}
2017-08-24 05:43:45 -07:00
":audio_objc",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
":base_objc",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
":default_codec_factory_objc",
Follow-up of 'Get WebRTC building for Mac Catalyst' This CL adds a missing "else" branch to add :metal_objc if the target is iOS/Catalist. Originally suggested https://webrtc-review.googlesource.com/c/src/+/224200/5#message-b43a38aa326df0133ae8f8af71c443d0c05098a8. Bug: webrtc:11516 Change-Id: I27746926a853cad9c2c7079f155dd858f04f1792 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245400 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#35732}
2022-01-19 08:43:17 +01:00
":metal_objc",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
":native_api",
":native_video",
":peerconnectionfactory_base_objc",
":videocapture_objc",
":videocodec_objc",
":videotoolbox_objc",
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
]
iOS: Get WebRTC building for Mac Catalyst - Add an option for disabling the OpenGL renderer - Change the build script to use correct header location - Use Metal compatibility for h264 CoreVideo buffers Bug: webrtc:11516 Change-Id: Ia34a9305648e75904ac36e69593ffefedd833bfb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/224200 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34426}
2021-07-06 12:16:41 -07:00
if (rtc_ios_macos_use_opengl_rendering) {
deps += [ ":opengl_ui_objc" ]
}
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
if (!build_with_chromium) {
deps += [
":callback_logger_objc",
":file_logger_objc",
]
}
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
Convert GN libs lists to frameworks GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: chromium:1052560 Change-Id: I263230ddd3c468061584423bba9e1f887503bcaa Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178601 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#31632}
2020-07-03 10:19:30 +02:00
frameworks = [
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
"AVFoundation.framework",
"CoreGraphics.framework",
"CoreMedia.framework",
]
Merge GN templates for iOS and MacOS framework creation The two GN templates are nearly identical, so merge them to reduce maintenance. Bug: webrtc:13949 Change-Id: I5f53ade5f9d09ce6f23a6cb29c9d39df4485a237 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/258380 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com> Cr-Commit-Position: refs/heads/main@{#36495}
2022-04-08 18:23:14 +09:00
configs = [
Broadcast extension for AppRTCMobile on iOS This provides an environment for testing out using WebRTC from an iOS extension. It implements a ReplayKit broadcast extension for live streaming games and screensharing. The extension is only supported on iOS 11+ and is guarded by a build flag. Bug: webrtc:9335 Change-Id: Id218d6c73ef7599f5953c5a1e0e62e5d0dc4f10b Reviewed-on: https://webrtc-review.googlesource.com/80000 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23504}
2018-06-04 10:24:37 +02:00
"..:common_objc",
":used_from_extension",
]
Actually move CoreVideoFrameBuffer from webrtc/common_video/ to webrtc/sdk/objc/ The previous reland https://codereview.webrtc.org/2860033002/ didn't actually move CoreVideoFrameBuffer because of a rebase mistake. This CL moves the files. BUG=None Review-Url: https://codereview.webrtc.org/2864303002 Cr-Commit-Position: refs/heads/master@{#18048}
2017-05-08 05:32:05 -07:00
Rename all objc targets to be suffixed for consistency BUG=webrtc:6412 Review-Url: https://codereview.webrtc.org/3001023003 Cr-Commit-Position: refs/heads/master@{#19489}
2017-08-24 05:43:45 -07:00
public_configs = [ ":common_config_objc" ]
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
}
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
bundle_data("ios_framework_bundle") {
Replace RTC_FALLTHROUGH with ABSL_FALLTHROUGH_INTENTED Bug: None Change-Id: I7287403f3fb13b8e30f92ca3cf1882b03bb53a6e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166176 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30283}
2020-01-16 14:41:10 +01:00
deps = [ "../sdk:framework_objc" ]
sources = [ "$root_build_dir/WebRTC.framework" ]
outputs = [ "{{bundle_resources_dir}}/Frameworks/{{source_file_part}}" ]
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
}
}
if (is_mac) {
Merge GN templates for iOS and MacOS framework creation The two GN templates are nearly identical, so merge them to reduce maintenance. Bug: webrtc:13949 Change-Id: I5f53ade5f9d09ce6f23a6cb29c9d39df4485a237 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/258380 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com> Cr-Commit-Position: refs/heads/main@{#36495}
2022-04-08 18:23:14 +09:00
apple_framework_bundle_with_umbrella_header("mac_framework_objc") {
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
info_plist = "objc/Info.plist"
output_name = "WebRTC"
Generate umbrella header for macOS framework. Similarly to how it is done for iOS. Bug: webrtc:9627 Change-Id: I7e4e3495d28a0a098531250bfdcf93d272e27b9d Reviewed-on: https://webrtc-review.googlesource.com/98162 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24594}
2018-09-05 16:29:27 +02:00
sources = [
"objc/api/peerconnection/RTCAudioSource.h",
"objc/api/peerconnection/RTCAudioTrack.h",
"objc/api/peerconnection/RTCCertificate.h",
"objc/api/peerconnection/RTCConfiguration.h",
Promotoing webrtc::CryptoOptions to RTCConfiguration. With the expanding use cases for webrtc::CryptoOptions it makes more sense for it to be be available per peer connection instead of only as a factory option. To support backwards compatability for now this code will support the factory method of setting crypto options by default. However it will completely overwrite these settings if an RTCConfiguration.crypto_options is provided. Got LGTM offline from Sami, adding him to TBR if he has any further comments. TBR=sakal@webrtc.org Bug: webrtc:9891 Change-Id: I86914cab69284ad82afd7285fd84ec5f4f2c4986 Reviewed-on: https://webrtc-review.googlesource.com/c/107029 Commit-Queue: Benjamin Wright <benwright@webrtc.org> Reviewed-by: Seth Hampson <shampson@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25375}
2018-10-25 10:16:44 -07:00
"objc/api/peerconnection/RTCCryptoOptions.h",
Generate umbrella header for macOS framework. Similarly to how it is done for iOS. Bug: webrtc:9627 Change-Id: I7e4e3495d28a0a098531250bfdcf93d272e27b9d Reviewed-on: https://webrtc-review.googlesource.com/98162 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24594}
2018-09-05 16:29:27 +02:00
"objc/api/peerconnection/RTCDataChannel.h",
"objc/api/peerconnection/RTCDataChannelConfiguration.h",
"objc/api/peerconnection/RTCDtmfSender.h",
"objc/api/peerconnection/RTCFieldTrials.h",
"objc/api/peerconnection/RTCIceCandidate.h",
Implement JNI and objc implementation for icecandidateerror event This CL adds the callback on ICE Candidate Error to the Android and the iOS SDKs. Spec: https://www.w3.org/TR/webrtc/#dom-rtcpeerconnection-onicecandidateerror Bug: webrtc:13446 Change-Id: I6e511aaa80f1aa8f4310d8518d1144d97470cd7e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239460 Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Henrik Andreassson <henrika@webrtc.org> Cr-Commit-Position: refs/heads/main@{#35531}
2021-11-30 19:01:43 +09:00
"objc/api/peerconnection/RTCIceCandidateErrorEvent.h",
Generate umbrella header for macOS framework. Similarly to how it is done for iOS. Bug: webrtc:9627 Change-Id: I7e4e3495d28a0a098531250bfdcf93d272e27b9d Reviewed-on: https://webrtc-review.googlesource.com/98162 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24594}
2018-09-05 16:29:27 +02:00
"objc/api/peerconnection/RTCIceServer.h",
"objc/api/peerconnection/RTCLegacyStatsReport.h",
"objc/api/peerconnection/RTCMediaConstraints.h",
"objc/api/peerconnection/RTCMediaSource.h",
"objc/api/peerconnection/RTCMediaStream.h",
"objc/api/peerconnection/RTCMediaStreamTrack.h",
"objc/api/peerconnection/RTCMetrics.h",
"objc/api/peerconnection/RTCMetricsSampleInfo.h",
"objc/api/peerconnection/RTCPeerConnection.h",
"objc/api/peerconnection/RTCPeerConnectionFactory.h",
"objc/api/peerconnection/RTCPeerConnectionFactoryOptions.h",
"objc/api/peerconnection/RTCRtcpParameters.h",
"objc/api/peerconnection/RTCRtpCodecParameters.h",
"objc/api/peerconnection/RTCRtpEncodingParameters.h",
"objc/api/peerconnection/RTCRtpHeaderExtension.h",
"objc/api/peerconnection/RTCRtpParameters.h",
"objc/api/peerconnection/RTCRtpReceiver.h",
"objc/api/peerconnection/RTCRtpSender.h",
"objc/api/peerconnection/RTCRtpTransceiver.h",
"objc/api/peerconnection/RTCSSLAdapter.h",
"objc/api/peerconnection/RTCSessionDescription.h",
Add missing header file in mac framework target Bug: webrtc:13025 Change-Id: I16c31717dd8ffa4075386b403827729099b567da Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227163 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34592}
2021-07-28 23:09:14 +02:00
"objc/api/peerconnection/RTCStatisticsReport.h",
Generate umbrella header for macOS framework. Similarly to how it is done for iOS. Bug: webrtc:9627 Change-Id: I7e4e3495d28a0a098531250bfdcf93d272e27b9d Reviewed-on: https://webrtc-review.googlesource.com/98162 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24594}
2018-09-05 16:29:27 +02:00
"objc/api/peerconnection/RTCTracing.h",
"objc/api/peerconnection/RTCVideoSource.h",
"objc/api/peerconnection/RTCVideoTrack.h",
Add AV1 encoder&decoder wrappers for iOS SDK. It is now possible to use AV1 encoder and decoder on iOS and test them in apps like AppRTCMobile. Bug: None Change-Id: Ifae221020e5abf3809010676862eecd9ffeec5e3 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/208400 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33378}
2021-03-03 12:29:42 +03:00
"objc/api/video_codec/RTCVideoDecoderAV1.h",
Generate umbrella header for macOS framework. Similarly to how it is done for iOS. Bug: webrtc:9627 Change-Id: I7e4e3495d28a0a098531250bfdcf93d272e27b9d Reviewed-on: https://webrtc-review.googlesource.com/98162 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24594}
2018-09-05 16:29:27 +02:00
"objc/api/video_codec/RTCVideoDecoderVP8.h",
"objc/api/video_codec/RTCVideoDecoderVP9.h",
Add AV1 encoder&decoder wrappers for iOS SDK. It is now possible to use AV1 encoder and decoder on iOS and test them in apps like AppRTCMobile. Bug: None Change-Id: Ifae221020e5abf3809010676862eecd9ffeec5e3 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/208400 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33378}
2021-03-03 12:29:42 +03:00
"objc/api/video_codec/RTCVideoEncoderAV1.h",
Generate umbrella header for macOS framework. Similarly to how it is done for iOS. Bug: webrtc:9627 Change-Id: I7e4e3495d28a0a098531250bfdcf93d272e27b9d Reviewed-on: https://webrtc-review.googlesource.com/98162 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24594}
2018-09-05 16:29:27 +02:00
"objc/api/video_codec/RTCVideoEncoderVP8.h",
"objc/api/video_codec/RTCVideoEncoderVP9.h",
"objc/api/video_frame_buffer/RTCNativeI420Buffer.h",
"objc/api/video_frame_buffer/RTCNativeMutableI420Buffer.h",
"objc/base/RTCCodecSpecificInfo.h",
"objc/base/RTCEncodedImage.h",
"objc/base/RTCI420Buffer.h",
"objc/base/RTCLogging.h",
"objc/base/RTCMacros.h",
"objc/base/RTCMutableI420Buffer.h",
"objc/base/RTCMutableYUVPlanarBuffer.h",
Expose RTCSSLCertificateVerifier from iOS SDK. Bug: webrtc:11710 Change-Id: I825c6350a71b2ff180520f8643cbd4d6febdc883 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/254821 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Yura Yaroshevich <yura.yaroshevich@gmail.com> Cr-Commit-Position: refs/heads/main@{#36284}
2022-03-11 09:22:08 +01:00
"objc/base/RTCSSLCertificateVerifier.h",
Generate umbrella header for macOS framework. Similarly to how it is done for iOS. Bug: webrtc:9627 Change-Id: I7e4e3495d28a0a098531250bfdcf93d272e27b9d Reviewed-on: https://webrtc-review.googlesource.com/98162 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24594}
2018-09-05 16:29:27 +02:00
"objc/base/RTCVideoCapturer.h",
"objc/base/RTCVideoCodecInfo.h",
"objc/base/RTCVideoDecoder.h",
"objc/base/RTCVideoDecoderFactory.h",
"objc/base/RTCVideoEncoder.h",
"objc/base/RTCVideoEncoderFactory.h",
"objc/base/RTCVideoEncoderQpThresholds.h",
"objc/base/RTCVideoEncoderSettings.h",
"objc/base/RTCVideoFrame.h",
"objc/base/RTCVideoFrameBuffer.h",
"objc/base/RTCVideoRenderer.h",
"objc/base/RTCYUVPlanarBuffer.h",
"objc/components/capturer/RTCCameraVideoCapturer.h",
"objc/components/capturer/RTCFileVideoCapturer.h",
"objc/components/renderer/metal/RTCMTLNSVideoView.h",
"objc/components/renderer/opengl/RTCNSGLVideoView.h",
"objc/components/renderer/opengl/RTCVideoViewShading.h",
"objc/components/video_codec/RTCCodecSpecificInfoH264.h",
"objc/components/video_codec/RTCDefaultVideoDecoderFactory.h",
"objc/components/video_codec/RTCDefaultVideoEncoderFactory.h",
"objc/components/video_codec/RTCH264ProfileLevelId.h",
"objc/components/video_codec/RTCVideoDecoderFactoryH264.h",
"objc/components/video_codec/RTCVideoDecoderH264.h",
"objc/components/video_codec/RTCVideoEncoderFactoryH264.h",
"objc/components/video_codec/RTCVideoEncoderH264.h",
"objc/components/video_frame_buffer/RTCCVPixelBuffer.h",
"objc/helpers/RTCDispatcher.h",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
]
Generate umbrella header for macOS framework. Similarly to how it is done for iOS. Bug: webrtc:9627 Change-Id: I7e4e3495d28a0a098531250bfdcf93d272e27b9d Reviewed-on: https://webrtc-review.googlesource.com/98162 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24594}
2018-09-05 16:29:27 +02:00
if (!build_with_chromium) {
sources += [
"objc/api/logging/RTCCallbackLogger.h",
"objc/api/peerconnection/RTCFileLogger.h",
]
}
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
deps = [
":base_objc",
":default_codec_factory_objc",
":native_api",
":native_video",
iOS: Get WebRTC building for Mac Catalyst - Add an option for disabling the OpenGL renderer - Change the build script to use correct header location - Use Metal compatibility for h264 CoreVideo buffers Bug: webrtc:11516 Change-Id: Ia34a9305648e75904ac36e69593ffefedd833bfb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/224200 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34426}
2021-07-06 12:16:41 -07:00
":opengl_ui_objc",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
":peerconnectionfactory_base_objc",
":videocapture_objc",
":videocodec_objc",
":videotoolbox_objc",
]
if (!build_with_chromium) {
deps += [
":callback_logger_objc",
":file_logger_objc",
]
}
Convert GN libs lists to frameworks GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: chromium:1052560 Change-Id: I263230ddd3c468061584423bba9e1f887503bcaa Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178601 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#31632}
2020-07-03 10:19:30 +02:00
frameworks = [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"AVFoundation.framework",
"CoreGraphics.framework",
"CoreMedia.framework",
"OpenGL.framework",
]
Generate umbrella header for macOS framework. Similarly to how it is done for iOS. Bug: webrtc:9627 Change-Id: I7e4e3495d28a0a098531250bfdcf93d272e27b9d Reviewed-on: https://webrtc-review.googlesource.com/98162 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24594}
2018-09-05 16:29:27 +02:00
configs = [ "..:common_objc" ]
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
public_configs = [ ":common_config_objc" ]
}
bundle_data("mac_framework_bundle") {
Replace RTC_FALLTHROUGH with ABSL_FALLTHROUGH_INTENTED Bug: None Change-Id: I7287403f3fb13b8e30f92ca3cf1882b03bb53a6e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166176 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30283}
2020-01-16 14:41:10 +01:00
deps = [ "../sdk:mac_framework_objc" ]
sources = [ "$root_build_dir/WebRTC.framework" ]
outputs = [ "{{bundle_contents_dir}}/Frameworks/{{source_file_part}}" ]
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
}
Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2911053002/ ) Reason for revert: Take three of relanding this after all internal issues have been resolved. Original issue's description: > Revert of Split iOS sdk in to separate targets (patchset #3 id:320001 of https://codereview.webrtc.org/2893843003/ ) > > Reason for revert: > Breaks downstream project. > > Original issue's description: > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2893593002/ ) > > > > Reason for revert: > > Take two of fixing downstream issues? > > > > Original issue's description: > > > Revert of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890733003/ ) > > > > > > Reason for revert: > > > Still problems with downstream projects > > > > > > Original issue's description: > > > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890513002/ ) > > > > > > > > Reason for revert: > > > > Fixing downstream breakages > > > > > > > > Original issue's description: > > > > > Revert of Split iOS sdk in to separate targets (patchset #13 id:280001 of https://codereview.webrtc.org/2862543002/ ) > > > > > > > > > > Reason for revert: > > > > > Breaking downstream projects. > > > > > > > > > > Original issue's description: > > > > > > Split iOS sdk in to separate targets > > > > > > > > > > > > This CL splits the iOS sdk into separate static libraries for video, > > > > > > audio, ui, common, and peerconnection-related code. This will in the > > > > > > future make it easier to compile WebRTC without unneeded components. > > > > > > > > > > > > BUG=webrtc:4867 > > > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2862543002 > > > > > > Cr-Commit-Position: refs/heads/master@{#18166} > > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/52c83fe7102f566cf35a7533092873d58b38f426 > > > > > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,kthelgason@webrtc.org > > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > > NOPRESUBMIT=true > > > > > NOTREECHECKS=true > > > > > NOTRY=true > > > > > BUG=webrtc:4867 > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2890513002 > > > > > Cr-Commit-Position: refs/heads/master@{#18170} > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/9756238084707787f735e1294e896e462e459717 > > > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > NOPRESUBMIT=true > > > > NOTREECHECKS=true > > > > NOTRY=true > > > > BUG=webrtc:4867 > > > > > > > > Review-Url: https://codereview.webrtc.org/2890733003 > > > > Cr-Commit-Position: refs/heads/master@{#18174} > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/d51e042492bedd057bc0cac7828979d5c7369cea > > > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=webrtc:4867 > > > > > > Review-Url: https://codereview.webrtc.org/2893593002 > > > Cr-Commit-Position: refs/heads/master@{#18182} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/37144b214e2baf62ecb262ab878dde8c59cdd6a3 > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=webrtc:4867 > > > > Review-Url: https://codereview.webrtc.org/2893843003 > > Cr-Commit-Position: refs/heads/master@{#18303} > > Committed: https://chromium.googlesource.com/external/webrtc/+/580c3522d294c877adfe555048c675bd8d166657 > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org,kthelgason@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:4867 > > Review-Url: https://codereview.webrtc.org/2911053002 > Cr-Commit-Position: refs/heads/master@{#18309} > Committed: https://chromium.googlesource.com/external/webrtc/+/af5c05540cc8208f682cafe88c5c16a505479196 TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org,mbonadei@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4867 Review-Url: https://codereview.webrtc.org/2913753003 Cr-Commit-Position: refs/heads/master@{#18319}
2017-05-30 01:48:47 -07:00
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("wrapped_native_codec_objc") {
Fix native api in preparation for native_api example. Add native api conversions for video frames and video renderer. This also requires some changes to sdk/BUILD to avoid cyclic dependencies. Bug: webrtc:8832 Change-Id: Ibf21e63bdcae195dcb61d63f9262e6a8dc4fa790 Reviewed-on: https://webrtc-review.googlesource.com/57142 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22340}
2018-03-07 10:32:03 +01:00
sources = [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/api/video_codec/RTCWrappedNativeVideoDecoder.h",
"objc/api/video_codec/RTCWrappedNativeVideoDecoder.mm",
"objc/api/video_codec/RTCWrappedNativeVideoEncoder.h",
"objc/api/video_codec/RTCWrappedNativeVideoEncoder.mm",
Fix native api in preparation for native_api example. Add native api conversions for video frames and video renderer. This also requires some changes to sdk/BUILD to avoid cyclic dependencies. Bug: webrtc:8832 Change-Id: Ibf21e63bdcae195dcb61d63f9262e6a8dc4fa790 Reviewed-on: https://webrtc-review.googlesource.com/57142 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22340}
2018-03-07 10:32:03 +01:00
]
configs += [ "..:common_objc" ]
public_configs = [ ":common_config_objc" ]
deps = [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
":base_objc",
":helpers_objc",
Fix native api in preparation for native_api example. Add native api conversions for video frames and video renderer. This also requires some changes to sdk/BUILD to avoid cyclic dependencies. Bug: webrtc:8832 Change-Id: Ibf21e63bdcae195dcb61d63f9262e6a8dc4fa790 Reviewed-on: https://webrtc-review.googlesource.com/57142 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22340}
2018-03-07 10:32:03 +01:00
"../api/video_codecs:video_codecs_api",
"../media:rtc_media_base",
]
}
Create experimental Obj-C++ API. This can be used to wrap Objective-C components in C++ classes, so users can use the WebRTC C++ API directly together with the iOS specific components provided by our SDK. Bug: webrtc:8832 Change-Id: I6d34f7ec62d51df8d3a5340a2e17d30ae73e13e8 Reviewed-on: https://webrtc-review.googlesource.com/46162 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21850}
2018-02-01 15:47:05 +01:00
# The native API is currently experimental and may change without notice.
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("native_api") {
Create experimental Obj-C++ API. This can be used to wrap Objective-C components in C++ classes, so users can use the WebRTC C++ API directly together with the iOS specific components provided by our SDK. Bug: webrtc:8832 Change-Id: I6d34f7ec62d51df8d3a5340a2e17d30ae73e13e8 Reviewed-on: https://webrtc-review.googlesource.com/46162 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21850}
2018-02-01 15:47:05 +01:00
visibility = [ "*" ]
Remove legacy video codec factories. Removes the deprecated video codec factories and the related flag and helper classes. Bug: webrtc:7925 Change-Id: I0a6d1666ece9ad074fefc79b626ba241765e1b98 Reviewed-on: https://webrtc-review.googlesource.com/c/113940 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Steve Anton <steveanton@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26245}
2019-01-14 14:23:23 +01:00
allow_poison = [ "audio_codecs" ] # TODO(bugs.webrtc.org/8396): Remove.
Create experimental Obj-C++ API. This can be used to wrap Objective-C components in C++ classes, so users can use the WebRTC C++ API directly together with the iOS specific components provided by our SDK. Bug: webrtc:8832 Change-Id: I6d34f7ec62d51df8d3a5340a2e17d30ae73e13e8 Reviewed-on: https://webrtc-review.googlesource.com/46162 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21850}
2018-02-01 15:47:05 +01:00
sources = [
Implement network monitor for iOS. Notably, this should detect whether an interface is "available" or not, which should prevent the failure is with dual SIM card setups. This is gated behind a field trial for now, to ensure this doesn't cause any regressions due to false negatives (interfaces that are usable but not listed as available by NWPathMonitor). Bug: webrtc:10966 Change-Id: Ia3942c4c57b525d08d8b340e2325f3705cfd0304 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180923 Commit-Queue: Taylor <deadbeef@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Jonas Oreland <jonaso@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31977}
2020-08-19 16:41:54 -07:00
"objc/native/api/network_monitor_factory.h",
"objc/native/api/network_monitor_factory.mm",
Expose RTCSSLCertificateVerifier from iOS SDK. Bug: webrtc:11710 Change-Id: I825c6350a71b2ff180520f8643cbd4d6febdc883 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/254821 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Yura Yaroshevich <yura.yaroshevich@gmail.com> Cr-Commit-Position: refs/heads/main@{#36284}
2022-03-11 09:22:08 +01:00
"objc/native/api/ssl_certificate_verifier.h",
"objc/native/api/ssl_certificate_verifier.mm",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/native/api/video_capturer.h",
"objc/native/api/video_capturer.mm",
"objc/native/api/video_decoder_factory.h",
"objc/native/api/video_decoder_factory.mm",
"objc/native/api/video_encoder_factory.h",
"objc/native/api/video_encoder_factory.mm",
"objc/native/api/video_frame.h",
"objc/native/api/video_frame.mm",
"objc/native/api/video_frame_buffer.h",
"objc/native/api/video_frame_buffer.mm",
"objc/native/api/video_renderer.h",
"objc/native/api/video_renderer.mm",
Create experimental Obj-C++ API. This can be used to wrap Objective-C components in C++ classes, so users can use the WebRTC C++ API directly together with the iOS specific components provided by our SDK. Bug: webrtc:8832 Change-Id: I6d34f7ec62d51df8d3a5340a2e17d30ae73e13e8 Reviewed-on: https://webrtc-review.googlesource.com/46162 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21850}
2018-02-01 15:47:05 +01:00
]
configs += [ "..:common_objc" ]
public_configs = [ ":common_config_objc" ]
deps = [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
":base_objc",
Create experimental Obj-C++ API. This can be used to wrap Objective-C components in C++ classes, so users can use the WebRTC C++ API directly together with the iOS specific components provided by our SDK. Bug: webrtc:8832 Change-Id: I6d34f7ec62d51df8d3a5340a2e17d30ae73e13e8 Reviewed-on: https://webrtc-review.googlesource.com/46162 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21850}
2018-02-01 15:47:05 +01:00
":native_video",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
":videoframebuffer_objc",
Add an example app for iOS native API. Demonstrates how to use the iOS native API to wrap components into C++ classes. This CL also introduces a native API wrapper for the capturer. The C++ code is forked from the corresponding CL for Android at https://webrtc-review.googlesource.com/c/src/+/60540 Bug: webrtc:8832 Change-Id: I12d9f30e701c0222628e329218f6d5bfca26e6e0 Reviewed-on: https://webrtc-review.googlesource.com/61422 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22484}
2018-03-15 09:41:03 +01:00
"../api:libjingle_peerconnection_api",
Move rtc::make_ref_counted to api/ Bug: webrtc:12701 Change-Id: If49095b101c1a1763c2a44a0284c0d670cce953f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265390 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37219}
2022-06-14 15:48:26 +02:00
"../api:make_ref_counted",
New build target api:media_interface Bug: webrtc:8733 Change-Id: I84bbefb1a5ef8e592db29b79499d60ac80c23464 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153180 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Steve Anton <steveanton@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29234}
2019-09-17 14:30:41 +02:00
"../api:media_stream_interface",
Remove rtc_base/scoped_ref_ptr.h. The type rtc::scoped_refptr<T> is now part of api/. Please include it from api/scoped_refptr.h. More info: See: https://groups.google.com/forum/#!topic/discuss-webrtc/Mme2MSz4z4o. Bug: webrtc:9887, webrtc:8205 No-Try: True Change-Id: Ic6c7c81e226e59f12f7933e472f573ae097b55bf Reviewed-on: https://webrtc-review.googlesource.com/c/119041 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26414}
2019-01-25 20:26:48 +01:00
"../api:scoped_refptr",
New file api/video/BUILD.gn Build targets involving files under api/video/ are moved into this file, from api/BUILD.gn. In addition, drop "_api" part of target names, and move the header file api/videosinkinterface.h to api/video/video_sink_interface.h. Bug: webrtc:9253 Change-Id: I2896d3f063db8dff902bc29738578395b2fcc155 Reviewed-on: https://webrtc-review.googlesource.com/75500 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23207}
2018-05-11 11:15:30 +02:00
"../api/video:video_frame",
Prepare for splitting the api/video:video_frames build rule. This change is part of a change to break the dependency between "api:rtp_headers" and "api/video:video_frame". It does so by first creating an empty "api/video:video_rtp_headers" build rule so that downstream projects can be fixed before moving the source files. Bug: webrtc:10668 Change-Id: I81aa6edfef3639b457a40aa93de048e62cbfd8ef Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140291 Commit-Queue: Chen Xing <chxg@google.com> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28209}
2019-06-10 12:59:38 +02:00
"../api/video:video_rtp_headers",
Create experimental Obj-C++ API. This can be used to wrap Objective-C components in C++ classes, so users can use the WebRTC C++ API directly together with the iOS specific components provided by our SDK. Bug: webrtc:8832 Change-Id: I6d34f7ec62d51df8d3a5340a2e17d30ae73e13e8 Reviewed-on: https://webrtc-review.googlesource.com/46162 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21850}
2018-02-01 15:47:05 +01:00
"../api/video_codecs:video_codecs_api",
"../common_video",
Cleanup BUILD.gn files from imports like foo:foo Repalce all occurrences of foo:foo in deps with just foo in BUILD.gn files. Done with Sublime regex replace. Find: \b([-a-zA-Z0-9_]+):+\1\b In: *.gn Replace with: \1 Bug: None Change-Id: I40aba1b14face687a595b852ffe443cb20197611 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127899 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27225}
2019-03-21 13:35:10 +01:00
"../rtc_base",
Cleanup rtc_base_approved target Removed all unused or transitional parts Bug: webrtc:9838 Change-Id: I6bc14e4e0ac09ab27e4d739ac76bb6a4dfff2cb7 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260140 Commit-Queue: Florent Castelli <orphis@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36741}
2022-04-26 22:54:59 +02:00
"../rtc_base:buffer",
Remove //rtc_base:logging from public deps Bug: webrtc:8603 Change-Id: I2704da8618f88032adac7ae9eb2a0f47fce4a836 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257908 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Florent Castelli <orphis@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36443}
2022-04-04 15:06:30 +02:00
"../rtc_base:logging",
Reland "Refactor rtc_base build targets." This is a reland of 69241a93fb14f6527a26d5c94dde879013012d2a Fix: The problem was related to NO_MAIN_THREAD_WRAPPING, which affects https://source.chromium.org/chromium/chromium/src/+/master:third_party/webrtc/rtc_base/thread.cc;l=257-263;drc=7acc2d9fe3a6e3c4d8881d2bdfc9b8968a724cd5. The original CL didn't attach the definition of the macro NO_MAIN_THREAD_WRAPPING when building for Chromium (which doesn't have to be related to //rtc_base anymore but to //rtc_base:threading). Original change's description: > Refactor rtc_base build targets. > > The "//rtc_base:rtc_base" build target has historically been one of the > biggest targets in the WebRTC build. Big targets are the main source of > circular dependencies and non-API types leakage. > > This CL is a step forward into splitting "//rtc_base:rtc_base" into > smaller targets (as originally started in 2018). > > The only non-automated changes are (like re-wiring the build system): > * The creation of //rtc_base/async_resolver.{h,cc} which allows to > break a circular dependency (is has been extracted from > //rtc_base/net_helpers.{h,cc}). > * The creation of //rtc_base/internal/default_socket_server.{h,cc} to > break another circular dependency. > > Bug: webrtc:9987 > Change-Id: I0c8f5e7efe2c8fd8e6bffa0d6dd2dd494cf3df02 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/196903 > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#32941} Bug: webrtc:9987 Change-Id: I7cdf49d2aac8357f1f50f90010bf2c2f62fa19f6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/202021 Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33001}
2021-01-15 10:41:01 +01:00
"../rtc_base:threading",
Create experimental Obj-C++ API. This can be used to wrap Objective-C components in C++ classes, so users can use the WebRTC C++ API directly together with the iOS specific components provided by our SDK. Bug: webrtc:8832 Change-Id: I6d34f7ec62d51df8d3a5340a2e17d30ae73e13e8 Reviewed-on: https://webrtc-review.googlesource.com/46162 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21850}
2018-02-01 15:47:05 +01:00
]
Implement network monitor for iOS. Notably, this should detect whether an interface is "available" or not, which should prevent the failure is with dual SIM card setups. This is gated behind a field trial for now, to ensure this doesn't cause any regressions due to false negatives (interfaces that are usable but not listed as available by NWPathMonitor). Bug: webrtc:10966 Change-Id: Ia3942c4c57b525d08d8b340e2325f3705cfd0304 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180923 Commit-Queue: Taylor <deadbeef@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Jonas Oreland <jonaso@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31977}
2020-08-19 16:41:54 -07:00
if (is_ios) {
deps += [ ":native_network_monitor" ]
}
Use absl_deps in order to preapre to the Abseil component build release. Bug: webrtc:1046390 Change-Id: Ia35545599de23b1a2c2d8be2d53469af7ac16f1d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176502 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31463}
2020-06-05 14:30:41 +02:00
absl_deps = [ "//third_party/abseil-cpp/absl/memory" ]
Create experimental Obj-C++ API. This can be used to wrap Objective-C components in C++ classes, so users can use the WebRTC C++ API directly together with the iOS specific components provided by our SDK. Bug: webrtc:8832 Change-Id: I6d34f7ec62d51df8d3a5340a2e17d30ae73e13e8 Reviewed-on: https://webrtc-review.googlesource.com/46162 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21850}
2018-02-01 15:47:05 +01:00
}
Implement network monitor for iOS. Notably, this should detect whether an interface is "available" or not, which should prevent the failure is with dual SIM card setups. This is gated behind a field trial for now, to ensure this doesn't cause any regressions due to false negatives (interfaces that are usable but not listed as available by NWPathMonitor). Bug: webrtc:10966 Change-Id: Ia3942c4c57b525d08d8b340e2325f3705cfd0304 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180923 Commit-Queue: Taylor <deadbeef@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Jonas Oreland <jonaso@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31977}
2020-08-19 16:41:54 -07:00
if (is_ios) {
rtc_library("native_network_monitor") {
visibility = [ "*" ]
sources = [
"objc/native/src/objc_network_monitor.h",
"objc/native/src/objc_network_monitor.mm",
]
deps = [
":network_monitor_objc",
":network_monitor_observer",
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 12/inf rename WebRtcKeyValueConfig to FieldTrialsView Bug: webrtc:10335 Change-Id: If725bd498c4c3daf144bee638230fa089fdde833 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256965 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Jonas Oreland <jonaso@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36365}
2022-03-29 11:04:48 +02:00
"../api:field_trials_view",
Use SequenceChecker from public API Bug: webrtc:12419 Change-Id: I00cca16a0ec70246156ba00b97aa7ae5ccbf5364 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/205323 Commit-Queue: Artem Titov <titovartem@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33220}
2021-02-10 14:31:24 +01:00
"../api:sequence_checker",
Move to_queued_task.h and pending_task_safety_flag.h into public API Bug: b/235812579 Change-Id: I9fa3dc4a65044df8b44fff4e9bfeac7233fa381c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266080 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37248}
2022-06-16 21:27:45 +02:00
"../api/task_queue:pending_task_safety_flag",
Implement network monitor for iOS. Notably, this should detect whether an interface is "available" or not, which should prevent the failure is with dual SIM card setups. This is gated behind a field trial for now, to ensure this doesn't cause any regressions due to false negatives (interfaces that are usable but not listed as available by NWPathMonitor). Bug: webrtc:10966 Change-Id: Ia3942c4c57b525d08d8b340e2325f3705cfd0304 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180923 Commit-Queue: Taylor <deadbeef@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Jonas Oreland <jonaso@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31977}
2020-08-19 16:41:54 -07:00
"../rtc_base",
Remove //rtc_base:logging from public deps Bug: webrtc:8603 Change-Id: I2704da8618f88032adac7ae9eb2a0f47fce4a836 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257908 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Florent Castelli <orphis@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36443}
2022-04-04 15:06:30 +02:00
"../rtc_base:logging",
Remove //rtc_base:macromagic from public deps Bug: webrtc:8603 Change-Id: I9708df48c9bde9f86ba2d1a92a278bb0d09f3865 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257909 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Florent Castelli <orphis@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36444}
2022-04-04 15:18:46 +02:00
"../rtc_base:macromagic",
Remove //rtc_base:stringutils from public deps Bug: webrtc:8603 Change-Id: Ic2dfbe28d310cb4b35983b73e895fc95e8439669 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257913 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Florent Castelli <orphis@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36453}
2022-04-04 17:14:02 +02:00
"../rtc_base:stringutils",
Reland "Refactor rtc_base build targets." This is a reland of 69241a93fb14f6527a26d5c94dde879013012d2a Fix: The problem was related to NO_MAIN_THREAD_WRAPPING, which affects https://source.chromium.org/chromium/chromium/src/+/master:third_party/webrtc/rtc_base/thread.cc;l=257-263;drc=7acc2d9fe3a6e3c4d8881d2bdfc9b8968a724cd5. The original CL didn't attach the definition of the macro NO_MAIN_THREAD_WRAPPING when building for Chromium (which doesn't have to be related to //rtc_base anymore but to //rtc_base:threading). Original change's description: > Refactor rtc_base build targets. > > The "//rtc_base:rtc_base" build target has historically been one of the > biggest targets in the WebRTC build. Big targets are the main source of > circular dependencies and non-API types leakage. > > This CL is a step forward into splitting "//rtc_base:rtc_base" into > smaller targets (as originally started in 2018). > > The only non-automated changes are (like re-wiring the build system): > * The creation of //rtc_base/async_resolver.{h,cc} which allows to > break a circular dependency (is has been extracted from > //rtc_base/net_helpers.{h,cc}). > * The creation of //rtc_base/internal/default_socket_server.{h,cc} to > break another circular dependency. > > Bug: webrtc:9987 > Change-Id: I0c8f5e7efe2c8fd8e6bffa0d6dd2dd494cf3df02 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/196903 > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#32941} Bug: webrtc:9987 Change-Id: I7cdf49d2aac8357f1f50f90010bf2c2f62fa19f6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/202021 Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33001}
2021-01-15 10:41:01 +01:00
"../rtc_base:threading",
Implement network monitor for iOS. Notably, this should detect whether an interface is "available" or not, which should prevent the failure is with dual SIM card setups. This is gated behind a field trial for now, to ensure this doesn't cause any regressions due to false negatives (interfaces that are usable but not listed as available by NWPathMonitor). Bug: webrtc:10966 Change-Id: Ia3942c4c57b525d08d8b340e2325f3705cfd0304 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180923 Commit-Queue: Taylor <deadbeef@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Jonas Oreland <jonaso@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31977}
2020-08-19 16:41:54 -07:00
]
Adopt absl::string_view in function parameters under rtc_base/ This is part of a large-scale effort to increase adoption of absl::string_view across the WebRTC code base. This CL converts the majority of "const std::string&"s in function parameters under rtc_base/ to absl::string_view. Bug: webrtc:13579 Change-Id: I2b1e3776aa42326aa405f76bb324a2d233b21dca Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/254081 Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Xavier Lepaul‎ <xalep@webrtc.org> Reviewed-by: Anders Lilienthal <andersc@webrtc.org> Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Ali Tofigh <alito@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36239}
2022-03-17 15:47:49 +01:00
absl_deps = [ "//third_party/abseil-cpp/absl/strings" ]
Implement network monitor for iOS. Notably, this should detect whether an interface is "available" or not, which should prevent the failure is with dual SIM card setups. This is gated behind a field trial for now, to ensure this doesn't cause any regressions due to false negatives (interfaces that are usable but not listed as available by NWPathMonitor). Bug: webrtc:10966 Change-Id: Ia3942c4c57b525d08d8b340e2325f3705cfd0304 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180923 Commit-Queue: Taylor <deadbeef@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Jonas Oreland <jonaso@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31977}
2020-08-19 16:41:54 -07:00
}
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("native_video") {
Create experimental Obj-C++ API. This can be used to wrap Objective-C components in C++ classes, so users can use the WebRTC C++ API directly together with the iOS specific components provided by our SDK. Bug: webrtc:8832 Change-Id: I6d34f7ec62d51df8d3a5340a2e17d30ae73e13e8 Reviewed-on: https://webrtc-review.googlesource.com/46162 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21850}
2018-02-01 15:47:05 +01:00
sources = [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/native/src/objc_frame_buffer.h",
"objc/native/src/objc_frame_buffer.mm",
"objc/native/src/objc_video_decoder_factory.h",
"objc/native/src/objc_video_decoder_factory.mm",
"objc/native/src/objc_video_encoder_factory.h",
"objc/native/src/objc_video_encoder_factory.mm",
"objc/native/src/objc_video_frame.h",
"objc/native/src/objc_video_frame.mm",
"objc/native/src/objc_video_renderer.h",
"objc/native/src/objc_video_renderer.mm",
"objc/native/src/objc_video_track_source.h",
"objc/native/src/objc_video_track_source.mm",
Create experimental Obj-C++ API. This can be used to wrap Objective-C components in C++ classes, so users can use the WebRTC C++ API directly together with the iOS specific components provided by our SDK. Bug: webrtc:8832 Change-Id: I6d34f7ec62d51df8d3a5340a2e17d30ae73e13e8 Reviewed-on: https://webrtc-review.googlesource.com/46162 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21850}
2018-02-01 15:47:05 +01:00
]
configs += [ "..:common_objc" ]
public_configs = [ ":common_config_objc" ]
deps = [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
":base_native_additions_objc",
":base_objc",
":helpers_objc",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
":videocodec_objc",
":videoframebuffer_objc",
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
":vpx_codec_constants",
Fix native api in preparation for native_api example. Add native api conversions for video frames and video renderer. This also requires some changes to sdk/BUILD to avoid cyclic dependencies. Bug: webrtc:8832 Change-Id: Ibf21e63bdcae195dcb61d63f9262e6a8dc4fa790 Reviewed-on: https://webrtc-review.googlesource.com/57142 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22340}
2018-03-07 10:32:03 +01:00
":wrapped_native_codec_objc",
Move rtc::make_ref_counted to api/ Bug: webrtc:12701 Change-Id: If49095b101c1a1763c2a44a0284c0d670cce953f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265390 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37219}
2022-06-14 15:48:26 +02:00
"../api:make_ref_counted",
New file api/video/BUILD.gn Build targets involving files under api/video/ are moved into this file, from api/BUILD.gn. In addition, drop "_api" part of target names, and move the header file api/videosinkinterface.h to api/video/video_sink_interface.h. Bug: webrtc:9253 Change-Id: I2896d3f063db8dff902bc29738578395b2fcc155 Reviewed-on: https://webrtc-review.googlesource.com/75500 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23207}
2018-05-11 11:15:30 +02:00
"../api/video:video_frame",
Prepare for splitting the api/video:video_frames build rule. This change is part of a change to break the dependency between "api:rtp_headers" and "api/video:video_frame". It does so by first creating an empty "api/video:video_rtp_headers" build rule so that downstream projects can be fixed before moving the source files. Bug: webrtc:10668 Change-Id: I81aa6edfef3639b457a40aa93de048e62cbfd8ef Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140291 Commit-Queue: Chen Xing <chxg@google.com> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28209}
2019-06-10 12:59:38 +02:00
"../api/video:video_rtp_headers",
Create experimental Obj-C++ API. This can be used to wrap Objective-C components in C++ classes, so users can use the WebRTC C++ API directly together with the iOS specific components provided by our SDK. Bug: webrtc:8832 Change-Id: I6d34f7ec62d51df8d3a5340a2e17d30ae73e13e8 Reviewed-on: https://webrtc-review.googlesource.com/46162 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21850}
2018-02-01 15:47:05 +01:00
"../api/video_codecs:video_codecs_api",
"../common_video",
"../media:rtc_audio_video",
"../media:rtc_media_base",
"../modules/video_coding:video_codec_interface",
Cleanup BUILD.gn files from imports like foo:foo Repalce all occurrences of foo:foo in deps with just foo in BUILD.gn files. Done with Sublime regex replace. Find: \b([-a-zA-Z0-9_]+):+\1\b In: *.gn Replace with: \1 Bug: None Change-Id: I40aba1b14face687a595b852ffe443cb20197611 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127899 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27225}
2019-03-21 13:35:10 +01:00
"../rtc_base",
Create experimental Obj-C++ API. This can be used to wrap Objective-C components in C++ classes, so users can use the WebRTC C++ API directly together with the iOS specific components provided by our SDK. Bug: webrtc:8832 Change-Id: I6d34f7ec62d51df8d3a5340a2e17d30ae73e13e8 Reviewed-on: https://webrtc-review.googlesource.com/46162 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21850}
2018-02-01 15:47:05 +01:00
"../rtc_base:checks",
Remove //rtc_base:logging from public deps Bug: webrtc:8603 Change-Id: I2704da8618f88032adac7ae9eb2a0f47fce4a836 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257908 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Florent Castelli <orphis@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36443}
2022-04-04 15:06:30 +02:00
"../rtc_base:logging",
Move timestamp_aligner out of rtc_base_approved Bug: webrtc:9838 Change-Id: I4ea34fd161e321f6506f300abfd27c4be6d785d7 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/258766 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36580}
2022-04-14 13:20:12 +02:00
"../rtc_base:timestamp_aligner",
Remove //rtc_base:timeutils from public deps Bug: webrtc:8603 Change-Id: Iaca9356d16275a02e8842c783f259131d72ef010 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257914 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Florent Castelli <orphis@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36460}
2022-04-04 17:16:15 +02:00
"../rtc_base:timeutils",
Create experimental Obj-C++ API. This can be used to wrap Objective-C components in C++ classes, so users can use the WebRTC C++ API directly together with the iOS specific components provided by our SDK. Bug: webrtc:8832 Change-Id: I6d34f7ec62d51df8d3a5340a2e17d30ae73e13e8 Reviewed-on: https://webrtc-review.googlesource.com/46162 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21850}
2018-02-01 15:47:05 +01:00
]
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("video_toolbox_cc") {
Add iOS SDK unit tests for nalu_rewriter Bug: webrtc:9939 Change-Id: I6848786009ee10ffed60743d9e3a2acaf65540c6 Reviewed-on: https://webrtc-review.googlesource.com/c/108440 Reviewed-by: Artem Titarenko <artit@webrtc.org> Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Commit-Queue: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25422}
2018-10-29 18:18:09 +01:00
visibility = [
Revert "Reland "Switch from "rtc_ios_xctest_test" to "rtc_test"."" This reverts commit 60c25a303fac85dccb2ccdd9e8d6d71be13b7541. Reason for revert: Breaks downstream iOS testers. From an offline discussion, the GN argument is not needed and only the 3 xctest needs the behavior of that argument. So I am reverting this one and preparing 2 CLs to properly fix. Original change's description: > Reland "Switch from "rtc_ios_xctest_test" to "rtc_test"." > > This is a reland of 7a73c772e21983857e46cb4fcedc6cfa3f42c03e > > The change to fix the downstream issue is just the switch from > "test" to "rtc_test" which is a GN template that expands to > "test". > > Original change's description: > > Switch from "rtc_ios_xctest_test" to "test". > > > > Using the "test" GN template instead of the "ios_xctest_test" one we > > will get iOS support for isolates via MB and GN for free, making it > > easier to migrate the iOS recipe and fix bugs.webrtc.org/11604. > > > > Bug: webrtc:11881 > > Change-Id: I72b90f8494c473fa567e6296caf7a771e4caba92 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/182680 > > Reviewed-by: Dirk Pranke <dpranke@google.com> > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#32064} > > Bug: webrtc:11881 > Change-Id: Ia5338859f4e893b9f19bcca6b26b8cf66d5984e8 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183766 > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Cr-Commit-Position: refs/heads/master@{#32075} TBR=mbonadei@webrtc.org,dpranke@google.com,jeffyoon@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:11881, webrtc:11937 Change-Id: Ie6eea6b2a8ba5c46af40b115c6db4fd0a38a25b0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184340 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32112}
2020-09-16 07:22:57 +00:00
":sdk_unittests_sources",
Reland "Switch from rtc_ios_xctest_test to rtc_test". This is a reland of https://webrtc-review.googlesource.com/c/src/+/182680, and it is based on https://chromium-review.googlesource.com/c/chromium/src/+/2414169 which allows to force a "test" to be executed as an XCtest on a build target basis instead of on a GN args basis like it was happening in https://webrtc-review.googlesource.com/c/src/+/182680 because that was causing issues when launching tests on real devices. Bug: webrtc:11881, webrtc:11937 Change-Id: I4bec7f471cd0f878b6050f266cd0cca3b518d415 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184360 Reviewed-by: Dirk Pranke <dpranke@google.com> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32126}
2020-09-16 15:09:53 +02:00
":videotoolbox_objc",
Add iOS SDK unit tests for nalu_rewriter Bug: webrtc:9939 Change-Id: I6848786009ee10ffed60743d9e3a2acaf65540c6 Reviewed-on: https://webrtc-review.googlesource.com/c/108440 Reviewed-by: Artem Titarenko <artit@webrtc.org> Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Commit-Queue: Peter Hanspers <peterhanspers@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25422}
2018-10-29 18:18:09 +01:00
]
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
sources = [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/components/video_codec/helpers.cc",
"objc/components/video_codec/helpers.h",
"objc/components/video_codec/nalu_rewriter.cc",
"objc/components/video_codec/nalu_rewriter.h",
The goal of this CL is to separate Obj-C/Obj-C++ code from targets which have also C++ code (see https://bugs.chromium.org/p/webrtc/issues/detail?id=7743 for more information). BUG=webrtc:7743 Review-Url: https://codereview.webrtc.org/2995753002 Cr-Commit-Position: refs/heads/master@{#19501}
2017-08-24 12:26:05 -07:00
]
deps = [
"../common_video",
"../modules/video_coding:webrtc_h264",
Cleanup rtc_base_approved target Removed all unused or transitional parts Bug: webrtc:9838 Change-Id: I6bc14e4e0ac09ab27e4d739ac76bb6a4dfff2cb7 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260140 Commit-Queue: Florent Castelli <orphis@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36741}
2022-04-26 22:54:59 +02:00
"../rtc_base:buffer",
Fix circular dependencies between optional, array_view, and rtc_base. This splits things out of rtc_base and makes dependencies explicit. Bug: webrtc:6828 Change-Id: Id521896c3c43595349021c857bec216e429a0c8d Reviewed-on: https://webrtc-review.googlesource.com/32780 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21264}
2017-12-13 16:05:42 +01:00
"../rtc_base:checks",
Remove //rtc_base:logging from public deps Bug: webrtc:8603 Change-Id: I2704da8618f88032adac7ae9eb2a0f47fce4a836 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257908 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Florent Castelli <orphis@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36443}
2022-04-04 15:06:30 +02:00
"../rtc_base:logging",
The goal of this CL is to separate Obj-C/Obj-C++ code from targets which have also C++ code (see https://bugs.chromium.org/p/webrtc/issues/detail?id=7743 for more information). BUG=webrtc:7743 Review-Url: https://codereview.webrtc.org/2995753002 Cr-Commit-Position: refs/heads/master@{#19501}
2017-08-24 12:26:05 -07:00
]
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("videotoolbox_objc") {
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
visibility = [ "*" ]
Remove legacy video codec factories. Removes the deprecated video codec factories and the related flag and helper classes. Bug: webrtc:7925 Change-Id: I0a6d1666ece9ad074fefc79b626ba241765e1b98 Reviewed-on: https://webrtc-review.googlesource.com/c/113940 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Steve Anton <steveanton@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26245}
2019-01-14 14:23:23 +01:00
allow_poison = [ "audio_codecs" ] # TODO(bugs.webrtc.org/8396): Remove.
The goal of this CL is to separate Obj-C/Obj-C++ code from targets which have also C++ code (see https://bugs.chromium.org/p/webrtc/issues/detail?id=7743 for more information). BUG=webrtc:7743 Review-Url: https://codereview.webrtc.org/2995753002 Cr-Commit-Position: refs/heads/master@{#19501}
2017-08-24 12:26:05 -07:00
sources = [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
"objc/components/video_codec/RTCVideoDecoderFactoryH264.h",
"objc/components/video_codec/RTCVideoDecoderFactoryH264.m",
"objc/components/video_codec/RTCVideoDecoderH264.h",
"objc/components/video_codec/RTCVideoDecoderH264.mm",
"objc/components/video_codec/RTCVideoEncoderFactoryH264.h",
"objc/components/video_codec/RTCVideoEncoderFactoryH264.m",
"objc/components/video_codec/RTCVideoEncoderH264.h",
"objc/components/video_codec/RTCVideoEncoderH264.mm",
Reland of Add a webrtc{en,de}coderfactory implementation for VideoToolbox (patchset #1 id:1 of https://codereview.webrtc.org/2483273002/ ) Reason for revert: Fix gyp build Original issue's description: > Revert of Add a webrtc{en,de}coderfactory implementation for VideoToolbox (patchset #2 id:20001 of https://codereview.webrtc.org/2463313002/ ) > > Reason for revert: > Broke dependent project because the .gn changes weren't accompanied by corresponding .gyp changes. > > Original issue's description: > > Add a webrtc{en,de}coderfactory implementation for VideoToolbox > > > > This CL removes the coupling of the VideoToolbox h264 implementation > > to the generic h264 code. The files have been moved into sdb/obj/Framework > > and all dependency on them has been removed from the rest of WebRTC. > > We now add it as an external encoder via a factory supplied to the > > CreatePeerConnectionFactory call. This also brings the iOS implementation > > closer to what we do on Android for MediaCodec. > > > > BUG=webrtc:6619 > > > > Committed: https://crrev.com/6a5047dad31f14f53dd9f8bc1ecde19e1dede2e4 > > Cr-Commit-Position: refs/heads/master@{#14953} > > TBR=magjed@webrtc.org,stefan@webrtc.org,kthelgason@webrtc.org > BUG=webrtc:6619 > > Committed: https://crrev.com/d69ad84420d9c0e1c11450c352f6c92e7c9583f1 > Cr-Commit-Position: refs/heads/master@{#14985} R=magjed@webrtc.org TBR=kwiberg@webrtc.org, magjed@webrtc.org, stefan@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6619 Review URL: https://codereview.webrtc.org/2487723004 . Cr-Commit-Position: refs/heads/master@{#14992}
2016-11-09 10:43:26 +01:00
]
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
Broadcast extension for AppRTCMobile on iOS This provides an environment for testing out using WebRTC from an iOS extension. It implements a ReplayKit broadcast extension for live streaming games and screensharing. The extension is only supported on iOS 11+ and is guarded by a build flag. Bug: webrtc:9335 Change-Id: Id218d6c73ef7599f5953c5a1e0e62e5d0dc4f10b Reviewed-on: https://webrtc-review.googlesource.com/80000 Commit-Queue: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23504}
2018-06-04 10:24:37 +02:00
configs += [
"..:common_objc",
":used_from_extension",
]
if (is_ios && rtc_apprtcmobile_broadcast_extension) {
defines = [ "RTC_APPRTCMOBILE_BROADCAST_EXTENSION" ]
}
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
deps = [
Obj-C SDK Cleanup This CL separates the files under sdk/objc into logical directories, replacing the previous file layout under Framework/. A long term goal is to have some system set up to generate the files under sdk/objc/api (the PeerConnection API wrappers) from the C++ code. In the shorter term the goal is to abstract out shared concepts from these classes in order to make them as uniform as possible. The separation into base/, components/, and helpers/ are to differentiate between the base layer's common protocols, various utilities and the actual platform specific components. The old directory layout that resembled a framework's internal layout is not necessary, since it is generated by the framework target when building it. Bug: webrtc:9627 Change-Id: Ib084fd83f050ae980649ca99e841f4fb0580bd8f Reviewed-on: https://webrtc-review.googlesource.com/94142 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24493}
2018-08-30 09:30:29 +02:00
":base_native_additions_objc",
":base_objc",
":helpers_objc",
The goal of this CL is to separate Obj-C/Obj-C++ code from targets which have also C++ code (see https://bugs.chromium.org/p/webrtc/issues/detail?id=7743 for more information). BUG=webrtc:7743 Review-Url: https://codereview.webrtc.org/2995753002 Cr-Commit-Position: refs/heads/master@{#19501}
2017-08-24 12:26:05 -07:00
":video_toolbox_cc",
Fix issues found by gn check. It turns out that some headers were not owned by any targets. These were: RTCVideoCodec.h RTCVideoCodecFactory.h RTCVideoCodecH264.h RTCVideoEncoderVP8.h RTCVideoDecoderVP8.h RTCVideoEncoderVP9.h RTCVideoDecoderVP9.h And some were owned by multiple targets, namely: RTCPeerConnectionFactory+Native.h RTCPeerConnectionFactory+Private.h RTCVideoFrameBuffer.h These have all been moved to their appropriate homes. This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files. Bug: webrtc:8855 Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7 Reviewed-on: https://webrtc-review.googlesource.com/49060 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22052}
2018-02-16 10:49:22 +01:00
":videocodec_objc",
":videoframebuffer_objc",
Move h264_profile_level_id and vp9_profile to api/video_codecs This is a refactor to simplify a follow-up CL of adding SdpVideoFormat::IsSameCodec. The original files media/base/h264_profile_level_id.* and media/base/vp9_profile.h must be kept until downstream projects stop using them. Bug: chroimium:1187565 Change-Id: Ib39eca095a3d61939a914d9bffaf4b891ddd222f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/215236 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Johannes Kron <kron@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33782}
2021-04-19 09:09:26 +02:00
"../api/video_codecs:video_codecs_api",
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
"../common_video",
Add untracked headers to video_coding. This creates a new target for pure defines and interfaces. I think that makes sense (though include/ makes it harder to see when .cc and .h files should live together). Bug: webrtc:7620 Change-Id: Ifb0f50faf99166202836c0446feed3443eb52c6e Reviewed-on: https://webrtc-review.googlesource.com/34657 Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21516}
2018-01-08 11:05:10 +01:00
"../modules/video_coding:video_codec_interface",
Cleanup rtc_base_approved target Removed all unused or transitional parts Bug: webrtc:9838 Change-Id: I6bc14e4e0ac09ab27e4d739ac76bb6a4dfff2cb7 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260140 Commit-Queue: Florent Castelli <orphis@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36741}
2022-04-26 22:54:59 +02:00
"../rtc_base:buffer",
Fix circular dependencies between optional, array_view, and rtc_base. This splits things out of rtc_base and makes dependencies explicit. Bug: webrtc:6828 Change-Id: Id521896c3c43595349021c857bec216e429a0c8d Reviewed-on: https://webrtc-review.googlesource.com/32780 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21264}
2017-12-13 16:05:42 +01:00
"../rtc_base:checks",
Remove //rtc_base:logging from public deps Bug: webrtc:8603 Change-Id: I2704da8618f88032adac7ae9eb2a0f47fce4a836 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257908 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Florent Castelli <orphis@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36443}
2022-04-04 15:06:30 +02:00
"../rtc_base:logging",
Remove //rtc_base:timeutils from public deps Bug: webrtc:8603 Change-Id: Iaca9356d16275a02e8842c783f259131d72ef010 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257914 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Florent Castelli <orphis@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36460}
2022-04-04 17:16:15 +02:00
"../rtc_base:timeutils",
Removing $rtc_libyuv_dir and removing useless dependencies on libyuv. This CL removes the following GN variables: rtc_build_libyuv, rtc_libyuv_dir (as requested in webrtc:7906). It also removes some unneeded dependencies on //third_party/libyuv. WebRTC targets were using public_deps to depend on //third_party/libyuv and this created a build graph where targets that were depending on //third_party/libyuv were not declaring the dependency to GN because they were somehow getting it from another target that was exposing //third_party/libyuv header files even if it wasn't directly depending on it. Bug: webrtc:8605, webrtc:7906 Change-Id: If71f7988fd80421dc2ad887cf94c2ac66366c3fb Reviewed-on: https://webrtc-review.googlesource.com/32201 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21275}
2017-12-14 11:24:00 +01:00
"//third_party/libyuv",
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
]
Convert GN libs lists to frameworks GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: chromium:1052560 Change-Id: I263230ddd3c468061584423bba9e1f887503bcaa Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178601 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#31632}
2020-07-03 10:19:30 +02:00
frameworks = [
Avoid to build most of webrtc/sdk in chromium BUG=webrtc:4867 NOTRY=True Review-Url: https://codereview.webrtc.org/2910153003 Cr-Commit-Position: refs/heads/master@{#18349}
2017-05-31 05:14:26 -07:00
"CoreFoundation.framework",
"CoreMedia.framework",
"CoreVideo.framework",
"VideoToolbox.framework",
]
Reland of Add a webrtc{en,de}coderfactory implementation for VideoToolbox (patchset #1 id:1 of https://codereview.webrtc.org/2483273002/ ) Reason for revert: Fix gyp build Original issue's description: > Revert of Add a webrtc{en,de}coderfactory implementation for VideoToolbox (patchset #2 id:20001 of https://codereview.webrtc.org/2463313002/ ) > > Reason for revert: > Broke dependent project because the .gn changes weren't accompanied by corresponding .gyp changes. > > Original issue's description: > > Add a webrtc{en,de}coderfactory implementation for VideoToolbox > > > > This CL removes the coupling of the VideoToolbox h264 implementation > > to the generic h264 code. The files have been moved into sdb/obj/Framework > > and all dependency on them has been removed from the rest of WebRTC. > > We now add it as an external encoder via a factory supplied to the > > CreatePeerConnectionFactory call. This also brings the iOS implementation > > closer to what we do on Android for MediaCodec. > > > > BUG=webrtc:6619 > > > > Committed: https://crrev.com/6a5047dad31f14f53dd9f8bc1ecde19e1dede2e4 > > Cr-Commit-Position: refs/heads/master@{#14953} > > TBR=magjed@webrtc.org,stefan@webrtc.org,kthelgason@webrtc.org > BUG=webrtc:6619 > > Committed: https://crrev.com/d69ad84420d9c0e1c11450c352f6c92e7c9583f1 > Cr-Commit-Position: refs/heads/master@{#14985} R=magjed@webrtc.org TBR=kwiberg@webrtc.org, magjed@webrtc.org, stefan@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6619 Review URL: https://codereview.webrtc.org/2487723004 . Cr-Commit-Position: refs/heads/master@{#14992}
2016-11-09 10:43:26 +01:00
}
GN: Build iOS framework in build_ios_libs.sh BUG=webrtc:6372 NOTRY=True R=kjellander@webrtc.org Review URL: https://codereview.webrtc.org/2408983002 . Cr-Commit-Position: refs/heads/master@{#14603}
2016-10-11 13:27:26 -07:00
}
Build dynamic iOS SDK. - Places most ObjC code into webrtc/sdk/objc instead. - New gyp targets to build, strip and export symbols for dylib. - Removes old script used to generate dylib. BUG= Review URL: https://codereview.webrtc.org/1903663002 Cr-Commit-Position: refs/heads/master@{#12524}
2016-04-27 01:54:20 -07:00
}
Reference in New Issue Copy Permalink