admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
webrtc_m130/modules/congestion_controller/BUILD.gn

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

72 lines
2.2 KiB
Plaintext
Raw Normal View History

Move congestion controller to a separate module. This allows other projects to more easily depend on this. The plan is to move remote_bitrate_estimator and bitrate_controller into this module and reduce the exposed interface to only a simplified version of congestion_controller.h. No functional changes in this CL. R=mflodman@webrtc.org, pbos@webrtc.org Review URL: https://codereview.webrtc.org/1718473002 . Cr-Commit-Position: refs/heads/master@{#11718}
2016-02-23 13:30:42 +01:00
# Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
#
# Use of this source code is governed by a BSD-style license
# that can be found in the LICENSE file in the root of the source
# tree. An additional intellectual property rights grant can be found
# in the file PATENTS. All contributing project authors may
# be found in the AUTHORS file in the root of the source tree.
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
import("../../webrtc.gni")
Move congestion controller to a separate module. This allows other projects to more easily depend on this. The plan is to move remote_bitrate_estimator and bitrate_controller into this module and reduce the exposed interface to only a simplified version of congestion_controller.h. No functional changes in this CL. R=mflodman@webrtc.org, pbos@webrtc.org Review URL: https://codereview.webrtc.org/1718473002 . Cr-Commit-Position: refs/heads/master@{#11718}
2016-02-23 13:30:42 +01:00
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("congestion_controller") {
Revert "Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*""" This reverts commit c73e1f437889d882cbf2987f7fb3a029a6150613. Reason for revert: The problem with failed deps in chrome content/renderer had already been fixed in https://webrtc-review.googlesource.com/c/src/+/38660 Original change's description: > Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*"" > > This reverts commit 588c548657b3ddf76e7b3f241263eef7f5799f16. > > Reason for revert: > > Breaks Chrome FYI: > > /b/c/b/Linux_Builder/src/buildtools/linux64/gn gen //out/Release --check > -> returned 1 > ERROR at //build/split_static_library.gni:12:5: Dependency not allowed. > static_library(target_name) { > ^---------------------------- > The item //content/renderer:renderer > can not depend on //third_party/webrtc/media:rtc_internal_video_codecs > because it is not in //third_party/webrtc/media:rtc_internal_video_codecs's visibility list: [ > //third_party/webrtc/* > //third_party/webrtc_overrides/* > ] > > https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webrtc.fyi%2FLinux_Builder%2F23560%2F%2B%2Frecipes%2Fsteps%2Fgenerate_build_files%2F0%2Fstdout > > Original change's description: > > GN rtc_* templates: Set default visibility to webrtc_root + "/*" > > > > This means that by default, targets are visible to everything under > > the WebRTC root, but not visible to anything else. > > > > API targets are manually tagged with visibility "*", so that targets > > outside the WebRTC tree can see them. > > > > BUG=webrtc:8254 > > > > Change-Id: Icdbee6e0d22d93240ff2fb530c8f9dc48e351509 > > Reviewed-on: https://webrtc-review.googlesource.com/24140 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#21548} > > TBR=mbonadei@webrtc.org,kwiberg@webrtc.org > > Change-Id: I06620ce3d6f67482935c22efa231dd6cab91625a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:8254 > Reviewed-on: https://webrtc-review.googlesource.com/38760 > Reviewed-by: Per Kjellander <perkj@webrtc.org> > Commit-Queue: Per Kjellander <perkj@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#21555} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,perkj@webrtc.org Change-Id: I6f720078ce21bd172e0a6471bae8c4c011e4a657 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:8254 Reviewed-on: https://webrtc-review.googlesource.com/38860 Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Per Kjellander <perkj@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21558}
2018-01-10 15:54:53 +00:00
visibility = [ "*" ]
Move congestion controller to a separate module. This allows other projects to more easily depend on this. The plan is to move remote_bitrate_estimator and bitrate_controller into this module and reduce the exposed interface to only a simplified version of congestion_controller.h. No functional changes in this CL. R=mflodman@webrtc.org, pbos@webrtc.org Review URL: https://codereview.webrtc.org/1718473002 . Cr-Commit-Position: refs/heads/master@{#11718}
2016-02-23 13:30:42 +01:00
sources = [
Split CongestionController into send- and receive-side classes. New class ReceiveSideCongestionController, extracted from CongestionController, and responsible for the OnReceivedPacket processing. Rest of the CongestionController moved to a new class SendSideCongestionController. To avoid breaking applications, CongestionController is redefined as a union of these two classes, with no intended change in behavior. With one exception: CongestionController::SetBweBitrates used to call remote_bitrate_estimator_.SetMinBitrate, but after remote_bitrate_estimator_ was moved to ReceiveSideCongestionController, it no longer does this. BUG=webrtc:6847 Review-Url: https://codereview.webrtc.org/2752233002 Cr-Commit-Position: refs/heads/master@{#17321}
2017-03-21 06:41:12 -07:00
"include/receive_side_congestion_controller.h",
"receive_side_congestion_controller.cc",
Replace interfaces for sending RTCP with std::functions in ReceiveSideCongestionController Logic for throttling how often REMB messages are sent is added to ReceiveSideCongestionController as well as a new method SetMaxDesiredReceiveBitrate. These are based on the logic in PacketRouter. The logic for throttling REMB and setting the max REMB will be removed from PacketRouter in a follow up cl. The purpose is to eventually decouple PacketRouter from sending RTCP messages when RtcpTransceiver is used. Bug: webrtc:12693 Change-Id: I9fb5cbcd14bb17d977e76d329a906fc0a9abc276 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/215685 Reviewed-by: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Commit-Queue: Per Kjellander <perkj@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33801}
2021-04-21 11:56:32 +02:00
"remb_throttler.cc",
"remb_throttler.h",
Move congestion controller to a separate module. This allows other projects to more easily depend on this. The plan is to move remote_bitrate_estimator and bitrate_controller into this module and reduce the exposed interface to only a simplified version of congestion_controller.h. No functional changes in this CL. R=mflodman@webrtc.org, pbos@webrtc.org Review URL: https://codereview.webrtc.org/1718473002 . Cr-Commit-Position: refs/heads/master@{#11718}
2016-02-23 13:30:42 +01:00
]
Fix circular dependency in BWE code. Bug: webrtc:6828 Change-Id: I531ee5dea41140f085d82641253fadb9e997a378 Reviewed-on: https://webrtc-review.googlesource.com/34641 Reviewed-by: Stefan Holmer <stefan@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21350}
2017-12-19 09:33:40 +01:00
deps = [
Send periodic TransportFeedback based on extension version Today, behaviour is decided based on if transport sequence number v2 is in the SDP answer. But it might be better to decide based on received packets since it is valid to negotiate both extensions. Another bonus With this solution is that Call does not need to know about receive header exensions. This is an alternative to https://webrtc-review.googlesource.com/c/src/+/291337 Bug: webrtc:7135 Change-Id: Ib75474127d6e2e2029557b8bb2528eaac66979f8 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/291525 Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Johannes Kron <kron@webrtc.org> Commit-Queue: Per Kjellander <perkj@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39226}
2023-01-30 12:26:17 +01:00
"../../api:rtp_parameters",
Add functions to send feedback according to RFC 8888 in ReceiveSideCongestionController. With this cl, sending can be forced with field trial "WebRTC-RFC8888CongestionControlFeedback/force_send:true/" In the future, ReceiveSideCongestionController::EnablSendCongestionControlFeedbackAccordingToRfc8888 if RFC 8888 has been negotiated. Bug: webrtc:42225697 Change-Id: Ib09066aa89ca7b3fffc551da541090c69ab8d75f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/352720 Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Commit-Queue: Per Kjellander <perkj@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42413}
2024-05-30 11:13:45 +00:00
"../../api:sequence_checker",
Provide Environment for ReceiveSideConfestionController construction Environment includes propagated field trials that can be later passed to RemoteBitrateEstimators member, and would allow not to rely on the global field trial string Bug: webrtc:42220378 Change-Id: Icf75a433c20352b2c22829c2148c92f69a2517aa Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349645 Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42242}
2024-05-06 19:51:23 +02:00
"../../api/environment",
Make NetworkStateEstimator injectable in RemoteBitrateEstimator The NetworkStateEstimator is updated on every incoming RTP packet if available. A rtcp::RemoteEstimate packet is sent every time a rtcp::TransportFeedback packet is sent. BUG=webrtc:10742 Change-Id: I4cd8e9d85d35faf76aeefd2e26c2a9fe1a62ca3b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/152161 Commit-Queue: Per Kjellander <perkj@webrtc.org> Reviewed-by: Sebastian Jansson <srte@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29143}
2019-09-10 19:28:06 +02:00
"../../api/transport:network_control",
Replace interfaces for sending RTCP with std::functions in ReceiveSideCongestionController Logic for throttling how often REMB messages are sent is added to ReceiveSideCongestionController as well as a new method SetMaxDesiredReceiveBitrate. These are based on the logic in PacketRouter. The logic for throttling REMB and setting the max REMB will be removed from PacketRouter in a follow up cl. The purpose is to eventually decouple PacketRouter from sending RTCP messages when RtcpTransceiver is used. Bug: webrtc:12693 Change-Id: I9fb5cbcd14bb17d977e76d329a906fc0a9abc276 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/215685 Reviewed-by: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Commit-Queue: Per Kjellander <perkj@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33801}
2021-04-21 11:56:32 +02:00
"../../api/units:data_rate",
Add functions to send feedback according to RFC 8888 in ReceiveSideCongestionController. With this cl, sending can be forced with field trial "WebRTC-RFC8888CongestionControlFeedback/force_send:true/" In the future, ReceiveSideCongestionController::EnablSendCongestionControlFeedbackAccordingToRfc8888 if RFC 8888 has been negotiated. Bug: webrtc:42225697 Change-Id: Ib09066aa89ca7b3fffc551da541090c69ab8d75f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/352720 Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Commit-Queue: Per Kjellander <perkj@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42413}
2024-05-30 11:13:45 +00:00
"../../api/units:data_size",
Replace interfaces for sending RTCP with std::functions in ReceiveSideCongestionController Logic for throttling how often REMB messages are sent is added to ReceiveSideCongestionController as well as a new method SetMaxDesiredReceiveBitrate. These are based on the logic in PacketRouter. The logic for throttling REMB and setting the max REMB will be removed from PacketRouter in a follow up cl. The purpose is to eventually decouple PacketRouter from sending RTCP messages when RtcpTransceiver is used. Bug: webrtc:12693 Change-Id: I9fb5cbcd14bb17d977e76d329a906fc0a9abc276 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/215685 Reviewed-by: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Commit-Queue: Per Kjellander <perkj@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33801}
2021-04-21 11:56:32 +02:00
"../../api/units:time_delta",
"../../api/units:timestamp",
Remove //rtc_base:logging from public deps Bug: webrtc:8603 Change-Id: I2704da8618f88032adac7ae9eb2a0f47fce4a836 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257908 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Florent Castelli <orphis@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36443}
2022-04-04 15:06:30 +02:00
"../../rtc_base:logging",
Cleanup ReceiveSideCongestionController: remove inner wrapper helper Bug: None Change-Id: Iff388a56176d90e300e0c12b34414ee21fa26bc8 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267406 Auto-Submit: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Philip Eliasson <philipel@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37429}
2022-07-01 16:28:55 +02:00
"../../rtc_base:macromagic",
Migrate modules/congestion_controller to webrtc::Mutex. Bug: webrtc:11567 Change-Id: I284eaebf863e0c63d2aa162a5df56380f9cf4838 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178841 Reviewed-by: Sebastian Jansson <srte@webrtc.org> Commit-Queue: Markus Handell <handellm@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31659}
2020-07-07 22:03:26 +02:00
"../../rtc_base/synchronization:mutex",
Fix circular dependency in BWE code. Bug: webrtc:6828 Change-Id: I531ee5dea41140f085d82641253fadb9e997a378 Reviewed-on: https://webrtc-review.googlesource.com/34641 Reviewed-by: Stefan Holmer <stefan@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21350}
2017-12-19 09:33:40 +01:00
"../pacing",
"../remote_bitrate_estimator",
Add functions to send feedback according to RFC 8888 in ReceiveSideCongestionController. With this cl, sending can be forced with field trial "WebRTC-RFC8888CongestionControlFeedback/force_send:true/" In the future, ReceiveSideCongestionController::EnablSendCongestionControlFeedbackAccordingToRfc8888 if RFC 8888 has been negotiated. Bug: webrtc:42225697 Change-Id: Ib09066aa89ca7b3fffc551da541090c69ab8d75f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/352720 Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Commit-Queue: Per Kjellander <perkj@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42413}
2024-05-30 11:13:45 +00:00
"../remote_bitrate_estimator:congestion_control_feedback_generator",
Add CongestionControlFeedbackGenerator CongestionControlFeedbackGenerator collect receive time information about received packets and sends feedback according to RFC8888 Bug: webrtc:42225697 Change-Id: I70b7f7322fd262f99f45fd56b6eb8630a11b30c9 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/351543 Commit-Queue: Per Kjellander <perkj@webrtc.org> Auto-Submit: Per Kjellander <perkj@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42404}
2024-05-29 12:37:40 +00:00
"../remote_bitrate_estimator:transport_sequence_number_feedback_generator",
Revert "Fix circular dependency in BWE code." This reverts commit 08279b5cf5a8412f7e946cc2bb43703e920f5855. Reason for revert: msvc bots breaking, blocking WebRTC rolls. Sample log: FAILED: obj/third_party/webrtc/modules/congestion_controller/estimators/probe_bitrate_estimator.obj ninja -t msvc -e environment.x64 -- E:\b\c\goma_client/gomacc.exe "e:\b\c\win_toolchain\vs_files\1180cb75833ea365097e279efb2d5d7a42dee4b0\vc\tools\msvc\14.11.25503\bin\hostx64\x64/cl.exe" /nologo /showIncludes @obj/third_party/webrtc/modules/congestion_controller/estimators/probe_bitrate_estimator.obj.rsp /c ../../third_party/webrtc/modules/congestion_controller/probe_bitrate_estimator.cc /Foobj/third_party/webrtc/modules/congestion_controller/estimators/probe_bitrate_estimator.obj /Fd"obj/third_party/webrtc/modules/congestion_controller/estimators_cc.pdb" ../../third_party/webrtc/modules/congestion_controller/probe_bitrate_estimator.cc(68): error C2220: warning treated as error - no 'object' file generated ../../third_party/webrtc/modules/congestion_controller/probe_bitrate_estimator.cc(68): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [22699/51826] CXX obj/third_party/webrtc/modules/pacing/pacing/packet_router.obj [22700/51826] CXX obj/third_party/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator/aimd_rate_control.obj [22701/51826] CXX obj/third_party/webrtc/modules/desktop_capture/desktop_capture_generic/dxgi_texture_mapping.obj [22702/51826] CXX obj/third_party/webrtc/modules/congestion_controller/estimators/acknowledged_bitrate_estimator.obj FAILED: obj/third_party/webrtc/modules/congestion_controller/estimators/acknowledged_bitrate_estimator.obj ninja -t msvc -e environment.x64 -- E:\b\c\goma_client/gomacc.exe "e:\b\c\win_toolchain\vs_files\1180cb75833ea365097e279efb2d5d7a42dee4b0\vc\tools\msvc\14.11.25503\bin\hostx64\x64/cl.exe" /nologo /showIncludes @obj/third_party/webrtc/modules/congestion_controller/estimators/acknowledged_bitrate_estimator.obj.rsp /c ../../third_party/webrtc/modules/congestion_controller/acknowledged_bitrate_estimator.cc /Foobj/third_party/webrtc/modules/congestion_controller/estimators/acknowledged_bitrate_estimator.obj /Fd"obj/third_party/webrtc/modules/congestion_controller/estimators_cc.pdb" ../../third_party/webrtc/modules/congestion_controller/acknowledged_bitrate_estimator.cc(41): error C2220: warning treated as error - no 'object' file generated ../../third_party/webrtc/modules/congestion_controller/acknowledged_bitrate_estimator.cc(41): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data https://logs.chromium.org/v/?s=chromium%2Fbb%2Ftryserver.chromium.win%2Fwin-msvc-dbg%2F1780%2F%2B%2Frecipes%2Fsteps%2Fcompile__with_patch_%2F0%2Fstdout Original change's description: > Fix circular dependency in BWE code. > > Bug: webrtc:6828 > Change-Id: I531ee5dea41140f085d82641253fadb9e997a378 > Reviewed-on: https://webrtc-review.googlesource.com/34641 > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Patrik Höglund <phoglund@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#21350} TBR=phoglund@webrtc.org,stefan@webrtc.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:6828 Change-Id: I361050942cbd1d2b344b129c8c3a4e7b6e1c02f4 Reviewed-on: https://webrtc-review.googlesource.com/35240 Reviewed-by: Olga Sharonova <olka@webrtc.org> Commit-Queue: Olga Sharonova <olka@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21384}
2017-12-20 13:13:32 +00:00
"../rtp_rtcp:rtp_rtcp_format",
Mass removal of absl_deps in all BUILD.gn files Bug: webrtc:341803749 Change-Id: Id73844ba8d63b9f2f2c9391d8d8116ad0864c36d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/351540 Commit-Queue: Florent Castelli <orphis@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42372}
2024-05-23 11:21:53 +00:00
"//third_party/abseil-cpp/absl/base:nullability",
Fix circular dependency in BWE code. Bug: webrtc:6828 Change-Id: I531ee5dea41140f085d82641253fadb9e997a378 Reviewed-on: https://webrtc-review.googlesource.com/34641 Reviewed-by: Stefan Holmer <stefan@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21350}
2017-12-19 09:33:40 +01:00
]
}
Remove from chromium build targets that are not compatible with it. We need to be able build chromium with rtc_include_tests = true. It reveals a lot of targets that are not compatible with chromium but aren't marked so. `rtc_include_tests=true` has been considered a way to disable targets for the Chromium build, causing an overload on rtc_include_tests while the meaning of the two GN args (rtc_include_tests and build_with_chromium) should be kept separated. Bug: webrtc:12404 Change-Id: I2f72825445916eae7c20ef9338672d6a07a9b9ff Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/203890 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Andrey Logvin <landrey@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33124}
2021-02-01 09:56:37 +00:00
if (rtc_include_tests && !build_with_chromium) {
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("congestion_controller_unittests") {
GN: Refactor modules_unittests to eliminate package boundary violations. BUG=webrtc:6954 Review-Url: https://codereview.webrtc.org/2629923002 Cr-Commit-Position: refs/heads/master@{#16166}
2017-01-19 08:27:11 -08:00
testonly = true
GN: Tighten up test target visibility + refactorings Make all rtc_source_test target that contains tests that are included in a test executable only be visible to the rtc_test target. Doing this exposed a couple of errors and dependency problems that were resolved. Having this could have prevented duplicated execution of tests like the case that was recently fixed by deadbeef@ in https://codereview.webrtc.org/2820263004 New targets: * //webrtc/modules/rtp_rtcp:fec_test_helper * //webrtc/modules/rtp_rtcp:mock_rtp_rtcp * //webrtc/modules/remote_bitrate_estimator:mock_remote_bitrate_observer The mock files and targets should probably be moved into webrtc/test in the future, but that's out of the scope of this CL. BUG=webrtc:5716 NOTRY=True Review-Url: https://codereview.webrtc.org/2828793003 Cr-Commit-Position: refs/heads/master@{#17863}
2017-04-25 04:04:50 -07:00
Replace interfaces for sending RTCP with std::functions in ReceiveSideCongestionController Logic for throttling how often REMB messages are sent is added to ReceiveSideCongestionController as well as a new method SetMaxDesiredReceiveBitrate. These are based on the logic in PacketRouter. The logic for throttling REMB and setting the max REMB will be removed from PacketRouter in a follow up cl. The purpose is to eventually decouple PacketRouter from sending RTCP messages when RtcpTransceiver is used. Bug: webrtc:12693 Change-Id: I9fb5cbcd14bb17d977e76d329a906fc0a9abc276 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/215685 Reviewed-by: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Commit-Queue: Per Kjellander <perkj@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33801}
2021-04-21 11:56:32 +02:00
sources = [
"receive_side_congestion_controller_unittest.cc",
"remb_throttler_unittest.cc",
]
GN: Refactor modules_unittests to eliminate package boundary violations. BUG=webrtc:6954 Review-Url: https://codereview.webrtc.org/2629923002 Cr-Commit-Position: refs/heads/master@{#16166}
2017-01-19 08:27:11 -08:00
deps = [
":congestion_controller",
Add functions to send feedback according to RFC 8888 in ReceiveSideCongestionController. With this cl, sending can be forced with field trial "WebRTC-RFC8888CongestionControlFeedback/force_send:true/" In the future, ReceiveSideCongestionController::EnablSendCongestionControlFeedbackAccordingToRfc8888 if RFC 8888 has been negotiated. Bug: webrtc:42225697 Change-Id: Ib09066aa89ca7b3fffc551da541090c69ab8d75f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/352720 Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Commit-Queue: Per Kjellander <perkj@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42413}
2024-05-30 11:13:45 +00:00
"../../api:rtp_parameters",
Provide Environment for ReceiveSideConfestionController construction Environment includes propagated field trials that can be later passed to RemoteBitrateEstimators member, and would allow not to rely on the global field trial string Bug: webrtc:42220378 Change-Id: Icf75a433c20352b2c22829c2148c92f69a2517aa Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349645 Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42242}
2024-05-06 19:51:23 +02:00
"../../api/environment:environment_factory",
Add cross trafic emulation api Bug: webrtc:12344 Change-Id: I958dc4deda4af4576818600c31aecdf48285172f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/200981 Reviewed-by: Sebastian Jansson <srte@webrtc.org> Reviewed-by: Artem Titov <titovartem@webrtc.org> Commit-Queue: Andrey Logvin <landrey@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32989}
2021-01-14 09:50:32 +00:00
"../../api/test/network_emulation",
"../../api/test/network_emulation:create_cross_traffic",
Replace interfaces for sending RTCP with std::functions in ReceiveSideCongestionController Logic for throttling how often REMB messages are sent is added to ReceiveSideCongestionController as well as a new method SetMaxDesiredReceiveBitrate. These are based on the logic in PacketRouter. The logic for throttling REMB and setting the max REMB will be removed from PacketRouter in a follow up cl. The purpose is to eventually decouple PacketRouter from sending RTCP messages when RtcpTransceiver is used. Bug: webrtc:12693 Change-Id: I9fb5cbcd14bb17d977e76d329a906fc0a9abc276 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/215685 Reviewed-by: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Commit-Queue: Per Kjellander <perkj@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33801}
2021-04-21 11:56:32 +02:00
"../../api/units:data_rate",
In ReceiveSideCongestionController unittest use modern version of OnReceivedPacket Bug: webrtc:14859 Change-Id: I8fd93272b0292947c93b5faaec2579a9c5ed3c5f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/296761 Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Per Kjellander <perkj@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39529}
2023-03-09 11:02:51 +01:00
"../../api/units:data_size",
Replace interfaces for sending RTCP with std::functions in ReceiveSideCongestionController Logic for throttling how often REMB messages are sent is added to ReceiveSideCongestionController as well as a new method SetMaxDesiredReceiveBitrate. These are based on the logic in PacketRouter. The logic for throttling REMB and setting the max REMB will be removed from PacketRouter in a follow up cl. The purpose is to eventually decouple PacketRouter from sending RTCP messages when RtcpTransceiver is used. Bug: webrtc:12693 Change-Id: I9fb5cbcd14bb17d977e76d329a906fc0a9abc276 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/215685 Reviewed-by: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Commit-Queue: Per Kjellander <perkj@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33801}
2021-04-21 11:56:32 +02:00
"../../api/units:time_delta",
"../../api/units:timestamp",
Stop using public_deps in system_wrappers. TBR=phoglund@webrtc.org Bug: webrtc:8603 Change-Id: I5e515f0e4dc955a01460d69ba4e21bdfdf152d20 Reviewed-on: https://webrtc-review.googlesource.com/29104 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21112}
2017-12-06 09:17:14 +01:00
"../../system_wrappers",
Add functions to send feedback according to RFC 8888 in ReceiveSideCongestionController. With this cl, sending can be forced with field trial "WebRTC-RFC8888CongestionControlFeedback/force_send:true/" In the future, ReceiveSideCongestionController::EnablSendCongestionControlFeedbackAccordingToRfc8888 if RFC 8888 has been negotiated. Bug: webrtc:42225697 Change-Id: Ib09066aa89ca7b3fffc551da541090c69ab8d75f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/352720 Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Commit-Queue: Per Kjellander <perkj@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42413}
2024-05-30 11:13:45 +00:00
"../../test:explicit_key_value_config",
GN: Refactor modules_unittests to eliminate package boundary violations. BUG=webrtc:6954 Review-Url: https://codereview.webrtc.org/2629923002 Cr-Commit-Position: refs/heads/master@{#16166}
2017-01-19 08:27:11 -08:00
"../../test:test_support",
Adds TCP fairness test to receive side congestion controller. Bug: webrtc:9883 Change-Id: I3697491285e4f70b8f7857198e4e1ccb0097da5b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140883 Commit-Queue: Sebastian Jansson <srte@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28196}
2019-06-07 15:24:57 +02:00
"../../test/scenario",
Cleanup BUILD.gn files from imports like foo:foo Repalce all occurrences of foo:foo in deps with just foo in BUILD.gn files. Done with Sublime regex replace. Find: \b([-a-zA-Z0-9_]+):+\1\b In: *.gn Replace with: \1 Bug: None Change-Id: I40aba1b14face687a595b852ffe443cb20197611 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127899 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27225}
2019-03-21 13:35:10 +01:00
"../pacing",
In ReceiveSideCongestionController unittest use modern version of OnReceivedPacket Bug: webrtc:14859 Change-Id: I8fd93272b0292947c93b5faaec2579a9c5ed3c5f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/296761 Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Per Kjellander <perkj@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39529}
2023-03-09 11:02:51 +01:00
"../rtp_rtcp:rtp_rtcp_format",
Replaces redundant congestion controller components This CL replaces components in the congestion controller module that are identical to equivalent components in the rtp and goog_cc subfolder. Some redundant components are left as they were not trivial to replace. Bug: webrtc:8415 Change-Id: I86a1f164d7b100b8ec8ba7dbc1c9bda2128a4f37 Reviewed-on: https://webrtc-review.googlesource.com/78521 Commit-Queue: Sebastian Jansson <srte@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23384}
2018-05-24 14:17:06 +02:00
"goog_cc:estimators",
Reland "Moved congestion controller to goog_cc folder." This is a reland of e6cefdf9c572cdce55ff0497ad6e516c76132ee8. Original change's description: > Moved congestion controller to goog_cc folder. > > Bug: webrtc:8415 > Change-Id: I2070da0cacf1dbfc4b6a89285af3e68fd03497ab > Reviewed-on: https://webrtc-review.googlesource.com/43841 > Commit-Queue: Sebastian Jansson <srte@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#21928} Bug: webrtc:8415 Change-Id: Ib5cf8641466655d64ac80f720561817f4cab49a9 Reviewed-on: https://webrtc-review.googlesource.com/53062 Commit-Queue: Sebastian Jansson <srte@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22244}
2018-02-28 16:48:00 +01:00
"goog_cc:goog_cc_unittests",
Adds Rtt tracker for PCC. This is a part of series of CLs adding PCC (Performance-oriented Congestion Control). Bug: webrtc:9434 Change-Id: Idd36d8abea008623ac64b939d0de7ee6001f7f23 Reviewed-on: https://webrtc-review.googlesource.com/86951 Commit-Queue: Anastasia Koloskova <koloskova@webrtc.org> Reviewed-by: Sebastian Jansson <srte@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24364}
2018-08-21 16:11:50 +02:00
"pcc:pcc_unittests",
Added unit tests for new congestion controller. This CL activates unit tests for the task queue based send side congestion controller that will replace the current one in the future. To be able to have the tests run side by side with the tests of the old congestion controller, the old tests have been prefixed with "Legacy". This CL also contains some minor fixes to the new congestion controller code. Bug: webrtc:8415 Change-Id: I5e7474d42f17fcbfef402e26f638846fa3424695 Reviewed-on: https://webrtc-review.googlesource.com/55381 Reviewed-by: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Commit-Queue: Sebastian Jansson <srte@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22229}
2018-02-28 13:07:28 +01:00
"rtp:congestion_controller_unittests",
GN: Refactor modules_unittests to eliminate package boundary violations. BUG=webrtc:6954 Review-Url: https://codereview.webrtc.org/2629923002 Cr-Commit-Position: refs/heads/master@{#16166}
2017-01-19 08:27:11 -08:00
]
}
}
Reference in New Issue Copy Permalink