Moved RtcEventLog files from call/ to logging/
The RtcEventLog headers need to be accessible from any place which needs
logging, and the implementation needs access to data structures that are
logged.
After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future).
The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/).
This change allows using RtcEventLog in the p2p/ directory, so that we
can log STUN pings and ICE state transitions.
BUG=webrtc:6393
R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org
Review URL: https://codereview.webrtc.org/2380683005 .
Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
|
|
|
# Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
|
|
|
|
|
#
|
|
|
|
|
# Use of this source code is governed by a BSD-style license
|
|
|
|
|
# that can be found in the LICENSE file in the root of the source
|
|
|
|
|
# tree. An additional intellectual property rights grant can be found
|
|
|
|
|
# in the file PATENTS. All contributing project authors may
|
|
|
|
|
# be found in the AUTHORS file in the root of the source tree.
|
|
|
|
|
|
2017-01-24 06:58:22 -08:00
|
|
|
import("../webrtc.gni")
|
2018-01-15 10:20:00 -05:00
|
|
|
if (!build_with_mozilla) {
|
|
|
|
|
import("//third_party/protobuf/proto_library.gni")
|
|
|
|
|
}
|
Moved RtcEventLog files from call/ to logging/
The RtcEventLog headers need to be accessible from any place which needs
logging, and the implementation needs access to data structures that are
logged.
After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future).
The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/).
This change allows using RtcEventLog in the p2p/ directory, so that we
can log STUN pings and ICE state transitions.
BUG=webrtc:6393
R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org
Review URL: https://codereview.webrtc.org/2380683005 .
Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
|
|
|
if (is_android) {
|
|
|
|
|
import("//build/config/android/config.gni")
|
|
|
|
|
import("//build/config/android/rules.gni")
|
|
|
|
|
}
|
|
|
|
|
|
2016-10-28 05:44:03 -07:00
|
|
|
group("logging") {
|
2017-12-12 12:46:13 +01:00
|
|
|
deps = [
|
2018-02-01 11:04:46 -08:00
|
|
|
":rtc_event_audio",
|
|
|
|
|
":rtc_event_bwe",
|
|
|
|
|
":rtc_event_log_impl_base",
|
|
|
|
|
":rtc_event_log_impl_encoder",
|
|
|
|
|
":rtc_event_log_impl_output",
|
|
|
|
|
":rtc_event_pacing",
|
|
|
|
|
":rtc_event_rtp_rtcp",
|
|
|
|
|
":rtc_event_video",
|
2016-10-28 05:44:03 -07:00
|
|
|
]
|
|
|
|
|
}
|
|
|
|
|
|
Moved RtcEventLog files from call/ to logging/
The RtcEventLog headers need to be accessible from any place which needs
logging, and the implementation needs access to data structures that are
logged.
After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future).
The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/).
This change allows using RtcEventLog in the p2p/ directory, so that we
can log STUN pings and ICE state transitions.
BUG=webrtc:6393
R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org
Review URL: https://codereview.webrtc.org/2380683005 .
Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
|
|
|
rtc_source_set("rtc_event_log_api") {
|
|
|
|
|
sources = [
|
2018-02-01 11:04:46 -08:00
|
|
|
"rtc_event_log/encoder/rtc_event_log_encoder.h",
|
2017-10-02 11:27:52 +02:00
|
|
|
"rtc_event_log/events/rtc_event.h",
|
2018-02-07 09:38:31 +01:00
|
|
|
"rtc_event_log/rtc_event_log.cc",
|
2018-02-01 11:04:46 -08:00
|
|
|
"rtc_event_log/rtc_event_log.h",
|
|
|
|
|
"rtc_event_log/rtc_event_log_factory_interface.h",
|
|
|
|
|
]
|
|
|
|
|
|
|
|
|
|
deps = [
|
|
|
|
|
"../api:libjingle_logging_api",
|
2018-06-26 11:41:27 +02:00
|
|
|
"../rtc_base:ptr_util",
|
2018-02-01 11:04:46 -08:00
|
|
|
"../rtc_base:rtc_base_approved",
|
2018-03-20 18:15:39 +01:00
|
|
|
"../rtc_base:rtc_task_queue",
|
2018-10-18 14:20:44 +02:00
|
|
|
"//third_party/abseil-cpp/absl/memory",
|
2018-02-01 11:04:46 -08:00
|
|
|
]
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
rtc_source_set("rtc_stream_config") {
|
|
|
|
|
sources = [
|
|
|
|
|
"rtc_event_log/rtc_stream_config.cc",
|
|
|
|
|
"rtc_event_log/rtc_stream_config.h",
|
|
|
|
|
]
|
|
|
|
|
|
|
|
|
|
deps = [
|
|
|
|
|
":rtc_event_log_api",
|
|
|
|
|
"..:webrtc_common",
|
|
|
|
|
"../api:libjingle_peerconnection_api",
|
|
|
|
|
]
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
rtc_source_set("rtc_event_pacing") {
|
|
|
|
|
sources = [
|
2017-12-05 13:19:45 +01:00
|
|
|
"rtc_event_log/events/rtc_event_alr_state.cc",
|
|
|
|
|
"rtc_event_log/events/rtc_event_alr_state.h",
|
2018-02-01 11:04:46 -08:00
|
|
|
]
|
|
|
|
|
|
|
|
|
|
deps = [
|
|
|
|
|
":rtc_event_log_api",
|
2018-06-26 11:41:27 +02:00
|
|
|
"../rtc_base:ptr_util",
|
Use absl::make_unique and absl::WrapUnique directly
Instead of going through our wrappers in ptr_util.h.
This CL was generated by the following script:
git grep -l ptr_util | xargs perl -pi -e 's,#include "rtc_base/ptr_util.h",#include "absl/memory/memory.h",'
git grep -l MakeUnique | xargs perl -pi -e 's,\b(rtc::)?MakeUnique\b,absl::make_unique,g'
git grep -l WrapUnique | xargs perl -pi -e 's,\b(rtc::)?WrapUnique\b,absl::WrapUnique,g'
git checkout -- rtc_base/ptr_util{.h,_unittest.cc}
git cl format
Followed by manually adding dependencies on
//third_party/abseil-cpp/absl/memory until `gn check` stopped
complaining.
Bug: webrtc:9473
Change-Id: I89ccd363f070479b8c431eb2c3d404a46eaacc1c
Reviewed-on: https://webrtc-review.googlesource.com/86600
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23850}
2018-07-05 11:40:33 +02:00
|
|
|
"//third_party/abseil-cpp/absl/memory",
|
2018-02-01 11:04:46 -08:00
|
|
|
]
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
rtc_source_set("rtc_event_audio") {
|
|
|
|
|
sources = [
|
2017-10-02 11:27:52 +02:00
|
|
|
"rtc_event_log/events/rtc_event_audio_network_adaptation.cc",
|
|
|
|
|
"rtc_event_log/events/rtc_event_audio_network_adaptation.h",
|
|
|
|
|
"rtc_event_log/events/rtc_event_audio_playout.cc",
|
|
|
|
|
"rtc_event_log/events/rtc_event_audio_playout.h",
|
|
|
|
|
"rtc_event_log/events/rtc_event_audio_receive_stream_config.cc",
|
|
|
|
|
"rtc_event_log/events/rtc_event_audio_receive_stream_config.h",
|
|
|
|
|
"rtc_event_log/events/rtc_event_audio_send_stream_config.cc",
|
|
|
|
|
"rtc_event_log/events/rtc_event_audio_send_stream_config.h",
|
2018-02-01 11:04:46 -08:00
|
|
|
]
|
|
|
|
|
|
|
|
|
|
deps = [
|
|
|
|
|
":rtc_event_log_api",
|
|
|
|
|
":rtc_stream_config",
|
|
|
|
|
"../modules/audio_coding:audio_network_adaptor_config",
|
2018-06-26 11:41:27 +02:00
|
|
|
"../rtc_base:ptr_util",
|
Use absl::make_unique and absl::WrapUnique directly
Instead of going through our wrappers in ptr_util.h.
This CL was generated by the following script:
git grep -l ptr_util | xargs perl -pi -e 's,#include "rtc_base/ptr_util.h",#include "absl/memory/memory.h",'
git grep -l MakeUnique | xargs perl -pi -e 's,\b(rtc::)?MakeUnique\b,absl::make_unique,g'
git grep -l WrapUnique | xargs perl -pi -e 's,\b(rtc::)?WrapUnique\b,absl::WrapUnique,g'
git checkout -- rtc_base/ptr_util{.h,_unittest.cc}
git cl format
Followed by manually adding dependencies on
//third_party/abseil-cpp/absl/memory until `gn check` stopped
complaining.
Bug: webrtc:9473
Change-Id: I89ccd363f070479b8c431eb2c3d404a46eaacc1c
Reviewed-on: https://webrtc-review.googlesource.com/86600
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23850}
2018-07-05 11:40:33 +02:00
|
|
|
"//third_party/abseil-cpp/absl/memory",
|
2018-02-01 11:04:46 -08:00
|
|
|
]
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
rtc_source_set("rtc_event_bwe") {
|
|
|
|
|
sources = [
|
2017-10-02 11:27:52 +02:00
|
|
|
"rtc_event_log/events/rtc_event_bwe_update_delay_based.cc",
|
|
|
|
|
"rtc_event_log/events/rtc_event_bwe_update_delay_based.h",
|
|
|
|
|
"rtc_event_log/events/rtc_event_bwe_update_loss_based.cc",
|
|
|
|
|
"rtc_event_log/events/rtc_event_bwe_update_loss_based.h",
|
|
|
|
|
"rtc_event_log/events/rtc_event_probe_cluster_created.cc",
|
|
|
|
|
"rtc_event_log/events/rtc_event_probe_cluster_created.h",
|
|
|
|
|
"rtc_event_log/events/rtc_event_probe_result_failure.cc",
|
|
|
|
|
"rtc_event_log/events/rtc_event_probe_result_failure.h",
|
|
|
|
|
"rtc_event_log/events/rtc_event_probe_result_success.cc",
|
|
|
|
|
"rtc_event_log/events/rtc_event_probe_result_success.h",
|
2018-02-01 11:04:46 -08:00
|
|
|
]
|
|
|
|
|
|
|
|
|
|
deps = [
|
|
|
|
|
":rtc_event_log_api",
|
|
|
|
|
"../modules/remote_bitrate_estimator:remote_bitrate_estimator",
|
2018-06-26 11:41:27 +02:00
|
|
|
"../rtc_base:ptr_util",
|
Use absl::make_unique and absl::WrapUnique directly
Instead of going through our wrappers in ptr_util.h.
This CL was generated by the following script:
git grep -l ptr_util | xargs perl -pi -e 's,#include "rtc_base/ptr_util.h",#include "absl/memory/memory.h",'
git grep -l MakeUnique | xargs perl -pi -e 's,\b(rtc::)?MakeUnique\b,absl::make_unique,g'
git grep -l WrapUnique | xargs perl -pi -e 's,\b(rtc::)?WrapUnique\b,absl::WrapUnique,g'
git checkout -- rtc_base/ptr_util{.h,_unittest.cc}
git cl format
Followed by manually adding dependencies on
//third_party/abseil-cpp/absl/memory until `gn check` stopped
complaining.
Bug: webrtc:9473
Change-Id: I89ccd363f070479b8c431eb2c3d404a46eaacc1c
Reviewed-on: https://webrtc-review.googlesource.com/86600
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23850}
2018-07-05 11:40:33 +02:00
|
|
|
"//third_party/abseil-cpp/absl/memory",
|
2018-02-01 11:04:46 -08:00
|
|
|
]
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
rtc_source_set("rtc_event_rtp_rtcp") {
|
|
|
|
|
sources = [
|
2017-10-02 11:27:52 +02:00
|
|
|
"rtc_event_log/events/rtc_event_rtcp_packet_incoming.cc",
|
|
|
|
|
"rtc_event_log/events/rtc_event_rtcp_packet_incoming.h",
|
|
|
|
|
"rtc_event_log/events/rtc_event_rtcp_packet_outgoing.cc",
|
|
|
|
|
"rtc_event_log/events/rtc_event_rtcp_packet_outgoing.h",
|
|
|
|
|
"rtc_event_log/events/rtc_event_rtp_packet_incoming.cc",
|
|
|
|
|
"rtc_event_log/events/rtc_event_rtp_packet_incoming.h",
|
|
|
|
|
"rtc_event_log/events/rtc_event_rtp_packet_outgoing.cc",
|
|
|
|
|
"rtc_event_log/events/rtc_event_rtp_packet_outgoing.h",
|
2018-02-01 11:04:46 -08:00
|
|
|
]
|
|
|
|
|
|
|
|
|
|
deps = [
|
|
|
|
|
":rtc_event_log_api",
|
|
|
|
|
"../api:array_view",
|
|
|
|
|
"../modules/rtp_rtcp:rtp_rtcp_format",
|
2018-06-26 11:41:27 +02:00
|
|
|
"../rtc_base:ptr_util",
|
2018-02-01 11:04:46 -08:00
|
|
|
"../rtc_base:rtc_base_approved",
|
Use absl::make_unique and absl::WrapUnique directly
Instead of going through our wrappers in ptr_util.h.
This CL was generated by the following script:
git grep -l ptr_util | xargs perl -pi -e 's,#include "rtc_base/ptr_util.h",#include "absl/memory/memory.h",'
git grep -l MakeUnique | xargs perl -pi -e 's,\b(rtc::)?MakeUnique\b,absl::make_unique,g'
git grep -l WrapUnique | xargs perl -pi -e 's,\b(rtc::)?WrapUnique\b,absl::WrapUnique,g'
git checkout -- rtc_base/ptr_util{.h,_unittest.cc}
git cl format
Followed by manually adding dependencies on
//third_party/abseil-cpp/absl/memory until `gn check` stopped
complaining.
Bug: webrtc:9473
Change-Id: I89ccd363f070479b8c431eb2c3d404a46eaacc1c
Reviewed-on: https://webrtc-review.googlesource.com/86600
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23850}
2018-07-05 11:40:33 +02:00
|
|
|
"//third_party/abseil-cpp/absl/memory",
|
2018-02-01 11:04:46 -08:00
|
|
|
]
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
rtc_source_set("rtc_event_video") {
|
|
|
|
|
sources = [
|
2017-10-02 11:27:52 +02:00
|
|
|
"rtc_event_log/events/rtc_event_video_receive_stream_config.cc",
|
|
|
|
|
"rtc_event_log/events/rtc_event_video_receive_stream_config.h",
|
|
|
|
|
"rtc_event_log/events/rtc_event_video_send_stream_config.cc",
|
|
|
|
|
"rtc_event_log/events/rtc_event_video_send_stream_config.h",
|
Moved RtcEventLog files from call/ to logging/
The RtcEventLog headers need to be accessible from any place which needs
logging, and the implementation needs access to data structures that are
logged.
After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future).
The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/).
This change allows using RtcEventLog in the p2p/ directory, so that we
can log STUN pings and ICE state transitions.
BUG=webrtc:6393
R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org
Review URL: https://codereview.webrtc.org/2380683005 .
Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
|
|
|
]
|
2017-10-04 13:18:26 +02:00
|
|
|
|
2017-03-08 02:12:11 -08:00
|
|
|
deps = [
|
2018-02-01 11:04:46 -08:00
|
|
|
":rtc_event_log_api",
|
|
|
|
|
":rtc_stream_config",
|
2018-06-26 11:41:27 +02:00
|
|
|
"../rtc_base:ptr_util",
|
Use absl::make_unique and absl::WrapUnique directly
Instead of going through our wrappers in ptr_util.h.
This CL was generated by the following script:
git grep -l ptr_util | xargs perl -pi -e 's,#include "rtc_base/ptr_util.h",#include "absl/memory/memory.h",'
git grep -l MakeUnique | xargs perl -pi -e 's,\b(rtc::)?MakeUnique\b,absl::make_unique,g'
git grep -l WrapUnique | xargs perl -pi -e 's,\b(rtc::)?WrapUnique\b,absl::WrapUnique,g'
git checkout -- rtc_base/ptr_util{.h,_unittest.cc}
git cl format
Followed by manually adding dependencies on
//third_party/abseil-cpp/absl/memory until `gn check` stopped
complaining.
Bug: webrtc:9473
Change-Id: I89ccd363f070479b8c431eb2c3d404a46eaacc1c
Reviewed-on: https://webrtc-review.googlesource.com/86600
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23850}
2018-07-05 11:40:33 +02:00
|
|
|
"//third_party/abseil-cpp/absl/memory",
|
2018-02-01 11:04:46 -08:00
|
|
|
]
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
rtc_static_library("rtc_event_log_impl_encoder") {
|
|
|
|
|
visibility = [ "*" ]
|
|
|
|
|
sources = [
|
2018-10-19 18:30:30 +02:00
|
|
|
"rtc_event_log/encoder/blob_encoding.cc",
|
|
|
|
|
"rtc_event_log/encoder/blob_encoding.h",
|
2018-10-18 13:43:35 +02:00
|
|
|
"rtc_event_log/encoder/delta_encoding.cc",
|
|
|
|
|
"rtc_event_log/encoder/delta_encoding.h",
|
2018-10-26 19:09:41 +02:00
|
|
|
"rtc_event_log/encoder/varint.cc",
|
|
|
|
|
"rtc_event_log/encoder/varint.h",
|
2018-02-01 11:04:46 -08:00
|
|
|
]
|
|
|
|
|
|
|
|
|
|
defines = []
|
|
|
|
|
|
|
|
|
|
deps = [
|
2017-12-13 16:05:42 +01:00
|
|
|
"../rtc_base:checks",
|
2017-07-19 10:40:47 -07:00
|
|
|
"../rtc_base:rtc_base_approved",
|
2018-10-18 13:43:35 +02:00
|
|
|
"//third_party/abseil-cpp/absl/memory",
|
2018-10-19 18:30:30 +02:00
|
|
|
"//third_party/abseil-cpp/absl/strings:strings",
|
2018-10-23 18:24:10 +02:00
|
|
|
"//third_party/abseil-cpp/absl/types:optional",
|
2017-03-08 02:12:11 -08:00
|
|
|
]
|
2017-10-04 13:18:26 +02:00
|
|
|
|
2018-02-01 11:04:46 -08:00
|
|
|
if (rtc_enable_protobuf) {
|
|
|
|
|
defines += [ "ENABLE_RTC_EVENT_LOG" ]
|
2018-10-24 13:51:56 +02:00
|
|
|
deps += [
|
|
|
|
|
":ice_log",
|
|
|
|
|
":rtc_event_audio",
|
|
|
|
|
":rtc_event_bwe",
|
|
|
|
|
":rtc_event_log2_proto",
|
|
|
|
|
":rtc_event_log_api",
|
|
|
|
|
":rtc_event_log_impl_output",
|
|
|
|
|
":rtc_event_log_proto",
|
|
|
|
|
":rtc_event_pacing",
|
|
|
|
|
":rtc_event_rtp_rtcp",
|
|
|
|
|
":rtc_event_video",
|
|
|
|
|
":rtc_stream_config",
|
|
|
|
|
"../api:array_view",
|
|
|
|
|
"../modules/audio_coding:audio_network_adaptor",
|
|
|
|
|
"../modules/remote_bitrate_estimator:remote_bitrate_estimator",
|
|
|
|
|
"../modules/rtp_rtcp:rtp_rtcp_format",
|
|
|
|
|
]
|
|
|
|
|
sources += [
|
|
|
|
|
"rtc_event_log/encoder/rtc_event_log_encoder_legacy.cc",
|
|
|
|
|
"rtc_event_log/encoder/rtc_event_log_encoder_legacy.h",
|
|
|
|
|
"rtc_event_log/encoder/rtc_event_log_encoder_new_format.cc",
|
|
|
|
|
"rtc_event_log/encoder/rtc_event_log_encoder_new_format.h",
|
|
|
|
|
]
|
2018-02-01 11:04:46 -08:00
|
|
|
}
|
Moved RtcEventLog files from call/ to logging/
The RtcEventLog headers need to be accessible from any place which needs
logging, and the implementation needs access to data structures that are
logged.
After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future).
The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/).
This change allows using RtcEventLog in the p2p/ directory, so that we
can log STUN pings and ICE state transitions.
BUG=webrtc:6393
R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org
Review URL: https://codereview.webrtc.org/2380683005 .
Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
|
|
|
}
|
|
|
|
|
|
2018-02-01 11:04:46 -08:00
|
|
|
rtc_source_set("rtc_event_log_impl_output") {
|
|
|
|
|
sources = [
|
|
|
|
|
"rtc_event_log/output/rtc_event_log_output_file.cc",
|
|
|
|
|
"rtc_event_log/output/rtc_event_log_output_file.h",
|
|
|
|
|
]
|
|
|
|
|
|
|
|
|
|
deps = [
|
|
|
|
|
":rtc_event_log_api",
|
|
|
|
|
"../api:libjingle_logging_api",
|
|
|
|
|
"../rtc_base:checks",
|
|
|
|
|
"../rtc_base:rtc_base_approved",
|
|
|
|
|
]
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
rtc_static_library("rtc_event_log_impl_base") {
|
2018-01-10 15:54:53 +00:00
|
|
|
visibility = [ "*" ]
|
Moved RtcEventLog files from call/ to logging/
The RtcEventLog headers need to be accessible from any place which needs
logging, and the implementation needs access to data structures that are
logged.
After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future).
The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/).
This change allows using RtcEventLog in the p2p/ directory, so that we
can log STUN pings and ICE state transitions.
BUG=webrtc:6393
R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org
Review URL: https://codereview.webrtc.org/2380683005 .
Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
|
|
|
sources = [
|
2017-06-15 12:52:32 -07:00
|
|
|
"rtc_event_log/rtc_event_log_factory.cc",
|
|
|
|
|
"rtc_event_log/rtc_event_log_factory.h",
|
2018-02-01 11:04:46 -08:00
|
|
|
"rtc_event_log/rtc_event_log_impl.cc",
|
Moved RtcEventLog files from call/ to logging/
The RtcEventLog headers need to be accessible from any place which needs
logging, and the implementation needs access to data structures that are
logged.
After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future).
The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/).
This change allows using RtcEventLog in the p2p/ directory, so that we
can log STUN pings and ICE state transitions.
BUG=webrtc:6393
R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org
Review URL: https://codereview.webrtc.org/2380683005 .
Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
|
|
|
]
|
|
|
|
|
|
|
|
|
|
defines = []
|
|
|
|
|
|
|
|
|
|
deps = [
|
2018-02-02 11:49:44 -08:00
|
|
|
":ice_log",
|
Moved RtcEventLog files from call/ to logging/
The RtcEventLog headers need to be accessible from any place which needs
logging, and the implementation needs access to data structures that are
logged.
After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future).
The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/).
This change allows using RtcEventLog in the p2p/ directory, so that we
can log STUN pings and ICE state transitions.
BUG=webrtc:6393
R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org
Review URL: https://codereview.webrtc.org/2380683005 .
Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
|
|
|
":rtc_event_log_api",
|
2018-10-24 13:51:56 +02:00
|
|
|
"../api:libjingle_logging_api",
|
2017-12-13 16:05:42 +01:00
|
|
|
"../rtc_base:checks",
|
2017-07-19 10:40:47 -07:00
|
|
|
"../rtc_base:rtc_base_approved",
|
2018-03-19 11:12:48 +01:00
|
|
|
"../rtc_base:rtc_task_queue",
|
2018-03-07 14:18:56 +01:00
|
|
|
"../rtc_base:safe_minmax",
|
2017-09-06 05:18:15 -07:00
|
|
|
"../rtc_base:sequenced_task_checker",
|
Use absl::make_unique and absl::WrapUnique directly
Instead of going through our wrappers in ptr_util.h.
This CL was generated by the following script:
git grep -l ptr_util | xargs perl -pi -e 's,#include "rtc_base/ptr_util.h",#include "absl/memory/memory.h",'
git grep -l MakeUnique | xargs perl -pi -e 's,\b(rtc::)?MakeUnique\b,absl::make_unique,g'
git grep -l WrapUnique | xargs perl -pi -e 's,\b(rtc::)?WrapUnique\b,absl::WrapUnique,g'
git checkout -- rtc_base/ptr_util{.h,_unittest.cc}
git cl format
Followed by manually adding dependencies on
//third_party/abseil-cpp/absl/memory until `gn check` stopped
complaining.
Bug: webrtc:9473
Change-Id: I89ccd363f070479b8c431eb2c3d404a46eaacc1c
Reviewed-on: https://webrtc-review.googlesource.com/86600
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23850}
2018-07-05 11:40:33 +02:00
|
|
|
"//third_party/abseil-cpp/absl/memory",
|
Moved RtcEventLog files from call/ to logging/
The RtcEventLog headers need to be accessible from any place which needs
logging, and the implementation needs access to data structures that are
logged.
After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future).
The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/).
This change allows using RtcEventLog in the p2p/ directory, so that we
can log STUN pings and ICE state transitions.
BUG=webrtc:6393
R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org
Review URL: https://codereview.webrtc.org/2380683005 .
Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
|
|
|
]
|
|
|
|
|
|
|
|
|
|
if (rtc_enable_protobuf) {
|
|
|
|
|
defines += [ "ENABLE_RTC_EVENT_LOG" ]
|
2018-10-24 13:51:56 +02:00
|
|
|
deps += [ ":rtc_event_log_impl_encoder" ]
|
Moved RtcEventLog files from call/ to logging/
The RtcEventLog headers need to be accessible from any place which needs
logging, and the implementation needs access to data structures that are
logged.
After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future).
The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/).
This change allows using RtcEventLog in the p2p/ directory, so that we
can log STUN pings and ICE state transitions.
BUG=webrtc:6393
R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org
Review URL: https://codereview.webrtc.org/2380683005 .
Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2018-06-11 20:15:46 -07:00
|
|
|
rtc_source_set("fake_rtc_event_log") {
|
|
|
|
|
testonly = true
|
|
|
|
|
sources = [
|
|
|
|
|
"rtc_event_log/fake_rtc_event_log.cc",
|
|
|
|
|
"rtc_event_log/fake_rtc_event_log.h",
|
|
|
|
|
"rtc_event_log/fake_rtc_event_log_factory.cc",
|
|
|
|
|
"rtc_event_log/fake_rtc_event_log_factory.h",
|
|
|
|
|
]
|
|
|
|
|
|
|
|
|
|
deps = [
|
|
|
|
|
":ice_log",
|
|
|
|
|
":rtc_event_log_api",
|
|
|
|
|
"../rtc_base:checks",
|
|
|
|
|
"../rtc_base:rtc_base",
|
|
|
|
|
]
|
|
|
|
|
}
|
|
|
|
|
|
Moved RtcEventLog files from call/ to logging/
The RtcEventLog headers need to be accessible from any place which needs
logging, and the implementation needs access to data structures that are
logged.
After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future).
The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/).
This change allows using RtcEventLog in the p2p/ directory, so that we
can log STUN pings and ICE state transitions.
BUG=webrtc:6393
R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org
Review URL: https://codereview.webrtc.org/2380683005 .
Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
|
|
|
if (rtc_enable_protobuf) {
|
|
|
|
|
proto_library("rtc_event_log_proto") {
|
|
|
|
|
sources = [
|
|
|
|
|
"rtc_event_log/rtc_event_log.proto",
|
|
|
|
|
]
|
2017-09-15 06:47:31 +02:00
|
|
|
proto_out_dir = "logging/rtc_event_log"
|
Moved RtcEventLog files from call/ to logging/
The RtcEventLog headers need to be accessible from any place which needs
logging, and the implementation needs access to data structures that are
logged.
After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future).
The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/).
This change allows using RtcEventLog in the p2p/ directory, so that we
can log STUN pings and ICE state transitions.
BUG=webrtc:6393
R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org
Review URL: https://codereview.webrtc.org/2380683005 .
Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
|
|
|
}
|
|
|
|
|
|
Reland "New protobuf format for event log.""""
This reverts commit 6cfbc35ad7e6c64874c1e2dbd58b8d7c4ab3a679.
Reason for revert: Fixing downstream projects.
Original change's description:
> Revert "Revert "Revert "New protobuf format for event log."""
>
> This reverts commit ef8f42040367b3809295a007d7eeeff4526e1b39.
>
> Reason for revert: New problems with downstream project.
>
> Original change's description:
> > Revert "Revert "New protobuf format for event log.""
> >
> > This reverts commit 546373fc66e24d041e8eb8ffd2fc522847d841d1.
> >
> > Reason for revert: Downstream project fixed.
> >
> > Original change's description:
> > > Revert "New protobuf format for event log."
> > >
> > > This reverts commit 99463c14dbbc88732f0991cb30e7bbfcdaeb3cdc.
> > >
> > > Reason for revert: Speculative revert for downstream project breakage.
> > >
> > > Original change's description:
> > > > New protobuf format for event log.
> > > >
> > > > Bug: webrtc:6295
> > > > Change-Id: Ie20a2808a4f076b05fb6195f4fed73215f6fd3b2
> > > > Reviewed-on: https://webrtc-review.googlesource.com/8880
> > > > Commit-Queue: Björn Terelius <terelius@webrtc.org>
> > > > Reviewed-by: Per Kjellander <perkj@webrtc.org>
> > > > Reviewed-by: Dino Radaković <dinor@webrtc.org>
> > > > Cr-Commit-Position: refs/heads/master@{#21291}
> > >
> > > TBR=terelius@webrtc.org,perkj@webrtc.org,dinor@webrtc.org
> > >
> > > Change-Id: Ic319170a7a777002ca29248d102cb4e26966d5ae
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: webrtc:6295
> > > Reviewed-on: https://webrtc-review.googlesource.com/33400
> > > Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
> > > Commit-Queue: Rasmus Brandt <brandtr@webrtc.org>
> > > Cr-Commit-Position: refs/heads/master@{#21292}
> >
> > TBR=brandtr@webrtc.org,terelius@webrtc.org,perkj@webrtc.org,dinor@webrtc.org
> >
> > Change-Id: I9e96e5007d0447e63178d47c7330488b2a8f2b6f
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: webrtc:6295
> > Reviewed-on: https://webrtc-review.googlesource.com/33440
> > Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
> > Commit-Queue: Rasmus Brandt <brandtr@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#21296}
>
> TBR=brandtr@webrtc.org,terelius@webrtc.org,perkj@webrtc.org,dinor@webrtc.org
>
> Change-Id: I4eb15c809f67af13ffa7b7df6eb06088af21f63f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:6295
> Reviewed-on: https://webrtc-review.googlesource.com/33480
> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
> Commit-Queue: Rasmus Brandt <brandtr@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#21297}
TBR=brandtr@webrtc.org,terelius@webrtc.org,perkj@webrtc.org,dinor@webrtc.org
Change-Id: I7895575f2b6e4ec2c36296fe81a7596147158601
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:6295
Reviewed-on: https://webrtc-review.googlesource.com/33520
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21299}
2017-12-15 17:12:42 +01:00
|
|
|
proto_library("rtc_event_log2_proto") {
|
|
|
|
|
sources = [
|
|
|
|
|
"rtc_event_log/rtc_event_log2.proto",
|
|
|
|
|
]
|
|
|
|
|
proto_out_dir = "logging/rtc_event_log"
|
|
|
|
|
}
|
|
|
|
|
|
Moved RtcEventLog files from call/ to logging/
The RtcEventLog headers need to be accessible from any place which needs
logging, and the implementation needs access to data structures that are
logged.
After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future).
The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/).
This change allows using RtcEventLog in the p2p/ directory, so that we
can log STUN pings and ICE state transitions.
BUG=webrtc:6393
R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org
Review URL: https://codereview.webrtc.org/2380683005 .
Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
|
|
|
rtc_static_library("rtc_event_log_parser") {
|
2018-04-26 14:46:06 +02:00
|
|
|
visibility = [ "*" ]
|
Moved RtcEventLog files from call/ to logging/
The RtcEventLog headers need to be accessible from any place which needs
logging, and the implementation needs access to data structures that are
logged.
After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future).
The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/).
This change allows using RtcEventLog in the p2p/ directory, so that we
can log STUN pings and ICE state transitions.
BUG=webrtc:6393
R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org
Review URL: https://codereview.webrtc.org/2380683005 .
Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
|
|
|
sources = [
|
2018-04-25 14:23:01 +00:00
|
|
|
"rtc_event_log/rtc_event_log_parser.cc",
|
|
|
|
|
"rtc_event_log/rtc_event_log_parser.h",
|
2018-04-27 14:33:34 +02:00
|
|
|
"rtc_event_log/rtc_event_log_parser_new.cc",
|
|
|
|
|
"rtc_event_log/rtc_event_log_parser_new.h",
|
2018-09-24 17:10:27 +02:00
|
|
|
"rtc_event_log/rtc_event_processor.h",
|
Moved RtcEventLog files from call/ to logging/
The RtcEventLog headers need to be accessible from any place which needs
logging, and the implementation needs access to data structures that are
logged.
After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future).
The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/).
This change allows using RtcEventLog in the p2p/ directory, so that we
can log STUN pings and ICE state transitions.
BUG=webrtc:6393
R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org
Review URL: https://codereview.webrtc.org/2380683005 .
Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
|
|
|
]
|
|
|
|
|
|
2017-12-12 12:46:13 +01:00
|
|
|
deps = [
|
2018-02-02 11:49:44 -08:00
|
|
|
":ice_log",
|
2018-02-01 11:04:46 -08:00
|
|
|
":rtc_event_bwe",
|
Reland "New protobuf format for event log.""""
This reverts commit 6cfbc35ad7e6c64874c1e2dbd58b8d7c4ab3a679.
Reason for revert: Fixing downstream projects.
Original change's description:
> Revert "Revert "Revert "New protobuf format for event log."""
>
> This reverts commit ef8f42040367b3809295a007d7eeeff4526e1b39.
>
> Reason for revert: New problems with downstream project.
>
> Original change's description:
> > Revert "Revert "New protobuf format for event log.""
> >
> > This reverts commit 546373fc66e24d041e8eb8ffd2fc522847d841d1.
> >
> > Reason for revert: Downstream project fixed.
> >
> > Original change's description:
> > > Revert "New protobuf format for event log."
> > >
> > > This reverts commit 99463c14dbbc88732f0991cb30e7bbfcdaeb3cdc.
> > >
> > > Reason for revert: Speculative revert for downstream project breakage.
> > >
> > > Original change's description:
> > > > New protobuf format for event log.
> > > >
> > > > Bug: webrtc:6295
> > > > Change-Id: Ie20a2808a4f076b05fb6195f4fed73215f6fd3b2
> > > > Reviewed-on: https://webrtc-review.googlesource.com/8880
> > > > Commit-Queue: Björn Terelius <terelius@webrtc.org>
> > > > Reviewed-by: Per Kjellander <perkj@webrtc.org>
> > > > Reviewed-by: Dino Radaković <dinor@webrtc.org>
> > > > Cr-Commit-Position: refs/heads/master@{#21291}
> > >
> > > TBR=terelius@webrtc.org,perkj@webrtc.org,dinor@webrtc.org
> > >
> > > Change-Id: Ic319170a7a777002ca29248d102cb4e26966d5ae
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: webrtc:6295
> > > Reviewed-on: https://webrtc-review.googlesource.com/33400
> > > Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
> > > Commit-Queue: Rasmus Brandt <brandtr@webrtc.org>
> > > Cr-Commit-Position: refs/heads/master@{#21292}
> >
> > TBR=brandtr@webrtc.org,terelius@webrtc.org,perkj@webrtc.org,dinor@webrtc.org
> >
> > Change-Id: I9e96e5007d0447e63178d47c7330488b2a8f2b6f
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: webrtc:6295
> > Reviewed-on: https://webrtc-review.googlesource.com/33440
> > Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
> > Commit-Queue: Rasmus Brandt <brandtr@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#21296}
>
> TBR=brandtr@webrtc.org,terelius@webrtc.org,perkj@webrtc.org,dinor@webrtc.org
>
> Change-Id: I4eb15c809f67af13ffa7b7df6eb06088af21f63f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:6295
> Reviewed-on: https://webrtc-review.googlesource.com/33480
> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
> Commit-Queue: Rasmus Brandt <brandtr@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#21297}
TBR=brandtr@webrtc.org,terelius@webrtc.org,perkj@webrtc.org,dinor@webrtc.org
Change-Id: I7895575f2b6e4ec2c36296fe81a7596147158601
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:6295
Reviewed-on: https://webrtc-review.googlesource.com/33520
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21299}
2017-12-15 17:12:42 +01:00
|
|
|
":rtc_event_log2_proto",
|
2017-03-08 02:12:11 -08:00
|
|
|
":rtc_event_log_api",
|
Moved RtcEventLog files from call/ to logging/
The RtcEventLog headers need to be accessible from any place which needs
logging, and the implementation needs access to data structures that are
logged.
After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future).
The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/).
This change allows using RtcEventLog in the p2p/ directory, so that we
can log STUN pings and ICE state transitions.
BUG=webrtc:6393
R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org
Review URL: https://codereview.webrtc.org/2380683005 .
Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
|
|
|
":rtc_event_log_proto",
|
2018-02-01 11:04:46 -08:00
|
|
|
":rtc_stream_config",
|
Moved RtcEventLog files from call/ to logging/
The RtcEventLog headers need to be accessible from any place which needs
logging, and the implementation needs access to data structures that are
logged.
After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future).
The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/).
This change allows using RtcEventLog in the p2p/ directory, so that we
can log STUN pings and ICE state transitions.
BUG=webrtc:6393
R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org
Review URL: https://codereview.webrtc.org/2380683005 .
Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
|
|
|
"..:webrtc_common",
|
2018-04-27 14:33:34 +02:00
|
|
|
"../api:libjingle_peerconnection_api",
|
2017-12-12 12:46:13 +01:00
|
|
|
"../call:video_stream_api",
|
2017-04-06 05:59:10 -07:00
|
|
|
"../modules/audio_coding:audio_network_adaptor",
|
2018-10-15 20:59:07 +02:00
|
|
|
"../modules/congestion_controller/rtp:transport_feedback",
|
2017-04-11 00:49:44 -07:00
|
|
|
"../modules/remote_bitrate_estimator:remote_bitrate_estimator",
|
2017-12-06 07:51:33 +01:00
|
|
|
"../modules/rtp_rtcp",
|
2017-12-12 12:46:13 +01:00
|
|
|
"../modules/rtp_rtcp:rtp_rtcp_format",
|
2017-12-13 16:05:42 +01:00
|
|
|
"../rtc_base:checks",
|
2017-12-12 12:46:13 +01:00
|
|
|
"../rtc_base:protobuf_utils",
|
|
|
|
|
"../rtc_base:rtc_base_approved",
|
Use absl::make_unique and absl::WrapUnique directly
Instead of going through our wrappers in ptr_util.h.
This CL was generated by the following script:
git grep -l ptr_util | xargs perl -pi -e 's,#include "rtc_base/ptr_util.h",#include "absl/memory/memory.h",'
git grep -l MakeUnique | xargs perl -pi -e 's,\b(rtc::)?MakeUnique\b,absl::make_unique,g'
git grep -l WrapUnique | xargs perl -pi -e 's,\b(rtc::)?WrapUnique\b,absl::WrapUnique,g'
git checkout -- rtc_base/ptr_util{.h,_unittest.cc}
git cl format
Followed by manually adding dependencies on
//third_party/abseil-cpp/absl/memory until `gn check` stopped
complaining.
Bug: webrtc:9473
Change-Id: I89ccd363f070479b8c431eb2c3d404a46eaacc1c
Reviewed-on: https://webrtc-review.googlesource.com/86600
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23850}
2018-07-05 11:40:33 +02:00
|
|
|
"//third_party/abseil-cpp/absl/memory",
|
2018-10-02 13:20:40 +02:00
|
|
|
"//third_party/abseil-cpp/absl/types:optional",
|
Moved RtcEventLog files from call/ to logging/
The RtcEventLog headers need to be accessible from any place which needs
logging, and the implementation needs access to data structures that are
logged.
After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future).
The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/).
This change allows using RtcEventLog in the p2p/ directory, so that we
can log STUN pings and ICE state transitions.
BUG=webrtc:6393
R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org
Review URL: https://codereview.webrtc.org/2380683005 .
Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
|
|
|
]
|
|
|
|
|
}
|
2017-01-17 02:37:34 -08:00
|
|
|
|
|
|
|
|
if (rtc_include_tests) {
|
|
|
|
|
rtc_source_set("rtc_event_log_tests") {
|
|
|
|
|
testonly = true
|
2017-10-03 15:01:03 +02:00
|
|
|
assert(rtc_enable_protobuf)
|
|
|
|
|
defines = [ "ENABLE_RTC_EVENT_LOG" ]
|
2017-01-17 02:37:34 -08:00
|
|
|
sources = [
|
2018-10-19 18:30:30 +02:00
|
|
|
"rtc_event_log/encoder/blob_encoding_unittest.cc",
|
2018-10-18 13:43:35 +02:00
|
|
|
"rtc_event_log/encoder/delta_encoding_unittest.cc",
|
2017-10-03 15:01:03 +02:00
|
|
|
"rtc_event_log/encoder/rtc_event_log_encoder_unittest.cc",
|
2017-10-04 13:18:26 +02:00
|
|
|
"rtc_event_log/output/rtc_event_log_output_file_unittest.cc",
|
2017-01-17 02:37:34 -08:00
|
|
|
"rtc_event_log/rtc_event_log_unittest.cc",
|
|
|
|
|
"rtc_event_log/rtc_event_log_unittest_helper.cc",
|
2017-08-17 08:32:39 -07:00
|
|
|
"rtc_event_log/rtc_event_log_unittest_helper.h",
|
2018-09-24 17:10:27 +02:00
|
|
|
"rtc_event_log/rtc_event_processor_unittest.cc",
|
2017-01-17 02:37:34 -08:00
|
|
|
]
|
|
|
|
|
deps = [
|
2018-06-26 11:41:27 +02:00
|
|
|
":ice_log",
|
2018-02-01 11:04:46 -08:00
|
|
|
":rtc_event_audio",
|
|
|
|
|
":rtc_event_bwe",
|
2018-10-24 13:51:56 +02:00
|
|
|
":rtc_event_log2_proto",
|
2017-12-12 12:46:13 +01:00
|
|
|
":rtc_event_log_api",
|
2018-02-01 11:04:46 -08:00
|
|
|
":rtc_event_log_impl_base",
|
|
|
|
|
":rtc_event_log_impl_encoder",
|
|
|
|
|
":rtc_event_log_impl_output",
|
2017-01-17 02:37:34 -08:00
|
|
|
":rtc_event_log_parser",
|
2017-12-12 12:46:13 +01:00
|
|
|
":rtc_event_log_proto",
|
2018-06-26 11:41:27 +02:00
|
|
|
":rtc_event_pacing",
|
2018-02-01 11:04:46 -08:00
|
|
|
":rtc_event_rtp_rtcp",
|
|
|
|
|
":rtc_event_video",
|
|
|
|
|
":rtc_stream_config",
|
2017-12-04 10:50:51 +01:00
|
|
|
"../api:libjingle_peerconnection_api",
|
2017-01-17 02:37:34 -08:00
|
|
|
"../call",
|
2017-12-04 10:50:51 +01:00
|
|
|
"../call:call_interfaces",
|
2017-04-06 05:59:10 -07:00
|
|
|
"../modules/audio_coding:audio_network_adaptor",
|
2017-04-11 00:49:44 -07:00
|
|
|
"../modules/remote_bitrate_estimator:remote_bitrate_estimator",
|
2017-12-06 07:51:33 +01:00
|
|
|
"../modules/rtp_rtcp:rtp_rtcp_format",
|
2017-12-13 16:05:42 +01:00
|
|
|
"../rtc_base:checks",
|
2017-07-19 10:40:47 -07:00
|
|
|
"../rtc_base:rtc_base_approved",
|
|
|
|
|
"../rtc_base:rtc_base_tests_utils",
|
2018-03-15 15:05:39 +01:00
|
|
|
"../test:fileutils",
|
2017-03-08 02:12:11 -08:00
|
|
|
"../test:test_support",
|
2017-01-17 02:37:34 -08:00
|
|
|
"//testing/gtest",
|
Use absl::make_unique and absl::WrapUnique directly
Instead of going through our wrappers in ptr_util.h.
This CL was generated by the following script:
git grep -l ptr_util | xargs perl -pi -e 's,#include "rtc_base/ptr_util.h",#include "absl/memory/memory.h",'
git grep -l MakeUnique | xargs perl -pi -e 's,\b(rtc::)?MakeUnique\b,absl::make_unique,g'
git grep -l WrapUnique | xargs perl -pi -e 's,\b(rtc::)?WrapUnique\b,absl::WrapUnique,g'
git checkout -- rtc_base/ptr_util{.h,_unittest.cc}
git cl format
Followed by manually adding dependencies on
//third_party/abseil-cpp/absl/memory until `gn check` stopped
complaining.
Bug: webrtc:9473
Change-Id: I89ccd363f070479b8c431eb2c3d404a46eaacc1c
Reviewed-on: https://webrtc-review.googlesource.com/86600
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23850}
2018-07-05 11:40:33 +02:00
|
|
|
"//third_party/abseil-cpp/absl/memory",
|
2018-10-30 22:23:02 +01:00
|
|
|
"//third_party/abseil-cpp/absl/types:optional",
|
2017-01-17 02:37:34 -08:00
|
|
|
]
|
|
|
|
|
if (!build_with_chromium && is_clang) {
|
|
|
|
|
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
|
|
|
|
|
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
|
|
|
|
|
}
|
|
|
|
|
}
|
2018-07-16 15:38:06 +02:00
|
|
|
|
2017-02-08 00:28:09 -08:00
|
|
|
rtc_test("rtc_event_log2rtp_dump") {
|
|
|
|
|
testonly = true
|
|
|
|
|
sources = [
|
|
|
|
|
"rtc_event_log/rtc_event_log2rtp_dump.cc",
|
|
|
|
|
]
|
|
|
|
|
deps = [
|
|
|
|
|
":rtc_event_log_api",
|
|
|
|
|
":rtc_event_log_parser",
|
2017-12-12 12:46:13 +01:00
|
|
|
"../modules/rtp_rtcp",
|
2017-12-06 07:51:33 +01:00
|
|
|
"../modules/rtp_rtcp:rtp_rtcp_format",
|
2017-12-13 16:05:42 +01:00
|
|
|
"../rtc_base:checks",
|
2017-12-12 12:46:13 +01:00
|
|
|
"../rtc_base:protobuf_utils",
|
2017-07-19 10:40:47 -07:00
|
|
|
"../rtc_base:rtc_base_approved",
|
2017-02-08 00:28:09 -08:00
|
|
|
"../test:rtp_test_utils",
|
2018-09-24 17:10:27 +02:00
|
|
|
"//third_party/abseil-cpp/absl/memory:memory",
|
|
|
|
|
"//third_party/abseil-cpp/absl/types:optional",
|
2017-02-08 00:28:09 -08:00
|
|
|
]
|
|
|
|
|
if (!build_with_chromium && is_clang) {
|
|
|
|
|
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
|
|
|
|
|
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
|
|
|
|
|
}
|
|
|
|
|
}
|
2017-01-17 02:37:34 -08:00
|
|
|
}
|
2018-01-03 09:08:20 +01:00
|
|
|
|
2017-02-08 04:22:53 -08:00
|
|
|
if (rtc_include_tests) {
|
|
|
|
|
rtc_executable("rtc_event_log2text") {
|
|
|
|
|
testonly = true
|
|
|
|
|
sources = [
|
|
|
|
|
"rtc_event_log/rtc_event_log2text.cc",
|
|
|
|
|
]
|
|
|
|
|
deps = [
|
|
|
|
|
":rtc_event_log_api",
|
|
|
|
|
":rtc_event_log_parser",
|
2017-12-12 12:46:13 +01:00
|
|
|
"../:webrtc_common",
|
2017-09-01 15:29:28 +02:00
|
|
|
"../call:video_stream_api",
|
2017-12-06 07:51:33 +01:00
|
|
|
"../modules/rtp_rtcp:rtp_rtcp_format",
|
2017-12-13 16:05:42 +01:00
|
|
|
"../rtc_base:checks",
|
2017-12-12 12:46:13 +01:00
|
|
|
"../rtc_base:protobuf_utils",
|
2017-07-19 10:40:47 -07:00
|
|
|
"../rtc_base:rtc_base_approved",
|
2018-04-27 14:33:34 +02:00
|
|
|
"../rtc_base:stringutils",
|
2017-02-08 09:37:30 -08:00
|
|
|
|
|
|
|
|
# TODO(kwiberg): Remove this dependency.
|
2017-02-10 08:15:44 -08:00
|
|
|
"../api/audio_codecs:audio_codecs_api",
|
2017-09-15 16:13:21 +02:00
|
|
|
"../modules/audio_coding:audio_network_adaptor_config",
|
2017-12-06 07:51:33 +01:00
|
|
|
"../modules/rtp_rtcp",
|
2017-02-08 04:22:53 -08:00
|
|
|
]
|
|
|
|
|
if (!build_with_chromium && is_clang) {
|
|
|
|
|
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
|
|
|
|
|
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
2017-04-28 07:48:17 -07:00
|
|
|
if (rtc_include_tests) {
|
|
|
|
|
rtc_executable("rtc_event_log2stats") {
|
|
|
|
|
testonly = true
|
|
|
|
|
sources = [
|
|
|
|
|
"rtc_event_log/rtc_event_log2stats.cc",
|
|
|
|
|
]
|
|
|
|
|
deps = [
|
|
|
|
|
":rtc_event_log_api",
|
|
|
|
|
":rtc_event_log_proto",
|
2017-12-13 16:05:42 +01:00
|
|
|
"../rtc_base:checks",
|
2017-07-19 10:40:47 -07:00
|
|
|
"../rtc_base:rtc_base_approved",
|
2017-04-28 07:48:17 -07:00
|
|
|
]
|
|
|
|
|
}
|
|
|
|
|
}
|
Moved RtcEventLog files from call/ to logging/
The RtcEventLog headers need to be accessible from any place which needs
logging, and the implementation needs access to data structures that are
logged.
After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future).
The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/).
This change allows using RtcEventLog in the p2p/ directory, so that we
can log STUN pings and ICE state transitions.
BUG=webrtc:6393
R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org
Review URL: https://codereview.webrtc.org/2380683005 .
Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
|
|
|
}
|
2018-01-03 09:08:20 +01:00
|
|
|
|
2018-02-02 11:49:44 -08:00
|
|
|
rtc_source_set("ice_log") {
|
|
|
|
|
sources = [
|
|
|
|
|
"rtc_event_log/events/rtc_event_ice_candidate_pair.cc",
|
|
|
|
|
"rtc_event_log/events/rtc_event_ice_candidate_pair.h",
|
|
|
|
|
"rtc_event_log/events/rtc_event_ice_candidate_pair_config.cc",
|
|
|
|
|
"rtc_event_log/events/rtc_event_ice_candidate_pair_config.h",
|
|
|
|
|
"rtc_event_log/icelogger.cc",
|
|
|
|
|
"rtc_event_log/icelogger.h",
|
|
|
|
|
]
|
|
|
|
|
|
|
|
|
|
deps = [
|
|
|
|
|
":rtc_event_log_api",
|
|
|
|
|
"../api:libjingle_logging_api",
|
|
|
|
|
"../rtc_base:rtc_base_approved",
|
Use absl::make_unique and absl::WrapUnique directly
Instead of going through our wrappers in ptr_util.h.
This CL was generated by the following script:
git grep -l ptr_util | xargs perl -pi -e 's,#include "rtc_base/ptr_util.h",#include "absl/memory/memory.h",'
git grep -l MakeUnique | xargs perl -pi -e 's,\b(rtc::)?MakeUnique\b,absl::make_unique,g'
git grep -l WrapUnique | xargs perl -pi -e 's,\b(rtc::)?WrapUnique\b,absl::WrapUnique,g'
git checkout -- rtc_base/ptr_util{.h,_unittest.cc}
git cl format
Followed by manually adding dependencies on
//third_party/abseil-cpp/absl/memory until `gn check` stopped
complaining.
Bug: webrtc:9473
Change-Id: I89ccd363f070479b8c431eb2c3d404a46eaacc1c
Reviewed-on: https://webrtc-review.googlesource.com/86600
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23850}
2018-07-05 11:40:33 +02:00
|
|
|
"//third_party/abseil-cpp/absl/memory",
|
2018-02-02 11:49:44 -08:00
|
|
|
]
|
|
|
|
|
}
|
|
|
|
|
|
2018-01-03 09:08:20 +01:00
|
|
|
if (rtc_include_tests) {
|
|
|
|
|
rtc_source_set("mocks") {
|
|
|
|
|
testonly = true
|
|
|
|
|
sources = [
|
2018-03-09 15:37:03 +00:00
|
|
|
"rtc_event_log/mock/mock_rtc_event_log.cc",
|
2018-01-03 09:08:20 +01:00
|
|
|
"rtc_event_log/mock/mock_rtc_event_log.h",
|
|
|
|
|
]
|
|
|
|
|
deps = [
|
|
|
|
|
":rtc_event_log_api",
|
2018-07-23 10:04:12 +02:00
|
|
|
"../test:test_support",
|
2018-01-03 09:08:20 +01:00
|
|
|
]
|
|
|
|
|
}
|
|
|
|
|
}
|