admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
webrtc_m130/logging/BUILD.gn

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

467 lines
14 KiB
Plaintext
Raw Normal View History

Moved RtcEventLog files from call/ to logging/ The RtcEventLog headers need to be accessible from any place which needs logging, and the implementation needs access to data structures that are logged. After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future). The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/). This change allows using RtcEventLog in the p2p/ directory, so that we can log STUN pings and ICE state transitions. BUG=webrtc:6393 R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org Review URL: https://codereview.webrtc.org/2380683005 . Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
# Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
#
# Use of this source code is governed by a BSD-style license
# that can be found in the LICENSE file in the root of the source
# tree. An additional intellectual property rights grant can be found
# in the file PATENTS. All contributing project authors may
# be found in the AUTHORS file in the root of the source tree.
Reland of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2657563002/ ) Reason for revert: Starting to work on a fix (it seems that there are third_party dependencies that depends on the path to the webrtc.gni file) Original issue's description: > Revert of Moving webrtc.gni up one level from build/ (patchset #1 id:1 of https://codereview.webrtc.org/2651543003/ ) > > Reason for revert: > This was causing the following failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/838/steps/generate_build_files/logs/stdio > > Original issue's description: > > Moving webrtc.gni up one level from build/ > > > > BUG=webrtc:7030 > > > > Review-Url: https://codereview.webrtc.org/2651543003 > > Cr-Commit-Position: refs/heads/master@{#16241} > > Committed: https://chromium.googlesource.com/external/webrtc/+/35a32700fc9b5d932ddbd528c12f59c3274e4774 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7030 > > Review-Url: https://codereview.webrtc.org/2657563002 > Cr-Commit-Position: refs/heads/master@{#16244} > Committed: https://chromium.googlesource.com/external/webrtc/+/69dc7dbe247ead087f3bae0eb7e23f27f0de1ec3 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2654773002 Cr-Commit-Position: refs/heads/master@{#16247}
2017-01-24 06:58:22 -08:00
import("../webrtc.gni")
Import proto_library.gni when rtc_enable_protobuf is true Import proto_library.gni when rtc_enable_protobuf is true instead of when build_with_mozilla is false. Makes it maybe easier to reason about the intention (e.g. intention is to not compile any protobuf in, hence flag rtc_enable_protobuf) The build file could not work if build_with_mozilla = true but rtc_enable_protobuf = true. Bug: webrtc:10338 Change-Id: I26e5983bd1519aa46c308b11796d518de5ef7597 Reviewed-on: https://webrtc-review.googlesource.com/c/123763 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26868}
2019-02-26 11:46:17 +02:00
if (rtc_enable_protobuf) {
Update gn files to support Mozilla build Bug: webrtc:8670 No-Presubmit: true Change-Id: I085dc63daa8274b5068540cbf56b6330f40643fa Reviewed-on: https://webrtc-review.googlesource.com/38920 Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21624}
2018-01-15 10:20:00 -05:00
import("//third_party/protobuf/proto_library.gni")
}
Moved RtcEventLog files from call/ to logging/ The RtcEventLog headers need to be accessible from any place which needs logging, and the implementation needs access to data structures that are logged. After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future). The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/). This change allows using RtcEventLog in the p2p/ directory, so that we can log STUN pings and ICE state transitions. BUG=webrtc:6393 R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org Review URL: https://codereview.webrtc.org/2380683005 . Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
if (is_android) {
import("//build/config/android/config.gni")
import("//build/config/android/rules.gni")
}
GN: New conventions, default target and refactorings Introduce a convention on categorizing GN targets: 1. Production code 2. Tests 3. Examples 4. Tools The first two have targets spread out all over the tree, while the latter are isolated to examples/ and tools/ directories. Another new convention: Each directory's BUILD.gn file shall contain a target named similar to the directory name. This target shall contain the 'most common' production code, i.e. so that most consumers of the directory can depend on only the directory (which implicitly means that target in GN). //webrtc:webrtc_tests is changed to depend on all WebRTC tests. From now on, it's necessary to add new test targets to this dependency tree in order to get them compiled. Two new group targets are created: //webrtc/modules/audio_coding:audio_coding_tests //webrtc/modules/audio_processing:audio_processing_tests to reduce the long list of tests in //webrtc:webrtc_tests. Visibility on //webrtc:webrtc and //webrtc:webrtc_tests is restricted to the root target, to avoid circular dependencies due to the monolithic property of these targets (a problem we've had in the past). The 'root' target at the top level is renamed to 'default', which means GN will build this target instead of _all_ generated targets (see https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/faq.md#Can-I-control-what-targets-are-built-by-default). This target now depends on everything we want to build, meaning all targets now explicitly needs to be wired up from the root target in order to get build. Having this, the number of compiled objects on Android is decreased from 8855 to 6276. It also gives us better control over our build. BUG=webrtc:6440 TESTED=git cl try --clobber NOTRY=True Review-Url: https://codereview.webrtc.org/2441383002 Cr-Commit-Position: refs/heads/master@{#14821}
2016-10-28 05:44:03 -07:00
group("logging") {
Stop using public_deps in logging/. Bug: webrtc:8603 Change-Id: Id0df997620a27e47067e4b21e4e8db16aec90640 No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/30940 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21228}
2017-12-12 12:46:13 +01:00
deps = [
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
":rtc_event_audio",
":rtc_event_bwe",
":rtc_event_log_impl_encoder",
":rtc_event_pacing",
":rtc_event_rtp_rtcp",
":rtc_event_video",
GN: New conventions, default target and refactorings Introduce a convention on categorizing GN targets: 1. Production code 2. Tests 3. Examples 4. Tools The first two have targets spread out all over the tree, while the latter are isolated to examples/ and tools/ directories. Another new convention: Each directory's BUILD.gn file shall contain a target named similar to the directory name. This target shall contain the 'most common' production code, i.e. so that most consumers of the directory can depend on only the directory (which implicitly means that target in GN). //webrtc:webrtc_tests is changed to depend on all WebRTC tests. From now on, it's necessary to add new test targets to this dependency tree in order to get them compiled. Two new group targets are created: //webrtc/modules/audio_coding:audio_coding_tests //webrtc/modules/audio_processing:audio_processing_tests to reduce the long list of tests in //webrtc:webrtc_tests. Visibility on //webrtc:webrtc and //webrtc:webrtc_tests is restricted to the root target, to avoid circular dependencies due to the monolithic property of these targets (a problem we've had in the past). The 'root' target at the top level is renamed to 'default', which means GN will build this target instead of _all_ generated targets (see https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/faq.md#Can-I-control-what-targets-are-built-by-default). This target now depends on everything we want to build, meaning all targets now explicitly needs to be wired up from the root target in order to get build. Having this, the number of compiled objects on Android is decreased from 8855 to 6276. It also gives us better control over our build. BUG=webrtc:6440 TESTED=git cl try --clobber NOTRY=True Review-Url: https://codereview.webrtc.org/2441383002 Cr-Commit-Position: refs/heads/master@{#14821}
2016-10-28 05:44:03 -07:00
]
}
Moved RtcEventLog files from call/ to logging/ The RtcEventLog headers need to be accessible from any place which needs logging, and the implementation needs access to data structures that are logged. After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future). The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/). This change allows using RtcEventLog in the p2p/ directory, so that we can log STUN pings and ICE state transitions. BUG=webrtc:6393 R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org Review URL: https://codereview.webrtc.org/2380683005 . Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
rtc_source_set("rtc_event_log_api") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "rtc_event_log/encoder/rtc_event_log_encoder.h" ]
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
deps = [ "../api/rtc_event_log" ]
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("rtc_stream_config") {
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
sources = [
"rtc_event_log/rtc_stream_config.cc",
"rtc_event_log/rtc_stream_config.h",
]
deps = [
Reland "Move api/rtp_headers.h to its own build target." This is a reland of a67050debcb5a3461a452a7928d7aaea1562747e Original change's description: > Move api/rtp_headers.h to its own build target. > > Reduces dependencies on the libjingle_peerconnection_api target from > lower-level code. > > Bug: None > Change-Id: I98576fc718c396cc0f720c3770acd2b696b9df89 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128565 > Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > Commit-Queue: Niels Moller <nisse@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#27213} Bug: None Tbr: kwiberg@webrtc.org Change-Id: If15b05957e50bb8f18a33c2ed1321e672311b626 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127895 Reviewed-by: Niels Moller <nisse@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27216}
2019-03-20 08:40:23 +01:00
"../api:rtp_headers",
New target for api/rtp_parameters.h and api/media_types.h. The new target does not depend on libjingle_peerconnection_api, and to do this, the named "audio" and "video" string literals had to be moved from media_stream_interface.cc to media_types.cc. In this cl, the dependency on libjingle_peerconnection_api can be dropped from a few targets. No-Presubmit: True Bug: webrtc:8733 Change-Id: Icc675280d5c3c537f2255a9389ff18a482049921 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/53861 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28998}
2019-08-26 10:45:28 +02:00
"../api:rtp_parameters",
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
]
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("rtc_event_pacing") {
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
sources = [
Add new event type to RtcEventLog Alr state is now logged by the pacer. To avoid confusion, loopback tools will now create two separate rtc event logs for sender and receiver calls. Bug: webrtc:8287, webrtc:8588 Change-Id: Ib3e47d109c3a65a7ed069b9a613e6a08fe6a2f30 Reviewed-on: https://webrtc-review.googlesource.com/26880 Reviewed-by: Erik Språng <sprang@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Reviewed-by: Philip Eliasson <philipel@webrtc.org> Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21084}
2017-12-05 13:19:45 +01:00
"rtc_event_log/events/rtc_event_alr_state.cc",
"rtc_event_log/events/rtc_event_alr_state.h",
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
]
deps = [
Remove rtc_base/scoped_ref_ptr.h. The type rtc::scoped_refptr<T> is now part of api/. Please include it from api/scoped_refptr.h. More info: See: https://groups.google.com/forum/#!topic/discuss-webrtc/Mme2MSz4z4o. Bug: webrtc:9887, webrtc:8205 No-Try: True Change-Id: Ic6c7c81e226e59f12f7933e472f573ae097b55bf Reviewed-on: https://webrtc-review.googlesource.com/c/119041 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26414}
2019-01-25 20:26:48 +01:00
"../api:scoped_refptr",
Stop using rtc_event.h forward header Bug: webrtc:10206 Change-Id: I16905ec745673178195d6715fda6175c31500163 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151601 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29149}
2019-09-05 11:29:59 +02:00
"../api/rtc_event_log",
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
]
Use absl_deps in order to preapre to the Abseil component build release. Bug: webrtc:1046390 Change-Id: Ia35545599de23b1a2c2d8be2d53469af7ac16f1d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176502 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31463}
2020-06-05 14:30:41 +02:00
absl_deps = [ "//third_party/abseil-cpp/absl/memory" ]
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("rtc_event_audio") {
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
sources = [
Introduce RtcEvent and subclasses We're moving to an RtcEventLog interface that accepts std::unique_ptr<EventLog> and stores the event for encoding when encoding becomes necessary, rather than before. This will be useful while we maintain the legacy (current) encoding alongside the new encoding on which we're working. This CL just introduces the new RtcEvent and its sub-classes, without constructors and without use. Upcoming CLs will finish the work. BUG=webrtc:8111 Change-Id: I782383e861c31670b7cd13ffc6b43ca6a26c98f6 Reviewed-on: https://webrtc-review.googlesource.com/1360 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20068}
2017-10-02 11:27:52 +02:00
"rtc_event_log/events/rtc_event_audio_network_adaptation.cc",
"rtc_event_log/events/rtc_event_audio_network_adaptation.h",
"rtc_event_log/events/rtc_event_audio_playout.cc",
"rtc_event_log/events/rtc_event_audio_playout.h",
"rtc_event_log/events/rtc_event_audio_receive_stream_config.cc",
"rtc_event_log/events/rtc_event_audio_receive_stream_config.h",
"rtc_event_log/events/rtc_event_audio_send_stream_config.cc",
"rtc_event_log/events/rtc_event_audio_send_stream_config.h",
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
]
deps = [
":rtc_stream_config",
Remove rtc_base/scoped_ref_ptr.h. The type rtc::scoped_refptr<T> is now part of api/. Please include it from api/scoped_refptr.h. More info: See: https://groups.google.com/forum/#!topic/discuss-webrtc/Mme2MSz4z4o. Bug: webrtc:9887, webrtc:8205 No-Try: True Change-Id: Ic6c7c81e226e59f12f7933e472f573ae097b55bf Reviewed-on: https://webrtc-review.googlesource.com/c/119041 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26414}
2019-01-25 20:26:48 +01:00
"../api:scoped_refptr",
Stop using rtc_event.h forward header Bug: webrtc:10206 Change-Id: I16905ec745673178195d6715fda6175c31500163 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151601 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29149}
2019-09-05 11:29:59 +02:00
"../api/rtc_event_log",
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
"../modules/audio_coding:audio_network_adaptor_config",
Hide RtcEvent members behind accessors Bug: webrtc:8111 Change-Id: I3d350a6e159330aed7362162006860ac86ed7c32 Reviewed-on: https://webrtc-review.googlesource.com/c/109881 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25590}
2018-11-09 21:50:14 +01:00
"../rtc_base:checks",
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
]
Use absl_deps in order to preapre to the Abseil component build release. Bug: webrtc:1046390 Change-Id: Ia35545599de23b1a2c2d8be2d53469af7ac16f1d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176502 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31463}
2020-06-05 14:30:41 +02:00
absl_deps = [ "//third_party/abseil-cpp/absl/memory" ]
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("rtc_event_bwe") {
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
sources = [
Introduce RtcEvent and subclasses We're moving to an RtcEventLog interface that accepts std::unique_ptr<EventLog> and stores the event for encoding when encoding becomes necessary, rather than before. This will be useful while we maintain the legacy (current) encoding alongside the new encoding on which we're working. This CL just introduces the new RtcEvent and its sub-classes, without constructors and without use. Upcoming CLs will finish the work. BUG=webrtc:8111 Change-Id: I782383e861c31670b7cd13ffc6b43ca6a26c98f6 Reviewed-on: https://webrtc-review.googlesource.com/1360 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20068}
2017-10-02 11:27:52 +02:00
"rtc_event_log/events/rtc_event_bwe_update_delay_based.cc",
"rtc_event_log/events/rtc_event_bwe_update_delay_based.h",
"rtc_event_log/events/rtc_event_bwe_update_loss_based.cc",
"rtc_event_log/events/rtc_event_bwe_update_loss_based.h",
"rtc_event_log/events/rtc_event_probe_cluster_created.cc",
"rtc_event_log/events/rtc_event_probe_cluster_created.h",
"rtc_event_log/events/rtc_event_probe_result_failure.cc",
"rtc_event_log/events/rtc_event_probe_result_failure.h",
"rtc_event_log/events/rtc_event_probe_result_success.cc",
"rtc_event_log/events/rtc_event_probe_result_success.h",
Adds remote estimates to rtc event log. Bug: webrtc:10742 Change-Id: I0db998a05492603fcdeedca780d9ee3d64aa00d4 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151651 Reviewed-by: Björn Terelius <terelius@webrtc.org> Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Sebastian Jansson <srte@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29233}
2019-09-18 15:37:31 +02:00
"rtc_event_log/events/rtc_event_remote_estimate.h",
Adds route changes in event logs. Bug: webrtc:10614 Change-Id: Ifd859c977fc66cb606914ddb38a3fb3618e3ad90 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/135952 Commit-Queue: Sebastian Jansson <srte@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27924}
2019-05-13 11:57:42 +02:00
"rtc_event_log/events/rtc_event_route_change.cc",
"rtc_event_log/events/rtc_event_route_change.h",
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
]
deps = [
Remove rtc_base/scoped_ref_ptr.h. The type rtc::scoped_refptr<T> is now part of api/. Please include it from api/scoped_refptr.h. More info: See: https://groups.google.com/forum/#!topic/discuss-webrtc/Mme2MSz4z4o. Bug: webrtc:9887, webrtc:8205 No-Try: True Change-Id: Ic6c7c81e226e59f12f7933e472f573ae097b55bf Reviewed-on: https://webrtc-review.googlesource.com/c/119041 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26414}
2019-01-25 20:26:48 +01:00
"../api:scoped_refptr",
Stop using rtc_event.h forward header Bug: webrtc:10206 Change-Id: I16905ec745673178195d6715fda6175c31500163 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151601 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29149}
2019-09-05 11:29:59 +02:00
"../api/rtc_event_log",
Adds remote estimates to rtc event log. Bug: webrtc:10742 Change-Id: I0db998a05492603fcdeedca780d9ee3d64aa00d4 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151651 Reviewed-by: Björn Terelius <terelius@webrtc.org> Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Sebastian Jansson <srte@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29233}
2019-09-18 15:37:31 +02:00
"../api/units:data_rate",
Cleanup BUILD.gn files from imports like foo:foo Repalce all occurrences of foo:foo in deps with just foo in BUILD.gn files. Done with Sublime regex replace. Find: \b([-a-zA-Z0-9_]+):+\1\b In: *.gn Replace with: \1 Bug: None Change-Id: I40aba1b14face687a595b852ffe443cb20197611 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127899 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27225}
2019-03-21 13:35:10 +01:00
"../modules/remote_bitrate_estimator",
Use absl_deps in order to preapre to the Abseil component build release. Bug: webrtc:1046390 Change-Id: Ia35545599de23b1a2c2d8be2d53469af7ac16f1d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176502 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31463}
2020-06-05 14:30:41 +02:00
]
absl_deps = [
Use absl::make_unique and absl::WrapUnique directly Instead of going through our wrappers in ptr_util.h. This CL was generated by the following script: git grep -l ptr_util | xargs perl -pi -e 's,#include "rtc_base/ptr_util.h",#include "absl/memory/memory.h",' git grep -l MakeUnique | xargs perl -pi -e 's,\b(rtc::)?MakeUnique\b,absl::make_unique,g' git grep -l WrapUnique | xargs perl -pi -e 's,\b(rtc::)?WrapUnique\b,absl::WrapUnique,g' git checkout -- rtc_base/ptr_util{.h,_unittest.cc} git cl format Followed by manually adding dependencies on //third_party/abseil-cpp/absl/memory until `gn check` stopped complaining. Bug: webrtc:9473 Change-Id: I89ccd363f070479b8c431eb2c3d404a46eaacc1c Reviewed-on: https://webrtc-review.googlesource.com/86600 Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23850}
2018-07-05 11:40:33 +02:00
"//third_party/abseil-cpp/absl/memory",
Adds remote estimates to rtc event log. Bug: webrtc:10742 Change-Id: I0db998a05492603fcdeedca780d9ee3d64aa00d4 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151651 Reviewed-by: Björn Terelius <terelius@webrtc.org> Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Sebastian Jansson <srte@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29233}
2019-09-18 15:37:31 +02:00
"//third_party/abseil-cpp/absl/types:optional",
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
]
}
Add logging of decoded video frames. This CL adds the possibility to log metainformation about decoded frames in RTC event log, including encoding parsing and tests. It will be wired up in a followup CL. Bug: webrtc:8802 Change-Id: Ied598b266513d0f63fce0484d741af1782607e74 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/181061 Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org> Reviewed-by: Artem Titov <titovartem@webrtc.org> Commit-Queue: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31873}
2020-08-06 12:37:08 +02:00
rtc_library("rtc_event_frame_events") {
sources = [
"rtc_event_log/events/rtc_event_frame_decoded.cc",
"rtc_event_log/events/rtc_event_frame_decoded.h",
]
deps = [
"../api/rtc_event_log",
"../api/video:video_frame",
"../rtc_base:timeutils",
]
absl_deps = [
"//third_party/abseil-cpp/absl/memory",
"//third_party/abseil-cpp/absl/types:optional",
]
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("rtc_event_generic_packet_events") {
Add rtc event generic packet sent and received. Bug: webrtc:9719 Change-Id: I2f692d9c1b33ac390975a9e695c7652cdc1b1e6e Reviewed-on: https://webrtc-review.googlesource.com/c/121680 Commit-Queue: Peter Slatala <psla@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Reviewed-by: Bjorn Mellem <mellem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26616}
2019-02-08 10:31:35 -08:00
visibility = [ "*" ]
sources = [
"rtc_event_log/events/rtc_event_generic_ack_received.cc",
"rtc_event_log/events/rtc_event_generic_ack_received.h",
"rtc_event_log/events/rtc_event_generic_packet_received.cc",
"rtc_event_log/events/rtc_event_generic_packet_received.h",
"rtc_event_log/events/rtc_event_generic_packet_sent.cc",
"rtc_event_log/events/rtc_event_generic_packet_sent.h",
]
deps = [
Stop using rtc_event.h forward header Bug: webrtc:10206 Change-Id: I16905ec745673178195d6715fda6175c31500163 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151601 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29149}
2019-09-05 11:29:59 +02:00
"../api/rtc_event_log",
Publish rtc event log api and default factory for it in api/ Bug: webrtc:10206 Change-Id: I34194ddb6fd2b0a3d7c553fadc9ddc1ea9740da0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/137500 Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28023}
2019-05-22 13:39:25 +02:00
"../rtc_base:timeutils",
Use absl_deps in order to preapre to the Abseil component build release. Bug: webrtc:1046390 Change-Id: Ia35545599de23b1a2c2d8be2d53469af7ac16f1d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176502 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31463}
2020-06-05 14:30:41 +02:00
]
absl_deps = [
Add missing absl/memory/memory.h to rtc_event_generic_ack_received.cc absl/memory/memory.h needs to be included for absl::WrapUnique on the C++17 mode build, as absl/types/optional.h has a conditional include of memory.h. Tbr: terelius@webrtc.org Bug: chromium:752720 Change-Id: I7bdfb200f29ac8ec11f0b102304b7788595e7eb9 Reviewed-on: https://webrtc-review.googlesource.com/c/123360 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26815}
2019-02-18 22:28:26 +09:00
"//third_party/abseil-cpp/absl/memory",
Publish rtc event log api and default factory for it in api/ Bug: webrtc:10206 Change-Id: I34194ddb6fd2b0a3d7c553fadc9ddc1ea9740da0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/137500 Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28023}
2019-05-22 13:39:25 +02:00
"//third_party/abseil-cpp/absl/types:optional",
Add rtc event generic packet sent and received. Bug: webrtc:9719 Change-Id: I2f692d9c1b33ac390975a9e695c7652cdc1b1e6e Reviewed-on: https://webrtc-review.googlesource.com/c/121680 Commit-Queue: Peter Slatala <psla@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Reviewed-by: Bjorn Mellem <mellem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26616}
2019-02-08 10:31:35 -08:00
]
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("rtc_event_rtp_rtcp") {
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
sources = [
Introduce RtcEvent and subclasses We're moving to an RtcEventLog interface that accepts std::unique_ptr<EventLog> and stores the event for encoding when encoding becomes necessary, rather than before. This will be useful while we maintain the legacy (current) encoding alongside the new encoding on which we're working. This CL just introduces the new RtcEvent and its sub-classes, without constructors and without use. Upcoming CLs will finish the work. BUG=webrtc:8111 Change-Id: I782383e861c31670b7cd13ffc6b43ca6a26c98f6 Reviewed-on: https://webrtc-review.googlesource.com/1360 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20068}
2017-10-02 11:27:52 +02:00
"rtc_event_log/events/rtc_event_rtcp_packet_incoming.cc",
"rtc_event_log/events/rtc_event_rtcp_packet_incoming.h",
"rtc_event_log/events/rtc_event_rtcp_packet_outgoing.cc",
"rtc_event_log/events/rtc_event_rtcp_packet_outgoing.h",
"rtc_event_log/events/rtc_event_rtp_packet_incoming.cc",
"rtc_event_log/events/rtc_event_rtp_packet_incoming.h",
"rtc_event_log/events/rtc_event_rtp_packet_outgoing.cc",
"rtc_event_log/events/rtc_event_rtp_packet_outgoing.h",
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
]
deps = [
"../api:array_view",
Remove rtc_base/scoped_ref_ptr.h. The type rtc::scoped_refptr<T> is now part of api/. Please include it from api/scoped_refptr.h. More info: See: https://groups.google.com/forum/#!topic/discuss-webrtc/Mme2MSz4z4o. Bug: webrtc:9887, webrtc:8205 No-Try: True Change-Id: Ic6c7c81e226e59f12f7933e472f573ae097b55bf Reviewed-on: https://webrtc-review.googlesource.com/c/119041 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26414}
2019-01-25 20:26:48 +01:00
"../api:scoped_refptr",
Stop using rtc_event.h forward header Bug: webrtc:10206 Change-Id: I16905ec745673178195d6715fda6175c31500163 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151601 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29149}
2019-09-05 11:29:59 +02:00
"../api/rtc_event_log",
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
"../modules/rtp_rtcp:rtp_rtcp_format",
Hide RtcEvent members behind accessors Bug: webrtc:8111 Change-Id: I3d350a6e159330aed7362162006860ac86ed7c32 Reviewed-on: https://webrtc-review.googlesource.com/c/109881 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25590}
2018-11-09 21:50:14 +01:00
"../rtc_base:checks",
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
"../rtc_base:rtc_base_approved",
]
Use absl_deps in order to preapre to the Abseil component build release. Bug: webrtc:1046390 Change-Id: Ia35545599de23b1a2c2d8be2d53469af7ac16f1d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176502 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31463}
2020-06-05 14:30:41 +02:00
absl_deps = [ "//third_party/abseil-cpp/absl/memory" ]
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("rtc_event_video") {
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
sources = [
Introduce RtcEvent and subclasses We're moving to an RtcEventLog interface that accepts std::unique_ptr<EventLog> and stores the event for encoding when encoding becomes necessary, rather than before. This will be useful while we maintain the legacy (current) encoding alongside the new encoding on which we're working. This CL just introduces the new RtcEvent and its sub-classes, without constructors and without use. Upcoming CLs will finish the work. BUG=webrtc:8111 Change-Id: I782383e861c31670b7cd13ffc6b43ca6a26c98f6 Reviewed-on: https://webrtc-review.googlesource.com/1360 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20068}
2017-10-02 11:27:52 +02:00
"rtc_event_log/events/rtc_event_video_receive_stream_config.cc",
"rtc_event_log/events/rtc_event_video_receive_stream_config.h",
"rtc_event_log/events/rtc_event_video_send_stream_config.cc",
"rtc_event_log/events/rtc_event_video_send_stream_config.h",
Moved RtcEventLog files from call/ to logging/ The RtcEventLog headers need to be accessible from any place which needs logging, and the implementation needs access to data structures that are logged. After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future). The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/). This change allows using RtcEventLog in the p2p/ directory, so that we can log STUN pings and ICE state transitions. BUG=webrtc:6393 R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org Review URL: https://codereview.webrtc.org/2380683005 . Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
]
Create and use RtcEventLogOutput for output We need to support two modes of writing to the output: 1. Current way - the application lets lets WebRTC know which file to write to, and WebRTC is then in charge of the writing. 2. New way - the application would receive indications from WebRTC about (encoded) RTC events, and would itself be in charge of processing them (be it writing it to a file, uploading it somewhere, etc.). We achieve this by creating an interface for output - RtcEventLogOutput. By providing an instance of the subclass, RtcEventLogOutputFile, the old behavior is achieved. The subclass of the new behavior is to be added by a later CL. TBR=stefan@webrtc.org Bug: webrtc:8111 Change-Id: I9c50521a7f7144d86d8353a65995795862e19c44 Reviewed-on: https://webrtc-review.googlesource.com/2686 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Elad Alon <eladalon@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20135}
2017-10-04 13:18:26 +02:00
Enable GN check for webrtc/logging BUG=webrtc:6828, webrtc:7257 NOTRY=True Review-Url: https://codereview.webrtc.org/2717903002 Cr-Commit-Position: refs/heads/master@{#17111}
2017-03-08 02:12:11 -08:00
deps = [
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
":rtc_stream_config",
Remove rtc_base/scoped_ref_ptr.h. The type rtc::scoped_refptr<T> is now part of api/. Please include it from api/scoped_refptr.h. More info: See: https://groups.google.com/forum/#!topic/discuss-webrtc/Mme2MSz4z4o. Bug: webrtc:9887, webrtc:8205 No-Try: True Change-Id: Ic6c7c81e226e59f12f7933e472f573ae097b55bf Reviewed-on: https://webrtc-review.googlesource.com/c/119041 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26414}
2019-01-25 20:26:48 +01:00
"../api:scoped_refptr",
Stop using rtc_event.h forward header Bug: webrtc:10206 Change-Id: I16905ec745673178195d6715fda6175c31500163 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151601 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29149}
2019-09-05 11:29:59 +02:00
"../api/rtc_event_log",
Hide RtcEvent members behind accessors Bug: webrtc:8111 Change-Id: I3d350a6e159330aed7362162006860ac86ed7c32 Reviewed-on: https://webrtc-review.googlesource.com/c/109881 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25590}
2018-11-09 21:50:14 +01:00
"../rtc_base:checks",
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
]
Use absl_deps in order to preapre to the Abseil component build release. Bug: webrtc:1046390 Change-Id: Ia35545599de23b1a2c2d8be2d53469af7ac16f1d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176502 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31463}
2020-06-05 14:30:41 +02:00
absl_deps = [ "//third_party/abseil-cpp/absl/memory" ]
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
}
Use delta-encoding in new WebRTC event logs The new event log format makes use of delta encoding to compress parts of the log. Bug: webrtc:8111 Change-Id: I7bec839555323a7537dcec831d4ac1d5eb109932 Reviewed-on: https://webrtc-review.googlesource.com/c/109161 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25584}
2018-11-09 16:38:54 +01:00
# TODO(eladalon): Break down into (1) encoder and (2) decoder; we don't need
# the decoder code in the WebRTC library, only in unit tests and tools.
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("rtc_event_log_impl_encoder") {
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
sources = [
Add blob-encoding support for RTC event logs A blob is a string of binary information, whose length may not necessarily be determined by looking into the string, so that concatenating all blobs without explicitly including their lengths as part of their encoding is not a viable option. Bug: webrtc:8111 Change-Id: I89fdca660e89a6a71eff3ecb7b86416312b81f23 Reviewed-on: https://webrtc-review.googlesource.com/c/104201 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Reviewed-by: Yves Gerey <yvesg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25278}
2018-10-19 18:30:30 +02:00
"rtc_event_log/encoder/blob_encoding.cc",
"rtc_event_log/encoder/blob_encoding.h",
Add fixed-size delta-encoding/decoding code for WebRTC event logs Add code for delta-encoding and decoding, to be used when producing WebRTC event logs of the new format. This CL supports fixed-size encoding only. Also, no support for signed deltas or optional values yet. These will be added in subsequent CLs. Bug: webrtc:8111 Change-Id: I531abd99fd924f4c9e692abe565bc6f66c875ad5 Reviewed-on: https://webrtc-review.googlesource.com/c/100304 Reviewed-by: Björn Terelius <terelius@webrtc.org> Commit-Queue: Elad Alon <eladalon@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25256}
2018-10-18 13:43:35 +02:00
"rtc_event_log/encoder/delta_encoding.cc",
"rtc_event_log/encoder/delta_encoding.h",
Use delta-encoding in new WebRTC event logs The new event log format makes use of delta encoding to compress parts of the log. Bug: webrtc:8111 Change-Id: I7bec839555323a7537dcec831d4ac1d5eb109932 Reviewed-on: https://webrtc-review.googlesource.com/c/109161 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25584}
2018-11-09 16:38:54 +01:00
"rtc_event_log/encoder/rtc_event_log_encoder_common.cc",
"rtc_event_log/encoder/rtc_event_log_encoder_common.h",
(4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries Mechanically generated by running this command: tools_webrtc/do-renames.sh update all-renames.txt && git cl format Then manually updating: tools_webrtc/sanitizers/tsan_suppressions_webrtc.cc Bug: webrtc:10159 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I54824cd91dada8fc3ee3d098f971bc319d477833 Reviewed-on: https://webrtc-review.googlesource.com/c/115653 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26226}
2019-01-11 09:11:00 -08:00
"rtc_event_log/encoder/var_int.cc",
"rtc_event_log/encoder/var_int.h",
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
]
defines = []
deps = [
Reland "Move api/rtp_headers.h to its own build target." This is a reland of a67050debcb5a3461a452a7928d7aaea1562747e Original change's description: > Move api/rtp_headers.h to its own build target. > > Reduces dependencies on the libjingle_peerconnection_api target from > lower-level code. > > Bug: None > Change-Id: I98576fc718c396cc0f720c3770acd2b696b9df89 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128565 > Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > Commit-Queue: Niels Moller <nisse@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#27213} Bug: None Tbr: kwiberg@webrtc.org Change-Id: If15b05957e50bb8f18a33c2ed1321e672311b626 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127895 Reviewed-by: Niels Moller <nisse@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27216}
2019-03-20 08:40:23 +01:00
"../api:rtp_headers",
New target for api/rtp_parameters.h and api/media_types.h. The new target does not depend on libjingle_peerconnection_api, and to do this, the named "audio" and "video" string literals had to be moved from media_stream_interface.cc to media_types.cc. In this cl, the dependency on libjingle_peerconnection_api can be dropped from a few targets. No-Presubmit: True Bug: webrtc:8733 Change-Id: Icc675280d5c3c537f2255a9389ff18a482049921 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/53861 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28998}
2019-08-26 10:45:28 +02:00
"../api:rtp_parameters",
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2. This is a follow-up to https://webrtc-review.googlesource.com/c/src/+/106280. This time the whole code base is covered. Some files may have not been fixed though, whenever the IWYU tool was breaking the build. Bug: webrtc:8311 Change-Id: I2c31f552a87e887d33931d46e87b6208b1e483ef Reviewed-on: https://webrtc-review.googlesource.com/c/111965 Commit-Queue: Yves Gerey <yvesg@google.com> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25830}
2018-11-28 16:47:49 +01:00
"../api/transport:network_control",
Fix circular dependencies between optional, array_view, and rtc_base. This splits things out of rtc_base and makes dependencies explicit. Bug: webrtc:6828 Change-Id: Id521896c3c43595349021c857bec216e429a0c8d Reviewed-on: https://webrtc-review.googlesource.com/32780 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21264}
2017-12-13 16:05:42 +01:00
"../rtc_base:checks",
Move rtc_base/ignore_wundef.h to its own target. Since rtc_base/ignore_wundef.h doesn't have any dependency, it is easy to move it to its own target and allow its dependant to avoid to take a dependency rtc_base:on rtc_base_approved. Bug: webrtc:9419 Change-Id: I17f205b0cb2b21cad388b04e60082df9398dffdf Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157428 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29548}
2019-10-19 12:03:23 +02:00
"../rtc_base:ignore_wundef",
Remove remains of webrtc/base All downstream code have been updated to the new location. In PRESUBMIT.py: * Remove webrtc/rtc_base from CPP_BLACKLIST * Add webrtc/rtc_base to LEGACY_API_DIRS Fix some duplicated paths in webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn BUG=webrtc:7634 TBR=kwiberg@webrtc.org Review-Url: https://codereview.webrtc.org/2976293002 Cr-Commit-Position: refs/heads/master@{#19094}
2017-07-19 10:40:47 -07:00
"../rtc_base:rtc_base_approved",
Use absl_deps in order to preapre to the Abseil component build release. Bug: webrtc:1046390 Change-Id: Ia35545599de23b1a2c2d8be2d53469af7ac16f1d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176502 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31463}
2020-06-05 14:30:41 +02:00
]
absl_deps = [
Add fixed-size delta-encoding/decoding code for WebRTC event logs Add code for delta-encoding and decoding, to be used when producing WebRTC event logs of the new format. This CL supports fixed-size encoding only. Also, no support for signed deltas or optional values yet. These will be added in subsequent CLs. Bug: webrtc:8111 Change-Id: I531abd99fd924f4c9e692abe565bc6f66c875ad5 Reviewed-on: https://webrtc-review.googlesource.com/c/100304 Reviewed-by: Björn Terelius <terelius@webrtc.org> Commit-Queue: Elad Alon <eladalon@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25256}
2018-10-18 13:43:35 +02:00
"//third_party/abseil-cpp/absl/memory",
Cleanup BUILD.gn files from imports like foo:foo Repalce all occurrences of foo:foo in deps with just foo in BUILD.gn files. Done with Sublime regex replace. Find: \b([-a-zA-Z0-9_]+):+\1\b In: *.gn Replace with: \1 Bug: None Change-Id: I40aba1b14face687a595b852ffe443cb20197611 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127899 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27225}
2019-03-21 13:35:10 +01:00
"//third_party/abseil-cpp/absl/strings",
Add support for signed deltas in FixedLengthDeltaEncoder Signed deltas can yield a more efficient encoding when the encoded sequence sometimes moves backwards. Bug: webrtc:8111 Change-Id: Ib1a50192851214ccc3f2bd7eaf88f4be97e4beb0 Reviewed-on: https://webrtc-review.googlesource.com/c/100423 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25324}
2018-10-23 18:24:10 +02:00
"//third_party/abseil-cpp/absl/types:optional",
Enable GN check for webrtc/logging BUG=webrtc:6828, webrtc:7257 NOTRY=True Review-Url: https://codereview.webrtc.org/2717903002 Cr-Commit-Position: refs/heads/master@{#17111}
2017-03-08 02:12:11 -08:00
]
Create and use RtcEventLogOutput for output We need to support two modes of writing to the output: 1. Current way - the application lets lets WebRTC know which file to write to, and WebRTC is then in charge of the writing. 2. New way - the application would receive indications from WebRTC about (encoded) RTC events, and would itself be in charge of processing them (be it writing it to a file, uploading it somewhere, etc.). We achieve this by creating an interface for output - RtcEventLogOutput. By providing an instance of the subclass, RtcEventLogOutputFile, the old behavior is achieved. The subclass of the new behavior is to be added by a later CL. TBR=stefan@webrtc.org Bug: webrtc:8111 Change-Id: I9c50521a7f7144d86d8353a65995795862e19c44 Reviewed-on: https://webrtc-review.googlesource.com/2686 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Elad Alon <eladalon@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20135}
2017-10-04 13:18:26 +02:00
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
if (rtc_enable_protobuf) {
Reland "Encode RTC event logs in new format." This is a reland of ece3c228a2cbd1c1b05eee3a7f55dbb6f020acbc Original change's description: > Encode RTC event logs in new format. > > This CL adds the encoder and wires it up to the event log. > Parser and unit tests are uploaded in a separate CL. > > Bug: webrtc:8111 > Change-Id: I6470003e55c2c4006cd8349a2c4bdc3f9491d869 > Reviewed-on: https://webrtc-review.googlesource.com/c/106708 > Commit-Queue: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Elad Alon <eladalon@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#25333} Bug: webrtc:8111 Change-Id: I22eeca36d6b1f7cfa1ac65347571ebe33cecc1fc Reviewed-on: https://webrtc-review.googlesource.com/c/108082 Reviewed-by: Elad Alon <eladalon@webrtc.org> Commit-Queue: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25382}
2018-10-24 13:51:56 +02:00
deps += [
":ice_log",
":rtc_event_audio",
":rtc_event_bwe",
Add logging of decoded video frames. This CL adds the possibility to log metainformation about decoded frames in RTC event log, including encoding parsing and tests. It will be wired up in a followup CL. Bug: webrtc:8802 Change-Id: Ied598b266513d0f63fce0484d741af1782607e74 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/181061 Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org> Reviewed-by: Artem Titov <titovartem@webrtc.org> Commit-Queue: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31873}
2020-08-06 12:37:08 +02:00
":rtc_event_frame_events",
Add rtc event generic packet sent and received. Bug: webrtc:9719 Change-Id: I2f692d9c1b33ac390975a9e695c7652cdc1b1e6e Reviewed-on: https://webrtc-review.googlesource.com/c/121680 Commit-Queue: Peter Slatala <psla@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Reviewed-by: Bjorn Mellem <mellem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26616}
2019-02-08 10:31:35 -08:00
":rtc_event_generic_packet_events",
Reland "Encode RTC event logs in new format." This is a reland of ece3c228a2cbd1c1b05eee3a7f55dbb6f020acbc Original change's description: > Encode RTC event logs in new format. > > This CL adds the encoder and wires it up to the event log. > Parser and unit tests are uploaded in a separate CL. > > Bug: webrtc:8111 > Change-Id: I6470003e55c2c4006cd8349a2c4bdc3f9491d869 > Reviewed-on: https://webrtc-review.googlesource.com/c/106708 > Commit-Queue: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Elad Alon <eladalon@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#25333} Bug: webrtc:8111 Change-Id: I22eeca36d6b1f7cfa1ac65347571ebe33cecc1fc Reviewed-on: https://webrtc-review.googlesource.com/c/108082 Reviewed-by: Elad Alon <eladalon@webrtc.org> Commit-Queue: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25382}
2018-10-24 13:51:56 +02:00
":rtc_event_log2_proto",
":rtc_event_log_api",
":rtc_event_log_proto",
":rtc_event_pacing",
":rtc_event_rtp_rtcp",
":rtc_event_video",
":rtc_stream_config",
"../api:array_view",
"../modules/audio_coding:audio_network_adaptor",
Cleanup BUILD.gn files from imports like foo:foo Repalce all occurrences of foo:foo in deps with just foo in BUILD.gn files. Done with Sublime regex replace. Find: \b([-a-zA-Z0-9_]+):+\1\b In: *.gn Replace with: \1 Bug: None Change-Id: I40aba1b14face687a595b852ffe443cb20197611 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127899 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27225}
2019-03-21 13:35:10 +01:00
"../modules/remote_bitrate_estimator",
Reland "Encode RTC event logs in new format." This is a reland of ece3c228a2cbd1c1b05eee3a7f55dbb6f020acbc Original change's description: > Encode RTC event logs in new format. > > This CL adds the encoder and wires it up to the event log. > Parser and unit tests are uploaded in a separate CL. > > Bug: webrtc:8111 > Change-Id: I6470003e55c2c4006cd8349a2c4bdc3f9491d869 > Reviewed-on: https://webrtc-review.googlesource.com/c/106708 > Commit-Queue: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Elad Alon <eladalon@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#25333} Bug: webrtc:8111 Change-Id: I22eeca36d6b1f7cfa1ac65347571ebe33cecc1fc Reviewed-on: https://webrtc-review.googlesource.com/c/108082 Reviewed-by: Elad Alon <eladalon@webrtc.org> Commit-Queue: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25382}
2018-10-24 13:51:56 +02:00
"../modules/rtp_rtcp:rtp_rtcp_format",
]
sources += [
"rtc_event_log/encoder/rtc_event_log_encoder_legacy.cc",
"rtc_event_log/encoder/rtc_event_log_encoder_legacy.h",
"rtc_event_log/encoder/rtc_event_log_encoder_new_format.cc",
"rtc_event_log/encoder/rtc_event_log_encoder_new_format.h",
]
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
}
Moved RtcEventLog files from call/ to logging/ The RtcEventLog headers need to be accessible from any place which needs logging, and the implementation needs access to data structures that are logged. After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future). The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/). This change allows using RtcEventLog in the p2p/ directory, so that we can log STUN pings and ICE state transitions. BUG=webrtc:6393 R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org Review URL: https://codereview.webrtc.org/2380683005 . Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
}
Promote RtcEventLogOutputFile to api/ Preparation for deleting PeerConnectionInterface::StartRtcEventLog method with a PlatformFile argument. Bug: webrtc:6463 Change-Id: Ia9fa1d99a3d87f3bf193e73382690b782ffea65c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/135285 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27879}
2019-05-08 13:53:51 +02:00
# TODO(bugs.webrtc.org/6463): For backwards compatibility; delete as
# soon as downstream dependencies are updated.
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
rtc_source_set("rtc_event_log_impl_output") {
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "rtc_event_log/output/rtc_event_log_output_file.h" ]
deps = [ "../api:rtc_event_log_output_file" ]
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
}
Publish rtc event log api and default factory for it in api/ Bug: webrtc:10206 Change-Id: I34194ddb6fd2b0a3d7c553fadc9ddc1ea9740da0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/137500 Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28023}
2019-05-22 13:39:25 +02:00
if (rtc_enable_protobuf) {
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("rtc_event_log_impl") {
Publish rtc event log api and default factory for it in api/ Bug: webrtc:10206 Change-Id: I34194ddb6fd2b0a3d7c553fadc9ddc1ea9740da0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/137500 Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28023}
2019-05-22 13:39:25 +02:00
visibility = [ "../api/rtc_event_log:rtc_event_log_factory" ]
sources = [
"rtc_event_log/rtc_event_log_impl.cc",
"rtc_event_log/rtc_event_log_impl.h",
]
deps = [
":ice_log",
":rtc_event_log_api",
":rtc_event_log_impl_encoder",
"../api:libjingle_logging_api",
"../api/rtc_event_log",
"../api/task_queue",
"../rtc_base:checks",
"../rtc_base:rtc_base_approved",
"../rtc_base:rtc_task_queue",
"../rtc_base:safe_minmax",
"../rtc_base/synchronization:sequence_checker",
Reland "Introduce RTC_NO_UNIQUE_ADDRESS." This is a reland of f5e261aaf65cdf2eb903cdf40d651846be44f447 This CL disables RTC_NO_UNIQUE_ADDRESS on MSan builds since there have been some issues. Original change's description: > Introduce RTC_NO_UNIQUE_ADDRESS. > > This macro introduces the possibility to suggest the compiler that a > data member doesn't need an address different from other non static > data members. > > The usage of a macro is to maintain portability since at the moment > the attribute [[no_unique_address]] is only supported by clang > with at least -std=c++11 but it should be supported by all the > compilers starting from C++20. > > Bug: webrtc:11495 > Change-Id: I9f12b67b4422a2749649eaa6b004a67d5fd572d8 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173331 > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#32246} Bug: webrtc:11495, webrtc:12218 Change-Id: I4e6c7cc37d3daffad2407c9a2acfa897fa5b426a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/189968 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32668}
2020-11-23 11:07:42 +01:00
"../rtc_base/system:no_unique_address",
Publish rtc event log api and default factory for it in api/ Bug: webrtc:10206 Change-Id: I34194ddb6fd2b0a3d7c553fadc9ddc1ea9740da0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/137500 Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28023}
2019-05-22 13:39:25 +02:00
]
Use absl_deps in order to preapre to the Abseil component build release. Bug: webrtc:1046390 Change-Id: Ia35545599de23b1a2c2d8be2d53469af7ac16f1d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176502 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31463}
2020-06-05 14:30:41 +02:00
absl_deps = [ "//third_party/abseil-cpp/absl/types:optional" ]
Publish rtc event log api and default factory for it in api/ Bug: webrtc:10206 Change-Id: I34194ddb6fd2b0a3d7c553fadc9ddc1ea9740da0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/137500 Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28023}
2019-05-22 13:39:25 +02:00
}
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("fake_rtc_event_log") {
Pass the RtcEventLog instance to ICE via JsepTransportController. This CL fixes a bug that the RtcEventLog owned by PeerConnection was not passed to P2PTransportChannel after JsepTransportController was introduced to deprecate the legacy TransportController. Bug: webrtc:9337 Change-Id: I406cd9c0761dfe67f969aa99c6141e1ab38249d5 Reviewed-on: https://webrtc-review.googlesource.com/79964 Commit-Queue: Qingsi Wang <qingsi@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23572}
2018-06-11 20:15:46 -07:00
testonly = true
sources = [
"rtc_event_log/fake_rtc_event_log.cc",
"rtc_event_log/fake_rtc_event_log.h",
"rtc_event_log/fake_rtc_event_log_factory.cc",
"rtc_event_log/fake_rtc_event_log_factory.h",
]
deps = [
":ice_log",
Delete deprecated rtc_event_log header Bug: webrtc:10206 Change-Id: I9ed3148843c647372993729b87c0e74741ab540b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/147870 Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28791}
2019-08-07 12:24:53 +02:00
"../api/rtc_event_log",
Cleanup BUILD.gn files from imports like foo:foo Repalce all occurrences of foo:foo in deps with just foo in BUILD.gn files. Done with Sublime regex replace. Find: \b([-a-zA-Z0-9_]+):+\1\b In: *.gn Replace with: \1 Bug: None Change-Id: I40aba1b14face687a595b852ffe443cb20197611 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127899 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27225}
2019-03-21 13:35:10 +01:00
"../rtc_base",
Pass the RtcEventLog instance to ICE via JsepTransportController. This CL fixes a bug that the RtcEventLog owned by PeerConnection was not passed to P2PTransportChannel after JsepTransportController was introduced to deprecate the legacy TransportController. Bug: webrtc:9337 Change-Id: I406cd9c0761dfe67f969aa99c6141e1ab38249d5 Reviewed-on: https://webrtc-review.googlesource.com/79964 Commit-Queue: Qingsi Wang <qingsi@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23572}
2018-06-11 20:15:46 -07:00
"../rtc_base:checks",
]
}
Moved RtcEventLog files from call/ to logging/ The RtcEventLog headers need to be accessible from any place which needs logging, and the implementation needs access to data structures that are logged. After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future). The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/). This change allows using RtcEventLog in the p2p/ directory, so that we can log STUN pings and ICE state transitions. BUG=webrtc:6393 R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org Review URL: https://codereview.webrtc.org/2380683005 . Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
if (rtc_enable_protobuf) {
proto_library("rtc_event_log_proto") {
Make rtc_event_log protos publicly visible. Bug: None Change-Id: I189f249914e0fa67826b69aacf93288aa54ac0d5 Reviewed-on: https://webrtc-review.googlesource.com/c/111254 Reviewed-by: Björn Terelius <terelius@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25689}
2018-11-19 12:00:51 +01:00
visibility = [ "*" ]
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "rtc_event_log/rtc_event_log.proto" ]
Fixing WebRTC after moving from src/webrtc to src/ In https://webrtc-review.googlesource.com/c/src/+/1560 we moved WebRTC from src/webrtc to src/ (in order to preserve an healthy git history). This CL takes care of fixing header guards, #include paths, etc... NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true TBR=tommi@webrtc.org Bug: chromium:611808 Change-Id: Iea91618212bee0af16aa3f05071eab8f93706578 Reviewed-on: https://webrtc-review.googlesource.com/1561 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#19846}
2017-09-15 06:47:31 +02:00
proto_out_dir = "logging/rtc_event_log"
Moved RtcEventLog files from call/ to logging/ The RtcEventLog headers need to be accessible from any place which needs logging, and the implementation needs access to data structures that are logged. After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future). The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/). This change allows using RtcEventLog in the p2p/ directory, so that we can log STUN pings and ICE state transitions. BUG=webrtc:6393 R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org Review URL: https://codereview.webrtc.org/2380683005 . Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
}
Reland "New protobuf format for event log."""" This reverts commit 6cfbc35ad7e6c64874c1e2dbd58b8d7c4ab3a679. Reason for revert: Fixing downstream projects. Original change's description: > Revert "Revert "Revert "New protobuf format for event log.""" > > This reverts commit ef8f42040367b3809295a007d7eeeff4526e1b39. > > Reason for revert: New problems with downstream project. > > Original change's description: > > Revert "Revert "New protobuf format for event log."" > > > > This reverts commit 546373fc66e24d041e8eb8ffd2fc522847d841d1. > > > > Reason for revert: Downstream project fixed. > > > > Original change's description: > > > Revert "New protobuf format for event log." > > > > > > This reverts commit 99463c14dbbc88732f0991cb30e7bbfcdaeb3cdc. > > > > > > Reason for revert: Speculative revert for downstream project breakage. > > > > > > Original change's description: > > > > New protobuf format for event log. > > > > > > > > Bug: webrtc:6295 > > > > Change-Id: Ie20a2808a4f076b05fb6195f4fed73215f6fd3b2 > > > > Reviewed-on: https://webrtc-review.googlesource.com/8880 > > > > Commit-Queue: Björn Terelius <terelius@webrtc.org> > > > > Reviewed-by: Per Kjellander <perkj@webrtc.org> > > > > Reviewed-by: Dino Radaković <dinor@webrtc.org> > > > > Cr-Commit-Position: refs/heads/master@{#21291} > > > > > > TBR=terelius@webrtc.org,perkj@webrtc.org,dinor@webrtc.org > > > > > > Change-Id: Ic319170a7a777002ca29248d102cb4e26966d5ae > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: webrtc:6295 > > > Reviewed-on: https://webrtc-review.googlesource.com/33400 > > > Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> > > > Commit-Queue: Rasmus Brandt <brandtr@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#21292} > > > > TBR=brandtr@webrtc.org,terelius@webrtc.org,perkj@webrtc.org,dinor@webrtc.org > > > > Change-Id: I9e96e5007d0447e63178d47c7330488b2a8f2b6f > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: webrtc:6295 > > Reviewed-on: https://webrtc-review.googlesource.com/33440 > > Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> > > Commit-Queue: Rasmus Brandt <brandtr@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#21296} > > TBR=brandtr@webrtc.org,terelius@webrtc.org,perkj@webrtc.org,dinor@webrtc.org > > Change-Id: I4eb15c809f67af13ffa7b7df6eb06088af21f63f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:6295 > Reviewed-on: https://webrtc-review.googlesource.com/33480 > Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> > Commit-Queue: Rasmus Brandt <brandtr@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#21297} TBR=brandtr@webrtc.org,terelius@webrtc.org,perkj@webrtc.org,dinor@webrtc.org Change-Id: I7895575f2b6e4ec2c36296fe81a7596147158601 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:6295 Reviewed-on: https://webrtc-review.googlesource.com/33520 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21299}
2017-12-15 17:12:42 +01:00
proto_library("rtc_event_log2_proto") {
Make rtc_event_log protos publicly visible. Bug: None Change-Id: I189f249914e0fa67826b69aacf93288aa54ac0d5 Reviewed-on: https://webrtc-review.googlesource.com/c/111254 Reviewed-by: Björn Terelius <terelius@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25689}
2018-11-19 12:00:51 +01:00
visibility = [ "*" ]
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "rtc_event_log/rtc_event_log2.proto" ]
Reland "New protobuf format for event log."""" This reverts commit 6cfbc35ad7e6c64874c1e2dbd58b8d7c4ab3a679. Reason for revert: Fixing downstream projects. Original change's description: > Revert "Revert "Revert "New protobuf format for event log.""" > > This reverts commit ef8f42040367b3809295a007d7eeeff4526e1b39. > > Reason for revert: New problems with downstream project. > > Original change's description: > > Revert "Revert "New protobuf format for event log."" > > > > This reverts commit 546373fc66e24d041e8eb8ffd2fc522847d841d1. > > > > Reason for revert: Downstream project fixed. > > > > Original change's description: > > > Revert "New protobuf format for event log." > > > > > > This reverts commit 99463c14dbbc88732f0991cb30e7bbfcdaeb3cdc. > > > > > > Reason for revert: Speculative revert for downstream project breakage. > > > > > > Original change's description: > > > > New protobuf format for event log. > > > > > > > > Bug: webrtc:6295 > > > > Change-Id: Ie20a2808a4f076b05fb6195f4fed73215f6fd3b2 > > > > Reviewed-on: https://webrtc-review.googlesource.com/8880 > > > > Commit-Queue: Björn Terelius <terelius@webrtc.org> > > > > Reviewed-by: Per Kjellander <perkj@webrtc.org> > > > > Reviewed-by: Dino Radaković <dinor@webrtc.org> > > > > Cr-Commit-Position: refs/heads/master@{#21291} > > > > > > TBR=terelius@webrtc.org,perkj@webrtc.org,dinor@webrtc.org > > > > > > Change-Id: Ic319170a7a777002ca29248d102cb4e26966d5ae > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: webrtc:6295 > > > Reviewed-on: https://webrtc-review.googlesource.com/33400 > > > Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> > > > Commit-Queue: Rasmus Brandt <brandtr@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#21292} > > > > TBR=brandtr@webrtc.org,terelius@webrtc.org,perkj@webrtc.org,dinor@webrtc.org > > > > Change-Id: I9e96e5007d0447e63178d47c7330488b2a8f2b6f > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: webrtc:6295 > > Reviewed-on: https://webrtc-review.googlesource.com/33440 > > Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> > > Commit-Queue: Rasmus Brandt <brandtr@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#21296} > > TBR=brandtr@webrtc.org,terelius@webrtc.org,perkj@webrtc.org,dinor@webrtc.org > > Change-Id: I4eb15c809f67af13ffa7b7df6eb06088af21f63f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:6295 > Reviewed-on: https://webrtc-review.googlesource.com/33480 > Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> > Commit-Queue: Rasmus Brandt <brandtr@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#21297} TBR=brandtr@webrtc.org,terelius@webrtc.org,perkj@webrtc.org,dinor@webrtc.org Change-Id: I7895575f2b6e4ec2c36296fe81a7596147158601 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:6295 Reviewed-on: https://webrtc-review.googlesource.com/33520 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21299}
2017-12-15 17:12:42 +01:00
proto_out_dir = "logging/rtc_event_log"
}
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("rtc_event_log_parser") {
Make rtc_event_log_parser visible to other targets. TBR=kwiberg@webrtc.org Bug: webrtc:8111 Change-Id: I1162403c75531bbbb258458319fd6ca7f654ac1d Reviewed-on: https://webrtc-review.googlesource.com/72820 Commit-Queue: Oleh Prypin <oprypin@webrtc.org> Reviewed-by: Oleh Prypin <oprypin@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23037}
2018-04-26 14:46:06 +02:00
visibility = [ "*" ]
Moved RtcEventLog files from call/ to logging/ The RtcEventLog headers need to be accessible from any place which needs logging, and the implementation needs access to data structures that are logged. After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future). The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/). This change allows using RtcEventLog in the p2p/ directory, so that we can log STUN pings and ICE state transitions. BUG=webrtc:6393 R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org Review URL: https://codereview.webrtc.org/2380683005 . Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
sources = [
Reland "Reland "Adds richer packet and ice processing to ParsedRtcEventLog."" This is a reland of 6fc6a0cbb10ee0e988b47f48935b630ba41d109d Original change's description: > Reland "Adds richer packet and ice processing to ParsedRtcEventLog." > > This is a reland of 4306a25dfcaba7defe09f5d4b669736d374fe985 > > Original change's description: > > Adds richer packet and ice processing to ParsedRtcEventLog. > > > > Bug: webrtc:10170 > > Change-Id: I0f10a8c0b5656917a806cf0f3ad88b7a6baee000 > > Reviewed-on: https://webrtc-review.googlesource.com/c/116069 > > Reviewed-by: Björn Terelius <terelius@webrtc.org> > > Commit-Queue: Sebastian Jansson <srte@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#26268} > > Bug: webrtc:10170 > Change-Id: Ie523427acba02b554583223b9ef800249d8d8f2b > Reviewed-on: https://webrtc-review.googlesource.com/c/117724 > Commit-Queue: Sebastian Jansson <srte@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#26350} Bug: webrtc:10170 Change-Id: I9b57ca754197822de9966ee4c93526c7f2159dfd Reviewed-on: https://webrtc-review.googlesource.com/c/118784 Reviewed-by: Björn Terelius <terelius@webrtc.org> Commit-Queue: Sebastian Jansson <srte@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26362}
2019-01-22 08:42:27 +01:00
"rtc_event_log/logged_events.cc",
Moves logged event structs to separate header. Bug: webrtc:10170 Change-Id: I2f6f5b9688f5064fc476063e4e64ac3f9a335b3c Reviewed-on: https://webrtc-review.googlesource.com/c/116061 Reviewed-by: Björn Terelius <terelius@webrtc.org> Commit-Queue: Sebastian Jansson <srte@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26123}
2019-01-03 14:42:15 +01:00
"rtc_event_log/logged_events.h",
Renames RtcEventLogParseNew to RtcEventLogParser Bug: webrtc:10170 Change-Id: I9232c276229a64fa4d8321b6c996387fe130f68b Reviewed-on: https://webrtc-review.googlesource.com/c/116064 Commit-Queue: Sebastian Jansson <srte@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Reviewed-by: Minyue Li <minyue@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26128}
2019-01-03 14:46:23 +01:00
"rtc_event_log/rtc_event_log_parser.cc",
"rtc_event_log/rtc_event_log_parser.h",
Simplifies RtcEventProcessor interface. Bug: webrtc:10170 Change-Id: Ie643e47c55b8c35ca9b8ef31eda5b1673f19d7b3 Reviewed-on: https://webrtc-review.googlesource.com/c/116066 Commit-Queue: Sebastian Jansson <srte@webrtc.org> Reviewed-by: Oskar Sundbom <ossu@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26160}
2019-01-08 15:31:06 +01:00
"rtc_event_log/rtc_event_processor.cc",
Add helper class to process RtcEventLog events in order. Add helper class to process RtcEventLog events in order. Use helper class to migrate rtc_event_log2rtp_dump.cc to new parser API. Bug: webrtc:8111 Change-Id: I7cbc220dad1f50be3a985ed44de27b38e5f20476 Reviewed-on: https://webrtc-review.googlesource.com/98601 Commit-Queue: Björn Terelius <terelius@webrtc.org> Reviewed-by: Elad Alon <eladalon@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24806}
2018-09-24 17:10:27 +02:00
"rtc_event_log/rtc_event_processor.h",
Moved RtcEventLog files from call/ to logging/ The RtcEventLog headers need to be accessible from any place which needs logging, and the implementation needs access to data structures that are logged. After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future). The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/). This change allows using RtcEventLog in the p2p/ directory, so that we can log STUN pings and ICE state transitions. BUG=webrtc:6393 R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org Review URL: https://codereview.webrtc.org/2380683005 . Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
]
Stop using public_deps in logging/. Bug: webrtc:8603 Change-Id: Id0df997620a27e47067e4b21e4e8db16aec90640 No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/30940 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21228}
2017-12-12 12:46:13 +01:00
deps = [
Reland "Structured ICE logging via RtcEventLog." This is a reland of eed5aa8904d09179971d3f4e7e10c109d7c62bfc Original change's description: > Structured ICE logging via RtcEventLog. > > This change list contains the structured logging module for ICE using > the RtcEventLog infrastructure, and also extension to the log parser > and analyzer. > > Bug: None > Change-Id: I6539cf282155c2cde4d3161c53500c0746671a02 > Reviewed-on: https://webrtc-review.googlesource.com/34622 > Commit-Queue: Qingsi Wang <qingsi@google.com> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Peter Thatcher <pthatcher@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#21816} TBR=pthatcher@webrtc.org,terelius@webrtc.org,deadbeef@webrtc.org Bug: None Change-Id: I3df585bf636315ceb0273967146111346a83be86 Reviewed-on: https://webrtc-review.googlesource.com/47545 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Qingsi Wang <qingsi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21881}
2018-02-02 11:49:44 -08:00
":ice_log",
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
":rtc_event_bwe",
Reland "New protobuf format for event log."""" This reverts commit 6cfbc35ad7e6c64874c1e2dbd58b8d7c4ab3a679. Reason for revert: Fixing downstream projects. Original change's description: > Revert "Revert "Revert "New protobuf format for event log.""" > > This reverts commit ef8f42040367b3809295a007d7eeeff4526e1b39. > > Reason for revert: New problems with downstream project. > > Original change's description: > > Revert "Revert "New protobuf format for event log."" > > > > This reverts commit 546373fc66e24d041e8eb8ffd2fc522847d841d1. > > > > Reason for revert: Downstream project fixed. > > > > Original change's description: > > > Revert "New protobuf format for event log." > > > > > > This reverts commit 99463c14dbbc88732f0991cb30e7bbfcdaeb3cdc. > > > > > > Reason for revert: Speculative revert for downstream project breakage. > > > > > > Original change's description: > > > > New protobuf format for event log. > > > > > > > > Bug: webrtc:6295 > > > > Change-Id: Ie20a2808a4f076b05fb6195f4fed73215f6fd3b2 > > > > Reviewed-on: https://webrtc-review.googlesource.com/8880 > > > > Commit-Queue: Björn Terelius <terelius@webrtc.org> > > > > Reviewed-by: Per Kjellander <perkj@webrtc.org> > > > > Reviewed-by: Dino Radaković <dinor@webrtc.org> > > > > Cr-Commit-Position: refs/heads/master@{#21291} > > > > > > TBR=terelius@webrtc.org,perkj@webrtc.org,dinor@webrtc.org > > > > > > Change-Id: Ic319170a7a777002ca29248d102cb4e26966d5ae > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: webrtc:6295 > > > Reviewed-on: https://webrtc-review.googlesource.com/33400 > > > Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> > > > Commit-Queue: Rasmus Brandt <brandtr@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#21292} > > > > TBR=brandtr@webrtc.org,terelius@webrtc.org,perkj@webrtc.org,dinor@webrtc.org > > > > Change-Id: I9e96e5007d0447e63178d47c7330488b2a8f2b6f > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: webrtc:6295 > > Reviewed-on: https://webrtc-review.googlesource.com/33440 > > Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> > > Commit-Queue: Rasmus Brandt <brandtr@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#21296} > > TBR=brandtr@webrtc.org,terelius@webrtc.org,perkj@webrtc.org,dinor@webrtc.org > > Change-Id: I4eb15c809f67af13ffa7b7df6eb06088af21f63f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:6295 > Reviewed-on: https://webrtc-review.googlesource.com/33480 > Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> > Commit-Queue: Rasmus Brandt <brandtr@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#21297} TBR=brandtr@webrtc.org,terelius@webrtc.org,perkj@webrtc.org,dinor@webrtc.org Change-Id: I7895575f2b6e4ec2c36296fe81a7596147158601 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:6295 Reviewed-on: https://webrtc-review.googlesource.com/33520 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21299}
2017-12-15 17:12:42 +01:00
":rtc_event_log2_proto",
Use delta-encoding in new WebRTC event logs The new event log format makes use of delta encoding to compress parts of the log. Bug: webrtc:8111 Change-Id: I7bec839555323a7537dcec831d4ac1d5eb109932 Reviewed-on: https://webrtc-review.googlesource.com/c/109161 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25584}
2018-11-09 16:38:54 +01:00
":rtc_event_log_impl_encoder",
Moved RtcEventLog files from call/ to logging/ The RtcEventLog headers need to be accessible from any place which needs logging, and the implementation needs access to data structures that are logged. After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future). The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/). This change allows using RtcEventLog in the p2p/ directory, so that we can log STUN pings and ICE state transitions. BUG=webrtc:6393 R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org Review URL: https://codereview.webrtc.org/2380683005 . Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
":rtc_event_log_proto",
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
":rtc_stream_config",
Move rtc::FunctionView to the public API Bug: webrtc:10138 Change-Id: Icc25a2a277a9608701aaddd546882366739991ca Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127898 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27227}
2019-03-21 14:37:36 +01:00
"../api:function_view",
Reland "Move api/rtp_headers.h to its own build target." This is a reland of a67050debcb5a3461a452a7928d7aaea1562747e Original change's description: > Move api/rtp_headers.h to its own build target. > > Reduces dependencies on the libjingle_peerconnection_api target from > lower-level code. > > Bug: None > Change-Id: I98576fc718c396cc0f720c3770acd2b696b9df89 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128565 > Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > Commit-Queue: Niels Moller <nisse@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#27213} Bug: None Tbr: kwiberg@webrtc.org Change-Id: If15b05957e50bb8f18a33c2ed1321e672311b626 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127895 Reviewed-by: Niels Moller <nisse@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27216}
2019-03-20 08:40:23 +01:00
"../api:rtp_headers",
New target for api/rtp_parameters.h and api/media_types.h. The new target does not depend on libjingle_peerconnection_api, and to do this, the named "audio" and "video" string literals had to be moved from media_stream_interface.cc to media_types.cc. In this cl, the dependency on libjingle_peerconnection_api can be dropped from a few targets. No-Presubmit: True Bug: webrtc:8733 Change-Id: Icc675280d5c3c537f2255a9389ff18a482049921 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/53861 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28998}
2019-08-26 10:45:28 +02:00
"../api:rtp_parameters",
Delete deprecated rtc_event_log header Bug: webrtc:10206 Change-Id: I9ed3148843c647372993729b87c0e74741ab540b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/147870 Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28791}
2019-08-07 12:24:53 +02:00
"../api/rtc_event_log",
Reland "Reland "Adds richer packet and ice processing to ParsedRtcEventLog."" This is a reland of 6fc6a0cbb10ee0e988b47f48935b630ba41d109d Original change's description: > Reland "Adds richer packet and ice processing to ParsedRtcEventLog." > > This is a reland of 4306a25dfcaba7defe09f5d4b669736d374fe985 > > Original change's description: > > Adds richer packet and ice processing to ParsedRtcEventLog. > > > > Bug: webrtc:10170 > > Change-Id: I0f10a8c0b5656917a806cf0f3ad88b7a6baee000 > > Reviewed-on: https://webrtc-review.googlesource.com/c/116069 > > Reviewed-by: Björn Terelius <terelius@webrtc.org> > > Commit-Queue: Sebastian Jansson <srte@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#26268} > > Bug: webrtc:10170 > Change-Id: Ie523427acba02b554583223b9ef800249d8d8f2b > Reviewed-on: https://webrtc-review.googlesource.com/c/117724 > Commit-Queue: Sebastian Jansson <srte@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#26350} Bug: webrtc:10170 Change-Id: I9b57ca754197822de9966ee4c93526c7f2159dfd Reviewed-on: https://webrtc-review.googlesource.com/c/118784 Reviewed-by: Björn Terelius <terelius@webrtc.org> Commit-Queue: Sebastian Jansson <srte@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26362}
2019-01-22 08:42:27 +01:00
"../api/units:data_rate",
"../api/units:time_delta",
"../api/units:timestamp",
Add logging of decoded video frames. This CL adds the possibility to log metainformation about decoded frames in RTC event log, including encoding parsing and tests. It will be wired up in a followup CL. Bug: webrtc:8802 Change-Id: Ied598b266513d0f63fce0484d741af1782607e74 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/181061 Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org> Reviewed-by: Artem Titov <titovartem@webrtc.org> Commit-Queue: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31873}
2020-08-06 12:37:08 +02:00
"../api/video:video_frame",
Stop using public_deps in logging/. Bug: webrtc:8603 Change-Id: Id0df997620a27e47067e4b21e4e8db16aec90640 No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/30940 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21228}
2017-12-12 12:46:13 +01:00
"../call:video_stream_api",
Reland "Reland "Improving robustness of feedback matching code in event log parser."" This is a reland of 0870c70b0471c3bae16ad9a6732d812ee25446dd Original change's description: > Reland "Improving robustness of feedback matching code in event log parser." > > This is a reland of a1e4fbb25371867349a0c2ed6ba62224735a2ec7 > > Original change's description: > > Improving robustness of feedback matching code in event log parser. > > > > Removes the dependency on TransportFeedbackAdapter thereby removing > > some of the complexity that came with it, in particular, we don't fill > > in missing packets. This makes the code easier to debug and avoids some > > confusing logging that's not relevant for the parser. > > > > Bug: webrtc:9883 > > Change-Id: I6df8425e8ab410514727c51a5e8d4981d6561f03 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133347 > > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > > Reviewed-by: Björn Terelius <terelius@webrtc.org> > > Commit-Queue: Sebastian Jansson <srte@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#27739} > > Bug: webrtc:9883 > Change-Id: I460d0c576626614fb4ce2c3d5e3ddbb5d1c122cf > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134106 > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Sebastian Jansson <srte@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#27763} Bug: webrtc:9883 Change-Id: I1f80ed1f63ad75fbb97f5f401fe486d19c057f75 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134462 Reviewed-by: Åsa Persson <asapersson@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Commit-Queue: Sebastian Jansson <srte@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27829}
2019-05-02 17:07:22 +02:00
"../modules:module_api",
Cleanup includes in modules/include/module_common_types.h Add missing includes to files that were transactivly depending on removed includes. Bug: None Change-Id: Id5923bb8dc3e1d8fbb664e460278ad3e5993be7e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/155963 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29396}
2019-10-07 12:56:24 +02:00
"../modules:module_api_public",
Resolve cyclic dependency between audio network adaptor and event log api BUG=webrtc:7257 Review-Url: https://codereview.webrtc.org/2745473003 Cr-Commit-Position: refs/heads/master@{#17565}
2017-04-06 05:59:10 -07:00
"../modules/audio_coding:audio_network_adaptor",
Cleanup BUILD.gn files from imports like foo:foo Repalce all occurrences of foo:foo in deps with just foo in BUILD.gn files. Done with Sublime regex replace. Find: \b([-a-zA-Z0-9_]+):+\1\b In: *.gn Replace with: \1 Bug: None Change-Id: I40aba1b14face687a595b852ffe443cb20197611 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127899 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27225}
2019-03-21 13:35:10 +01:00
"../modules/remote_bitrate_estimator",
Stop using public_deps in modules/rtp_rtcp. TBR=phoglund@webrtc.org Bug: webrtc:8603 Change-Id: I86830df23db3f33a1a26098e639596bd3b86485a No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/29780 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21108}
2017-12-06 07:51:33 +01:00
"../modules/rtp_rtcp",
Stop using public_deps in logging/. Bug: webrtc:8603 Change-Id: Id0df997620a27e47067e4b21e4e8db16aec90640 No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/30940 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21228}
2017-12-12 12:46:13 +01:00
"../modules/rtp_rtcp:rtp_rtcp_format",
Fix circular dependencies between optional, array_view, and rtc_base. This splits things out of rtc_base and makes dependencies explicit. Bug: webrtc:6828 Change-Id: Id521896c3c43595349021c857bec216e429a0c8d Reviewed-on: https://webrtc-review.googlesource.com/32780 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21264}
2017-12-13 16:05:42 +01:00
"../rtc_base:checks",
Renames RtcEventLogParseNew to RtcEventLogParser Bug: webrtc:10170 Change-Id: I9232c276229a64fa4d8321b6c996387fe130f68b Reviewed-on: https://webrtc-review.googlesource.com/c/116064 Commit-Queue: Sebastian Jansson <srte@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Reviewed-by: Minyue Li <minyue@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26128}
2019-01-03 14:46:23 +01:00
"../rtc_base:deprecation",
Move rtc_base/ignore_wundef.h to its own target. Since rtc_base/ignore_wundef.h doesn't have any dependency, it is easy to move it to its own target and allow its dependant to avoid to take a dependency rtc_base:on rtc_base_approved. Bug: webrtc:9419 Change-Id: I17f205b0cb2b21cad388b04e60082df9398dffdf Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157428 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29548}
2019-10-19 12:03:23 +02:00
"../rtc_base:ignore_wundef",
Stop using public_deps in logging/. Bug: webrtc:8603 Change-Id: Id0df997620a27e47067e4b21e4e8db16aec90640 No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/30940 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21228}
2017-12-12 12:46:13 +01:00
"../rtc_base:protobuf_utils",
"../rtc_base:rtc_base_approved",
Reland "Reland "Adds richer packet and ice processing to ParsedRtcEventLog."" This is a reland of 6fc6a0cbb10ee0e988b47f48935b630ba41d109d Original change's description: > Reland "Adds richer packet and ice processing to ParsedRtcEventLog." > > This is a reland of 4306a25dfcaba7defe09f5d4b669736d374fe985 > > Original change's description: > > Adds richer packet and ice processing to ParsedRtcEventLog. > > > > Bug: webrtc:10170 > > Change-Id: I0f10a8c0b5656917a806cf0f3ad88b7a6baee000 > > Reviewed-on: https://webrtc-review.googlesource.com/c/116069 > > Reviewed-by: Björn Terelius <terelius@webrtc.org> > > Commit-Queue: Sebastian Jansson <srte@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#26268} > > Bug: webrtc:10170 > Change-Id: Ie523427acba02b554583223b9ef800249d8d8f2b > Reviewed-on: https://webrtc-review.googlesource.com/c/117724 > Commit-Queue: Sebastian Jansson <srte@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#26350} Bug: webrtc:10170 Change-Id: I9b57ca754197822de9966ee4c93526c7f2159dfd Reviewed-on: https://webrtc-review.googlesource.com/c/118784 Reviewed-by: Björn Terelius <terelius@webrtc.org> Commit-Queue: Sebastian Jansson <srte@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26362}
2019-01-22 08:42:27 +01:00
"../rtc_base:rtc_numerics",
Use absl_deps in order to preapre to the Abseil component build release. Bug: webrtc:1046390 Change-Id: Ia35545599de23b1a2c2d8be2d53469af7ac16f1d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176502 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31463}
2020-06-05 14:30:41 +02:00
]
absl_deps = [
Use absl::make_unique and absl::WrapUnique directly Instead of going through our wrappers in ptr_util.h. This CL was generated by the following script: git grep -l ptr_util | xargs perl -pi -e 's,#include "rtc_base/ptr_util.h",#include "absl/memory/memory.h",' git grep -l MakeUnique | xargs perl -pi -e 's,\b(rtc::)?MakeUnique\b,absl::make_unique,g' git grep -l WrapUnique | xargs perl -pi -e 's,\b(rtc::)?WrapUnique\b,absl::WrapUnique,g' git checkout -- rtc_base/ptr_util{.h,_unittest.cc} git cl format Followed by manually adding dependencies on //third_party/abseil-cpp/absl/memory until `gn check` stopped complaining. Bug: webrtc:9473 Change-Id: I89ccd363f070479b8c431eb2c3d404a46eaacc1c Reviewed-on: https://webrtc-review.googlesource.com/86600 Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23850}
2018-07-05 11:40:33 +02:00
"//third_party/abseil-cpp/absl/memory",
Include optional.h in rtc_event_log_parser_new.cc Bug: None Change-Id: I5ef8227ca4763232717808aae2f6395ce66a4ed9 Reviewed-on: https://webrtc-review.googlesource.com/103160 Reviewed-by: Björn Terelius <terelius@webrtc.org> Commit-Queue: Elad Alon <eladalon@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24927}
2018-10-02 13:20:40 +02:00
"//third_party/abseil-cpp/absl/types:optional",
Moved RtcEventLog files from call/ to logging/ The RtcEventLog headers need to be accessible from any place which needs logging, and the implementation needs access to data structures that are logged. After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future). The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/). This change allows using RtcEventLog in the p2p/ directory, so that we can log STUN pings and ICE state transitions. BUG=webrtc:6393 R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org Review URL: https://codereview.webrtc.org/2380683005 . Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
]
}
GN: Refactor so that WebRTC compiles with rtc_enable_protobuf=false. This is a first step towards it. I plan to refactor modules_unittests before continuing with this. BUG=webrtc:6626 NOTRY=True Review-Url: https://codereview.webrtc.org/2626163004 Cr-Commit-Position: refs/heads/master@{#16109}
2017-01-17 02:37:34 -08:00
if (rtc_include_tests) {
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("rtc_event_log_tests") {
GN: Refactor so that WebRTC compiles with rtc_enable_protobuf=false. This is a first step towards it. I plan to refactor modules_unittests before continuing with this. BUG=webrtc:6626 NOTRY=True Review-Url: https://codereview.webrtc.org/2626163004 Cr-Commit-Position: refs/heads/master@{#16109}
2017-01-17 02:37:34 -08:00
testonly = true
Create RtcEventLogEncoderLegacy We're moving to an RtcEventLog interface that accepts std::unique_ptr<EventLog> and stores the event for encoding when encoding becomes necessary, rather than before. This will be useful while we maintain the legacy (current) encoding alongside the new encoding on which we're working. This CL introduces RtcEventLogEncoderLegacy, which takes provides the encoding currently done by RtcEventLogImpl. After this, we can modify RtcEventLogImpl to use a dynamically chosen encoding, allowing us to easily choose between the current encoding and the new one on which we're working. BUG=webrtc:8111 TBR=stefan@webrtc.org Change-Id: I3dde7e222a40a117549a094a59b04219467f490a Reviewed-on: https://webrtc-review.googlesource.com/1364 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Elad Alon <eladalon@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20116}
2017-10-03 15:01:03 +02:00
assert(rtc_enable_protobuf)
GN: Refactor so that WebRTC compiles with rtc_enable_protobuf=false. This is a first step towards it. I plan to refactor modules_unittests before continuing with this. BUG=webrtc:6626 NOTRY=True Review-Url: https://codereview.webrtc.org/2626163004 Cr-Commit-Position: refs/heads/master@{#16109}
2017-01-17 02:37:34 -08:00
sources = [
Add blob-encoding support for RTC event logs A blob is a string of binary information, whose length may not necessarily be determined by looking into the string, so that concatenating all blobs without explicitly including their lengths as part of their encoding is not a viable option. Bug: webrtc:8111 Change-Id: I89fdca660e89a6a71eff3ecb7b86416312b81f23 Reviewed-on: https://webrtc-review.googlesource.com/c/104201 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Reviewed-by: Yves Gerey <yvesg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25278}
2018-10-19 18:30:30 +02:00
"rtc_event_log/encoder/blob_encoding_unittest.cc",
Add fixed-size delta-encoding/decoding code for WebRTC event logs Add code for delta-encoding and decoding, to be used when producing WebRTC event logs of the new format. This CL supports fixed-size encoding only. Also, no support for signed deltas or optional values yet. These will be added in subsequent CLs. Bug: webrtc:8111 Change-Id: I531abd99fd924f4c9e692abe565bc6f66c875ad5 Reviewed-on: https://webrtc-review.googlesource.com/c/100304 Reviewed-by: Björn Terelius <terelius@webrtc.org> Commit-Queue: Elad Alon <eladalon@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25256}
2018-10-18 13:43:35 +02:00
"rtc_event_log/encoder/delta_encoding_unittest.cc",
Use delta-encoding in new WebRTC event logs The new event log format makes use of delta encoding to compress parts of the log. Bug: webrtc:8111 Change-Id: I7bec839555323a7537dcec831d4ac1d5eb109932 Reviewed-on: https://webrtc-review.googlesource.com/c/109161 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25584}
2018-11-09 16:38:54 +01:00
"rtc_event_log/encoder/rtc_event_log_encoder_common_unittest.cc",
Create RtcEventLogEncoderLegacy We're moving to an RtcEventLog interface that accepts std::unique_ptr<EventLog> and stores the event for encoding when encoding becomes necessary, rather than before. This will be useful while we maintain the legacy (current) encoding alongside the new encoding on which we're working. This CL introduces RtcEventLogEncoderLegacy, which takes provides the encoding currently done by RtcEventLogImpl. After this, we can modify RtcEventLogImpl to use a dynamically chosen encoding, allowing us to easily choose between the current encoding and the new one on which we're working. BUG=webrtc:8111 TBR=stefan@webrtc.org Change-Id: I3dde7e222a40a117549a094a59b04219467f490a Reviewed-on: https://webrtc-review.googlesource.com/1364 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Elad Alon <eladalon@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20116}
2017-10-03 15:01:03 +02:00
"rtc_event_log/encoder/rtc_event_log_encoder_unittest.cc",
GN: Refactor so that WebRTC compiles with rtc_enable_protobuf=false. This is a first step towards it. I plan to refactor modules_unittests before continuing with this. BUG=webrtc:6626 NOTRY=True Review-Url: https://codereview.webrtc.org/2626163004 Cr-Commit-Position: refs/heads/master@{#16109}
2017-01-17 02:37:34 -08:00
"rtc_event_log/rtc_event_log_unittest.cc",
"rtc_event_log/rtc_event_log_unittest_helper.cc",
Add rtc_event_log_unittest_helper.h to relevant BUILD.gn BUG=None Review-Url: https://codereview.webrtc.org/3002813002 Cr-Commit-Position: refs/heads/master@{#19389}
2017-08-17 08:32:39 -07:00
"rtc_event_log/rtc_event_log_unittest_helper.h",
Add helper class to process RtcEventLog events in order. Add helper class to process RtcEventLog events in order. Use helper class to migrate rtc_event_log2rtp_dump.cc to new parser API. Bug: webrtc:8111 Change-Id: I7cbc220dad1f50be3a985ed44de27b38e5f20476 Reviewed-on: https://webrtc-review.googlesource.com/98601 Commit-Queue: Björn Terelius <terelius@webrtc.org> Reviewed-by: Elad Alon <eladalon@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24806}
2018-09-24 17:10:27 +02:00
"rtc_event_log/rtc_event_processor_unittest.cc",
GN: Refactor so that WebRTC compiles with rtc_enable_protobuf=false. This is a first step towards it. I plan to refactor modules_unittests before continuing with this. BUG=webrtc:6626 NOTRY=True Review-Url: https://codereview.webrtc.org/2626163004 Cr-Commit-Position: refs/heads/master@{#16109}
2017-01-17 02:37:34 -08:00
]
deps = [
Rewrite the RtcEventLog unit test. Bug: webrtc:8111 Change-Id: I36780940b54bf500244c6755113153c84c997942 Reviewed-on: https://webrtc-review.googlesource.com/80660 Commit-Queue: Björn Terelius <terelius@webrtc.org> Reviewed-by: Elad Alon <eladalon@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23736}
2018-06-26 11:41:27 +02:00
":ice_log",
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
":rtc_event_audio",
":rtc_event_bwe",
Add logging of decoded video frames. This CL adds the possibility to log metainformation about decoded frames in RTC event log, including encoding parsing and tests. It will be wired up in a followup CL. Bug: webrtc:8802 Change-Id: Ied598b266513d0f63fce0484d741af1782607e74 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/181061 Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org> Reviewed-by: Artem Titov <titovartem@webrtc.org> Commit-Queue: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31873}
2020-08-06 12:37:08 +02:00
":rtc_event_frame_events",
Support GenericPacketReceived/Sent/AckReceived event logs. This change does not include receive_timestamps for ACKs, because there is 1 problem. That problem will be resolved in a separate change. I am getting receive_timestamp errors that have to do with delta compression with optional fields. Two failure modes that I noticed: 1) the base event does not have the timestamp: it crashes with length validation # Check failed: base <= MaxUnsignedValueOfBitWidth(params_.value_width_bits()) (1820716 vs. 131071) 2) all events are null, it crashes with assert that X events were expected, but no events were deserialized. Bug: webrtc:9719 Change-Id: I5d1bbb95dfd15ca7321667aad5e4d89c085e9c06 Reviewed-on: https://webrtc-review.googlesource.com/c/122360 Commit-Queue: Peter Slatala <psla@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26668}
2019-02-13 07:49:30 -08:00
":rtc_event_generic_packet_events",
Reland "Encode RTC event logs in new format." This is a reland of ece3c228a2cbd1c1b05eee3a7f55dbb6f020acbc Original change's description: > Encode RTC event logs in new format. > > This CL adds the encoder and wires it up to the event log. > Parser and unit tests are uploaded in a separate CL. > > Bug: webrtc:8111 > Change-Id: I6470003e55c2c4006cd8349a2c4bdc3f9491d869 > Reviewed-on: https://webrtc-review.googlesource.com/c/106708 > Commit-Queue: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Elad Alon <eladalon@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#25333} Bug: webrtc:8111 Change-Id: I22eeca36d6b1f7cfa1ac65347571ebe33cecc1fc Reviewed-on: https://webrtc-review.googlesource.com/c/108082 Reviewed-by: Elad Alon <eladalon@webrtc.org> Commit-Queue: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25382}
2018-10-24 13:51:56 +02:00
":rtc_event_log2_proto",
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
":rtc_event_log_impl_encoder",
GN: Refactor so that WebRTC compiles with rtc_enable_protobuf=false. This is a first step towards it. I plan to refactor modules_unittests before continuing with this. BUG=webrtc:6626 NOTRY=True Review-Url: https://codereview.webrtc.org/2626163004 Cr-Commit-Position: refs/heads/master@{#16109}
2017-01-17 02:37:34 -08:00
":rtc_event_log_parser",
Stop using public_deps in logging/. Bug: webrtc:8603 Change-Id: Id0df997620a27e47067e4b21e4e8db16aec90640 No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/30940 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21228}
2017-12-12 12:46:13 +01:00
":rtc_event_log_proto",
Rewrite the RtcEventLog unit test. Bug: webrtc:8111 Change-Id: I36780940b54bf500244c6755113153c84c997942 Reviewed-on: https://webrtc-review.googlesource.com/80660 Commit-Queue: Björn Terelius <terelius@webrtc.org> Reviewed-by: Elad Alon <eladalon@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23736}
2018-06-26 11:41:27 +02:00
":rtc_event_pacing",
Reland "Break up rtc_event_log_api to solve circular dependencies." This is a reland of 001546da953275c7a39eb220592b440c9b47d756 Original change's description: > Break up rtc_event_log_api to solve circular dependencies. > > The original rtc_event_log_api is refactored to a pure API target plus > multiple targets coupled with WebRTC implementations. > > Bug: None > Change-Id: Iab9eee3f7bf4228c52d94a5f26fc39bb99b5033f > Reviewed-on: https://webrtc-review.googlesource.com/43247 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#21811} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,terelius@webrtc.org,stefan@webrtc.org Bug: None Change-Id: I3e7213733741cbfd5dd0076f32209e6bc42a0647 Reviewed-on: https://webrtc-review.googlesource.com/46900 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21862}
2018-02-01 11:04:46 -08:00
":rtc_event_rtp_rtcp",
":rtc_event_video",
":rtc_stream_config",
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2. This is a follow-up to https://webrtc-review.googlesource.com/c/src/+/106280. This time the whole code base is covered. Some files may have not been fixed though, whenever the IWYU tool was breaking the build. Bug: webrtc:8311 Change-Id: I2c31f552a87e887d33931d46e87b6208b1e483ef Reviewed-on: https://webrtc-review.googlesource.com/c/111965 Commit-Queue: Yves Gerey <yvesg@google.com> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25830}
2018-11-28 16:47:49 +01:00
"../api:array_view",
Promote RtcEventLogOutputFile to api/ Preparation for deleting PeerConnectionInterface::StartRtcEventLog method with a PlatformFile argument. Bug: webrtc:6463 Change-Id: Ia9fa1d99a3d87f3bf193e73382690b782ffea65c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/135285 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27879}
2019-05-08 13:53:51 +02:00
"../api:rtc_event_log_output_file",
Reland "Move api/rtp_headers.h to its own build target." This is a reland of a67050debcb5a3461a452a7928d7aaea1562747e Original change's description: > Move api/rtp_headers.h to its own build target. > > Reduces dependencies on the libjingle_peerconnection_api target from > lower-level code. > > Bug: None > Change-Id: I98576fc718c396cc0f720c3770acd2b696b9df89 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128565 > Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > Commit-Queue: Niels Moller <nisse@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#27213} Bug: None Tbr: kwiberg@webrtc.org Change-Id: If15b05957e50bb8f18a33c2ed1321e672311b626 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127895 Reviewed-by: Niels Moller <nisse@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27216}
2019-03-20 08:40:23 +01:00
"../api:rtp_headers",
New target for api/rtp_parameters.h and api/media_types.h. The new target does not depend on libjingle_peerconnection_api, and to do this, the named "audio" and "video" string literals had to be moved from media_stream_interface.cc to media_types.cc. In this cl, the dependency on libjingle_peerconnection_api can be dropped from a few targets. No-Presubmit: True Bug: webrtc:8733 Change-Id: Icc675280d5c3c537f2255a9389ff18a482049921 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/53861 Commit-Queue: Niels Moller <nisse@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28998}
2019-08-26 10:45:28 +02:00
"../api:rtp_parameters",
Delete deprecated rtc_event_log header Bug: webrtc:10206 Change-Id: I9ed3148843c647372993729b87c0e74741ab540b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/147870 Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28791}
2019-08-07 12:24:53 +02:00
"../api/rtc_event_log",
Delete RtcEventLogFactory factory as now unused Bug: webrtc:10206, webrtc:10284 Change-Id: I34fa780f566b52e375ec625bf0d5d02c505d9912 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/143782 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28400}
2019-06-26 15:49:47 +02:00
"../api/rtc_event_log:rtc_event_log_factory",
Add RtcEventLogFactory factory with explicit TaskQueueFactory remove RtcEventLog factory function that relies on GlobalTaskQueueFactory, move that default behaviour up to RtcEventLogFactory level. Bug: webrtc:10284 Change-Id: I512d8a13e6a2f320000dd08e6355c0a7e9de8561 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132542 Reviewed-by: Björn Terelius <terelius@webrtc.org> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27573}
2019-04-11 15:18:18 +02:00
"../api/task_queue:default_task_queue_factory",
GN: Refactor so that WebRTC compiles with rtc_enable_protobuf=false. This is a first step towards it. I plan to refactor modules_unittests before continuing with this. BUG=webrtc:6626 NOTRY=True Review-Url: https://codereview.webrtc.org/2626163004 Cr-Commit-Position: refs/heads/master@{#16109}
2017-01-17 02:37:34 -08:00
"../call",
Stop using public_deps in the call module. Bug: webrtc:8603 Change-Id: I048127bc86f213e638e6814ac8a86761cb8a64db Reviewed-on: https://webrtc-review.googlesource.com/28624 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21072}
2017-12-04 10:50:51 +01:00
"../call:call_interfaces",
Resolve cyclic dependency between audio network adaptor and event log api BUG=webrtc:7257 Review-Url: https://codereview.webrtc.org/2745473003 Cr-Commit-Position: refs/heads/master@{#17565}
2017-04-06 05:59:10 -07:00
"../modules/audio_coding:audio_network_adaptor",
Cleanup BUILD.gn files from imports like foo:foo Repalce all occurrences of foo:foo in deps with just foo in BUILD.gn files. Done with Sublime regex replace. Find: \b([-a-zA-Z0-9_]+):+\1\b In: *.gn Replace with: \1 Bug: None Change-Id: I40aba1b14face687a595b852ffe443cb20197611 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127899 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27225}
2019-03-21 13:35:10 +01:00
"../modules/remote_bitrate_estimator",
Stop using public_deps in modules/rtp_rtcp. TBR=phoglund@webrtc.org Bug: webrtc:8603 Change-Id: I86830df23db3f33a1a26098e639596bd3b86485a No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/29780 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21108}
2017-12-06 07:51:33 +01:00
"../modules/rtp_rtcp:rtp_rtcp_format",
Fix circular dependencies between optional, array_view, and rtc_base. This splits things out of rtc_base and makes dependencies explicit. Bug: webrtc:6828 Change-Id: Id521896c3c43595349021c857bec216e429a0c8d Reviewed-on: https://webrtc-review.googlesource.com/32780 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21264}
2017-12-13 16:05:42 +01:00
"../rtc_base:checks",
Remove remains of webrtc/base All downstream code have been updated to the new location. In PRESUBMIT.py: * Remove webrtc/rtc_base from CPP_BLACKLIST * Add webrtc/rtc_base to LEGACY_API_DIRS Fix some duplicated paths in webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn BUG=webrtc:7634 TBR=kwiberg@webrtc.org Review-Url: https://codereview.webrtc.org/2976293002 Cr-Commit-Position: refs/heads/master@{#19094}
2017-07-19 10:40:47 -07:00
"../rtc_base:rtc_base_approved",
"../rtc_base:rtc_base_tests_utils",
Cleanup BUILD.gn files from imports like foo:foo Repalce all occurrences of foo:foo in deps with just foo in BUILD.gn files. Done with Sublime regex replace. Find: \b([-a-zA-Z0-9_]+):+\1\b In: *.gn Replace with: \1 Bug: None Change-Id: I40aba1b14face687a595b852ffe443cb20197611 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127899 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27225}
2019-03-21 13:35:10 +01:00
"../system_wrappers",
Remove the public_deps to fileutils from test_support. Bug: webrtc:8946 Change-Id: Ia01d8bb1b42485e29f26792b9266228743d7fd90 No-Presubmit: true Reviewed-on: https://webrtc-review.googlesource.com/62100 Commit-Queue: Artem Titov <titovartem@webrtc.org> Reviewed-by: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22465}
2018-03-15 15:05:39 +01:00
"../test:fileutils",
Enable GN check for webrtc/logging BUG=webrtc:6828, webrtc:7257 NOTRY=True Review-Url: https://codereview.webrtc.org/2717903002 Cr-Commit-Position: refs/heads/master@{#17111}
2017-03-08 02:12:11 -08:00
"../test:test_support",
GN: Refactor so that WebRTC compiles with rtc_enable_protobuf=false. This is a first step towards it. I plan to refactor modules_unittests before continuing with this. BUG=webrtc:6626 NOTRY=True Review-Url: https://codereview.webrtc.org/2626163004 Cr-Commit-Position: refs/heads/master@{#16109}
2017-01-17 02:37:34 -08:00
"//testing/gtest",
Use absl_deps in order to preapre to the Abseil component build release. Bug: webrtc:1046390 Change-Id: Ia35545599de23b1a2c2d8be2d53469af7ac16f1d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176502 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31463}
2020-06-05 14:30:41 +02:00
]
absl_deps = [
Use absl::make_unique and absl::WrapUnique directly Instead of going through our wrappers in ptr_util.h. This CL was generated by the following script: git grep -l ptr_util | xargs perl -pi -e 's,#include "rtc_base/ptr_util.h",#include "absl/memory/memory.h",' git grep -l MakeUnique | xargs perl -pi -e 's,\b(rtc::)?MakeUnique\b,absl::make_unique,g' git grep -l WrapUnique | xargs perl -pi -e 's,\b(rtc::)?WrapUnique\b,absl::WrapUnique,g' git checkout -- rtc_base/ptr_util{.h,_unittest.cc} git cl format Followed by manually adding dependencies on //third_party/abseil-cpp/absl/memory until `gn check` stopped complaining. Bug: webrtc:9473 Change-Id: I89ccd363f070479b8c431eb2c3d404a46eaacc1c Reviewed-on: https://webrtc-review.googlesource.com/86600 Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23850}
2018-07-05 11:40:33 +02:00
"//third_party/abseil-cpp/absl/memory",
Depend directly on destination targets. Makes 'gn check' happy. Followup to https://webrtc-review.googlesource.com/c/src/+/106820 Bug: webrtc:5876, webrtc:9855 Change-Id: I33fa2c31ba26dc10c9a9c17da0ffed255c1f4d5b Reviewed-on: https://webrtc-review.googlesource.com/c/108760 Commit-Queue: Yves Gerey <yvesg@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25447}
2018-10-30 22:23:02 +01:00
"//third_party/abseil-cpp/absl/types:optional",
GN: Refactor so that WebRTC compiles with rtc_enable_protobuf=false. This is a first step towards it. I plan to refactor modules_unittests before continuing with this. BUG=webrtc:6626 NOTRY=True Review-Url: https://codereview.webrtc.org/2626163004 Cr-Commit-Position: refs/heads/master@{#16109}
2017-01-17 02:37:34 -08:00
]
}
Removing clang:find_bad_constructs from logging (part 1). Bug: webrtc:9251, webrtc:163 Change-Id: I42ce2edd4d5974e89d7d29f242d99d1c721b9bc0 Reviewed-on: https://webrtc-review.googlesource.com/88763 Reviewed-by: Stefan Holmer <stefan@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24017}
2018-07-16 15:38:06 +02:00
Switch rtc_event_log2rtp_dump to ABSL_FLAG. Bug: webrtc:10616 Change-Id: Ic917f04565709a90440450f86cffebb03b511aae Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144633 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28501}
2019-07-08 12:31:59 +02:00
rtc_executable("rtc_event_log_rtp_dump") {
Added gn target for rtc_event_log2rtp_dump. BUG=webrtc:6191 Review-Url: https://codereview.webrtc.org/2629353004 Cr-Commit-Position: refs/heads/master@{#16483}
2017-02-08 00:28:09 -08:00
testonly = true
Reformat GN files. `gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:10:10 +01:00
sources = [ "rtc_event_log/rtc_event_log2rtp_dump.cc" ]
Added gn target for rtc_event_log2rtp_dump. BUG=webrtc:6191 Review-Url: https://codereview.webrtc.org/2629353004 Cr-Commit-Position: refs/heads/master@{#16483}
2017-02-08 00:28:09 -08:00
deps = [
":rtc_event_log_parser",
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2. This is a follow-up to https://webrtc-review.googlesource.com/c/src/+/106280. This time the whole code base is covered. Some files may have not been fixed though, whenever the IWYU tool was breaking the build. Bug: webrtc:8311 Change-Id: I2c31f552a87e887d33931d46e87b6208b1e483ef Reviewed-on: https://webrtc-review.googlesource.com/c/111965 Commit-Queue: Yves Gerey <yvesg@google.com> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25830}
2018-11-28 16:47:49 +01:00
"../api:array_view",
Reland "Move api/rtp_headers.h to its own build target." This is a reland of a67050debcb5a3461a452a7928d7aaea1562747e Original change's description: > Move api/rtp_headers.h to its own build target. > > Reduces dependencies on the libjingle_peerconnection_api target from > lower-level code. > > Bug: None > Change-Id: I98576fc718c396cc0f720c3770acd2b696b9df89 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128565 > Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > Commit-Queue: Niels Moller <nisse@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#27213} Bug: None Tbr: kwiberg@webrtc.org Change-Id: If15b05957e50bb8f18a33c2ed1321e672311b626 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127895 Reviewed-by: Niels Moller <nisse@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27216}
2019-03-20 08:40:23 +01:00
"../api:rtp_headers",
Delete deprecated rtc_event_log header Bug: webrtc:10206 Change-Id: I9ed3148843c647372993729b87c0e74741ab540b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/147870 Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28791}
2019-08-07 12:24:53 +02:00
"../api/rtc_event_log",
Stop using public_deps in logging/. Bug: webrtc:8603 Change-Id: Id0df997620a27e47067e4b21e4e8db16aec90640 No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/30940 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21228}
2017-12-12 12:46:13 +01:00
"../modules/rtp_rtcp",
Stop using public_deps in modules/rtp_rtcp. TBR=phoglund@webrtc.org Bug: webrtc:8603 Change-Id: I86830df23db3f33a1a26098e639596bd3b86485a No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/29780 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21108}
2017-12-06 07:51:33 +01:00
"../modules/rtp_rtcp:rtp_rtcp_format",
Fix circular dependencies between optional, array_view, and rtc_base. This splits things out of rtc_base and makes dependencies explicit. Bug: webrtc:6828 Change-Id: Id521896c3c43595349021c857bec216e429a0c8d Reviewed-on: https://webrtc-review.googlesource.com/32780 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21264}
2017-12-13 16:05:42 +01:00
"../rtc_base:checks",
Stop using public_deps in logging/. Bug: webrtc:8603 Change-Id: Id0df997620a27e47067e4b21e4e8db16aec90640 No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/30940 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21228}
2017-12-12 12:46:13 +01:00
"../rtc_base:protobuf_utils",
Remove remains of webrtc/base All downstream code have been updated to the new location. In PRESUBMIT.py: * Remove webrtc/rtc_base from CPP_BLACKLIST * Add webrtc/rtc_base to LEGACY_API_DIRS Fix some duplicated paths in webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn BUG=webrtc:7634 TBR=kwiberg@webrtc.org Review-Url: https://codereview.webrtc.org/2976293002 Cr-Commit-Position: refs/heads/master@{#19094}
2017-07-19 10:40:47 -07:00
"../rtc_base:rtc_base_approved",
Added gn target for rtc_event_log2rtp_dump. BUG=webrtc:6191 Review-Url: https://codereview.webrtc.org/2629353004 Cr-Commit-Position: refs/heads/master@{#16483}
2017-02-08 00:28:09 -08:00
"../test:rtp_test_utils",
Switch rtc_event_log2rtp_dump to ABSL_FLAG. Bug: webrtc:10616 Change-Id: Ic917f04565709a90440450f86cffebb03b511aae Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144633 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28501}
2019-07-08 12:31:59 +02:00
"//third_party/abseil-cpp/absl/flags:flag",
"//third_party/abseil-cpp/absl/flags:parse",
Add usage message to rtc_event_log2rtp_dump. Bug: webrtc:10616 Change-Id: I363715bedd28b9c74cefd3b4fd510f16963909f7 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146210 Reviewed-by: Björn Terelius <terelius@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28633}
2019-07-19 12:05:09 +02:00
"//third_party/abseil-cpp/absl/flags:usage",
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2. This is a follow-up to https://webrtc-review.googlesource.com/c/src/+/106280. This time the whole code base is covered. Some files may have not been fixed though, whenever the IWYU tool was breaking the build. Bug: webrtc:8311 Change-Id: I2c31f552a87e887d33931d46e87b6208b1e483ef Reviewed-on: https://webrtc-review.googlesource.com/c/111965 Commit-Queue: Yves Gerey <yvesg@google.com> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25830}
2018-11-28 16:47:49 +01:00
"//third_party/abseil-cpp/absl/memory",
Add helper class to process RtcEventLog events in order. Add helper class to process RtcEventLog events in order. Use helper class to migrate rtc_event_log2rtp_dump.cc to new parser API. Bug: webrtc:8111 Change-Id: I7cbc220dad1f50be3a985ed44de27b38e5f20476 Reviewed-on: https://webrtc-review.googlesource.com/98601 Commit-Queue: Björn Terelius <terelius@webrtc.org> Reviewed-by: Elad Alon <eladalon@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24806}
2018-09-24 17:10:27 +02:00
"//third_party/abseil-cpp/absl/types:optional",
Added gn target for rtc_event_log2rtp_dump. BUG=webrtc:6191 Review-Url: https://codereview.webrtc.org/2629353004 Cr-Commit-Position: refs/heads/master@{#16483}
2017-02-08 00:28:09 -08:00
]
New tool for printing basic packet information from an RTC event log to stdout. BUG=webrtc:7118 Review-Url: https://codereview.webrtc.org/2673403002 Cr-Commit-Position: refs/heads/master@{#16488}
2017-02-08 04:22:53 -08:00
}
}
Moved RtcEventLog files from call/ to logging/ The RtcEventLog headers need to be accessible from any place which needs logging, and the implementation needs access to data structures that are logged. After a discussion in the code review, we all agreed to move the RtcEventLog implementation into its own top level directory - which I called "logging/" in expectation that other types of logging may have similar requirements. The directory contains two main build targets - "rtc_event_log_api", which is just rtc_event_log.h, that has no external dependencies and can be used from anywhere, and "rtc_event_log_impl" which contains the rest of the implementation and has many dependencies (more in the future). The "api" target can be referenced from anywhere, while the "impl" target is only needed at the place of instantiation (currently Call, soon to be moved to PeerConnection by https://codereview.webrtc.org/2353033005/). This change allows using RtcEventLog in the p2p/ directory, so that we can log STUN pings and ICE state transitions. BUG=webrtc:6393 R=kjellander@webrtc.org, kwiberg@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org Review URL: https://codereview.webrtc.org/2380683005 . Cr-Commit-Position: refs/heads/master@{#14485}
2016-10-03 18:31:22 -07:00
}
Reland: Add mock_rtc_event_log.h. Bug: webrtc:7642 Change-Id: I3f97a8b603e34819e1563b335c1eeb51f89b11ac Reviewed-on: https://webrtc-review.googlesource.com/37081 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21480}
2018-01-03 09:08:20 +01:00
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("ice_log") {
Reland "Structured ICE logging via RtcEventLog." This is a reland of eed5aa8904d09179971d3f4e7e10c109d7c62bfc Original change's description: > Structured ICE logging via RtcEventLog. > > This change list contains the structured logging module for ICE using > the RtcEventLog infrastructure, and also extension to the log parser > and analyzer. > > Bug: None > Change-Id: I6539cf282155c2cde4d3161c53500c0746671a02 > Reviewed-on: https://webrtc-review.googlesource.com/34622 > Commit-Queue: Qingsi Wang <qingsi@google.com> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Peter Thatcher <pthatcher@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#21816} TBR=pthatcher@webrtc.org,terelius@webrtc.org,deadbeef@webrtc.org Bug: None Change-Id: I3df585bf636315ceb0273967146111346a83be86 Reviewed-on: https://webrtc-review.googlesource.com/47545 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Qingsi Wang <qingsi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21881}
2018-02-02 11:49:44 -08:00
sources = [
Log DTLS state changes to RtcEventLog Bug: webrtc:9972 Change-Id: Icb2cdda87c1c42607ed06653e053699532f25e84 Reviewed-on: https://webrtc-review.googlesource.com/c/111023 Commit-Queue: Zach Stein <zstein@webrtc.org> Reviewed-by: Qingsi Wang <qingsi@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Reviewed-by: Steve Anton <steveanton@webrtc.org> Reviewed-by: Elad Alon <eladalon@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25832}
2018-11-27 15:53:01 -08:00
"rtc_event_log/events/rtc_event_dtls_transport_state.cc",
"rtc_event_log/events/rtc_event_dtls_transport_state.h",
Log DTLS writable changes to RtcEventLog Bug: webrtc:9972 Change-Id: I8d29dcbc200bd0aad7f4c2600459c4d344c61bbb Reviewed-on: https://webrtc-review.googlesource.com/c/111453 Reviewed-by: Qingsi Wang <qingsi@webrtc.org> Reviewed-by: Elad Alon <eladalon@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Commit-Queue: Zach Stein <zstein@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25866}
2018-11-29 14:12:17 -08:00
"rtc_event_log/events/rtc_event_dtls_writable_state.cc",
"rtc_event_log/events/rtc_event_dtls_writable_state.h",
Reland "Structured ICE logging via RtcEventLog." This is a reland of eed5aa8904d09179971d3f4e7e10c109d7c62bfc Original change's description: > Structured ICE logging via RtcEventLog. > > This change list contains the structured logging module for ICE using > the RtcEventLog infrastructure, and also extension to the log parser > and analyzer. > > Bug: None > Change-Id: I6539cf282155c2cde4d3161c53500c0746671a02 > Reviewed-on: https://webrtc-review.googlesource.com/34622 > Commit-Queue: Qingsi Wang <qingsi@google.com> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Peter Thatcher <pthatcher@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#21816} TBR=pthatcher@webrtc.org,terelius@webrtc.org,deadbeef@webrtc.org Bug: None Change-Id: I3df585bf636315ceb0273967146111346a83be86 Reviewed-on: https://webrtc-review.googlesource.com/47545 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Qingsi Wang <qingsi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21881}
2018-02-02 11:49:44 -08:00
"rtc_event_log/events/rtc_event_ice_candidate_pair.cc",
"rtc_event_log/events/rtc_event_ice_candidate_pair.h",
"rtc_event_log/events/rtc_event_ice_candidate_pair_config.cc",
"rtc_event_log/events/rtc_event_ice_candidate_pair_config.h",
(4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries Mechanically generated by running this command: tools_webrtc/do-renames.sh update all-renames.txt && git cl format Then manually updating: tools_webrtc/sanitizers/tsan_suppressions_webrtc.cc Bug: webrtc:10159 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I54824cd91dada8fc3ee3d098f971bc319d477833 Reviewed-on: https://webrtc-review.googlesource.com/c/115653 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26226}
2019-01-11 09:11:00 -08:00
"rtc_event_log/ice_logger.cc",
"rtc_event_log/ice_logger.h",
Reland "Structured ICE logging via RtcEventLog." This is a reland of eed5aa8904d09179971d3f4e7e10c109d7c62bfc Original change's description: > Structured ICE logging via RtcEventLog. > > This change list contains the structured logging module for ICE using > the RtcEventLog infrastructure, and also extension to the log parser > and analyzer. > > Bug: None > Change-Id: I6539cf282155c2cde4d3161c53500c0746671a02 > Reviewed-on: https://webrtc-review.googlesource.com/34622 > Commit-Queue: Qingsi Wang <qingsi@google.com> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Peter Thatcher <pthatcher@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#21816} TBR=pthatcher@webrtc.org,terelius@webrtc.org,deadbeef@webrtc.org Bug: None Change-Id: I3df585bf636315ceb0273967146111346a83be86 Reviewed-on: https://webrtc-review.googlesource.com/47545 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Qingsi Wang <qingsi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21881}
2018-02-02 11:49:44 -08:00
]
deps = [
"../api:libjingle_logging_api",
Stop using rtc_event.h forward header Bug: webrtc:10206 Change-Id: I16905ec745673178195d6715fda6175c31500163 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151601 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29149}
2019-09-05 11:29:59 +02:00
"../api:libjingle_peerconnection_api", # For api/dtls_transport_interface.h
Delete deprecated rtc_event_log header Bug: webrtc:10206 Change-Id: I9ed3148843c647372993729b87c0e74741ab540b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/147870 Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28791}
2019-08-07 12:24:53 +02:00
"../api/rtc_event_log",
Reland "Structured ICE logging via RtcEventLog." This is a reland of eed5aa8904d09179971d3f4e7e10c109d7c62bfc Original change's description: > Structured ICE logging via RtcEventLog. > > This change list contains the structured logging module for ICE using > the RtcEventLog infrastructure, and also extension to the log parser > and analyzer. > > Bug: None > Change-Id: I6539cf282155c2cde4d3161c53500c0746671a02 > Reviewed-on: https://webrtc-review.googlesource.com/34622 > Commit-Queue: Qingsi Wang <qingsi@google.com> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Peter Thatcher <pthatcher@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#21816} TBR=pthatcher@webrtc.org,terelius@webrtc.org,deadbeef@webrtc.org Bug: None Change-Id: I3df585bf636315ceb0273967146111346a83be86 Reviewed-on: https://webrtc-review.googlesource.com/47545 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Qingsi Wang <qingsi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21881}
2018-02-02 11:49:44 -08:00
"../rtc_base:rtc_base_approved",
]
Use absl_deps in order to preapre to the Abseil component build release. Bug: webrtc:1046390 Change-Id: Ia35545599de23b1a2c2d8be2d53469af7ac16f1d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176502 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31463}
2020-06-05 14:30:41 +02:00
absl_deps = [ "//third_party/abseil-cpp/absl/memory" ]
Reland "Structured ICE logging via RtcEventLog." This is a reland of eed5aa8904d09179971d3f4e7e10c109d7c62bfc Original change's description: > Structured ICE logging via RtcEventLog. > > This change list contains the structured logging module for ICE using > the RtcEventLog infrastructure, and also extension to the log parser > and analyzer. > > Bug: None > Change-Id: I6539cf282155c2cde4d3161c53500c0746671a02 > Reviewed-on: https://webrtc-review.googlesource.com/34622 > Commit-Queue: Qingsi Wang <qingsi@google.com> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Reviewed-by: Peter Thatcher <pthatcher@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#21816} TBR=pthatcher@webrtc.org,terelius@webrtc.org,deadbeef@webrtc.org Bug: None Change-Id: I3df585bf636315ceb0273967146111346a83be86 Reviewed-on: https://webrtc-review.googlesource.com/47545 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Qingsi Wang <qingsi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21881}
2018-02-02 11:49:44 -08:00
}
Reland: Add mock_rtc_event_log.h. Bug: webrtc:7642 Change-Id: I3f97a8b603e34819e1563b335c1eeb51f89b11ac Reviewed-on: https://webrtc-review.googlesource.com/37081 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21480}
2018-01-03 09:08:20 +01:00
if (rtc_include_tests) {
Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#29525}
2019-10-17 21:32:04 +02:00
rtc_library("mocks") {
Reland: Add mock_rtc_event_log.h. Bug: webrtc:7642 Change-Id: I3f97a8b603e34819e1563b335c1eeb51f89b11ac Reviewed-on: https://webrtc-review.googlesource.com/37081 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21480}
2018-01-03 09:08:20 +01:00
testonly = true
sources = [
Reland "Enable and fix chromium clang warnings in rtp_rtcp test targets" This reverts commit 01aa210fad68f1006528d32d388b307c22990734. Reason for revert: downstream project adjusted Original change's description: > Revert "Enable and fix chromium clang warnings in rtp_rtcp test targets" > > This reverts commit 9486b117daac09c9f7ac8450ccda835938cf3150. > > Reason for revert: Breaks downstream project > > Original change's description: > > Enable and fix chromium clang warnings in rtp_rtcp test targets > > > > Bug: webrtc:163 > > Change-Id: I4ed3e63296d8bf06536a83196d597c7a906ba11c > > Reviewed-on: https://webrtc-review.googlesource.com/60802 > > Reviewed-by: Björn Terelius <terelius@webrtc.org> > > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > > Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#22357} > > TBR=danilchap@webrtc.org,phoglund@webrtc.org,terelius@webrtc.org > > Change-Id: I2c3777ea9f26813bdb395e7fd68f6b49443586ea > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:163 > Reviewed-on: https://webrtc-review.googlesource.com/61060 > Reviewed-by: Oleh Prypin <oprypin@webrtc.org> > Commit-Queue: Oleh Prypin <oprypin@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#22365} TBR=danilchap@webrtc.org,phoglund@webrtc.org,oprypin@webrtc.org,terelius@webrtc.org Change-Id: I0b4cb6d05b37caeb52cca9abf95417ad3ad6f76b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:163 Reviewed-on: https://webrtc-review.googlesource.com/61080 Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22368}
2018-03-09 15:37:03 +00:00
"rtc_event_log/mock/mock_rtc_event_log.cc",
Reland: Add mock_rtc_event_log.h. Bug: webrtc:7642 Change-Id: I3f97a8b603e34819e1563b335c1eeb51f89b11ac Reviewed-on: https://webrtc-review.googlesource.com/37081 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21480}
2018-01-03 09:08:20 +01:00
"rtc_event_log/mock/mock_rtc_event_log.h",
]
deps = [
Delete deprecated rtc_event_log header Bug: webrtc:10206 Change-Id: I9ed3148843c647372993729b87c0e74741ab540b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/147870 Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28791}
2019-08-07 12:24:53 +02:00
"../api/rtc_event_log",
Fix paths that were trying to go above the root by using too many "../.." This doesn't cause problems because seems like GN just ignores these attempts and confines everything to the root. Bug: None Change-Id: Ief50b6e10f3950b319d0bde547f91dcc7f237cda Reviewed-on: https://webrtc-review.googlesource.com/90041 Commit-Queue: Oleh Prypin <oprypin@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24063}
2018-07-23 10:04:12 +02:00
"../test:test_support",
Reland: Add mock_rtc_event_log.h. Bug: webrtc:7642 Change-Id: I3f97a8b603e34819e1563b335c1eeb51f89b11ac Reviewed-on: https://webrtc-review.googlesource.com/37081 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21480}
2018-01-03 09:08:20 +01:00
]
}
}
Reference in New Issue Copy Permalink