41548 Commits

Author SHA1 Message Date
Per K
fe47d7d567 Add perkj@ as owner in test/peer_scenario
Bug: None
Change-Id: If341854bd7c936fee6914668dd8120027df6991f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350740
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42316}
2024-05-16 08:12:08 +00:00
webrtc-version-updater
1ce3e049a0 Update WebRTC code version (2024-05-16T04:03:03).
Bug: None
Change-Id: Ief379ad2d2717d13b893373667859dec98ed38a6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350720
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42315}
2024-05-16 05:53:34 +00:00
Danil Chapovalov
b84097e139 Delete deprecated ReceiveSideCongestionController constructor
This makes Environment and thus field trials a required parameter, thus
RemoteBitrateEstimators member no longer need to fallback to the global field trial string.

Bug: webrtc:42220378
Change-Id: Ieb6ff442d5fde5fa9715573c758a7e078f0ceea4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349922
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42314}
2024-05-15 14:32:01 +00:00
Jeremy Leconte
5e194e9d24 Remove unused linux_memcheck bot.
Change-Id: I2427c05c8376f1d21703e05bb93c77982a5beb25
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350605
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#42313}
2024-05-15 14:21:05 +00:00
Erik Språng
a8da642371 Reconfigure encoders or source change
This is done in case the new source has a different clock source which
might be out of sync with the previous one, leading to timestamp
conflicts.

Bug: b/340198307
Change-Id: Id1a82823ca85e03d99dad31b7ce9f19f09447755
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350560
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42312}
2024-05-15 13:12:08 +00:00
philipel
7db2a85697 Add Performance::encode_on_calling_thread flag.
Bug: b/336978562
Change-Id: Id6edf45e80efb99ace46299ef36082f280cb8921
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350622
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42311}
2024-05-15 12:57:54 +00:00
Jeremy Leconte
f9da667dca [DVQA] Sum the encoded_image_size for simulcast scenario.
This aligns actual_encode_bitrate with target_encode_bitrate

Change-Id: I8c460a5883e5eacbee8e67b5b6625f65792efb77
Bug: b/340790240
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350620
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#42310}
2024-05-15 11:23:45 +00:00
Mirko Bonadei
ff2dd50fd8 Revert "Replace usage of link_capacity_kbps with DataRate link_capacity"
This reverts commit 6186c0226e41dabbfc5cc8527e6b350b62f39f02.

Reason for revert: Breaks downstream project.

Original change's description:
> Replace usage of link_capacity_kbps with DataRate link_capacity
>
> Replace usage of BuiltInNetworkBehaviorConfig.link_capacity_kbps in tests with  DataRate link_capacity.
>
> Bug: webrtc:14525
> Change-Id: Id1c1b8d20eb2be5e9d1461704bb7c37c61c491f0
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350300
> Reviewed-by: Erik Språng <sprang@webrtc.org>
> Reviewed-by: Harald Alvestrand <hta@webrtc.org>
> Commit-Queue: Per Kjellander <perkj@webrtc.org>
> Reviewed-by: Björn Terelius <terelius@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#42306}

Bug: webrtc:14525
Change-Id: I09ede3e89d065061cb4133bff96dbf242ff70832
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350621
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42309}
2024-05-15 11:09:33 +00:00
Mirko Bonadei
7b3b2da46e Add visibility for new rtc_base targets.
This is a follow-up for
https://webrtc-review.googlesource.com/c/src/+/350260.

Bug: webrtc:339300437
Change-Id: Ia736dd59cb6fcc74df0e500620bf2a5b47a7a73b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350601
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42308}
2024-05-15 09:27:52 +00:00
chromium-webrtc-autoroll
84e4363ddf Roll chromium_revision 4a41aa5275..b20474a192 (1301045:1301151)
Change log: 4a41aa5275..b20474a192
Full diff: 4a41aa5275..b20474a192

Changed dependencies
* src/base: 43273383ee..cde519af17
* src/build: 26998e9872..4eca45df04
* src/ios: 7515cb2484..ed7037a134
* src/testing: d1626503da..506cd72a25
* src/third_party: 984509bc3d..4789c15118
* src/third_party/depot_tools: 6421eb2eda..2b6524b208
* src/tools: d09caa9089..98dcc03c82
DEPS diff: 4a41aa5275..b20474a192/DEPS

No update to Clang.

BUG=None

Change-Id: Ie3d75444a1a22847e475d0bcf6bf34e037f020e3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350584
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42307}
2024-05-15 08:52:45 +00:00
Per K
6186c0226e Replace usage of link_capacity_kbps with DataRate link_capacity
Replace usage of BuiltInNetworkBehaviorConfig.link_capacity_kbps in tests with  DataRate link_capacity.

Bug: webrtc:14525
Change-Id: Id1c1b8d20eb2be5e9d1461704bb7c37c61c491f0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350300
Reviewed-by: Erik Språng <sprang@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42306}
2024-05-15 08:44:20 +00:00
webrtc-version-updater
26a39f273c Update WebRTC code version (2024-05-15T04:05:57).
Bug: None
Change-Id: I80f53bde21844cc50bb93f0a5863f4fcf538ce36
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350582
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42305}
2024-05-15 06:41:19 +00:00
Philipp Hancke
57dbb1e53e Reland "Split digest methods from ssl target into digest target"
This is a reland of commit 47bfe39ecfe45b2f94c616ace97949003d9e87b4

Original change's description:
> Split digest methods from ssl target into digest target
>
> in an attempt to break up the monolithic ssl target.
>
> BUG=None
>
> Change-Id: I38f5b3e2828742d5d918460db1af0a5797d6a5c2
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349764
> Reviewed-by: Harald Alvestrand <hta@webrtc.org>
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Commit-Queue: Philipp Hancke <phancke@meta.com>
> Cr-Commit-Position: refs/heads/main@{#42249}

Bug: webrtc:339300437
Change-Id: I31bb79bbc6cc55a2634176f95ec67de195974e1b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350260
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@meta.com>
Cr-Commit-Position: refs/heads/main@{#42304}
2024-05-15 06:40:16 +00:00
chromium-webrtc-autoroll
f80bea13b5 Roll chromium_revision 143185866a..4a41aa5275 (1300921:1301045)
Change log: 143185866a..4a41aa5275
Full diff: 143185866a..4a41aa5275

Changed dependencies
* src/base: e7a0d09134..43273383ee
* src/build: c8cf096a50..26998e9872
* src/ios: 70378ce063..7515cb2484
* src/testing: 292daad51d..d1626503da
* src/third_party: 9e90fd64a6..984509bc3d
* src/third_party/android_build_tools/manifest_merger: Uecrn-wUXzvUON7QkiZPlANRvFr6yFM05_M_S7q8IFoC..tL_JG7yL7RqVT4RB2rD5aN3xhRGKPh-V87_YnzX_eSwC
* src/third_party/depot_tools: 6a7597cf9a..6421eb2eda
* src/tools: 1a1a421d01..d09caa9089
DEPS diff: 143185866a..4a41aa5275/DEPS

No update to Clang.

BUG=None

Change-Id: I49f8435e9bfcf940e23a1b8763405c72b9170854
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350581
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42303}
2024-05-15 02:36:40 +00:00
chromium-webrtc-autoroll
7eff7e6d83 Roll chromium_revision 7b0dbaf21a..143185866a (1300655:1300921)
Change log: 7b0dbaf21a..143185866a
Full diff: 7b0dbaf21a..143185866a

Changed dependencies
* reclient_version: re_client_version:0.141.1.29a9d3c-gomaip..re_client_version:0.143.0.518e369-gomaip
* src/base: 2c77edb79f..e7a0d09134
* src/build: e6bad9d579..c8cf096a50
* src/buildtools/reclient: re_client_version:0.141.1.29a9d3c-gomaip..re_client_version:0.143.0.518e369-gomaip
* src/ios: c7e4c69b99..70378ce063
* src/third_party: 0bc446e638..9e90fd64a6
* src/third_party/androidx: f1Bj3ULRcpJf4oqa2lCfAQvtCeeyVsDq876w4esaoT8C..boqwrBEk7n2uyvEyOQybF6HuJ7oPTDgV6joQofLkDfgC
* src/third_party/depot_tools: 8479869311..6a7597cf9a
* src/third_party/harfbuzz-ng/src: bba0c0e27c..1da053e87f
* src/third_party/perfetto: 15decdc02f..2a0df8bad1
* src/third_party/re2/src: f31c2c6f38..b7e96b34c0
* src/tools: 0a0483184d..1a1a421d01
DEPS diff: 7b0dbaf21a..143185866a/DEPS

No update to Clang.

BUG=None

Change-Id: Ibf58f1a6fc40d8a196ab732c03897da9777bf7cc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350580
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42302}
2024-05-14 22:49:51 +00:00
chromium-webrtc-autoroll
f674a9edb0 Roll chromium_revision 279e7226e3..7b0dbaf21a (1300530:1300655)
Change log: 279e7226e3..7b0dbaf21a
Full diff: 279e7226e3..7b0dbaf21a

Changed dependencies
* src/buildtools: 4e0e9c73a0..6206ead2d5
* src/ios: 003762fbc1..c7e4c69b99
* src/testing: 4f5466937c..292daad51d
* src/third_party: 09e6bbdf6d..0bc446e638
* src/third_party/harfbuzz-ng/src: 155015f4be..bba0c0e27c
* src/third_party/libc++/src: e3b94d0e5b..852bc6746f
* src/third_party/perfetto: 6aaa8a1fb1..15decdc02f
* src/tools: 0a53973274..0a0483184d
DEPS diff: 279e7226e3..7b0dbaf21a/DEPS

No update to Clang.

BUG=None

Change-Id: Ic80e9695e45097d7aa92549999b56e65f524b332
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350503
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42301}
2024-05-14 17:12:29 +00:00
Danil Chapovalov
4ea65f4cd1 Use Environment to create GoogCcNetworkController
Environment guarantees field trials are provided, thus GoogCcNetworkController doesn't need to fallback to the global field trials.

Bug: webrtc:42220378
Change-Id: Iff8e00504b43b074dc41b5ac9908fd0e2be18959
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350540
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42300}
2024-05-14 15:37:28 +00:00
Prashanth Swaminathan
3896112de7 Remove stale test from audio_processing
The 'apmtest' folder contains code that is not part of any build graph
and has not been updated since 2017 since the code migrated locations.
At a glance, it does not seem to be testing anything specific to the
audio-processing module either.

This implicitly resolves the usage of the deprecated ALooper_pollAll API
by removing the code entirely.

Bug: webrtc:42225691
Change-Id: I79e14140ee40c567e1d07431f874d5f48e39d384
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350270
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42299}
2024-05-14 13:26:23 +00:00
Danil Chapovalov
179f96de7e Provide Environment to construct VideoBitrateAllocator
To allow various VideoBitrateAllocators to use propagated rather than global field trials

This relands the
https://webrtc-review.googlesource.com/c/src/+/349920
where patchset#1 is identical to the original change,
patchset#2 undoes (postpones) the expectation downstream propagates the Environment too.

Bug: webrtc:42220378
Change-Id: I4a9a32bb0926a875d37f3ba19dd5309e97546553
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350364
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42298}
2024-05-14 11:36:42 +00:00
chromium-webrtc-autoroll
1f90b92eda Roll chromium_revision 488ccc5d17..279e7226e3 (1300426:1300530)
Change log: 488ccc5d17..279e7226e3
Full diff: 488ccc5d17..279e7226e3

Changed dependencies
* src/base: 10f6cf877c..2c77edb79f
* src/ios: 5b4fde158a..003762fbc1
* src/testing: 06ffccb6d2..4f5466937c
* src/third_party: adc34c3dea..09e6bbdf6d
* src/third_party/androidx: wca_lJQ6FRpEyA5uKD90LCn02gX5VM9Z4mniCykiW-AC..f1Bj3ULRcpJf4oqa2lCfAQvtCeeyVsDq876w4esaoT8C
* src/third_party/depot_tools: af58dae320..8479869311
* src/tools: 59dbdb16b8..0a53973274
DEPS diff: 488ccc5d17..279e7226e3/DEPS

No update to Clang.

BUG=None

Change-Id: I65d2fca61b620abbfa88a6fb5ac64128641bef29
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350500
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42297}
2024-05-14 11:06:12 +00:00
Lionel Koenig
8d070464e8 Pass the absolute capture timestamp to rtcp
This pass the absolute capture timestamp at the beginning of the frame
to the rtcp module.

Bug: webrtc:42226041
Change-Id: Iae85a56bfd9d33f7eb9eac3c68961235fe16dc6b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350202
Commit-Queue: Lionel Koenig <lionelk@webrtc.org>
Reviewed-by: Jakob Ivarsson‎ <jakobi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42296}
2024-05-14 08:35:44 +00:00
webrtc-version-updater
95fc15b5a1 Update WebRTC code version (2024-05-14T04:05:39).
Bug: None
Change-Id: Ic2126fc890939b962cf8707b6bcb6a47afc0a68d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350461
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42295}
2024-05-14 05:38:48 +00:00
chromium-webrtc-autoroll
960df4b9fc Roll chromium_revision 2e4dacf46d..488ccc5d17 (1300318:1300426)
Change log: 2e4dacf46d..488ccc5d17
Full diff: 2e4dacf46d..488ccc5d17

Changed dependencies
* src/ios: 536dde4397..5b4fde158a
* src/testing: 9965a71a86..06ffccb6d2
* src/third_party: 3e94dab61d..adc34c3dea
* src/third_party/androidx: UiIzVBfVIy9mCbzMX3fEPiFC3Vez6AiL1NueeljGtEUC..wca_lJQ6FRpEyA5uKD90LCn02gX5VM9Z4mniCykiW-AC
* src/third_party/depot_tools: 28ece72a5d..af58dae320
* src/third_party/freetype/src: a46424228f..68399b4244
* src/tools: bff5467904..59dbdb16b8
DEPS diff: 2e4dacf46d..488ccc5d17/DEPS

No update to Clang.

BUG=None

Change-Id: I19c3126d8bb432919dd3e1aee1cc212f64dbfa2f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350460
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42294}
2024-05-14 04:32:22 +00:00
chromium-webrtc-autoroll
3afee0b7b5 Roll chromium_revision dc3597a14f..2e4dacf46d (1299980:1300318)
Change log: dc3597a14f..2e4dacf46d
Full diff: dc3597a14f..2e4dacf46d

Changed dependencies
* src/base: 2f20fae2cd..10f6cf877c
* src/build: ef48ed5d95..e6bad9d579
* src/ios: a5a5c2649f..536dde4397
* src/testing: 066811c908..9965a71a86
* src/third_party: 5e3f3bd93a..3e94dab61d
* src/third_party/androidx: WYLdeHVNODwUgqqiHA4ty21Gk_nBkv16YJzGeEtW438C..UiIzVBfVIy9mCbzMX3fEPiFC3Vez6AiL1NueeljGtEUC
* src/third_party/depot_tools: e1385296c4..28ece72a5d
* src/third_party/googletest/src: fa6de7f438..33af80a883
* src/third_party/harfbuzz-ng/src: bba0c0e27c..155015f4be
* src/third_party/r8: DcVi2RjfFH55zitouMx3JJtwdiShMM2rWsdAoGYUIRsC..COW7cFK6pwOVeM1EEvoEXOYDwDbWVkPQDC63mlyb3m4C
* src/third_party/re2/src: 2b354c6ad0..f31c2c6f38
* src/tools: 7d98d76cec..bff5467904
DEPS diff: dc3597a14f..2e4dacf46d/DEPS

No update to Clang.

BUG=None

Change-Id: Ifc108c334f0b6503b94507ce5fd2fd7e998f0c05
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350438
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42293}
2024-05-13 23:42:28 +00:00
Jan Grulich
cfbd6b0884 Video capture PipeWire: drop corrupted PipeWire buffers
Use SPA_CHUNK_FLAG_CORRUPTED and SPA_META_HEADER_FLAG_CORRUPTED flags to
determine corrupted buffers or corrupted buffer data. We used to only
rely on compositors setting chunk->size, but this doesn't make sense for
dmabufs where they have to make up arbitrary values. It also looks this
is not reliable and can cause glitches as we end up processing corrupted buffers.

Bug: webrtc:338232699
Change-Id: Ida0c6a5e7a37e19598c6d5884726200f81b94962
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349881
Commit-Queue: Mark Foltz <mfoltz@chromium.org>
Reviewed-by: Mark Foltz <mfoltz@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/main@{#42292}
2024-05-13 18:09:07 +00:00
Philipp Hancke
2cb3c54273 tls: replace call to deprecated SSL_library_init with OPENSSL_init_ssl
SSL_library_init
https://www.openssl.org/docs/manmaster/man3/SSL_library_init.html
has been deprecated by OPENSSL_init_ssl
https://www.openssl.org/docs/man1.1.1/man3/OPENSSL_init_ssl.html
which no longer needs to be called as of OpenSSL 1.1.0 (2017).
It is still required for boringssl for the time being:
  https://bugs.chromium.org/p/boringssl/issues/detail?id=35
  https://bugs.chromium.org/p/boringssl/issues/detail?id=673
so a TODO is added.

BUG=webrtc:339300437

Change-Id: If4c7a9f4935521b33fc19b5fff72d293c0e17b81
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350145
Reviewed-by: David Benjamin <davidben@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@meta.com>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42291}
2024-05-13 17:04:10 +00:00
Jeremy Leconte
16fb7903e5 Revert "Provide Environment to construct VideoBitrateAllocator"
This reverts commit 4bf4e1753ce1567aab9f83f3a324e8bda2833459.

Reason for revert: break upstream 

Original change's description:
> Provide Environment to construct VideoBitrateAllocator
>
> To allow various VideoBitrateAllocators to use propagated rather than global field trials
>
> Bug: webrtc:42220378
> Change-Id: I52816628169a54b18a4405d84fee69b101f92f72
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349920
> Reviewed-by: Erik Språng <sprang@webrtc.org>
> Reviewed-by: Philip Eliasson <philipel@webrtc.org>
> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#42288}

Bug: webrtc:42220378
Change-Id: I7d47eb635c2d312d97a870c2a8eca0b23d2f86a0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350307
Owners-Override: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42290}
2024-05-13 13:32:28 +00:00
chromium-webrtc-autoroll
dcdb140576 Roll chromium_revision 19260a1dc2..dc3597a14f (1299861:1299980)
Change log: 19260a1dc2..dc3597a14f
Full diff: 19260a1dc2..dc3597a14f

Changed dependencies
* src/base: 61ee4ef40c..2f20fae2cd
* src/build: 01e3c73f58..ef48ed5d95
* src/buildtools/linux64: git_revision:b0c2742896b6b9f869dc0eb35ae4785cbf2a4512..git_revision:df98b86690c83b81aedc909ded18857296406159
* src/buildtools/mac: git_revision:b0c2742896b6b9f869dc0eb35ae4785cbf2a4512..git_revision:df98b86690c83b81aedc909ded18857296406159
* src/buildtools/win: git_revision:b0c2742896b6b9f869dc0eb35ae4785cbf2a4512..git_revision:df98b86690c83b81aedc909ded18857296406159
* src/ios: 63cfd07fb3..a5a5c2649f
* src/testing: cb48097393..066811c908
* src/third_party: d1f7abb197..5e3f3bd93a
* src/third_party/depot_tools: a9b9284faf..e1385296c4
* src/third_party/harfbuzz-ng/src: 155015f4be..bba0c0e27c
* src/tools: aa688e98b1..7d98d76cec
DEPS diff: 19260a1dc2..dc3597a14f/DEPS

No update to Clang.

BUG=None

Change-Id: I79253ea73c299761f8696beae755190b81a22583
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350434
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42289}
2024-05-13 12:39:12 +00:00
Danil Chapovalov
4bf4e1753c Provide Environment to construct VideoBitrateAllocator
To allow various VideoBitrateAllocators to use propagated rather than global field trials

Bug: webrtc:42220378
Change-Id: I52816628169a54b18a4405d84fee69b101f92f72
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349920
Reviewed-by: Erik Språng <sprang@webrtc.org>
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42288}
2024-05-13 12:12:01 +00:00
Björn Terelius
eaa4f3ae3c Fix nits in simulated network.
(Spelling, missing includes, unused declaration)

Bug: None
Change-Id: Ia7b714de1532e7657b5d07c8a98513d2a4430cec
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350041
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42287}
2024-05-13 12:00:23 +00:00
Danil Chapovalov
67ba914249 Propagate FieldTrialsView through FEC protection method helpers
And thus in those helpers query RateControlSettings field trials via propagated FieldTrialView instead of the via global field trial string

Bug: webrtc:42220378
Change-Id: I84f4bf42037d864519c4d2031d25cf909fd5010f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350305
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42286}
2024-05-13 11:44:26 +00:00
philipel
a9d7c19011 Make EncodeResultCallback rvalue ref-qualified.
Bug: b/336978562
Change-Id: Icc9be7a5ad095304bf68e19ffedca77d8bc1810c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349266
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42285}
2024-05-13 10:53:48 +00:00
philipel
cf4764e062 Move EncodeResultCallback to FrameEncodeSettings.
Bug: b/336978562
Change-Id: I25cb6662a6b66fba9d22d974e1b6da48e137d0ea
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349225
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42284}
2024-05-13 10:16:32 +00:00
Jakob Ivarsson
28a4ec36a0 Fix use of uninitialized value in NetEq test.
Bug: chromium:339308502
Change-Id: Iee2a6ca190fdd2dee498afa6e36fa0eb1f7dd9b9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350304
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org>
Commit-Queue: Jakob Ivarsson‎ <jakobi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42283}
2024-05-13 09:32:31 +00:00
Christoffer Dewerin
36ecffa129 Revert "Temporary disable sharding on Fuchsia bots."
This reverts commit 5dbc4a45bc3f8b6eee99426fb7ebfb76c861e8c2.

Reason for revert: Sharding should now work on fuchsia + no new generated starlark files have been uploaded since.

Original change's description:
> Temporary disable sharding on Fuchsia bots.
>
> Change-Id: I248ef19317de9a93751641e8bf0cab80a42a35f7
> Bug: b/338087169
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349840
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#42230}

Bug: b/338087169
Change-Id: I25f29a64a4a2ca40afb0ac9fbbc2a821c3ca4551
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350182
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#42282}
2024-05-13 08:53:13 +00:00
Lionel Koenig
a656b9d781 Use absolute capture timestamp from the beginning of payload
This ensure the absolute capture timestamp from the first audio sample
encoded in the payload is used for the corresponding rtp header.

Bug: webrtc:42226041
Change-Id: Ib8f2e3a5df5c82c5806171bd5b36a26d92fbea72
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349265
Commit-Queue: Lionel Koenig <lionelk@webrtc.org>
Reviewed-by: Jakob Ivarsson‎ <jakobi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42281}
2024-05-13 08:10:56 +00:00
Sergey Silkin
29d4062ff6 Make SpatialLayer to be an alias of SimulcastStream
Bug: b/337757868, b/42234533
Change-Id: I3a5088c2ef64ebc48b37aa51b3ebb7cd395e537b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349960
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42280}
2024-05-13 08:05:19 +00:00
Jeremy Leconte
042973f624 Regenerate infra/specs json files.
* ios_runtime_cache_15_5 has been removed from Chromium config, adding it back in mixins_webrtc.pyl.
* The order of the arguments in the json file has been changed.
* Seems using 'remove_mixins' is now required to get the same behavior as before.

Change-Id: Ia252aaa6458f8c9caed5ead3b641bb85cd1917e8
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350362
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Christoffer Dewerin <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42279}
2024-05-13 07:22:45 +00:00
webrtc-version-updater
ded1b97aeb Update WebRTC code version (2024-05-13T04:02:33).
Bug: None
Change-Id: I678c11728d58d1fca8705639b83ce95be275c061
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350433
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42278}
2024-05-13 05:08:27 +00:00
chromium-webrtc-autoroll
139bfe8958 Roll chromium_revision 36998814bd..19260a1dc2 (1299750:1299861)
Change log: 36998814bd..19260a1dc2
Full diff: 36998814bd..19260a1dc2

Changed dependencies
* src/ios: 14610e3547..63cfd07fb3
* src/testing: 94887c975e..cb48097393
* src/third_party: 220c66207a..d1f7abb197
* src/tools: 5872252f91..aa688e98b1
DEPS diff: 36998814bd..19260a1dc2/DEPS

No update to Clang.

BUG=None

Change-Id: I087a3e2a3c0eb0591906184f878e7bd6458b4ea2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350432
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42277}
2024-05-13 02:48:14 +00:00
webrtc-version-updater
76c02aff4c Update WebRTC code version (2024-05-12T04:02:36).
Bug: None
Change-Id: I90089d5d37f1f8981fd265c8fb883fb1ec9e43e5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350426
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42276}
2024-05-12 05:09:58 +00:00
chromium-webrtc-autoroll
ba89aa613c Roll chromium_revision 6893822af1..36998814bd (1299647:1299750)
Change log: 6893822af1..36998814bd
Full diff: 6893822af1..36998814bd

Changed dependencies
* src/base: eca74b9a11..61ee4ef40c
* src/ios: 3df98e1107..14610e3547
* src/testing: efc3bab65d..94887c975e
* src/third_party: 6bf0c6a91e..220c66207a
* src/third_party/androidx: j5SPXMRBFQj3DnOZgOt50K6mxX9Cih4dqeDDsEUH1xYC..WYLdeHVNODwUgqqiHA4ty21Gk_nBkv16YJzGeEtW438C
* src/third_party/flatbuffers/src: bcb9ef1876..c696275eaf
* src/tools: 1e12d458b7..5872252f91
DEPS diff: 6893822af1..36998814bd/DEPS

No update to Clang.

BUG=None

Change-Id: I826bca256079fca6fde6866ed76c0dab9d89b7e0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350422
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42275}
2024-05-11 18:41:26 +00:00
Danil Chapovalov
b0fe794d7d Delete expired field trial WebRTC-SignalNetworkPreferenceChange
Bug: webrtc:42221944
Change-Id: I786d73f5ede27d4ab40a9b3b2fef49da45bd3444
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350302
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42274}
2024-05-11 09:50:40 +00:00
webrtc-version-updater
14426c0ff9 Update WebRTC code version (2024-05-11T04:03:38).
Bug: None
Change-Id: I00da0eeec69f005754f01413a6e30fe9fda7f334
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350382
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42273}
2024-05-11 05:30:05 +00:00
chromium-webrtc-autoroll
43dc4e57dd Roll chromium_revision b42414ce8c..6893822af1 (1299281:1299647)
Change log: b42414ce8c..6893822af1
Full diff: b42414ce8c..6893822af1

Changed dependencies
* src/base: a23b0a1282..eca74b9a11
* src/ios: 755be2aee3..3df98e1107
* src/testing: 5a26b48913..efc3bab65d
* src/third_party: f997803062..6bf0c6a91e
* src/third_party/android_build_tools/manifest_merger: tz8dYQ_yBEZJRVhtzyyCjOlbOfujkHRWcYZy7419o_cC..Uecrn-wUXzvUON7QkiZPlANRvFr6yFM05_M_S7q8IFoC
* src/third_party/androidx: xPTxMXGIMD8m1NX85ML_1b1KgouD9WTgIKB2Rz3EYicC..j5SPXMRBFQj3DnOZgOt50K6mxX9Cih4dqeDDsEUH1xYC
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/3a1d1cc096..923a565b97
* src/third_party/depot_tools: 6e32e926e9..a9b9284faf
* src/third_party/libaom/source/libaom: https://aomedia.googlesource.com/aom.git/+log/5ccdc66ab6..d9ab67e87c
* src/third_party/libc++abi/src: d17298ab09..a37a3aa431
* src/tools: a184749b9d..1e12d458b7
DEPS diff: b42414ce8c..6893822af1/DEPS

No update to Clang.

BUG=None

Change-Id: I9c70848f7bda3c592c1603ae34945960dbd0d29b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350380
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42272}
2024-05-11 03:28:06 +00:00
chromium-webrtc-autoroll
c9e81edc9e Roll chromium_revision 1f2c94c46e..b42414ce8c (1299115:1299281)
Change log: 1f2c94c46e..b42414ce8c
Full diff: 1f2c94c46e..b42414ce8c

Changed dependencies
* src/build: b2163519a9..01e3c73f58
* src/ios: 853d3fcffd..755be2aee3
* src/testing: 46a35f0196..5a26b48913
* src/third_party: e16870de33..f997803062
* src/third_party/androidx: fG3g8L4td5DpT3iW59x4D3ReoFAGMuXSci0S7xKAZhcC..xPTxMXGIMD8m1NX85ML_1b1KgouD9WTgIKB2Rz3EYicC
* src/third_party/kotlin_stdlib: 05hzFgOi0AqRK3RxbSvGj2TWTFUNeLcwkJwVzwgLttUC..bCpFA9jdfF0zeuOKYuv9n1vqxV_lykSRR1oAYrVKmFsC
* src/third_party/kotlinc/current: tTF6GjpaBABskkNJqSoDgeXpbdlbjV1F46x9lYzBxBgC..NL2kgA9OlpYPhqM3x3fUl_nbJCGGPtPyNGN3fsrHcwYC
* src/tools: 79bd89fb62..a184749b9d
DEPS diff: 1f2c94c46e..b42414ce8c/DEPS

No update to Clang.

BUG=None

Change-Id: I45a91bc5980b62ebcbcede363070c00bbb92812d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350345
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42271}
2024-05-10 16:43:06 +00:00
Danil Chapovalov
ac426265b6 Cleanup usage of FieldTrialsView by RateControlSettings and CongestionWindowPushbackController
Replace factory that takes optional FieldTrialView with a constructor that takes non-optional reference to the same interface - all callers already guarantee it is not nullptr
Replace several local IsEnabled/IsDisabled helpers with the same helpers in FieldTrialView
In CongestionWindowPushbackController tests pass field trials bypassing global field trial string

Bug: webrtc:42220378
Change-Id: Ic49ad78919d834a5e3b9b69545d3b39088023a75
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349900
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42270}
2024-05-10 12:40:20 +00:00
Danil Chapovalov
58a9f6d490 Delete depercated variant of the Network::GetCost function
Bug: webrtc:42220378
Change-Id: Iebfc924ab55896981cbf83407a9b049e4d0dde8f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350303
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42269}
2024-05-10 11:25:19 +00:00
Danil Chapovalov
2cdf840b53 Read WebRTC-BweLossExperiment from propagated instead of global field trial
Bug: webrtc:42220378
Change-Id: I4ddb0719aabe89997ba4f2e663515c1b227938ad
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350301
Reviewed-by: Ying Wang <yinwa@google.com>
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42268}
2024-05-10 10:05:27 +00:00
Sergey Silkin
dbdf36c437 Add key_interval command line argument to codec test
Bug: webrtc:42225151, b/337757868
Change-Id: I5b085bdb334cb6cfb304424a466fc119196d14d4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350200
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42267}
2024-05-10 09:40:18 +00:00