Reason for revert: Seems to be causing flakiness in perf test: FullStackTest.ScreenshareSlidesVP8_2TL_LossyNet Original issue's description: > Reland of Issue 2434073003: Extract bitrate allocation ... > > This is a reland of https://codereview.webrtc.org/2434073003/ including > some fixes for failing test cases. > > Original description: > > Extract bitrate allocation of spatial/temporal layers out of codec impl. > > This CL makes a number of intervowen changes: > > * Add BitrateAllocation struct, that contains a codec independent view > of how the target bitrate is distributed over spatial and temporal > layers. > > * Adds the BitrateAllocator interface, which takes a bitrate and frame > rate and produces a BitrateAllocation. > > * A default (non layered) implementation is added, and > SimulcastRateAllocator is extended to fully handle VP8 allocation. > This includes capturing TemporalLayer instances created by the > encoder. > > * ViEEncoder now owns both the bitrate allocator and the temporal layer > factories for VP8. This allows allocation to happen fully outside of > the encoder implementation. > > This refactoring will make it possible for ViEEncoder to signal the > full picture of target bitrates to the RTCP module. > > BUG=webrtc:6301 > > Committed: https://crrev.com/647bf43dcb2fd16fccf276bd94dc4400728bb405 > Cr-Commit-Position: refs/heads/master@{#15023} TBR=mflodman@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6301 Review-Url: https://codereview.webrtc.org/2491393002 Cr-Commit-Position: refs/heads/master@{#15026}
96 lines
2.5 KiB
C++
96 lines
2.5 KiB
C++
/*
|
|
* Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h"
|
|
|
|
namespace webrtc {
|
|
namespace testing {
|
|
|
|
class TestVp8Impl : public TestVp8Simulcast {
|
|
public:
|
|
TestVp8Impl()
|
|
: TestVp8Simulcast(VP8Encoder::Create(), VP8Decoder::Create()) {}
|
|
|
|
protected:
|
|
virtual void SetUp() { TestVp8Simulcast::SetUp(); }
|
|
virtual void TearDown() { TestVp8Simulcast::TearDown(); }
|
|
};
|
|
|
|
TEST_F(TestVp8Impl, TestKeyFrameRequestsOnAllStreams) {
|
|
TestVp8Simulcast::TestKeyFrameRequestsOnAllStreams();
|
|
}
|
|
|
|
TEST_F(TestVp8Impl, TestPaddingAllStreams) {
|
|
TestVp8Simulcast::TestPaddingAllStreams();
|
|
}
|
|
|
|
TEST_F(TestVp8Impl, TestPaddingTwoStreams) {
|
|
TestVp8Simulcast::TestPaddingTwoStreams();
|
|
}
|
|
|
|
TEST_F(TestVp8Impl, TestPaddingTwoStreamsOneMaxedOut) {
|
|
TestVp8Simulcast::TestPaddingTwoStreamsOneMaxedOut();
|
|
}
|
|
|
|
TEST_F(TestVp8Impl, TestPaddingOneStream) {
|
|
TestVp8Simulcast::TestPaddingOneStream();
|
|
}
|
|
|
|
TEST_F(TestVp8Impl, TestPaddingOneStreamTwoMaxedOut) {
|
|
TestVp8Simulcast::TestPaddingOneStreamTwoMaxedOut();
|
|
}
|
|
|
|
TEST_F(TestVp8Impl, TestSendAllStreams) {
|
|
TestVp8Simulcast::TestSendAllStreams();
|
|
}
|
|
|
|
TEST_F(TestVp8Impl, TestDisablingStreams) {
|
|
TestVp8Simulcast::TestDisablingStreams();
|
|
}
|
|
|
|
TEST_F(TestVp8Impl, TestSwitchingToOneStream) {
|
|
TestVp8Simulcast::TestSwitchingToOneStream();
|
|
}
|
|
|
|
TEST_F(TestVp8Impl, TestSwitchingToOneOddStream) {
|
|
TestVp8Simulcast::TestSwitchingToOneOddStream();
|
|
}
|
|
|
|
TEST_F(TestVp8Impl, TestSwitchingToOneSmallStream) {
|
|
TestVp8Simulcast::TestSwitchingToOneSmallStream();
|
|
}
|
|
|
|
TEST_F(TestVp8Impl, TestRPSIEncoder) {
|
|
TestVp8Simulcast::TestRPSIEncoder();
|
|
}
|
|
|
|
TEST_F(TestVp8Impl, TestRPSIEncodeDecode) {
|
|
TestVp8Simulcast::TestRPSIEncodeDecode();
|
|
}
|
|
|
|
TEST_F(TestVp8Impl, TestSaptioTemporalLayers333PatternEncoder) {
|
|
TestVp8Simulcast::TestSaptioTemporalLayers333PatternEncoder();
|
|
}
|
|
|
|
TEST_F(TestVp8Impl, TestSpatioTemporalLayers321PatternEncoder) {
|
|
TestVp8Simulcast::TestSpatioTemporalLayers321PatternEncoder();
|
|
}
|
|
|
|
TEST_F(TestVp8Impl, TestStrideEncodeDecode) {
|
|
TestVp8Simulcast::TestStrideEncodeDecode();
|
|
}
|
|
|
|
TEST_F(TestVp8Impl, TestSkipEncodingUnusedStreams) {
|
|
TestVp8Simulcast::TestSkipEncodingUnusedStreams();
|
|
}
|
|
|
|
} // namespace testing
|
|
} // namespace webrtc
|